From nobody Mon Feb 9 09:10:15 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646E037F10D for ; Fri, 30 Jan 2026 18:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; cv=none; b=lyaQCK4gGErnnxG3tLX47LjENJJ6ICyaszfvxxD+CmUERG7LXVa5U7jHXDq8AfX2nMfYkqwjNZ0suo8wOrJlXhQvwnz0WYehf/Y5k8lvV4tw5FiSepArdmHP5CCWBeox9ONMsbDaBH9S1xrbAsp35rlgOjFqseG1IZ4T8gLxnFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797008; c=relaxed/simple; bh=BTGD8PKhmsfkb+4Q1sKuryoutQRF30cIq9URLzQ0h4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gAiWlk3UQaeLKqKgMgU+78Jgv894AODls1VYzkND8oBc7xu4HKUHq9WqsSba19jwG8Y2Me+6urfB4ojomfyrOwVIbeM3KO7buqAi5/wBGFf6uvy2NJ5tUb/smVBDm4cICsi4L1cQ/y+chtWC5eptmJVz6pOqQjG4I+tY9J3W41U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bgSi2OZ0; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bgSi2OZ0" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4807068eacbso20519765e9.2 for ; Fri, 30 Jan 2026 10:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797005; x=1770401805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=bgSi2OZ0l9WsEW1NYP+pVq8AQB4r8vVT01P8G5PztBqTv8G9WMMN702gbOv98CaPfE 6EcOZ41aDMGZlWFnfRvDVhFFZHcItaJhQSj5uAKvoi6XpvNzvVptm6TKPj/pt/16YD2g NKerTaoy22ys1LGYw+w9AZhasC6giNVed/iYJygPJG/11NkGcW8Rrt03GXXGnDgi22Mt rSgUBNP0GK9SD3d4uOzqnljHG4swT1/cIaTqSIOrG2ireWBSpccFs48tVT7wYLPq2YKC bSvZNvp60B4R5EuACUPPODGT2L6X8iTT+KvFNE3bSR7NiX6UhPKhAkRyTNX3mmmwaSyA gkdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797005; x=1770401805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HRDtc7+pH6qw1+quaRjh9oBVjXVe884KC2sSKvso1A4=; b=OGGjev8l/6z8tiez1DTf4dSdWyVaOQlvi2GrmhS3rNAVjuvkXboBEmw3TuBpNbxCWo UqvldykqjIMxIkTolHox/968n4ikn5iRlF4qDZfcmidQGwKLs3aVpxLENsFBEeLU1Zwe F1OpYrSiXi4Na7g/lnQhIzxCCXSudN7T0Apae7oipTad8Cqic48YoaYOlQd5a0+zdnvx 6rs0odzgvz9029WSLRjaKBk3NPrvU8nWG7sSIcMVlJM3fo9/ogJl8z6ku5uOjFCEjeEr dncEkaeCnQEKB2hij4rneFpDrB10kHENh6sTXyus9F3d5Ip4E33REvZIbTgLelNJhvvO q4FA== X-Forwarded-Encrypted: i=1; AJvYcCXRL27VZQ6jFohZrVA2mNZb1rEKNClK68yoWZLgmvfWpPzOEHZLCEOukSlHKM83g3OIvH6x9juP6BkfJOc=@vger.kernel.org X-Gm-Message-State: AOJu0YwmDP8SeDasYme/3SbkGmqJPQxNhysfwiIpsl0DAliLrbMH6gLx fOz7/Y/tN0uAZfJ9gQ++VvBrS0Xk1rsvKbnL5rxCnYVJ+7hYdWYQevo= X-Gm-Gg: AZuq6aLIqG9H4nJbkpslQVe0OUr9SqRSy9c3D4rR/8HbvpGKl5QPhCBd1ymX4qAG38x TfGOEF42BJumaHbW+BYGKu7CoowT09r8pwlMgmr9iaptcTvipm/o29WWaBTOgMXHDUJqYYWG4QD 6CXIrn7Dq/q5+/cyB5bq5nWqz8eTYmp61SU6O97Zg3up5qkI4cNwz5/y+H8XLsvm/6UaKPpxBKj epTMU8iBgGReiNw23YS61fEPkA4C3jzzJymVnMTUDNYmjSkMZMA+blELZR8cGegWbLam4fmgKcT G1g0VPOjWT346N6pUq5RypwbuddkKK6SH+CZIAWJjFsrQvcl43vHbj/sz2wD/xTWPnJzgF32HxV Gh/xAf0kC/1VYUkFg24yptlm6J+Bwe0DapYbyg+yScqrNLD8MIGAR/acAjzzEyqWDvvsw/vM682 NvOHOavtAp0hkGCyyYikvytsvs/2OILAJ9CVI+et2/4pwK4UdBWNB8sWHB63LYpw== X-Received: by 2002:a05:600c:b99:b0:479:3a86:dc1c with SMTP id 5b1f17b1804b1-482db49a407mr47035185e9.36.1769797004485; Fri, 30 Jan 2026 10:16:44 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:44 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v5 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Fri, 30 Jan 2026 19:16:17 +0100 Message-ID: <20260130181620.199152-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0