From nobody Sun Feb 8 21:46:56 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2F233C18B for ; Fri, 30 Jan 2026 18:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; cv=none; b=gO5XMJHK1cd1wjpmJA0WIy4F4Id4FhMrORcO0K8bRDdcz4I932XFoyUo2sdSIuJNG1k4pLfcDm+1rKbhI253/IHgrnDC4cUsgjvo+w97TBIWjqlAJ7WDOUN+HJgKBspyBCwjH0rFAmXsnRSY4q8UNgNq2YrDTsbAN8pHRJHdjrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797005; c=relaxed/simple; bh=54jF80axLN2UJAh0SY0zu8J2BqHK+0mKcS7a+qODr54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JWgSXwYYButSy1zAbA+wmCyt74CfNnRdpnpfV01HMx6BUiUVCV0vJX/QZTXfc0EZGp1k9ypjK+4SvhVUplqVi6gvS4FQ5IVAO7Kr89UjsjX4MYRKhWi3c8rMcoTUSWkBIOLpvQeuJta+nJvz2OpI8kBcvKC/Ggv5y6m996YqS6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/B+PItv; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/B+PItv" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so18414235e9.2 for ; Fri, 30 Jan 2026 10:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769797003; x=1770401803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=h/B+PItvtCLrF0JiS1yXe9+U3x5Rio87GZyET+2RaQ83/LGjt6/RoEsU3jFV3LWK2I /RZ68vT8OulcHOrpx3qeYEBdvwUx2XzMSmnFFxXLrngFKsPBdswyuNSsVIAktkTINXPV ha6+sqzr2TAtHh3Bamk9VcMUVqZJBM+l/3Od3HFyIBhqsOHdySwFVVA+XPS+Btr5PUPr Ghz2Ix2vnnX2yLd7q06b0v9ajr2fBnaDU2n79qs+09EjMQH9uco8euOGksMVy83ptabI Zu+nH9dfb34g82c1Iq9Lrx2U5R6IDZrD8OsXMN67/KuKe/8PWp2n0wGpuY8lFk+tjPFZ DXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797003; x=1770401803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2f4MfuhNu/cLjFrGUoAiSMm/1GSuujiaDwedPKXZAI=; b=r87zfktC1jWfhTOg4cfOX0OmGI6bmBaGusAoBGgddhSxTu9yzM28zQRqi+DYm4vLou l+eqhcyvO5qIJLPVn708gBfNUAzxicJlaM6U37ATx6Dyva8Z+pO7y/XnnLTlqVLXpI2f a9jJmIO5bnpk74mFxhNs7oJ2iqKoAHl7ZJYuEgJgCGlrzKtCD2wv/twnZkf6JLD0bfaY 207sC/dNCEDnO3YfUdTScxSyz0hLN5T98/pfCzNNJjx6h61gZ5T7ydRQqR+7rMYSbAai L8d6JeT/P7bUMfmbJm9jovXixfs1R6aZZqeJI84e8Mjyg//gx/bh3CrHBaNIeABwFT/A dieA== X-Forwarded-Encrypted: i=1; AJvYcCW5KWuCHrV2a3fnYDToOR+PCbmETYSnusdIg6tplTe2eCAQV8RmpjAaDs6RxO20Z5XOjvNXvmO2W97pGcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyeKaB47V6ASyZE+4Mvgw3tp0pkHtD8Uc+yVLrZ+pUIShJeGgyF wrBCjnS0bv94faAPqjDfKgh/tOXnNIXWwlMRFc9ttMCTOjtoz0agtCU= X-Gm-Gg: AZuq6aId34V5cN7qXQmtPq8Jts4MndmfkoCXtYEgbimtUXfActodqXXRz4hvu3CL85b saa+kiYILDcQKcd1kpeUTqRn4LgVMJmd0ptp12YE674QtRNDxG8sK2p37grh5YXh0MnGq+WzlnA 1scLSPOJdXsGNWKCD3uky3B1yy6h3BxAuws4eInFn3ugtI0Tq+dpwF4qA4IeSyb0EHxU2ufOlCo psEi1QHyf1lb2wWqNTw5Oh+IjZSZ6Kcnxb69CVq6xD+pniYzizHY0G5Z0g58CiXLu842Qs2HFgp Z/VbCCzu/Kgdk2IX2andursbzg3w1SYI86GUD52+hWTZB2S1ypsJMpjJ1Jotg1I+8eWHNKtXLMs /iAN2055nC8ZG3CsY/9wGc7nUnkyA41VEKMlYenC1Uyitjc8EVwZyf4JWXhA85WZt3V9vhyt/AU anJZKPufWhQZwNAPBlKUuIlUkjr1ipVWx3bbRxkDEqCJ333UBDR5fd8UnknomjFqWeaRZ2sKbO X-Received: by 2002:a05:600c:3e1b:b0:477:7af8:c88b with SMTP id 5b1f17b1804b1-482db45129bmr44705235e9.11.1769797002303; Fri, 30 Jan 2026 10:16:42 -0800 (PST) Received: from LGPC ([31.223.131.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm280571025e9.13.2026.01.30.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 10:16:41 -0800 (PST) From: Luka Gejak To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v5 1/5] staging: rtl8723bs: fix potential out-of-bounds Date: Fri, 30 Jan 2026 19:16:16 +0100 Message-ID: <20260130181620.199152-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130181620.199152-1-lukagejak5@gmail.com> References: <20260130181620.199152-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0