From nobody Mon Feb 9 05:58:18 2026 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874A8275B1A for ; Fri, 30 Jan 2026 17:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793273; cv=none; b=Sg4ZuCQfQKXyGaH95lrsV/cNWMyK+OvhVFXZvU5ALCh0RayalPoagiKjhxZvyI1lcyFEiZxr5nc7l0wtrKXRnkIX035AahKFAXWHTZxJaMtsZpiJ4obaUxrKUJ2sxwyMJXZXkdhayNIK+lCkvfCNDffIFPa44vGimGj6I1njFtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793273; c=relaxed/simple; bh=wCkT+0Fo7ip1VAXveKM+pIVE+TBXQ2MYyUCKXghWGUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hR2r4XOj11bPqxCHfsKq6U9FfKEQ5c7NNt0+XbICyNLcFlyaQZJlhNaVG+bdPNLSD3JBaNn+2UaQytmF9ByvbUtLXluywFp6yWQ7E/9I0NOf05ZIIfQCrMn8coDvgORQbBQZs6fvAcz7NQBArRYR5cL+hMawtX8AiPjEYm6tYg4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=d0IE/pIA; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="d0IE/pIA" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2a7a9e4bcc2so947575ad.2 for ; Fri, 30 Jan 2026 09:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1769793271; x=1770398071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8pYvyvztBv1OPHWCa1BTrjMg7Bnkkyf2mkorsSdzRqM=; b=d0IE/pIA7Bkt9TI8aV6P4pbUhC9xy0MzHVQSH+kaY/cPj8PjP/hj8rlEdm8OTSTkmy cAkTq+4aSLTwePCjIteUozWQZQSE9MQAZIu+zcOmUj2MZxGI0eX7MzVdpJoFcl5HsBOh Zz9JaczA0L2rmb1eFqb0fU3IQkre13+Aqen0V3ubULFZRVhrTpcnwIHN8eORVyBVv2xU mm2MWkbPMP7ieI6pTmmdhEUNxUfJy0OPX9RVp0Ofv/I2axax/1Na4WkApIrN1Hq4v7jq 1eRqWrz9YspFPuNGhQMkr8NNGKIqNXTVJpBwc+4o4ov8h65lWy5k+f1YERN7YkH9aZsj ApOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769793271; x=1770398071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8pYvyvztBv1OPHWCa1BTrjMg7Bnkkyf2mkorsSdzRqM=; b=McAFstk7powxBxAKhz1lfhG+aqlj/4pamBilzBMLqzeytA2Z4cmvtmPBuk0JLJZ2hE vAxOTLQPVaQura7Jpb03UHiBemJuTey6D9GdQSLBo8zixCm4Q9aIrgF+m0smKFfimPHC B3S9ta8fgzrGA3YuH7e75ihHA8MyikjMcxci1pC/G8bchPVF+nXv+pKTaouqEkQgGkTU RunB/yvIXxOGVe1AuMVn8EOQzB6ZWukKSGwmI2cJ2deq5k2poTnuB8NJvK5PfCqAQcza CaRUs8TQIfExRnxbiFraEnc+lm0Nelh5eFWAOwI3aT5BEgocRNu5Py9sOV0zwhVBD5n8 maFA== X-Forwarded-Encrypted: i=1; AJvYcCVhyJksGPKT1weFxDZfnrJZqfdZ1+LgVNhIaSJ2DVtdGRmUWBF+yROIAvajEMlP+TnsAew0ZdXywPv3Rl4=@vger.kernel.org X-Gm-Message-State: AOJu0YzSEMDc0cNfogCZatBDuuA8bZMkZhpY416xzITEygBfJBDR/AZN 4KrXVRxTraW3L9P/2gpZDl/pX5F9wxdJQwIas16pXQ5+v7z+Hxpx60zneSHI9aj66bb3P7gFXOe yJXjUxkUAVASRcRvwUA/OLzkQZsHyVDWDO0K6Qk1kHCs5xq+LwZt9 X-Gm-Gg: AZuq6aIPjSDkL4Rz3G6tYABuW0JxQ9Fp98w2xSGN06NnFKtyXwhWENGTjdAOAP5GlfF m3DAHGXtaUGh5kO+UJbsiqWyTDXOhNTsF9QWIK7yMAEmsk3hmTIXb/NTm6fZCraN6awrA/iY69K LAPUawaDVJFojPy9mZ475pMmJ7M4+e/gH7Jl6gEhUI0Ve9DjMwCjcNorvqr/QRSqC1dxmbZyrPw R1GZ9mz8C9E++p+9IRMuJUXp9oeCH3YLnEa0tfvYFbI5wUjJKRlz6sP7BwnIZKC1g/fdt9q1Hjb rqMIpPZcgf0EmBh9hJGOHeDEOgFJuURDkpnBG871xqcMQdAf+k8raJo4OqvFeYKdDPL/lgfdOsU fNU+4J7WQzdi2URnT+YK7v4UAPWk= X-Received: by 2002:a17:903:2c07:b0:2a7:87c0:d1d7 with SMTP id d9443c01a7336-2a8d9a7f66emr27658905ad.9.1769793270768; Fri, 30 Jan 2026 09:14:30 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2a88b3eeec9sm11140785ad.12.2026.01.30.09.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 09:14:30 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id D75B634058D; Fri, 30 Jan 2026 10:14:29 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id D18B7E40249; Fri, 30 Jan 2026 10:14:29 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe Cc: Govindarajulu Varadarajan , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 1/3] ublk: Validate SQE128 flag before accessing the cmd Date: Fri, 30 Jan 2026 10:14:12 -0700 Message-ID: <20260130171414.1376543-2-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260130171414.1376543-1-csander@purestorage.com> References: <20260130171414.1376543-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Govindarajulu Varadarajan ublk_ctrl_cmd_dump() accesses (header *)sqe->cmd before IO_URING_F_SQE128 flag check. This could cause out of boundary memory access. Move the SQE128 flag check earlier in ublk_ctrl_uring_cmd() to return -EINVAL immediately if the flag is not set. Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Govindarajulu Varadarajan Reviewed-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- drivers/block/ublk_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 5efaf53261ce..01088194c8d3 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -5219,14 +5219,14 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd = *cmd, =20 if (ublk_ctrl_uring_cmd_may_sleep(cmd_op) && issue_flags & IO_URING_F_NONBLOCK) return -EAGAIN; =20 - ublk_ctrl_cmd_dump(cmd); - if (!(issue_flags & IO_URING_F_SQE128)) - goto out; + return -EINVAL; + + ublk_ctrl_cmd_dump(cmd); =20 ret =3D ublk_check_cmd_op(cmd_op); if (ret) goto out; =20 --=20 2.45.2