From nobody Mon Feb 9 19:26:02 2026 Received: from smtp82.ord1d.emailsrvr.com (smtp82.ord1d.emailsrvr.com [184.106.54.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABA53590A4 for ; Fri, 30 Jan 2026 17:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.82 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793111; cv=none; b=EgL1Uds5w4RlCE7mHq+FODJfgPfwI4ttTgFLtDvgJWOAcm0P4vSlcz/Q8kAtIRHXsqOv2OLqNWmNXZlTdQvGHzmHDE4pCDlgig+cFUsVDwEZEWXvE+7Uojpl5mjWEdtPyYQWK5tRoxsYEXN19FNDIsTbzrUyDdC+t/z/VgJJcV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793111; c=relaxed/simple; bh=yQZVnBTx0nGZHwR2d2ypziqfr/nt7ZXizswIE0zJ5Ks=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PGKgwY8947plV1UWv4/HY0HBxAFWq7rqHOnM7aDSlK0TrjKOjZ7R9GnuqykYUDChUdJQUlnz6QcFP/Arx/ZpN3Rk+tzWhHjBxngV3p9MJPGUlp+nLCSkPXQxZnPfBFkNtUUsDjCvvEW6WWpTjcfHSnG+Nc6efEZ+9vMbrHNyfO0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=XzsXWYWN; arc=none smtp.client-ip=184.106.54.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="XzsXWYWN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792678; bh=yQZVnBTx0nGZHwR2d2ypziqfr/nt7ZXizswIE0zJ5Ks=; h=From:To:Subject:Date:From; b=XzsXWYWNlQyhprV7KFF/Sw4yMnCF0iUMdgIpCsUC7ZTlFh5VxcPGpbLUOd5YWR7yt mJ9O5hdqnxR1RQXD966eonEeuN3qKI7DGz80KPI2vsCTJryPHezoW9/Phgor49J9C6 pErISHXZv6KpS+C+5tHjTGaBvGSmC7MN9IjeJ1x8= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 6CE38602EC; Fri, 30 Jan 2026 12:04:37 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 07/46] comedi: amplc_pc236: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:47:32 +0000 Message-ID: <20260130170416.49994-8-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-8-1 Content-Type: text/plain; charset="utf-8" The "amplc_pc236" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a supported PC36AT board. It currently allows any base address to be configured but the hardware only supports base addresses (set by on-board DIP switches) in the range 0 to 0xFFC on 4-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/amplc_pc236.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/amplc_pc236.c b/drivers/comedi/drivers/= amplc_pc236.c index b21e0c906aab..eadee10983bf 100644 --- a/drivers/comedi/drivers/amplc_pc236.c +++ b/drivers/comedi/drivers/amplc_pc236.c @@ -45,7 +45,8 @@ static int pc236_attach(struct comedi_device *dev, struct= comedi_devconfig *it) if (!devpriv) return -ENOMEM; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x4); + ret =3D comedi_check_request_region(dev, it->options[0], 0x4, + 0, 0xfff, 4); if (ret) return ret; =20 --=20 2.51.0