From nobody Mon Feb 9 17:23:19 2026 Received: from smtp82.ord1d.emailsrvr.com (smtp82.ord1d.emailsrvr.com [184.106.54.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE2E7347FC4 for ; Fri, 30 Jan 2026 17:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.82 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793109; cv=none; b=Ux3+w/qILFC4Qk4QZDER7PcZuvVnNrVZvfwcYiO2IG59Htujouh/RSPhMHVlqaQHVUjT+2W1mwOqR91c4Zqm6MWdixf6Vjtwe62BvkfUXB00zQhW/qArrtp6+yZGpyfupGkYvO60R1/7FIj/PgKiBrGWqh3qk1z1SAypD9c4gXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769793109; c=relaxed/simple; bh=JLBg96HHc/Pl1yZ6W1y8i3QL5bXjiybg7vwXzmHgPE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NoDhBAhW2TeU60uhAyGfiwbrrECSNeqNQYA4VEzXu5VEjgwPQG4JC4b4vyTBTWzuCUxSX7QFo/i1HGNi3LWXk35qMG70eTAw3LNwd+qx/XuULrHEWZpnwq4Z/4zywEGuu8Uq+A1f+iD1IxnZDtChxSb1QFFifCAa7TVvH9rRXTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=hZKnl8SH; arc=none smtp.client-ip=184.106.54.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="hZKnl8SH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792677; bh=JLBg96HHc/Pl1yZ6W1y8i3QL5bXjiybg7vwXzmHgPE8=; h=From:To:Subject:Date:From; b=hZKnl8SHjRICOry4dAPhGek3bTIOj0D0nb7/sy0yzRfniwXRyI6/GiukEH/cwriEF OM/oEaJrkOTkyzpCGigDScLGAyrSCSetQilB2o6PB3nZVBusya99lI8fRnlM/yR1fA TpmGrr/77kcDlxRdzpsY5SZpVleFqyOAPAMjbE7E= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 6ABE3602E5; Fri, 30 Jan 2026 12:04:36 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 06/46] comedi: amplc_dio200: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:47:31 +0000 Message-ID: <20260130170416.49994-7-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-7-1 Content-Type: text/plain; charset="utf-8" The "amplc_dio200" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a supported board (PC212E, PC214E, PC215E, PC218E, or PC272E). It currently allows any base address to be configured but the hardware only supports base addresses (set by on-board DIP switches) in the range 0 to 0xFE0 on 32-byte boundaries. (Technically, the DIP switches allow 16-byte boundaries, but I do not think that is advisable given that the boards decode a 32-byte address range.) Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/amplc_dio200.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/amplc_dio200.c b/drivers/comedi/drivers= /amplc_dio200.c index 4544bcdd8a70..8b1cbc3d24e5 100644 --- a/drivers/comedi/drivers/amplc_dio200.c +++ b/drivers/comedi/drivers/amplc_dio200.c @@ -242,7 +242,8 @@ static int dio200_attach(struct comedi_device *dev, str= uct comedi_devconfig *it) { int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x20); + ret =3D comedi_check_request_region(dev, it->options[0], 0x20, + 0, 0xfff, 0x20); if (ret) return ret; =20 --=20 2.51.0