From nobody Tue Feb 10 05:27:19 2026 Received: from smtp84.ord1d.emailsrvr.com (smtp84.ord1d.emailsrvr.com [184.106.54.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763E2387344 for ; Fri, 30 Jan 2026 17:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792722; cv=none; b=tYRLkwkEng4dMVFssyjao4RWPgdDlLxY1RzdGqFCT3ds8X1i3WYJD80GT8miM+bmNxZD9V5YgBZ1gNKXFCbAwY503NvVHdskTCeN6jA0tNgRUnjJ3GLA4b6XM5io+2atmZEfkdji09Bq31ESS8kxdh+i4vjUV3V7VqdGkiZOc94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792722; c=relaxed/simple; bh=b+02Z7RR60i8vuOwiPfoY7md+K3xR7uYMw9zWtcWCLg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AlVxAJ0vQ2rVFYYS5uYerv0iPmWjEFq9HGv2itbxWLG3Oyev59yfZbsSJKHP4Y+6BPjgrmb86VRUzMPBuHRvWxecmBsTivK+LdRgYkj2IPKME4q9VBsctYf627sVES3IVJBbj3BC+pSB2S1AFKXnHrSaGGbLhsEhVeZcrQmeiA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=j0cjAXMW; arc=none smtp.client-ip=184.106.54.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="j0cjAXMW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792720; bh=b+02Z7RR60i8vuOwiPfoY7md+K3xR7uYMw9zWtcWCLg=; h=From:To:Subject:Date:From; b=j0cjAXMW6hywgAElIdL8VVqk5JhvKYFumfbLjRvzQZnyiQarzIj9R2rjnMx1IIjiq tbZG0JJvr98IS3GA5MXNs4zqxcuc1DpVD2b+FGr/vUP4wQ42hS6t1T9HJlIAiNgQjG 23RaG+aKGTCIHe5I+uaGW8W3VH9lS1lwIM5nZFfs= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 29CDE602BD; Fri, 30 Jan 2026 12:05:20 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 46/46] comedi: s526: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:48:11 +0000 Message-ID: <20260130170416.49994-47-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-47-1 Content-Type: text/plain; charset="utf-8" The "s526" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a Sensoray 526 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board DIP switches) in the range 0 to 0xFFC0 on 64-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/s526.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/s526.c b/drivers/comedi/drivers/s526.c index 9245c679a3c4..dd27c754dea4 100644 --- a/drivers/comedi/drivers/s526.c +++ b/drivers/comedi/drivers/s526.c @@ -553,7 +553,8 @@ static int s526_attach(struct comedi_device *dev, struc= t comedi_devconfig *it) struct comedi_subdevice *s; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x40); + ret =3D comedi_check_request_region(dev, it->options[0], 0x40, + 0, 0xffc0, 64); if (ret) return ret; =20 --=20 2.51.0