From nobody Mon Feb 9 19:26:02 2026 Received: from smtp87.ord1d.emailsrvr.com (smtp87.ord1d.emailsrvr.com [184.106.54.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFB338553A for ; Fri, 30 Jan 2026 17:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.87 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792716; cv=none; b=SPhGfKAvFuyaawU3zSgES8pHwuYNT6obZ+ez3IfwPF/Lo6LqE3U6mYX5zBEZ/DqEAEY3unH0UIbkPAZ4YxTVG+JhwqpVzfDaGnq0NRogHqdBFuJNr4jTkF11rt8xaO7zc8svRJUd2LKfQyBpeLlASByp8m6c8KuKD4xd0DsI2B8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792716; c=relaxed/simple; bh=jB+ajCqgfVksmcnaVupswMOIMZgZSMp+yjfqojBXKgA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=du5J3bOmvF+owUPhufBsesqk/NTgBsUweTuXis6W3GDT6AwgKvk39+EWMkJzEueoDN6HEhsg/Si5t/Fy3ZNaAOUE9JoXSk9eWsZBlE1xJmvju6NUrngN4zqTdy4ByTS0i7YrNqh1vIJHhuA648B1sBxxEifbYchgZy4A5UdwynM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=lz77N8j8; arc=none smtp.client-ip=184.106.54.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="lz77N8j8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792714; bh=jB+ajCqgfVksmcnaVupswMOIMZgZSMp+yjfqojBXKgA=; h=From:To:Subject:Date:From; b=lz77N8j8nAS+z+n4y+CNR1VL3Sk/Xz6ceeTYfNdmINDWMUvnAiTRcwYn2HwviB56C x5ZDFjQ9lVnEcxr4wVdDZagAiU6TwK4qPv/uhTYBfx8yYWmJMyLfZZPqjlsU3WHIfi BzQWkkJ19xdA/k4dyeYAEJK/DlIuNt5A0sBP19Mo= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 01DA9602BD; Fri, 30 Jan 2026 12:05:13 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 40/46] comedi: pcmad: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:48:05 +0000 Message-ID: <20260130170416.49994-41-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-41-1 Content-Type: text/plain; charset="utf-8" The "pcmad" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a PCM-A/D-12 or PCM-A/D-16 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board jumpers) in the range 0 to 0x3FC on 4-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/pcmad.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/pcmad.c b/drivers/comedi/drivers/pcmad.c index 976eda43881b..fd26b1eed1db 100644 --- a/drivers/comedi/drivers/pcmad.c +++ b/drivers/comedi/drivers/pcmad.c @@ -106,7 +106,8 @@ static int pcmad_attach(struct comedi_device *dev, stru= ct comedi_devconfig *it) struct comedi_subdevice *s; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x04); + ret =3D comedi_check_request_region(dev, it->options[0], 0x04, + 0, 0x3ff, 4); if (ret) return ret; =20 --=20 2.51.0