From nobody Mon Feb 9 19:05:02 2026 Received: from smtp80.ord1d.emailsrvr.com (smtp80.ord1d.emailsrvr.com [184.106.54.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1172E37648A for ; Fri, 30 Jan 2026 17:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.80 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792704; cv=none; b=SRao1to59zY9t07kYKodZ8I+t0diqx5RMBONaywMkfBiRHlLdxE/qaxF/tF+4C2nTK3qXAItQDS5NEI/o/s4vFhrNQ1NGxW34YhmOopKDNAQFeRlxfjOa31McKQUbYctWwgkkUIiW6ZeZjAXcWN1TQ9IRXhlkpSpAvarMOwGk4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792704; c=relaxed/simple; bh=BoSAf/nPeMGqA2+lvXjR714pUehq6Kfv2DBCQ2rU/iw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ErMzCmGBdtx9X2BBcO5lselO/iOY5vKAgbbGKEI6Q+/L/H/f92YMDZu/ieGVU73QZTXtRJZxQcx+bVzshe4gtTux+6SaXTqviipbd41QEK8exq/l060DnmK6rz8ie7pvwK0N5aVigkuPe1mZcBbRhIKuInK6awlSONYmILGChdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=Sh5plknF; arc=none smtp.client-ip=184.106.54.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="Sh5plknF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792701; bh=BoSAf/nPeMGqA2+lvXjR714pUehq6Kfv2DBCQ2rU/iw=; h=From:To:Subject:Date:From; b=Sh5plknFVHul9QxgbZMO37Nf4GmtZJVQvtqoOdYUO8ABJHl849HKHFJvYeZUvauFt pN4o43HCFlXpOfJEx/HCKYhZCCTGMipG7stAzh5S4z/0TRrBOYu0wc9VhIBKTp9DTr 1RdNwP9VXXBjbNwau8ZaorMdDyGLAZ+8VsuxA5Ws= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id A679460300; Fri, 30 Jan 2026 12:05:00 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 27/46] comedi: ni_at_a2150: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:47:52 +0000 Message-ID: <20260130170416.49994-28-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-28-1 Content-Type: text/plain; charset="utf-8" The "ni_at_a2150" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of an AT-A2150 series board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board jumpers) in the range 0 to 0x3E0 on 32-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/ni_at_a2150.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/ni_at_a2150.c b/drivers/comedi/drivers/= ni_at_a2150.c index e4e5a0ebd195..44221c928e32 100644 --- a/drivers/comedi/drivers/ni_at_a2150.c +++ b/drivers/comedi/drivers/ni_at_a2150.c @@ -694,7 +694,8 @@ static int a2150_attach(struct comedi_device *dev, stru= ct comedi_devconfig *it) if (!devpriv) return -ENOMEM; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x1c); + ret =3D comedi_check_request_region(dev, it->options[0], 0x1c, + 0, 0x3ff, 32); if (ret) return ret; =20 --=20 2.51.0