From nobody Mon Feb 9 19:05:05 2026 Received: from smtp86.ord1d.emailsrvr.com (smtp86.ord1d.emailsrvr.com [184.106.54.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05CB9359710 for ; Fri, 30 Jan 2026 17:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.86 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792701; cv=none; b=D42zBTS3XtHy3PvxV/lbQBDaml5SgCF9w8n4CkLbrjM/s3nsvBH41X2k2Fga1tq+zRMiCtCYlYW7IriBRJAFL4qk/yEND2rp88WtJCet73oodIHoqU+2BJtOwVnPDRMfF/u2kbuquaYd/IfBeWFbaZHKQyEcIPKlMafPHE1qaEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792701; c=relaxed/simple; bh=uHMu7IhuuzzkEmakGjFVZw/equ2mKtVdw171aHn2PSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PkngEJ0VPXEJfP7ohy3sVlmi7ujQ9EN3DGkV8s7HFGEVru8p2jkoG06DoUFp8TQB81M2Zywt3MHZxKwNZ/qX2xi18XQXtp2mCBx5SngynXOcDpSk6mq0vRu/vCiFJUAWk0pzNYOqAp2hH8/YkhCBsrT/Vds2S1vMaQrcvF3v1lg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=PQoQZgUo; arc=none smtp.client-ip=184.106.54.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="PQoQZgUo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792699; bh=uHMu7IhuuzzkEmakGjFVZw/equ2mKtVdw171aHn2PSM=; h=From:To:Subject:Date:From; b=PQoQZgUoLULx89GGyHScJ9UoHYDPx+fCbKphc82ibeBkEeHhXDDujIp4doQqweJOh FQrMw155OA1XAqaG5NELl8pNDEH4V1hrnJrd/DTW1KTMccREKNSa3UQBwwMbXCO465 iE9DlWdetPIWSSFbwQ6UgAOuamAn68nC9CqrYSNk= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 9928C601DE; Fri, 30 Jan 2026 12:04:58 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 25/46] comedi: mpc624: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:47:50 +0000 Message-ID: <20260130170416.49994-26-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-26-1 Content-Type: text/plain; charset="utf-8" The "mpc624" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a MPC624 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board jumpers) in the range 0 to 0x3F0 on 16-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/fl512.c | 8 +++++++- drivers/comedi/drivers/mpc624.c | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/comedi/drivers/fl512.c b/drivers/comedi/drivers/fl512.c index 139e801fc358..d9e6007556ac 100644 --- a/drivers/comedi/drivers/fl512.c +++ b/drivers/comedi/drivers/fl512.c @@ -98,9 +98,15 @@ static int fl512_ao_insn_write(struct comedi_device *dev, static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig= *it) { struct comedi_subdevice *s; + unsigned int iobase =3D it->options[0]; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x10); + /* + * FIXME: Don't know the allowed range, but assume it needs to be + * on a 16-byte boundary - Ian Abbott + */ + ret =3D comedi_check_request_region(dev, iobase, 0x10, + 0, UINT_MAX, 16); if (ret) return ret; =20 diff --git a/drivers/comedi/drivers/mpc624.c b/drivers/comedi/drivers/mpc62= 4.c index 9e51ff528ed1..e6343f4267c1 100644 --- a/drivers/comedi/drivers/mpc624.c +++ b/drivers/comedi/drivers/mpc624.c @@ -237,7 +237,8 @@ static int mpc624_attach(struct comedi_device *dev, str= uct comedi_devconfig *it) struct comedi_subdevice *s; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x10); + ret =3D comedi_check_request_region(dev, it->options[0], 0x10, + 0, 0x3ff, 16); if (ret) return ret; =20 --=20 2.51.0