From nobody Tue Feb 10 05:44:05 2026 Received: from smtp84.ord1d.emailsrvr.com (smtp84.ord1d.emailsrvr.com [184.106.54.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C37C35A92A for ; Fri, 30 Jan 2026 17:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792693; cv=none; b=cp0s99Chtr7wfhjQxGinQfI99JOuwFO7MHmoYJBKDeAEbY0DfDhCc8Mf7I+JmrTi/xg5RlQ+I5UePE3tnSfoLvamGLsMlyGLFsu89s5xAH4HpKqMdGAIdp88uoRc7kvoE7789cT0djSnl8iS4R9T/zjb5uRrU0LKZlF2jwbmOcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792693; c=relaxed/simple; bh=gS0bCEFKkxpiy9qE/LxjoabaeuYokeU/oXd9ZL1Rv+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rnNJ9Nl/Kifj0wDwDg7fldEsHEI5K1uat/1pOl5Wbpprnsxo9LAm04+foFHjrBQeeePjv0j/pBhKs8hHPydwpph0XPHbn/4a9d0lZIFskovx/ZYhN5rTp1mHubFv9VYtfe3rkW9UHbLgLdfrzIDcJV/uOCShtPhBqxvtOlsxA9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=BH1aqcht; arc=none smtp.client-ip=184.106.54.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="BH1aqcht" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792689; bh=gS0bCEFKkxpiy9qE/LxjoabaeuYokeU/oXd9ZL1Rv+c=; h=From:To:Subject:Date:From; b=BH1aqchtQcfO+JWxZQlDhd8gKFAfHiGmhiqlsFG0C4G3FFqWsW4Odh3we0F742BG6 LQuKWEMgzH8OR+E6+HvBNS4uUbOvFoW9+361B1t8rlcCovHaqwr5YxeFtj/G8ZYiM9 OP6Tg9Z0zNjQgmDc3esEiCzb1o3Q0bhwyTAe6W58= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id BEB7F602F0; Fri, 30 Jan 2026 12:04:48 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 18/46] comedi: dmm32at: Add sanity check for I/O base address Date: Fri, 30 Jan 2026 16:47:43 +0000 Message-ID: <20260130170416.49994-19-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-19-1 Content-Type: text/plain; charset="utf-8" The "dmm32at" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a Diamond-MM-32-AT board. It currently allows any base address to be configured but the hardware only supports 8 possible base addresses (selected by 3 on-board jumpers). These are 0x100, 0x140, 0x180, 0x200, 0x280, 0x300, 0x340, and 0x380. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/dmm32at.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/comedi/drivers/dmm32at.c b/drivers/comedi/drivers/dmm3= 2at.c index 910cd24b1bed..d1d9f75e168f 100644 --- a/drivers/comedi/drivers/dmm32at.c +++ b/drivers/comedi/drivers/dmm32at.c @@ -572,11 +572,27 @@ static int dmm32at_attach(struct comedi_device *dev, struct comedi_devconfig *it) { struct comedi_subdevice *s; + unsigned int iobase =3D it->options[0]; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x10); - if (ret) - return ret; + switch (iobase) { + case 0x100: + case 0x140: + case 0x180: + case 0x200: + case 0x280: + case 0x300: + case 0x340: + case 0x380: + ret =3D comedi_request_region(dev, iobase, 0x10); + if (ret) + return ret; + break; + default: + dev_err(dev->class_dev, "unsupported base address %#x\n", + iobase); + return -EINVAL; + } =20 ret =3D dmm32at_reset(dev); if (ret) { --=20 2.51.0