From nobody Mon Feb 9 19:05:09 2026 Received: from smtp82.ord1d.emailsrvr.com (smtp82.ord1d.emailsrvr.com [184.106.54.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74163357714 for ; Fri, 30 Jan 2026 17:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.82 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792685; cv=none; b=t8mvnFCP7IcjNx9Ezx1YJscvd755QM9DzhBnGbpyDJMaGFxgOqUVO5D/zao0iAUmd0Md0j59hGhkqvneJHR4yI7ylu4kPTZhQ0gwhg4iSdICz8sLIKwo8G86O9kzdKlh4PurEwGoY07ZQyxUPpFELL/DV694o0hv6/MUpgflXo0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792685; c=relaxed/simple; bh=d9B+RL2+UH5QxZ5qABG0TuhtSZiM+KTMtpJ+NHNoRXI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hPjZE8Xl0Oo867zsGZx8CUYTYL1TVrxgAP2rFvs3nu19UcVLHjP1P3vYJUVmIlC7q+GeCvyqQ6X9D+aTy0gASxYhTn2FzaY+UBoOsfgZoz8+CtUn1DzSey3UoVI1a3srG4NpCzJGZP+0Ptggrh4PE0BoCermmDlEhBSE8WyCPoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=yHiLmTQ8; arc=none smtp.client-ip=184.106.54.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="yHiLmTQ8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1769792682; bh=d9B+RL2+UH5QxZ5qABG0TuhtSZiM+KTMtpJ+NHNoRXI=; h=From:To:Subject:Date:From; b=yHiLmTQ8oJnZ1FUzGhzEx1EMZREViTLaQzbdJ68bQIR2RcslqxfL6SVFgQ4q/Xg4Y jtG6oKAMHNiCtg04VspuhN7PfFPRu0SIl+P9/BBouRzC9Zxhw6mqgRAQuReSd5tqyZ 3gT/hxzxoRlAimbu+RuORj78DH+dWubglJLAmjLc= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 911C8602F9; Fri, 30 Jan 2026 12:04:41 -0500 (EST) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten Subject: [PATCH 11/46] comedi: dac02: Add sanity checks for I/O base address Date: Fri, 30 Jan 2026 16:47:36 +0000 Message-ID: <20260130170416.49994-12-abbotti@mev.co.uk> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130170416.49994-1-abbotti@mev.co.uk> References: <20260130170416.49994-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 429d5722-7f90-4557-8586-08913fa85e9e-12-1 Content-Type: text/plain; charset="utf-8" The "dac02" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a supported DAC-02 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by an on-board DIP switch) in the range 0x200 to 0x3f8 on 8-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott --- drivers/comedi/drivers/dac02.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/dac02.c b/drivers/comedi/drivers/dac02.c index 4b011d66d7b0..2c04472c5078 100644 --- a/drivers/comedi/drivers/dac02.c +++ b/drivers/comedi/drivers/dac02.c @@ -103,7 +103,8 @@ static int dac02_attach(struct comedi_device *dev, stru= ct comedi_devconfig *it) struct comedi_subdevice *s; int ret; =20 - ret =3D comedi_request_region(dev, it->options[0], 0x08); + ret =3D comedi_check_request_region(dev, it->options[0], 0x08, + 0x200, 0x3ff, 8); if (ret) return ret; =20 --=20 2.51.0