From nobody Mon Feb 9 03:29:08 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 119B236CDEF for ; Fri, 30 Jan 2026 15:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786950; cv=none; b=mlDVg/+0b/PDzFi/f8+FZ+RthA5h64GBuagERI6LM9S28HF12M/PQVXXH/QUvee/Q6uFsXluIM97c5knwHoXavZsfruXPEnZ6XR8B0Uy70DDzAs0trKRI6RTPexDyY72WgrcQ59sGPvQSdqYRb0SK9tco9sDJhlZBVOomfMtHy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786950; c=relaxed/simple; bh=5ZgUaAF9iNgoML7Qc29CrTODzvgzuTVSF2bB4q5IyFw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=k9WIAXGMp8uGcS4/GGCZrnxjaiTV/lvhIVQAa6+hlFchqB4fzwmfMgzy+vHiSHqqcyavUzGxyTM4AuYQjq75I3lO0iIQH4qRzJlCuM5/CvhMrNEYR5U0oai+Ej4aTbPWAubRbZJpkx1tvnWjTC9IhCsatNUz2fs1PQLJ60dbLds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fsvXaafb; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fsvXaafb" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6581af9c94aso4350272a12.1 for ; Fri, 30 Jan 2026 07:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769786947; x=1770391747; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kKsGSVs9HgJgiM9uYG4RRpRUVIdzeoi/1Scz/zV4Tjs=; b=fsvXaafb1Zp/vctE9GrTD2XE3W61io0mLZ0tHoHxiCx75+ioG6oYbSCwGmRNYRDFxG 5ivcD9Pt4a5UD5pjbsnYsTUmNgr3HT7AnBnsMuXKKcn36ZbsnbC5Uvlmk+zckvJG2OtJ tP9xxU8t4o/vbtAyzmNZB2URLR/+SIWhs0ybjS5VKp6pMob6Rf3a7WFLIAo0lPOLgaL8 46hLyRBsOSSxgsg0gh5ZdcgKcr3nXQ8jIZfl5gmM8bOuIsK5tacdjtxqvdq+tMdhD8+4 6L0ydtnFYARWwvVrkx+IPldQ4ql+k15n3k7Nt5FvVBQUngaoeQgb3JYgDgEThHpGMQLM bfiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769786947; x=1770391747; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kKsGSVs9HgJgiM9uYG4RRpRUVIdzeoi/1Scz/zV4Tjs=; b=fXhlgQLGJUqDRBT8BRSgxMTsAIGQXxybzhh83Hm0p8+xm9G3k8uTlWqRRZMA6i6czD Xp9wX9D60F+f9U7zIHUueiOTQdd5XoZiY3BSrTwfJuniVBIBDVrJBnINL97xPUdMsXzT PmEsAkS58Pf5R3IMsntNFXBd2nH9qqBr2OL08uAN+zb4BM8xMPDIx2H4UQTJJ+2S6dEb BKHTTecA6Tev/gD3CJjMZGrpxg/MsATRgXIZwK37JB0H73jnLAhUcJ4Rqf1GfKU7Rmgy OhMUvDKUAn5AMeBYK+X9sPHYh67uwRo1mCDQCcvOtoyJqrcqa+Pk9N4XMSwqzLsMScWb WSxA== X-Forwarded-Encrypted: i=1; AJvYcCXs2UMe/K2a17EjU4rRk5yISzTrDSvc6oOUBPnGZ7HM0DKvqokmyeWpeu0/juHJzhEXuWOXENNxr+u2KFo=@vger.kernel.org X-Gm-Message-State: AOJu0YwVrppv5l45OErWbR9e8yo8ZlarfDywvuwTJceF7wJYOoXjM6Db yTzWax8X6PEW8eqPqKQkPuvHvCPauzM9Ocov0z3cGNOktSUaobgrCuSraAy8tZgydLTkew== X-Gm-Gg: AZuq6aLds7ali5oKB304aDWqd5ymn6Fv1dpVMuFJEjLomiNqpz5+LDJNB+/XyIJL7Uz aMB6lhWqEh0I+HaBh5bN9r2tlkATBA44K5vWZwPPw+w8HDt3PRC4OygjksePrKM8/KuzhrgMOtA EzhnVtxlUUmFzuXl1Lwm/Vdxg9VD4ztvdTU0hjNyu7D6LMwNXODcEKCAqnx/viVR5pKmFfecTtn JxsA8CvpfSKFbffyVS/GgeqYg9SZ+2oKwyOTL6oyH0vW1zhjScTjDuUkNZ6iyx3aWVIKfZt+3GY BBew0XH2Ws21pofBmKDw8zwGCrl+Ahlk+m7+lDRO/68WUaE/bWNbMBc7Qz9xmO6t0ICS75ucRZ7 X+jhbcHhoAHU38haxj7iKFm38EBwKwAvjhEwRtagSBVMYye54i1L5BBRSr5JU84/wIfEvf5Kpr+ ZVAstlXYT6QADTMA== X-Received: by 2002:a17:906:dc92:b0:b86:e938:1b3a with SMTP id a640c23a62f3a-b8dff53de9dmr168833266b.17.1769786947125; Fri, 30 Jan 2026 07:29:07 -0800 (PST) Received: from fedora ([146.70.126.190]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbeffed15sm430285966b.31.2026.01.30.07.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 07:29:06 -0800 (PST) From: =?UTF-8?q?Filippo=20Muscher=C3=A0?= To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Filippo=20Muscher=C3=A0?= Subject: [PATCH] staging: vme_user: add identifier names to function prototypes Date: Fri, 30 Jan 2026 16:28:07 +0100 Message-ID: <20260130152807.111025-1-filippo.muschera@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fix checkpatch warnings: WARNING: function definition argument '...' should also have an identifier = name Add parameter names to function prototypes in vme.h to match their implementation in the source files. Signed-off-by: Filippo Muscher=C3=A0 --- drivers/staging/vme_user/vme.h | 121 ++++++++++++++++++--------------- 1 file changed, 67 insertions(+), 54 deletions(-) diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h index 7753e736f9fd..97e3aa8a677c 100644 --- a/drivers/staging/vme_user/vme.h +++ b/drivers/staging/vme_user/vme.h @@ -121,69 +121,82 @@ struct vme_dev { */ struct vme_driver { const char *name; - int (*match)(struct vme_dev *); - int (*probe)(struct vme_dev *); - void (*remove)(struct vme_dev *); + int (*match)(struct vme_dev *vdev); + int (*probe)(struct vme_dev *vdev); + void (*remove)(struct vme_dev *vdev); struct device_driver driver; struct list_head devices; }; =20 -void *vme_alloc_consistent(struct vme_resource *, size_t, dma_addr_t *); -void vme_free_consistent(struct vme_resource *, size_t, void *, dma_addr_= t); +void *vme_alloc_consistent(struct vme_resource *resource, size_t size, + dma_addr_t *dma); +void vme_free_consistent(struct vme_resource *resource, size_t size, + void *vaddr, dma_addr_t dma); =20 -size_t vme_get_size(struct vme_resource *); +size_t vme_get_size(struct vme_resource *resource); int vme_check_window(struct vme_bridge *bridge, u32 aspace, unsigned long long vme_base, unsigned long long size); =20 -struct vme_resource *vme_slave_request(struct vme_dev *, u32, u32); -int vme_slave_set(struct vme_resource *, int, unsigned long long, - unsigned long long, dma_addr_t, u32, u32); -int vme_slave_get(struct vme_resource *, int *, unsigned long long *, - unsigned long long *, dma_addr_t *, u32 *, u32 *); -void vme_slave_free(struct vme_resource *); - -struct vme_resource *vme_master_request(struct vme_dev *, u32, u32, u32); -int vme_master_set(struct vme_resource *, int, unsigned long long, - unsigned long long, u32, u32, u32); -int vme_master_get(struct vme_resource *, int *, unsigned long long *, - unsigned long long *, u32 *, u32 *, u32 *); -ssize_t vme_master_read(struct vme_resource *, void *, size_t, loff_t); -ssize_t vme_master_write(struct vme_resource *, void *, size_t, loff_t); -unsigned int vme_master_rmw(struct vme_resource *, unsigned int, unsigned = int, - unsigned int, loff_t); +struct vme_resource *vme_slave_request(struct vme_dev *vdev, u32 address, = u32 cycle); +int vme_slave_set(struct vme_resource *resource, int enabled, + unsigned long long vme_base, unsigned long long size, + dma_addr_t buf_base, u32 aspace, u32 cycle); +int vme_slave_get(struct vme_resource *resource, int *enabled, + unsigned long long *vme_base, unsigned long long *size, + dma_addr_t *buf_base, u32 *aspace, u32 *cycle); +void vme_slave_free(struct vme_resource *resource); + +struct vme_resource *vme_master_request(struct vme_dev *vdev, u32 address, + u32 cycle, u32 dwidth); +int vme_master_set(struct vme_resource *resource, int enabled, + unsigned long long vme_base, unsigned long long size, + u32 aspace, u32 cycle, u32 dwidth); +int vme_master_get(struct vme_resource *resource, int *enabled, + unsigned long long *vme_base, unsigned long long *size, + u32 *aspace, u32 *cycle, u32 *dwidth); +ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t c= ount, + loff_t offset); +ssize_t vme_master_write(struct vme_resource *resource, void *buf, + size_t count, loff_t offset); +unsigned int vme_master_rmw(struct vme_resource *resource, unsigned int ma= sk, + unsigned int compare, unsigned int swap, loff_t offset); int vme_master_mmap(struct vme_resource *resource, struct vm_area_struct *= vma); -void vme_master_free(struct vme_resource *); - -struct vme_resource *vme_dma_request(struct vme_dev *, u32); -struct vme_dma_list *vme_new_dma_list(struct vme_resource *); -struct vme_dma_attr *vme_dma_pattern_attribute(u32, u32); -struct vme_dma_attr *vme_dma_pci_attribute(dma_addr_t); -struct vme_dma_attr *vme_dma_vme_attribute(unsigned long long, u32, u32, u= 32); -void vme_dma_free_attribute(struct vme_dma_attr *); -int vme_dma_list_add(struct vme_dma_list *, struct vme_dma_attr *, - struct vme_dma_attr *, size_t); -int vme_dma_list_exec(struct vme_dma_list *); -int vme_dma_list_free(struct vme_dma_list *); -int vme_dma_free(struct vme_resource *); - -int vme_irq_request(struct vme_dev *, int, int, - void (*callback)(int, int, void *), void *); -void vme_irq_free(struct vme_dev *, int, int); -int vme_irq_generate(struct vme_dev *, int, int); - -struct vme_resource *vme_lm_request(struct vme_dev *); -int vme_lm_count(struct vme_resource *); -int vme_lm_set(struct vme_resource *, unsigned long long, u32, u32); -int vme_lm_get(struct vme_resource *, unsigned long long *, u32 *, u32 *); -int vme_lm_attach(struct vme_resource *, int, void (*callback)(void *), vo= id *); -int vme_lm_detach(struct vme_resource *, int); -void vme_lm_free(struct vme_resource *); - -int vme_slot_num(struct vme_dev *); -int vme_bus_num(struct vme_dev *); - -int vme_register_driver(struct vme_driver *, unsigned int); -void vme_unregister_driver(struct vme_driver *); +void vme_master_free(struct vme_resource *resource); + +struct vme_resource *vme_dma_request(struct vme_dev *vdev, u32 route); +struct vme_dma_list *vme_new_dma_list(struct vme_resource *resource); +struct vme_dma_attr *vme_dma_pattern_attribute(u32 pattern, u32 type); +struct vme_dma_attr *vme_dma_pci_attribute(dma_addr_t address); +struct vme_dma_attr *vme_dma_vme_attribute(unsigned long long address, + u32 aspace, u32 cycle, u32 dwidth); +void vme_dma_free_attribute(struct vme_dma_attr *attributes); +int vme_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src, + struct vme_dma_attr *dest, size_t count); +int vme_dma_list_exec(struct vme_dma_list *list); +int vme_dma_list_free(struct vme_dma_list *list); +int vme_dma_free(struct vme_resource *resource); + +int vme_irq_request(struct vme_dev *vdev, int level, int statid, + void (*callback)(int, int, void *), void *priv_data); +void vme_irq_free(struct vme_dev *vdev, int level, int statid); +int vme_irq_generate(struct vme_dev *vdev, int level, int statid); + +struct vme_resource *vme_lm_request(struct vme_dev *vdev); +int vme_lm_count(struct vme_resource *resource); +int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base, + u32 aspace, u32 cycle); +int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base, + u32 *aspace, u32 *cycle); +int vme_lm_attach(struct vme_resource *resource, int monitor, + void (*callback)(void *), void *data); +int vme_lm_detach(struct vme_resource *resource, int monitor); +void vme_lm_free(struct vme_resource *resource); + +int vme_slot_num(struct vme_dev *vdev); +int vme_bus_num(struct vme_dev *vdev); + +int vme_register_driver(struct vme_driver *drv, unsigned int ndevs); +void vme_unregister_driver(struct vme_driver *drv); =20 #endif /* _VME_H_ */ =20 --=20 2.52.0