From nobody Sun Feb 8 19:25:37 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2484F36AB4D for ; Fri, 30 Jan 2026 11:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769772759; cv=none; b=pD1cmohPgCeUqHE/bZxh3f05eDCo7FLmYBQPOsUVtRNc44XtpJCSLFNXfApVKOcDU3UPUTEWnxjIEJPDPdDF5EX5+wBEAN20hTMMXjdMuKxB6nnL1ct9xIWVrbUmzFlmr1CLLX7VyAuGmpvdvD7F5VXTkKuvuUOIq1usl48tdmw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769772759; c=relaxed/simple; bh=TRd6n5kGc2KcLJ0MbCFgqLpuTS8vYw2K1Pe1DVWG7X4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NlY+Wam8kw2iPQzQmva+QgdLuoI7dNNrjAOQtlwjG4bjqLmQL1hhFnmd2Q3yyh54qXteqk3hHPWegqSnTOPd5R8WBmRRfeYTKFEKTHA/NQZ0+1O8Iebr+/MsBmrqymed3KkCBj3WAdF2UJuNXOSiNzJTiCHYUCLy3XN5m8JhdSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=SBx8gzWL; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=amHq7Vb8; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="SBx8gzWL"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="amHq7Vb8" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769772751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y/X4T+gcALGbtYm3GL9og2QAkAj/d8qaAdcQ1KRZKqM=; b=SBx8gzWLJua8ca3lu90UyRq5vh+7jeD8E6IPZJVb/9NtBoP3KphV0tWdZav5wcI7RMUUsU Ol1uGLzoKiOn7xorYXJm1VX9Xx58E3tZxF4t1SDzSBX7OgXiWteMRs5nNXGoQNE5QnzNVd zKeQduTrAzIHEva4gQJoimKheg+k5AbRHELyro4z20zxuALNg2djbRAoIQI4HD2j+IxC2L EY5oRyWBIwDtNCq/tA/hnHhpYI1ep7K2OhEnYf0K0BKcN+bIOhDwU01wn4kYtDOgd3Pua1 rLrfddE3uYToR/87LKhNVmH+lM6McV3PbCZh/yTQ/TQDWk+hTbb21uQvsMXEyw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769772751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y/X4T+gcALGbtYm3GL9og2QAkAj/d8qaAdcQ1KRZKqM=; b=amHq7Vb81t23HVNxsqAe91ZH1/B2OldqENhCGBLwEFxCp1X2Ub5JhLWOTRKcyU3Zr7o6FG OOTyhqPfpuVxQPDg== To: Lyude Paul Cc: Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, Dave Airlie , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH drm] Revert "drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)" Date: Fri, 30 Jan 2026 12:38:08 +0106 Message-ID: <20260130113230.2311221-1-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 604826acb3f53c6648a7ee99a3914ead680ab7fb. Apparently there is more to supporting atomic modesetting than providing atomic_(check|commit) callbacks. Before this revert: WARNING: [] drivers/gpu/drm/drm_plane.c:389 at .__drm_universal_plane_init+= 0x13c/0x794 [drm], CPU#1: modprobe/1790 BUG: Kernel NULL pointer dereference on read at 0x00000000 .drm_atomic_get_plane_state+0xd4/0x210 [drm] (unreliable) .drm_client_modeset_commit_atomic+0xf8/0x338 [drm] .drm_client_modeset_commit_locked+0x80/0x260 [drm] .drm_client_modeset_commit+0x40/0x7c [drm] .__drm_fb_helper_restore_fbdev_mode_unlocked.part.0+0xfc/0x108 [drm_kms_hel= per] .drm_fb_helper_set_par+0x8c/0xb8 [drm_kms_helper] .fbcon_init+0x31c/0x618 [...] .__drm_fb_helper_initial_config_and_unlock+0x474/0x7f4 [drm_kms_helper] .drm_fbdev_client_hotplug+0xb0/0x120 [drm_client_lib] .drm_client_register+0x88/0xe4 [drm] .drm_fbdev_client_setup+0x12c/0x19b4 [drm_client_lib] .drm_client_setup+0x15c/0x18c [drm_client_lib] .nouveau_drm_probe+0x19c/0x268 [nouveau] Fixes: 604826acb3f5 ("drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(c= heck|commit)") Reported-by: John Ogness Closes: https://lore.kernel.org/lkml/87ldhf1prw.fsf@jogness.linutronix.de Signed-off-by: John Ogness Tested-by: Daniel Palmer --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/no= uveau/nouveau_display.c index 829c2b573971c..00515623a2cc7 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -352,8 +352,6 @@ nouveau_user_framebuffer_create(struct drm_device *dev, =20 static const struct drm_mode_config_funcs nouveau_mode_config_funcs =3D { .fb_create =3D nouveau_user_framebuffer_create, - .atomic_commit =3D drm_atomic_helper_commit, - .atomic_check =3D drm_atomic_helper_check, }; =20 =20 base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377 --=20 2.47.3