From nobody Sun Feb 8 07:58:54 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09383128A9 for ; Fri, 30 Jan 2026 10:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770537; cv=none; b=hWG8O5ETgDw8BdKa+KkaDcaCHmFLA6OQhcqPXVGGtZE9HOW4g7NNv+w3F53F9GbKq/iVZQGxGGMuTMIVHZqpZH+fG7RsrpBKcbrmV5RAWx+JPW8/b1PUMqHWZAwJWUDCsoFR8qe7ECYoHxT+sAuqjmmJUPilk/YgZQtmms/h89Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770537; c=relaxed/simple; bh=AaPeK0VmM69mFjreiitpUQAEejQt4aFHjIEG/tY27w0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e9k4CIpgwqn//7teGs6RXG835vEL/bOZ/+nQra4zFSE/3aufwmVfUb4xRmO3mAZMqjJAzxuVJX0TfEfBsAJNrEMDjHU34uj78lTqvuCQzzecyUGw3jTdvnAF22FWEk6TzOLPA7N9gw6aoKuRJ6yDCO7370UTCCAiNa4U+LRg7Qc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UigQU3vA; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UigQU3vA" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-34c708702dfso1073146a91.1 for ; Fri, 30 Jan 2026 02:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769770536; x=1770375336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vRv3bSPigsfGmDwQFDWnV3Nevq7ozcWAGXJVJ3SjVX4=; b=UigQU3vAZdzLOZbMfphNMyFZN4vhO9yscOiAfMYv7zsbUYWib1Xm9f8ZcwqSa37ERt mch5nQiY3gVB9FpWt9zOBXcgwXheL6M+vzP0/VGISX8WdBzRWgTG6LfBblTVzoGh6I9n njGgmeHpCBWG0THmrclhxwOSAiCXCZaZo3xNyTk4qqRLnG5OCOpjEVi0LwumGC0eyia5 kUD2fqK04cdnwZGHrEB9JpYLzgqKyjyomR9zVN0xGMCIMVaINbXw/EWfy+3DTjx33Cbb t0PfKjhCKS4QatWB/Kq9UM1kzEg47nTzmQ1hxbtQbElGaYxWQRewPfXdDIslUn9FC1Id 1JlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769770536; x=1770375336; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vRv3bSPigsfGmDwQFDWnV3Nevq7ozcWAGXJVJ3SjVX4=; b=uW8da3X653UdnaFstrvpylFFxXCxSnsjRuyTRFfzS6RUOx+nrUsTQit3XiIT443bUE fhB32rWE3ao2ZKimB1mVOuW0mQGEM4DUBpZ9gNof0l6afmpFad92+FrXMWSR/HKJUStR 7cgdMYHLWctyPMkzrtPf6DwtupcwEGNX0iEmmtzrwNP2IOV9NsuKl1IfJDqqjCNmCOd1 cI2fUjoR8LIkeXOYKMSeVdbxBhBZXGKRmWrRnvzt87VBklXJwsY487q/6QwV21K907a2 2QkeOCWHq9y94vxun9gEg8ZfzgOESr0jGCQpiG+44O2hTWruGAk5V7HuZsoYUrjIUAKZ Qocw== X-Forwarded-Encrypted: i=1; AJvYcCVKnnKWTN3zQzxe6NBI+IHUGBFaLOcdOuUxNN36/zwgo4nVBkMvCk9DWICTd2WQOK9N1xTB0JCgYJoL7+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8VLkVLdx3+lPoGCDmMyLgctYI1enWT7s7sNj1rDffHVbYDhEp 694UjgKFnwnjpmYiYCrNjkHBcmcliUYi1Rhyvb/eYuiJLNDbAGq6C+fr X-Gm-Gg: AZuq6aIROIOuLh8gzaIaTLJGlD0E8m6A1N4MKaxOucGjf31EBqfxXOdb2/rXXaZdIMy LH7C/BC7AaVklWcDeOhn9QlwDFH3+JcEwZ3D8TOKiC/FRLrN3TSEVr9CjuHC7wLsrjyuP3HG4QO TwxbUtyGO+rmbKWX3ooj2rVBs0PBZNTQ92TmmMEooxvvAYyz5e2YBqLavTslQ5ZgwRoKAohCADe eYZnFNE/3IGUERBNhOqu8DgRMK9aXQD5OjOjgeaZnVd7VPpShA6+gu288FQHux+jx5RgSUjJ/Ug 7rVu3JoaNmIDQaGBgyqAMqasJ/MLWlL4oG4gHlp4Rle6Nnj6KBQUKBPoIrm+rJOARcc9/OI4SSd ZfGMJhiuOzP5Hkz1w5vwu4vO8DjndvRPaG5xMU5uzEs43M8MZe0CWJE+pAmzEg8GJJLd4bq+WhF rjUffZg6sUdxDsZvS4SvpsttXYn2i1b2Sd/6s5DUagyvWRl23DPs6UFnSY1GG9Ig== X-Received: by 2002:a17:90b:2244:b0:32e:749d:fcb7 with SMTP id 98e67ed59e1d1-3543b33884cmr2530907a91.13.1769770535916; Fri, 30 Jan 2026 02:55:35 -0800 (PST) Received: from mi-HP-ProDesk-680-G6-PCI-Microtower-PC.mioffice.cn ([43.224.245.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3543d607c98sm663154a91.12.2026.01.30.02.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 02:55:35 -0800 (PST) From: zhidao su X-Google-Original-From: zhidao su To: tj@kernel.org, void@manifault.com, arighi@nvidia.com, changwoo@igalia.com Cc: sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org, suzhidao@xiaomi.com Subject: [PATCH] tools/sched_ext: Add error logging for dsq creation failures in remaining schedulers Date: Fri, 30 Jan 2026 18:55:11 +0800 Message-ID: <20260130105511.250947-1-suzhidao@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add scx_bpf_error() calls when scx_bpf_create_dsq() fails in the remaining schedulers to improve debuggability: - scx_simple.bpf.c: simple_init() - scx_sdt.bpf.c: sdt_init() - scx_cpu0.bpf.c: cpu0_init() - scx_flatcg.bpf.c: fcg_init() This follows the same pattern established in commit 2f8d489897ae ("sched_ext: Add error logging for dsq creation failures") for other schedulers and ensures consistent error reporting across all schedulers. Signed-off-by: zhidao su --- tools/sched_ext/scx_cpu0.bpf.c | 10 +++++++++- tools/sched_ext/scx_flatcg.bpf.c | 10 +++++++++- tools/sched_ext/scx_sdt.bpf.c | 8 +++++++- tools/sched_ext/scx_simple.bpf.c | 10 +++++++++- 4 files changed, 34 insertions(+), 4 deletions(-) diff --git a/tools/sched_ext/scx_cpu0.bpf.c b/tools/sched_ext/scx_cpu0.bpf.c index 6326ce598c8e..9b67ab11b04c 100644 --- a/tools/sched_ext/scx_cpu0.bpf.c +++ b/tools/sched_ext/scx_cpu0.bpf.c @@ -71,7 +71,15 @@ void BPF_STRUCT_OPS(cpu0_dispatch, s32 cpu, struct task_= struct *prev) =20 s32 BPF_STRUCT_OPS_SLEEPABLE(cpu0_init) { - return scx_bpf_create_dsq(DSQ_CPU0, -1); + int ret; + + ret =3D scx_bpf_create_dsq(DSQ_CPU0, -1); + if (ret) { + scx_bpf_error("failed to create DSQ %d (%d)", DSQ_CPU0, ret); + return ret; + } + + return 0; } =20 void BPF_STRUCT_OPS(cpu0_exit, struct scx_exit_info *ei) diff --git a/tools/sched_ext/scx_flatcg.bpf.c b/tools/sched_ext/scx_flatcg.= bpf.c index c216480c3ee0..0e785cff0f24 100644 --- a/tools/sched_ext/scx_flatcg.bpf.c +++ b/tools/sched_ext/scx_flatcg.bpf.c @@ -929,7 +929,15 @@ void BPF_STRUCT_OPS(fcg_cgroup_move, struct task_struc= t *p, =20 s32 BPF_STRUCT_OPS_SLEEPABLE(fcg_init) { - return scx_bpf_create_dsq(FALLBACK_DSQ, -1); + int ret; + + ret =3D scx_bpf_create_dsq(FALLBACK_DSQ, -1); + if (ret) { + scx_bpf_error("failed to create DSQ %d (%d)", FALLBACK_DSQ, ret); + return ret; + } + + return 0; } =20 void BPF_STRUCT_OPS(fcg_exit, struct scx_exit_info *ei) diff --git a/tools/sched_ext/scx_sdt.bpf.c b/tools/sched_ext/scx_sdt.bpf.c index 48ea18614e28..d965f7d209de 100644 --- a/tools/sched_ext/scx_sdt.bpf.c +++ b/tools/sched_ext/scx_sdt.bpf.c @@ -691,7 +691,13 @@ s32 BPF_STRUCT_OPS_SLEEPABLE(sdt_init) return ret; } =20 - return scx_bpf_create_dsq(SHARED_DSQ, -1); + ret =3D scx_bpf_create_dsq(SHARED_DSQ, -1); + if (ret) { + scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret); + return ret; + } + + return 0; } =20 void BPF_STRUCT_OPS(sdt_exit, struct scx_exit_info *ei) diff --git a/tools/sched_ext/scx_simple.bpf.c b/tools/sched_ext/scx_simple.= bpf.c index e6de99dba7db..b456bd7cae77 100644 --- a/tools/sched_ext/scx_simple.bpf.c +++ b/tools/sched_ext/scx_simple.bpf.c @@ -131,7 +131,15 @@ void BPF_STRUCT_OPS(simple_enable, struct task_struct = *p) =20 s32 BPF_STRUCT_OPS_SLEEPABLE(simple_init) { - return scx_bpf_create_dsq(SHARED_DSQ, -1); + int ret; + + ret =3D scx_bpf_create_dsq(SHARED_DSQ, -1); + if (ret) { + scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret); + return ret; + } + + return 0; } =20 void BPF_STRUCT_OPS(simple_exit, struct scx_exit_info *ei) --=20 2.43.0