From nobody Mon Feb 9 16:17:15 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 734B72D3ECF for ; Fri, 30 Jan 2026 09:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765140; cv=none; b=F0Bh1miq76QcR5Dot9kYNOXUBccxRc0iZxHA3lgG1jVWlh19qPgxWVISDKumr/I4Q4gufXaDwEYOYCPlquj01pzQMbSskkYBptKLF7Issa3C03oqFrWtkVaFLkWLFMMRcjfJ5droYRiU/h0t8y1v1mIr16FWEWnGrOG6KP+hngI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765140; c=relaxed/simple; bh=v4uvtN3kEtHaSGwIA/Ac6etILfAKnwUA6PVgLjXtGSE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lNcyj1/t2oxvdQjr0WLUSOnNJyMqsCqyaPdmrpveeI6rxymzz0VCyoONJvrukZaVTrBeLse8yXXILMPmCJeM5ZEl2PEzg+e0YGik7ZzGvCrNBRi/oJLP+0mR/Sd0LVjbJJPUpSLX/WA9NC5xkuw8lXYB/zrB9vRWR5YGwCiqVmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XStNiv5a; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XStNiv5a" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c636487ccaeso757186a12.1 for ; Fri, 30 Jan 2026 01:25:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769765139; x=1770369939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KvpJFnejTXh/YO8agJdfgwPv43+krClG8TqDCYLuRPA=; b=XStNiv5aHpqO3MJUhz6J9/A8EKxmXD+VUkWzUuibB4+k885zcyQXF3yRctAMKm4lfe cLT7HeKY2OAQR3WQ6josoiYJKuFFItBSTuml4Zxcqb6GO9lvcpjvitUFykNnqGeANZnS 3V3++8+mrKoB2cwAxLoiSxjbSooDXPRGMz28AN+44HY5Jl+dtZlO7l7FT3J4R1kfns2Z Yhd1s53yBbT5Qbv9VcOC5D5q0oXuFZRR8pUDowI+vw3tXnkeCzX6CsIrZUj9UeDMatx+ AVVZXOhMP0YM1yfpeYimH1/n6ZHS4Iri3hiirPFIiFW+oS/DeLGRcFzV20wOSDccxisy yiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769765139; x=1770369939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KvpJFnejTXh/YO8agJdfgwPv43+krClG8TqDCYLuRPA=; b=HYEoMPvGMpX+KT6mOxxCGP/psEyPD8zmkPLo0M4+vfQcLZ5b9q7ER54BJkZzzSNQB9 EnIp46BMPHXtQIScjTwtrSufWK/6LJK3VOpWu9yDdOLrvNAbw1k0+EsHNQOZxRF8fxNB uwAv+FMVykjoZCTZrEYuTZl/9zKoslcgel/CGYIA5Ts1+wfvn1UlkIRovJ3eEd+nx/kJ PHNG+QHf0fuWZc5pJQVBGBjGUcbIQ86nwB5hV1dhR2cFaPBoRNvrdTncoV9fOJlaNj2j zMGIl0Q+wi3UbifPdF5R5bUMNGyPhe9h4zqR2dbOvhiI/iHd8WrY9NNwTrktcu9cAfPM 48Xg== X-Forwarded-Encrypted: i=1; AJvYcCVhXoxzm0rrrHowBjGYgXKGMIpIycpmRgwIpY7H335546BmqryYdCTu6he4hoUM93YEeVGsqbI1xMs/gFs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8jxqj+o6t3z7CVZXT3/1X1L4CsClinc25TCW2M0PN8BpM9oCl miY5obOXA6olvgVP+OADpWPuUiPQG1wSP1IEtgWrMskGvV91XVLAD6/wY+DIeQ== X-Gm-Gg: AZuq6aLvC8A5gjYYHwEN5h3ETFa3hB1BEVqE0dFizAuv44QvvAS8lT4Y47pW8cbEO9f GMvqVOi8UQ1mNrHX59hg/z6KFo92Sb3aiRaPhekEovIn8NxkCZUAT6mMvwsltVwwbIOPxm+tUsw LIcKlf+DWO8/27qDxq21fbOFVpV6QQZx9Xujr+LxJ9GaZvVfww/Ba8K55h1YJzuhz+SYqQwpt2n 84bzcduolWZ48IrYahBb3cS5Z9AISUjARGG3Dv8nDd+aJOKWK8yixrF1ymYHVGjKZdPVGa8TJg+ ajtQ7K3yPFJTYCiYsM8Qt2fbht6zUJ1OZLBjAFcO1Qc3YV94/F1W/twItBXUeMlR/ockYRdEEKk wPaNSJPkJdizm1Ya0okQJXHXtTiVX38B4PF/IJsjUDhh3fwbBJrnwh9zWCeKRDTOUmE/e7i5HP7 Pg1T8X3rOLcUwR5H+iHrt/MnZBm7f53QdF0w== X-Received: by 2002:a05:6a20:4327:b0:38d:f62a:a9e8 with SMTP id adf61e73a8af0-392e00007d9mr1937087637.7.1769765138815; Fri, 30 Jan 2026 01:25:38 -0800 (PST) Received: from twhmp6px (mxsmtp211.mxic.com.tw. [211.75.127.162]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c64284689fasm6771372a12.15.2026.01.30.01.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 01:25:38 -0800 (PST) Received: from hqs-appsw-a2o.mp600.macronix.com (unknown [172.17.236.67]) by twhmp6px (Postfix) with ESMTPS id 1F46A4136075; Fri, 30 Jan 2026 17:25:36 +0800 (CST) From: Cheng Ming Lin To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , Tudor Ambarus , Martin Kurbanov , Mikhail Kshevetskiy , Pratyush Yadav , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Cheng Ming Lin Subject: [PATCH v3 2/2] mtd: spi-nand: macronix: Enable randomizer support Date: Fri, 30 Jan 2026 17:23:49 +0800 Message-Id: <20260130092349.621034-3-linchengming884@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260130092349.621034-1-linchengming884@gmail.com> References: <20260130092349.621034-1-linchengming884@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cheng Ming Lin Implement the 'set_randomizer' callback for Macronix SPI NAND chips. This feature is controlled via the "mxic,randomizer-enable" device tree property. The randomizer is enabled by setting bit 1 of the Configuration Register (address 0x10). This patch adds support for the following chips: - MX35LFxG24AD series - MX35UFxG24AD series When the randomizer is enabled, data is scrambled internally during program operations and automatically descrambled during read operations. This helps reduce bit errors caused by program disturbance. Signed-off-by: Cheng Ming Lin --- drivers/mtd/nand/spi/macronix.c | 47 ++++++++++++++++++++++++++------- 1 file changed, 37 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macroni= x.c index edf63b9996cf..0212d44b1a3f 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -14,6 +14,8 @@ #define MACRONIX_ECCSR_BF_LAST_PAGE(eccsr) FIELD_GET(GENMASK(3, 0), eccsr) #define MACRONIX_ECCSR_BF_ACCUMULATED_PAGES(eccsr) FIELD_GET(GENMASK(7, 4)= , eccsr) #define MACRONIX_CFG_CONT_READ BIT(2) +#define MACRONIX_CFG_RANDOMIZER_EN BIT(1) +#define MACRONIX_FEATURE_ADDR_RANDOMIZER 0x10 #define MACRONIX_FEATURE_ADDR_READ_RETRY 0x70 #define MACRONIX_NUM_READ_RETRY_MODES 5 =20 @@ -155,6 +157,21 @@ static int macronix_set_read_retry(struct spinand_devi= ce *spinand, return spi_mem_exec_op(spinand->spimem, &op); } =20 +static int macronix_set_randomizer(struct spinand_device *spinand, bool en= able) +{ + struct device_node *np =3D spinand->spimem->spi->dev.of_node; + int ret; + + if (of_property_read_bool(np, "mxic,randomizer-enable")) { + ret =3D spinand_write_reg_op(spinand, MACRONIX_FEATURE_ADDR_RANDOMIZER, + enable ? MACRONIX_CFG_RANDOMIZER_EN : 0); + if (ret) + return ret; + } + + return 0; +} + static const struct spinand_info macronix_spinand_table[] =3D { SPINAND_INFO("MX35LF1GE4AB", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x12), @@ -213,7 +230,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF2G24AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x24, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), @@ -225,7 +243,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_PROG_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF2G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x64, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -236,7 +255,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF4G24AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x35, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 2, 1, 1), @@ -248,7 +268,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_PROG_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35LF4G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x75, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -259,7 +280,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_HAS_QE_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX31LF1GE4BC", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e), NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1), @@ -305,7 +327,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF4G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xf5, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -317,7 +340,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF4GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xb7, 0x03), NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), @@ -355,7 +379,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF2G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xe4, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -367,7 +392,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF2GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xa6, 0x03), NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1), @@ -413,7 +439,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, macronix_ecc_get_status), SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES, - macronix_set_read_retry)), + macronix_set_read_retry), + SPINAND_RANDOMIZER(macronix_set_randomizer)), SPINAND_INFO("MX35UF1GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x96, 0x03), NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), --=20 2.25.1