From nobody Sat Feb 7 23:23:06 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF2A2EB87E for ; Fri, 30 Jan 2026 07:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769759487; cv=none; b=qj5uS+fSXbM3soOriUz4uMm7d7W/rzoY0Ft+WPQ8vDgMYaEtPkNLxdfOQCBYxCCtIMT5xWPSJ5IS/ZYNfKIBExEy1ubyuGuZSYmJKQwO6r3TjBoWXXvxcLkJJGt/uuEf77N4qpiUTUaUGIRXBNCHnks7HsoN2xx+F72K3n3Jlg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769759487; c=relaxed/simple; bh=OtqpskiRHinTNYIo1so3B49+jdqv4EaJ7ulxmT+E84A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=o+RDx1VheiNg64Qiil8+SGdRl+3FOxZKVU8vI6KfEb/a+Kafg41DPyZmqIIXHt5Hb6j205t51xUUPowtEuhImdkF2Qq18w9P73gMOf8+WBR3iG9Nf+0v4Q45nxiO2mJVYdT8qeFDufrXhK9uOrksLGG2FOt0Ur34NScEyq7b1FM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CpipK2SH; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CpipK2SH" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-823081bb15fso1014133b3a.3 for ; Thu, 29 Jan 2026 23:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769759486; x=1770364286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XdjfaAMe7i3Y77xkWmVmlbZ6HZaBYnYgt+qo5FS/RlY=; b=CpipK2SHv6pJbGd8J08qQ2R/zSC9aFbj58vMxNien5alhUxFW+qjU11Z2yiXwrdleB uIWzrfrkPwLJK1azOQ5t86T1q2OhiqLzjEH7jXRE3RWOQ7j0+O88hig7E+E9wi0DkozF kaQot6S5hj5g8CxUQwGoaSCg2HXkoFyDQgqpUtSNPldpBgO9i3netdruDtBaneOt6xi0 T2vsKHjW5vcQIL7PTj6YkU3QOHVh6q1ONS2KkZsbgS2/utYC8/Wh8ZD398gyum1Z7Inn HZD3DK0SymNcNcIJa/ad5JeEvlK/EoxhOO3xzK267GX5CvkGgJe/PFBFQZ12N9qc/bO4 SwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769759486; x=1770364286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XdjfaAMe7i3Y77xkWmVmlbZ6HZaBYnYgt+qo5FS/RlY=; b=GytDxi1O9IWBbd5JW3XJ0ezdp475rFY0aIRjv0aeuE2jWHMCRN49AQPuG176/GwlCG YQ/NJe0EAYQFbpz+EYvWe9OKMUyRpv1e3ZJrpBy0ttBtqUwM/Zxpbulm4OyGNcWzRTHq fX9ErVNDmbhGcha1lv6wvbzaivZH6tJKr+PARs4YqJqS714gy9Gzp93xc6WxM35Tb9sE PXV2pFT934w5x8gxeT9hDD3nUAX/LXuWqSTCMNHgEDzk4UMLsM9XLjGbz3StuwMnmCAy ozbkeuvk34M8PjRNvIsvCj9B0jAPcgsQRQb5hm6xGvfE6Z6bt0VAF5PBGz0QLXyoPpCm vhnw== X-Forwarded-Encrypted: i=1; AJvYcCUvP/uaHe9Pz/qcEKNEC/E8dYLbPlooDIub+OuqQdedGWl9LGEc8hl/rMxR8lUkfrw7HnoqB9XJOvctJn8=@vger.kernel.org X-Gm-Message-State: AOJu0YwHSwmL4Bwz4BxIwewparkPhVXy9seIr5P2zPQtgNqQoEqv0wwy 8Ydavfmy/ExzXHfSeIW+WDiQQYiwMvJRP/79aNCAk2zqbYNYd+Wrd9JL X-Gm-Gg: AZuq6aJc9j8U+I1THcf1t6kMmNnCLQtUebt/2izyv/CL4vgyjh5M3cm90LioeJMZYxS GZFmeXkQol2u6SLkuGV74nFj8KPg6DCm3D1sgPJacx0RNL13wR3ZtRdZliTkVnQkvZKPdT5oNLS l0RVsT197hDA8Z2TQ63aySr/SMk0w8Ju5U1UcNbij8Ih7aJHSnHnqZ0y43UyE2KQnguXbe9JKc0 2kFd0G5wKwh2WcYa/hHkwtBcz6DLxzNVnaIfviT32iC8mgH9zNmK7W+TZtM2ehGXNici+JEzF9s w9mPdq0AbOxwbTQS71Ol9b3lBaq6Hu0HSAyiLk7I/mhTJPalE+/hrg1HNzWx/+hR804RPrtyvdJ 9nOuDoy2E08RXnFb3Sw+/Icn7r1uN2bOCUCPR9frWUFiPQRS9dOEFDN6LwsOMh3yWPtIB9zm3Xs ixefbqX1FQU8y8aCoiMB7jwbcHZVf8Vg== X-Received: by 2002:a05:6a00:ad5:b0:81f:4dc7:d44 with SMTP id d2e1a72fcca58-823aa94032fmr2091381b3a.66.1769759485812; Thu, 29 Jan 2026 23:51:25 -0800 (PST) Received: from debian.ari ([152.58.179.158]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bff93esm8679447b3a.41.2026.01.29.23.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 23:51:25 -0800 (PST) From: Archit Anant To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH] staging: rtl8723bs: use unaligned access macros in rtw_security.c Date: Fri, 30 Jan 2026 13:21:13 +0530 Message-Id: <20260130075113.34666-1-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver defines custom functions secmicgetuint32() and secmicputuint32() to handle little-endian byte-to-integer conversion. This is redundant as the kernel provides optimized standard macros for this purpose in . Replace the custom implementations with get_unaligned_le32() and put_unaligned_le32() and delete the now-unused local functions. Signed-off-by: Archit Anant Reviewed-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_security.c | 32 +++---------------- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index 2f941ffbd465..fd63fce6f12d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include #include #include #include @@ -128,29 +129,6 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *pr= ecvframe) =20 /* 3 =3D=3D=3D=3D=3DTKIP related =3D=3D=3D=3D=3D */ =20 -static u32 secmicgetuint32(u8 *p) -/* Convert from Byte[] to Us3232 in a portable way */ -{ - s32 i; - u32 res =3D 0; - - for (i =3D 0; i < 4; i++) - res |=3D ((u32)(*p++)) << (8 * i); - - return res; -} - -static void secmicputuint32(u8 *p, u32 val) -/* Convert from Us3232 to Byte[] in a portable way */ -{ - long i; - - for (i =3D 0; i < 4; i++) { - *p++ =3D (u8) (val & 0xff); - val >>=3D 8; - } -} - static void secmicclear(struct mic_data *pmicdata) { /* Reset the state to the empty message. */ @@ -163,8 +141,8 @@ static void secmicclear(struct mic_data *pmicdata) void rtw_secmicsetkey(struct mic_data *pmicdata, u8 *key) { /* Set the key */ - pmicdata->K0 =3D secmicgetuint32(key); - pmicdata->K1 =3D secmicgetuint32(key + 4); + pmicdata->K0 =3D get_unaligned_le32(key); + pmicdata->K1 =3D get_unaligned_le32(key + 4); /* and reset the message */ secmicclear(pmicdata); } @@ -212,8 +190,8 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst) while (pmicdata->nBytesInM !=3D 0) rtw_secmicappendbyte(pmicdata, 0); /* The appendByte function has already computed the result. */ - secmicputuint32(dst, pmicdata->L); - secmicputuint32(dst + 4, pmicdata->R); + put_unaligned_le32(pmicdata->L, dst); + put_unaligned_le32(pmicdata->R, dst + 4); /* Reset to the empty message. */ secmicclear(pmicdata); } --=20 2.39.5