From nobody Mon Feb 9 04:04:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEA932FC881 for ; Fri, 30 Jan 2026 07:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769757592; cv=none; b=pq9xs3LaQkAIZx6XBfui2iM+zYVl0cPlNOOEZA2fv7MvMu8umwCk9lhoM1TaYFELl2jkGKwBtszPYMWx5gZDhWI8tOjzl8ApTSPAQbvnmi8alwRuGnFg+r12091OBHD6TvG/Jm2W9QfQpDFJwOjDCL+OV6nFaakA8fSHcbgSPxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769757592; c=relaxed/simple; bh=XbqXCUGickOIvAHuTScPhFbiiOhmUvouEQJa9UTNZbc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aAnWDLUl27goRsUVf2MSTcKtTXKi4MhG5v7RnqtrgCQ2brXxG1ot+gxinXsde5A/u0iP8IG9JL14WSbVKqzAI+jMZnEB3CQOLyaox2HUSQtZut8uVMgZJE8YRrZG5KNLclppcq4zOS/jw9joIRFSLonxhF0WIZxWw+uo2WP9G1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RkkK08jf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XTOZFvrb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RkkK08jf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XTOZFvrb" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U4tODk2294941 for ; Fri, 30 Jan 2026 07:19:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=efUT9YVinjOUDB9FWngFq5/PMyszXgXdXEr rMvlcZCs=; b=RkkK08jfUFzmo/UaHmZy0S/mALQWROnwi4sfPRmoMA+d1Jxafpg +ZsWaJGdtHoSHCr+2VHVpw8D1t7Hck0PLuH5Hmo746V+ekZzrEgYlJ38eQtzyPWk q9JDwrwSp1T1iXHRLtTR9OAfsPkfBh4+y/G1wsl8yVSuiWYsMRzeVWE6CuN2p0pW FCQvhJpGRVFUpbx8vVQa8j1qVVYJYlqyys65x87YuFLcHAQb7qBYUPcxjqyIqfF0 rnTavZVa4DHc36LFdR4aEIGgnhUbKpMXubfufyjUVGXi0Od2rmr92x1S/takiUKb ke72ywqvYUH55Z6HHOsVGkzx4dYoxzTerQQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0p1x8c49-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 07:19:49 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c6136af8e06so1272600a12.1 for ; Thu, 29 Jan 2026 23:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769757589; x=1770362389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=efUT9YVinjOUDB9FWngFq5/PMyszXgXdXErrMvlcZCs=; b=XTOZFvrbwwa6+MSluoqINW8HNS8gE1krAmc8N3GmPYwa1NOIvXCgsYi9b3gV8EOXng lMoHJgEe0Q0LNbZzemanC39vlh7SRvlrrJN6cLast+furiBwRBz6wazh6eNabMT//2Pw 8hA6vbnPjo7SVYOUAuUHW6XoeMLe6IF2VqhuQLaQljxX8So7xj7QB4YtAt95J4fc9O8h iFI1ShDmBVwvi4OclfeJWO2JJKJptuR4PqDkjbrR0sdYh7yRqdusyHzlEEySPbfJ+cFL vk0bn93ZJMvYgPXXgA3gg3DaEk9JOfyQwKgQ2SnjoxEdk+8W/6bQlH2Rvl5r0hc2BW8N iBDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769757589; x=1770362389; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=efUT9YVinjOUDB9FWngFq5/PMyszXgXdXErrMvlcZCs=; b=OGOlKNFPTUC5GPY7PkITSkEAp61wxBJ8fCpxuz1WKtSQ+AURcv9eCW+RZrY9bI/pGB g4cwF+5Ke0hhUD3Fun4CIdIn8kuEpdPXFiaisJHracX0O+kY2T8F4+eFrxxcpfvngGaI piVFYKWoa46iLpBrR6mbKQx//xwcULGotwp8CkzAIg54hxCk+YlL31yLif73J5w1uHci jDa28MwIXJoTr7OfUVdOT1XC3rURZT2O8wfF8MZMKzKKYo0VJ3WrRt8Gq9s3SepeXbAJ 3/aAYFtx/yAYbAtp4pke2ykCVzCYS8vKG3X6qAXHt8x5ZrT1CGxy5OIlvtPlpLhKhOym BD3A== X-Forwarded-Encrypted: i=1; AJvYcCUa7eOBrQdYAN0dUUAxzPNl/Y8KjrwTQps/qfcQQFyZmq0gqVv9IMcQW4pxvTjMv/3pKx75E5DKaDOWzyY=@vger.kernel.org X-Gm-Message-State: AOJu0YxEIiFOII+1ahZ0+bda4O9KDB3Z4n/uIA9InegSu6grkyVqyqry 5/TnQWBWDVx8mvl95cHWG4JYjyNYjNlyBOY7CcJRi8DkuYdwZRl9xAy3ni8vaxnxnx3VlUbM4Fn HBRZV1YzB9egTzDBuj8owG2JcXYKOfwfxS2Bc2o6V63wINRiXUGFezzMru+BFZDZaiRU= X-Gm-Gg: AZuq6aJbejKQLEu/081K+mLPzCUFQGyxlQm0hTBXbP05mR/v2QILw69Qyvwrc9CzflH SU4NSCAhvhPZF2ufra3/2XB3X5Ev2JgcT3DBRUZv3EjubT2A38GlWQz1O7qbKdi69zPXEoLgkfe XDfY9Krt2ZNPs4j99nkh38Ny87vLptxK4N32zlHArFtGJVwV1kjIIDHhJYbUs0Y0y2DPpc7GRap pw1SDBwbMuXTDssJoXwdU5HgmFQcM6VkXRaRGk6bB1duatIgywpAyYktbNZV7eIRXdfVRbUbBZ0 dPxjaHkNWRdfmHEPK00k/YnhzZwtMxylzLcYJYyJP3Lw8WlcQ+BO6ru2S2fiw/ahGlmRXopprkL 7GACg8CC6zXNLp2/+bhoCSpF2CQ== X-Received: by 2002:a05:6a20:7491:b0:35e:86d3:88ca with SMTP id adf61e73a8af0-392e015d37amr1825913637.59.1769757588515; Thu, 29 Jan 2026 23:19:48 -0800 (PST) X-Received: by 2002:a05:6a20:7491:b0:35e:86d3:88ca with SMTP id adf61e73a8af0-392e015d37amr1825891637.59.1769757587969; Thu, 29 Jan 2026 23:19:47 -0800 (PST) Received: from work ([120.60.134.148]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6432e27aa5sm6627128a12.6.2026.01.29.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 23:19:47 -0800 (PST) From: Manivannan Sadhasivam To: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bjorn Andersson Subject: [PATCH v2] OPP: debugfs: Use performance level if available to distinguish between rates Date: Fri, 30 Jan 2026 12:49:40 +0530 Message-ID: <20260130071940.6949-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 9610a6enjJcVtzLvp4qKGoUDx40xO_IF X-Proofpoint-ORIG-GUID: 9610a6enjJcVtzLvp4qKGoUDx40xO_IF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA1NiBTYWx0ZWRfXwyvggN8LLb3F NTa46ihKpBz1XvaFjcDKIr+BeS677DDl4lXI710l7t8db2GjlQIDiy2jdouREOYFAyY0FthGl8e 09TB84ORxIbYE/ShiDUJcNg7py3pJMArZ9BVFe6OuhiQMqNZBD1DCGWHB0IRWz7kpA3t1ROTVr/ pOBu7I1FJcfSW8oPDv744D5DljyqVPDp9kkbKTSL3FWlURT73rJn16vVr03l7rNESoDl0ZRD69w Y6aP+UCN5ICtaYssY73CRJiUbdZh0S7j2OqVohucfj6/kzHKrgnj9w2J/sCuwhekJPG/Dw8hiqi 0ZyZKzoTnEyg+eQjyOUmU4NV4iP8DW28ZsDDanHmDNoCSyK5uNtBW4773kuqndjBnXBnWojQSep LlPmO4L8+JOy3+qQdshSBjpTjLHToMO1Jq7Wkvbf84cjJDKPJWOf6MepB4xLDb9d3b4nfPO816I JSBv2GJhb85VaZATVKg== X-Authority-Analysis: v=2.4 cv=G5cR0tk5 c=1 sm=1 tr=0 ts=697c5b95 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=2V1Ify4SBoSVV1xbfEOURw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=UdqTqlS5sJmFKW4WO-8A:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300056 Content-Type: text/plain; charset="utf-8" Some OPP tables have entries with same rate and different performance level. For these entries, using only the rate as the debugfs directory name causes below error: debugfs: 'opp:5000000' already exists in 'soc@0-1c00000.pci' Fix it by appending the performance level to the dir name if available. Reported-by: Bjorn Andersson Closes: https://lore.kernel.org/linux-arm-msm/75lzykd37zdvrks5i2bb4zb2yzjtm= 25kv3hegmikndkbr772mz@w2ykff3ny45u/ Fixes: 05db35963eef ("OPP: Add support to find OPP for a set of keys") Signed-off-by: Manivannan Sadhasivam --- Changes in v2: - Used OPP_LEVEL_UNSET check drivers/opp/debugfs.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 8fc6238b1728..61506d30d5ff 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -130,22 +130,24 @@ void opp_debug_create_one(struct dev_pm_opp *opp, str= uct opp_table *opp_table) { struct dentry *pdentry =3D opp_table->dentry; struct dentry *d; - unsigned long id; - char name[25]; /* 20 chars for 64 bit value + 5 (opp:\0) */ + char name[36]; /* "opp:"(4) + u64(20) + "-" (1) + u32(10) + NULL(1) */ =20 /* * Get directory name for OPP. * - * - Normally rate is unique to each OPP, use it to get unique opp-name. + * - Normally rate is unique to each OPP, use it to get unique opp-name, + * together with performance level if available. * - For some devices rate isn't available or there are multiple, use * index instead for them. */ - if (likely(opp_table->clk_count =3D=3D 1 && opp->rates[0])) - id =3D opp->rates[0]; - else - id =3D _get_opp_count(opp_table); - - snprintf(name, sizeof(name), "opp:%lu", id); + if (likely(opp_table->clk_count =3D=3D 1 && opp->rates[0])) { + if (opp->level =3D=3D OPP_LEVEL_UNSET) + snprintf(name, sizeof(name), "opp:%lu", opp->rates[0]); + else + snprintf(name, sizeof(name), "opp:%lu-%u", opp->rates[0], opp->level); + } else { + snprintf(name, sizeof(name), "opp:%u", _get_opp_count(opp_table)); + } =20 /* Create per-opp directory */ d =3D debugfs_create_dir(name, pdentry); --=20 2.51.0