From nobody Sun Feb 8 20:58:55 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF8B27603C; Fri, 30 Jan 2026 00:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732213; cv=none; b=O0hS31L7NLNptnEq47klZ3UBfeKuB4yhIUfgSN7W4G8YBpv6MVxwTOV6droSQ1Ha/BCOjfuIjhaXYlvNxdA1uCIikJ6cmboaQVegg5DbFgMvJQzY7k28vc2GiVo+VKh80hzYX4XS2gXROvEx3kkVf2lOypmL6VaUrG4Itws/rMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732213; c=relaxed/simple; bh=9LjqytfvU+ZFcPy2TL3ckCjKviHsxjJ7yqYUWMbFBGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZESTDwZtljhDXoPIL9E+RIUkXJVOYc5r/8PTjGvNd3oJHkyr9XsoZgHKFjaepKSPr76DKZkgOJOx9EQ2MwKOVEc7Rl9yi0cr066hwQrnIdEHAFktYqbRXqkO16R4CpVLV8BytiWv8lmXLJSaJJvZRZo97qG0Ve46SWI000GPzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=oToymM5T; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oToymM5T" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TMUINF676658; Fri, 30 Jan 2026 00:16:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=I+RIs Ibr1gy5lRlJFoPvBZz0Dyzz8Q3VcnTN1ATL99k=; b=oToymM5TntgyjNEomckeX x/MGgT6/N+qVCdEsV7DvWy95Vjpa305dUR9cbAntzTU0AdX0vSe3U1m+KUR9UhnH OjsrtVACjV9SuYx15p+XY57rpweo6SZXKSuvXKNfo4t+O9D6XzKpiYx756Gixq7t 07oUcDMzpm0z1a/vUIpR0q5owhbryMnPluhlL9zfOy3n4o3AXhW2+T09HO2gRinU 6d2u95f6dPgdkM+yA7wWV4O8FO1LKLro2Esai7aWBgdiImRbyhe1N4uSEKmeskRM pUVYA/evCt+rBTLE2VqZaNOGBz9i0T18NrgeGeFAD2zKHY67fO/kq3eKOCTI9tfs w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4by2vgmbxq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:49 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60U00GE6010023; Fri, 30 Jan 2026 00:16:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4bvmhd19k7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:43 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 60U0GgZD007973; Fri, 30 Jan 2026 00:16:43 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4bvmhd19jr-2; Fri, 30 Jan 2026 00:16:43 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, samasth.norway.ananda@oracle.com Subject: [PATCH v3 1/3] staging: rtl8723bs: fix firmware memory leak on error Date: Thu, 29 Jan 2026 16:16:39 -0800 Message-ID: <20260130001641.17941-2-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> References: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601290179 X-Proofpoint-GUID: T0FjYGl50ktcMKJDrD5r3csTBf1lyW2S X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDAwMCBTYWx0ZWRfX33bq9dDl1C6A 2BfW6cheD2y7uieNTHyWNw6JrJgdlYwxbAILEPLlC1CrhEHpogDMBFx2HeU6TAQJnEDmMMaOsRY mMxRCo/geAvUoTYPkvaWhY2UXJyeltOqH2VyBPTaoJB/Zk0Zynt3GXLn6qDF9QEBHnutQRPm3MH cLhT6SPpvH5kDNgApc0+kw50nqdr26UflKwy2vVbulC5EYo56PvWz77RMZ157myTsDW4AMH3WxY ZihQbpews4dNdoj0FHNgitfbAJMhAn/9DbuqXDf3DmR4HrPXtJNMziFVy5rpy3rZ3dLT9pEpke/ T1aqJP/3gQrVnBltjDbMZBLiu7/+f6oXf4gHqmbJC9L/FOuTiM5EOd2USePyLw2ktCl3G92yc+c LyUV/eB/mwtWhuDtcfZgvDpu32tBV9sB0D/KIAhQ8QEtIuKM1BmxcNfGuPBseVz7pk0U2hPuTbI oH30fwK3T+Cy57VeZZQ== X-Proofpoint-ORIG-GUID: T0FjYGl50ktcMKJDrD5r3csTBf1lyW2S X-Authority-Analysis: v=2.4 cv=a7s9NESF c=1 sm=1 tr=0 ts=697bf872 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=KKAkSRfTAAAA:8 a=uo-a5Ro3onDdK20lcsEA:9 a=cvBusfyB2V15izCimMoJ:22 Content-Type: text/plain; charset="utf-8" After successfully calling request_firmware(), if the firmware size check fails or if kmemdup() fails, the code jumps to the exit label without calling release_firmware(), causing a memory leak. Call release_firmware() directly in each error path before jumping to cleanup label. Signed-off-by: Samasth Norway Ananda Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 054e2c2eab02..528bc05169de 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -346,12 +346,14 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapte= r, bool bUsedWoWLANFw) =20 if (fw->size > FW_8723B_SIZE) { rtStatus =3D _FAIL; + release_firmware(fw); goto exit; } =20 pFirmware->fw_buffer_sz =3D kmemdup(fw->data, fw->size, GFP_KERNEL); if (!pFirmware->fw_buffer_sz) { rtStatus =3D _FAIL; + release_firmware(fw); goto exit; } =20 --=20 2.50.1 From nobody Sun Feb 8 20:58:55 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B08269811; Fri, 30 Jan 2026 00:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732211; cv=none; b=ViZjD0VkKxz5m73OqOiQ8nTCZf1m/56JuYa73z2EJ5vYiMe7cLl5k8V3WeIiJYqcQeAmqbCkOcTZJaqTLwQKHNGVD6BJSeMdapj7DyeheNeb+veU6yfvZEMwgTV18r5NRlKKmhSQQ+ACxFFPS8kOSFWU0XEW7B9f9UTQA6h/IiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732211; c=relaxed/simple; bh=LDO4wnjirwwRr9RpEg1ZK920C0c2biHvXmSTgEPy3lg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S5ZkbmwfXy/G3cQaqnLYCBYmcYGgHkLwnupz46WxD6sTquxwUrWHi43Rdn6fYSrzMIGDV3s875lQYvdR3BcJt+rJhiMxkIzHkCAy8HB1ppqT5+Z74Zd95d/waPNRoArGbnw1Oqgi3jhr0q69OHMK+oX6RPa4Eh7p1eRV7V7ZMHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=b6DYUYkv; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="b6DYUYkv" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TLwXkY676717; Fri, 30 Jan 2026 00:16:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=LXWH+ JTvYpqBkRtPjG3XgN9A0XTahvxPboYf+d5s8ks=; b=b6DYUYkvDgZ2UIofNIT4D 781+03TmcZ1iE9AhqK+o43uEMbhXD/Ch9QpcLOifQIJTBnwcgcbkefYoPRtMfXFB 578WocVYrvCbgHnksRdCQE6dee6UMeosdILNG5ZNsgmQ1j2CNRBZucrD0/9Gs9/+ d37Abh2xi9hXQrZJjgsIftitUEAdduRi4tRVbOJ/u55Oo/V8zfwEefmK1gv9qKtN TpEIhf02y1OZoWyIM4FdF7yy8/X8IbfOAgZiWcbZOpomAXAnf7GRbrwGg/4EUChZ F6wBIEsYIHAfOmoeKtvwp5NMAW8yP48Fdh/Cv3ErqpAOHOCTR+YaaREFqV6qkJ6Q g== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4by2vgmbxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:46 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60TMOcSh010548; Fri, 30 Jan 2026 00:16:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4bvmhd19ke-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:44 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 60U0GgZF007973; Fri, 30 Jan 2026 00:16:43 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4bvmhd19jr-3; Fri, 30 Jan 2026 00:16:43 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, samasth.norway.ananda@oracle.com Subject: [PATCH v3 2/3] staging: rtl8723bs: fix memory leak in rtw_cfg80211_inform_bss() Date: Thu, 29 Jan 2026 16:16:40 -0800 Message-ID: <20260130001641.17941-3-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> References: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601290179 X-Proofpoint-GUID: BlvrcBd9tZICaep8USu_8uupuPCmlf5m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDAwMCBTYWx0ZWRfX/EOIYdkmKBJf L1i6WoVQSNMISzfpVHDTJwSK6HbtzAV6U1ja/SWC2aMLMbaxsbhfh/B1NFjgJukt/1K6bXwOTq5 LnQ7OzA4xE1LgSMobJx6iSGobOYI/2GH0rZ4Cl5O/t/X4J+8/vPz7dw41kLWwlNW7KAluQgYlGq bJCFSudqiwtwC6zLmXnhfUM/eNFctMLdrGCPCZJywbmytN2uDMYY8CCQ4+3m+whip/lKcLS9+KN dJLuaVDJ03BJuaGCQKdvIO1T0b53w5+Sl0rFaw4ddiyp7oQAZ1GKlMKFwA3HryCENMwxYK5fiDx oPIQPwqEn4DFJ0+GsDKY4nGYP5erbZBgJhyty2lIl1CmIPIcVTqDiNJFEgxyvUpdmgICxR7SoWZ xkHN/GBW48ZrSuekbr8ufXGU83gqSN/m3UBJmDuQw7EKkWQZ+COILIlgFMlIEomF5mysWTxSGAN HXhrVh3jqDu4or0Lt5g== X-Proofpoint-ORIG-GUID: BlvrcBd9tZICaep8USu_8uupuPCmlf5m X-Authority-Analysis: v=2.4 cv=a7s9NESF c=1 sm=1 tr=0 ts=697bf86e cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=KKAkSRfTAAAA:8 a=lX7pHSL-l9_-PgaVgB0A:9 a=cvBusfyB2V15izCimMoJ:22 Content-Type: text/plain; charset="utf-8" After successfully allocating buf with kzalloc(), if cfg80211_inform_bss_frame() returns NULL, the code jumps to the exit label without freeing buf, causing a memory leak. Add kfree(buf) before the goto to properly free the buffer in this error case. Signed-off-by: Samasth Norway Ananda Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 60edeae1cffe..d80e23cfdf8d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -314,8 +314,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ad= apter *padapter, struct wl bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, len, notify_signal, GFP_ATOMIC); =20 - if (unlikely(!bss)) + if (unlikely(!bss)) { + kfree(buf); goto exit; + } =20 cfg80211_put_bss(wiphy, bss); kfree(buf); --=20 2.50.1 From nobody Sun Feb 8 20:58:55 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F4626B764; Fri, 30 Jan 2026 00:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732211; cv=none; b=Rzody+bda7pEurUTlkIBeqYz1a1eNELI8RKrfRFdlI4EQAqBXteq2P3AUOz/J6uXN5po/o4PaNd6hmfJQYxuj332rCgXpB8hi7DIaifQvnJ8cQiPYxIMAGOUpWEefnfyDmz9kKQIhYoBky2zFK5BKbdibgGEnRzHjIX3QToa+wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732211; c=relaxed/simple; bh=dDdF8/a1FUED7Dzq6c4djwn+PFOJL64E9hnncpOm12c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kyvHM5QDKlgSfvwt+KrvZTZ+2txTYDG2mthJEDqTbFnTENnYRY1cjWnh6WkjNjP085ZIyqd9+/GSVF3bs9VzmPfzIUKqaMcGizRXqamxG00lXxMaoPWYrIXpVYmhmLcEstEX397tz2KPeV7pnpKXbXe+juT2tX5JfvSoRkzUbAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=WCwU2Y8u; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="WCwU2Y8u" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TMMMQH1278711; Fri, 30 Jan 2026 00:16:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=oVLWJ H4JkrTr6fvY20JVUCLXKWM2kxWYhBmsgJUuiLk=; b=WCwU2Y8uKDDMktnuLx0Ye sBwpaLzfWGsKPCULJJvlkUr99Xtm1P0HJo6ZoEafRY7PsHrkOn0edhubX9MNWA6X RS5FZE8JC8FxyAzNOiQLU9JSeXR+3Aiz7vQ9Mx4Xj/++AQexhQVZE/DipBAVt2Pz PwZyR9F6tGMmi/yTibpz/w1haXPi9HnwUGa9c+NLD6NQaGDqaq8Y3MX5nOfwEWQM 4do0+RMD1CVynM2jhWdLuoQQWV2KiYLfSmlrxaWijhqvC8ynHzi7fnynA+UV7KOY 3dR1DXaNfpUitgg8B6rfmSdjAq9Mdo0uFMjxOTLoRgBhIDZxI2FXLe2n7rk/jG+f w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4by2xqvd6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:46 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60TNj97h010549; Fri, 30 Jan 2026 00:16:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4bvmhd19km-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jan 2026 00:16:44 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 60U0GgZH007973; Fri, 30 Jan 2026 00:16:44 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4bvmhd19jr-4; Fri, 30 Jan 2026 00:16:44 +0000 From: Samasth Norway Ananda To: dan.carpenter@linaro.org, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, samasth.norway.ananda@oracle.com Subject: [PATCH v3 3/3] staging: rtl8723bs: remove thread wraper functions and add IS_ERR() check Date: Thu, 29 Jan 2026 16:16:41 -0800 Message-ID: <20260130001641.17941-4-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> References: <20260130001641.17941-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601290179 X-Proofpoint-GUID: jg7GMaVuDoMxjR731IL2gIgcNO064nWT X-Proofpoint-ORIG-GUID: jg7GMaVuDoMxjR731IL2gIgcNO064nWT X-Authority-Analysis: v=2.4 cv=UepciaSN c=1 sm=1 tr=0 ts=697bf86e cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=ag1SF4gXAAAA:8 a=yPCof4ZbAAAA:8 a=4GFln_ug5z8xBbYvM2cA:9 a=Yupwre4RP9_Eg_Bd0iYG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDAwMCBTYWx0ZWRfX+8Uhx7wka/NU X5hn/CojQlQQtWHA6OP5zKdEsl5w77EmjmbWuHn2lZRC4yeoKRH7kWov9U3wvHRVH4DgybWKRHo POrd6zsL78yOLynfxBjoAhQNn25wmjfuR7NRsNQgklYuGmVFWSp3NXsarOvT+SZFWhv27R6eIBb bsh6FM8MVCxvdin9242H4VPEVQopwnwcZ/PuQzO4IC7+Q8o81lls44bwQjrbYJzWRVC5HcnLujj ljoaiqS3gvo7/z7qsJq0aDtf5an+36ZXYE7hwZrzMjeV07hyYV561CDAKMPwlqfBPmC5FPP6XbT CHxSXzdXssDHBX590FET/IG+youKCcdqmxUOybbhKbJ1LCZt7/vvC7ziHVykFsCty9JLSq4OGDT SQoPjdUapvheVSWaRVXVviJSWwnlWbh52FY568yWPkL8W7NW4pJWxJqKKoaaHgPFY+cvCXhdUTE s9Aw6Dij9dKZpi+mWww== Content-Type: text/plain; charset="utf-8" The rtl8723b_start_thread() and rtl8723b_stop_thread() functions are wrappers that are only called from one place each. Remove these wrapper functions and inline the thread handling directly in rtw_start_drv_threads() and rtw_stop_drv_threads(). This also fixes a bug where kthread_run() was not checked for errors using IS_ERR(). kthread_run() returns ERR_PTR(-ENOMEM) on failure, not NULL. Without this check, the SdioXmitThread pointer could contain an error value, causing issues when rtw_stop_drv_threads() later attempts to use it. The inlined code now follows the same pattern as xmitThread and cmdThread in rtw_start_drv_threads(), with proper IS_ERR() checking. Suggested-by: Greg Kroah-Hartman Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/hal/hal_intf.c | 11 ----------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 19 ------------------- drivers/staging/rtl8723bs/include/hal_intf.h | 3 --- .../staging/rtl8723bs/include/rtl8723b_hal.h | 3 --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 16 ++++++++++++++-- 5 files changed, 14 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 462553d296ff..f55b99f92691 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -218,17 +218,6 @@ void rtw_hal_add_ra_tid(struct adapter *padapter, u32 = bitmap, u8 *arg, u8 rssi_l rtl8723b_Add_RateATid(padapter, bitmap, arg, rssi_level); } =20 -/*Start specifical interface thread */ -void rtw_hal_start_thread(struct adapter *padapter) -{ - rtl8723b_start_thread(padapter); -} -/*Start specifical interface thread */ -void rtw_hal_stop_thread(struct adapter *padapter) -{ - rtl8723b_stop_thread(padapter); -} - u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask) { return PHY_QueryBBReg_8723B(padapter, RegAddr, BitMask); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 528bc05169de..3a8062d31175 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2916,22 +2916,3 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum = hal_def_variable variable, v =20 return bResult; } - -void rtl8723b_start_thread(struct adapter *padapter) -{ - struct xmit_priv *xmitpriv =3D &padapter->xmitpriv; - - xmitpriv->SdioXmitThread =3D kthread_run(rtl8723bs_xmit_thread, padapter,= "RTWHALXT"); -} - -void rtl8723b_stop_thread(struct adapter *padapter) -{ - struct xmit_priv *xmitpriv =3D &padapter->xmitpriv; - - /* stop xmit_buf_thread */ - if (xmitpriv->SdioXmitThread) { - complete(&xmitpriv->SdioXmitStart); - wait_for_completion(&xmitpriv->SdioXmitTerminate); - xmitpriv->SdioXmitThread =3D NULL; - } -} diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 82b60899129d..b193854bfe6e 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -221,9 +221,6 @@ void rtw_hal_free_recv_priv(struct adapter *padapter); void rtw_hal_update_ra_mask(struct sta_info *psta, u8 rssi_level); void rtw_hal_add_ra_tid(struct adapter *padapter, u32 bitmap, u8 *arg, u8 = rssi_level); =20 -void rtw_hal_start_thread(struct adapter *padapter); -void rtw_hal_stop_thread(struct adapter *padapter); - void beacon_timing_control(struct adapter *padapter); =20 u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask); diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index 06e0a549fa9d..7ec84304a19e 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -231,9 +231,6 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter); void _InitBurstPktLen_8723BS(struct adapter *adapter); void _8051Reset8723(struct adapter *padapter); =20 -void rtl8723b_start_thread(struct adapter *padapter); -void rtl8723b_stop_thread(struct adapter *padapter); - int FirmwareDownloadBT(struct adapter *adapter, struct rt_firmware *firmwa= re); =20 void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len); diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index bc02db13781c..6080cdc2a096 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -6,6 +6,7 @@ *************************************************************************= *****/ #include #include +#include =20 MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek Wireless Lan Driver"); @@ -480,7 +481,13 @@ u32 rtw_start_drv_threads(struct adapter *padapter) else wait_for_completion(&padapter->cmdpriv.terminate_cmdthread_comp); /* wai= t for cmd_thread to run */ =20 - rtw_hal_start_thread(padapter); + padapter->xmitpriv.SdioXmitThread =3D kthread_run(rtl8723bs_xmit_thread, + padapter, "RTWHALXT"); + if (IS_ERR(padapter->xmitpriv.SdioXmitThread)) { + padapter->xmitpriv.SdioXmitThread =3D NULL; + _status =3D _FAIL; + } + return _status; } =20 @@ -492,7 +499,12 @@ void rtw_stop_drv_threads(struct adapter *padapter) complete(&padapter->xmitpriv.xmit_comp); wait_for_completion(&padapter->xmitpriv.terminate_xmitthread_comp); =20 - rtw_hal_stop_thread(padapter); + /* stop SdioXmitThread */ + if (padapter->xmitpriv.SdioXmitThread) { + complete(&padapter->xmitpriv.SdioXmitStart); + wait_for_completion(&padapter->xmitpriv.SdioXmitTerminate); + padapter->xmitpriv.SdioXmitThread =3D NULL; + } } =20 static void rtw_init_default_value(struct adapter *padapter) --=20 2.50.1