From nobody Mon Feb 9 00:39:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0E935773F; Fri, 30 Jan 2026 16:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792104; cv=none; b=Trp+NEBEHurq3LNtbMLWK5cyQsEj6EF7ehM+U+NXRfdKrOVhbB9MYqnQSPWA2xRpUe/SmcFyavkwpNudPIUOE8D2i7ZvolTqhHEMikvLcN5zw0sAvZK6ftF+Cgfb8PSp1f/mMoD4K106NMw0bK6YjB0SHFIZdJYC1i+pvkwXMaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769792104; c=relaxed/simple; bh=dM6ywpWOByIu1UZJyYxKcmpZP8XQxaOuztl8PUCyAug=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=luqkUK/lgP0GYMbaZ1syRwmZOGt9/qBR4kPfgrzPRaI/kuU9fCW4Ye6QuLdQ1ZcIDD1mI3wa1B/hDs1vQefKKKiEHt86I+EEfNDLQDWOH+jdIdxhysptTW4H3imxH9AlsOgcWc74VPNVxI1nU3cwVIOaH2uQixYQ8r5O1AqAozU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ocwzdLxs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ocwzdLxs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4F55C16AAE; Fri, 30 Jan 2026 16:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769792103; bh=dM6ywpWOByIu1UZJyYxKcmpZP8XQxaOuztl8PUCyAug=; h=From:Date:Subject:To:Cc:From; b=ocwzdLxsuPFxhBP39QxSReO2ZrhA+Tjmq0FlL6qfY7J8xXJzP3f7pxmdSg/rb4z7A 5TlB15Ph6zXfTwj1rwLL47m37ObmLgfjvjUSSKkORCrxudc8EytBCyGtWtq8jk9yp6 wIY5zHmKCXUjxFsfVr63dGeWkwew6Si3NxSWoxFtUyPZykDkqlHmSzIze6xLzpcqqh mbyY0kIeo36bRS4eqBL9ndnVi/CwvuJUGwa9Q5kZQDDnP9gR5BMfPrtJ7M4HswKcLM L2f4FF1KW4p3DoU2XepgyhUXdADEIUHO2vQQlMeW8o71w+RUzf5+kXN0Xffl6jmLIx 1yE/QQCDvCoSg== From: Mark Brown Date: Fri, 30 Jan 2026 16:54:45 +0000 Subject: [PATCH] thermal/drivers/qcom/lmh: Remove spurious IRQF_ONESHOT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260130-thermal-lmh-oneshot-v1-1-9b132204ef1b@kernel.org> X-B4-Tracking: v=1; b=H4sIAFTifGkC/yXMQQrCMBBG4auUWTuQjljBq4iLJv41I20imShC6 d2NuvwW761kKAqjU7dSwUtNc2rodx2FOKYbWK/NJE4G1+8d14iyjDPPS+ScYDFXPgQcnYj3kwz UykfBpO/f9Xz5257+jlC/K9q2D6yeglJ3AAAA X-Change-ID: 20260130-thermal-lmh-oneshot-5ce7022bbf26 To: Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Aishwarya TCV , Mark Brown X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1867; i=broonie@kernel.org; h=from:subject:message-id; bh=dM6ywpWOByIu1UZJyYxKcmpZP8XQxaOuztl8PUCyAug=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBpfOJkDc9DZd38l/z9fSyCjZxjSYU7zqk3EigJs 5XHAyxAcSGJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaXziZAAKCRAk1otyXVSH 0HvbB/9nZ0sXz3btbZcW4vmORAmDGBE0St3AWpKFslcDPZXiBJnLxeKyk+3vHC2B7m5z+nb1Tz5 FopmF+icQCTKtkBel8G60ghkt6g24NuakbX74gH40V/IYh1p4PnhKPf3b2qiJs6S8bMByO/x1Pc zM64Q8EK4GkKrJwE4BJ4KFdwtHwKjrJJl5fREK+sHkhJjoTECJWnH01EF+eI81Q3D2jv83qX4V0 KCz+IgX4aGECB7wG7tLo6P4tZCaML4c57dSjaKYgFb97kCQblmF2KfwkRKmkldWckiPLmPMMiHo elwno0BCwNrEqc/uA0EVpDTK7w/wH63mSm26jPoxKxZv0AR5 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The lmh driver triggers a WARN_ON() due to requesting an interrupt with IRQF_ONESHOT without a threaded handler: [ 17.414825] WARNING: kernel/irq/manage.c:1502 at __setup_irq+0xd0/0x7a0,= CPU#7: (udev-worker)/154 ... 2361 18:49:55.941384 <4>[ 17.415074] __setup_irq+0xd0/0x7a0 (P) 2362 18:49:55.981820 <4>[ 17.415085] request_threaded_irq+0xec/0x1a4 2363 18:49:55.982122 <4>[ 17.415095] devm_request_threaded_irq+0x80/0x= 134 2364 18:49:55.982365 <4>[ 17.415103] lmh_probe+0x31c/0x4c8 [lmh] 2365 18:49:55.982594 <4>[ 17.415118] platform_probe+0x5c/0x98 This warning is there because IRQF_ONESHOT is only meaningful when there is a threaded interrupt handler and this driver does not register one. Just remove IRQF_ONESHOT, it wasn't doing anything. Reported-by: Aishwarya TCV Signed-off-by: Mark Brown Reviewed-by: Dmitry Baryshkov --- drivers/thermal/qcom/lmh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c index ddadcfada513..b6b7f1193c44 100644 --- a/drivers/thermal/qcom/lmh.c +++ b/drivers/thermal/qcom/lmh.c @@ -220,8 +220,7 @@ static int lmh_probe(struct platform_device *pdev) /* Disable the irq and let cpufreq enable it when ready to handle the int= errupt */ irq_set_status_flags(lmh_data->irq, IRQ_NOAUTOEN); ret =3D devm_request_irq(dev, lmh_data->irq, lmh_handle_irq, - IRQF_ONESHOT | IRQF_NO_SUSPEND, - "lmh-irq", lmh_data); + IRQF_NO_SUSPEND, "lmh-irq", lmh_data); if (ret) { dev_err(dev, "Error %d registering irq %x\n", ret, lmh_data->irq); irq_domain_remove(lmh_data->domain); --- base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377 change-id: 20260130-thermal-lmh-oneshot-5ce7022bbf26 Best regards, -- =20 Mark Brown