From nobody Sun Feb 8 12:51:41 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2EE33A9EE for ; Thu, 29 Jan 2026 16:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703687; cv=none; b=r6GAVIdAvjfduSIqOkswMgsCTZohPw7vx+6x6Z+dCDqm4X/txV6A6yts+DJQPHdD2iLUA7RO5cWKo26ZHm/cfK+hLm9R9sOPHC/E+NxtaT6LYW3441trpMNmy34kQozY1pkhWOeYF6VuHR7atvCfXhjhi5Qyqmm50a7MXW0KgT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703687; c=relaxed/simple; bh=zwjOf1i4lGOL1MPJJBIakEtH6mLVNfzraj+FW/M7s80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=i//Owh4wsQsL1p9S9fdIQFcz2/UKEpyTkkquKc/Lx/F8PFReGUHgooPR+HWjtfe1CO822CY4xC5344UfMtAliamjnVuKbaA2JPplQAV9O8+4AwNWP4hsAhvirukPLtNtcJjWjWaleOH2M5m3T28CfoKjz/DMz1bUQdhRFzPiCPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YcS69cOc; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcS69cOc" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81f39438187so619135b3a.2 for ; Thu, 29 Jan 2026 08:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769703685; x=1770308485; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8Trr4HnVnERvKYHpT258ly9SLNvFfewR7K2JtYDPUe0=; b=YcS69cOchuxcqj9FibpiZxXPHj4VXmN+9UtKbv8jmPreWRwA/OyE7ZGUHcyA3d6xjn zz0kFCMpOG7P0JdnExHC8KFcHM96I8265hiKuLUMs83HHejVb8ud9V7/3Sy8pk9MPMCK wNaHDnWrw31XpydbWxcKbkjUsxw0LSuNlsJvfaeN+p/0EXoJWu/4MBzCNCY5tmGGOyFz SNi7G7T4q4MbJZh1qg6cv38An/fYAYn7kJG44+Y13ZOW+CJ7jPeHLM9n4JdhfmpJAdY3 V/mWjmtdK/xdYVU2u8YoobI6LTlRA07V04mNUqjndR9q9ZM+wAsBoqc3Bw5BoHrmIFrk NinA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769703685; x=1770308485; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Trr4HnVnERvKYHpT258ly9SLNvFfewR7K2JtYDPUe0=; b=aboWVeMAPg5NJYn5/b1DUwj+AZiXtLoH1JhezuVGePLmHV4aVt6cd0R6u9l3LwbW1O goJoXZ/swWre8y3tBPdwXn1dPIHMDl8OcB7v4ZXEvB9PARj0vm3UD4Dhvx9suSCmDuTc nDNLnALinR1AyfCZjCFxB3qbecoC9Jt/6nETiohCPD+chc2lW6WrDpZfJbZRX4n2M/Hb VoNB+4dCIHK554rtdzw/e/yL7Oo5sZXQ4z8u2z/MEJkeA/mI8ZfcNOuaiHolyoLQCwyx KQ//okVgYIgwa7d+8ajRuBEe2wXcsJoZ8TX/uLxDl+0F+Z/aeTZNOD6kD6Q9ncrRCwdp UWPQ== X-Forwarded-Encrypted: i=1; AJvYcCXfL7cxBuXp3jI5aDYQLnUVpgA5oj0j+tIq2Qenq6KE5HJKv8K5XAX/LWHevDb1ytSzbEgQ0ujvrpW2ToU=@vger.kernel.org X-Gm-Message-State: AOJu0YxgKnNyQVerq/8RxsK4IZSqwqUlKtaq0n+7zvtHzGheeGePiFDm VM5/Tnna0d7JObSUiSrbmu7kkAGetHPH2cFLyW2oL826MtnrWG1EJPjX X-Gm-Gg: AZuq6aKISEsCJEM+JTkDoc+98Vdw8SUIwb9dPxreHEZ6+sgeB0OT2WeBUgKgPu7+MZd I30DiTLTsdr9wbIGsyd64MiiS8k7gpjuMfclncn4uZBQ+6qbcvEOO1hNMnxCM+oFBHe3BauI85p yYHe8plvpDyKHdxnfi5lVgkKjmJDkdd0FHvrHP+lJEianxi/d4tzn8GTHi63pcPRy4/4KL8YtI8 F/8eIn3dqRyLFyTwA6NMF12EHHo7AkiSdg9KU9/i8YDCNTu+E795QBzCf+uFlHAnswwoeKpVQmR 7WZ+kIHsRFLNsVphBqljx/XXqS3oJmIWCwsuGMkbW6btxvSAepmhmOVsXmLREfM2OzDsGuzebRR XqnUDh9gQHne5RssbqglM90Q6owAPY39E2x1cWBNOG++NkbBZ1u/Uep6OViCt3E81w+eFfculE5 0/7Peb6B5vqB8+8pbfgJ6c8gIq0g== X-Received: by 2002:a05:6300:4086:b0:366:14af:9bc0 with SMTP id adf61e73a8af0-38ec659f89emr7640806637.74.1769703685336; Thu, 29 Jan 2026 08:21:25 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:ad1a:7b1d:fd68:35f0]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6427da845csm5475039a12.12.2026.01.29.08.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:21:24 -0800 (PST) From: Felix Gu Date: Fri, 30 Jan 2026 00:21:19 +0800 Subject: [PATCH] drm/logicvc: Fix device node reference leak in logicvc_drm_config_parse() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260130-logicvc_drm-v1-1-04366463750c@gmail.com> X-B4-Tracking: v=1; b=H4sIAP6Ie2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDQyNL3Zz89MzksuT4lKJc3SQL06TEFGNTA1MDSyWgjoKi1LTMCrBp0bG 1tQD+jQIHXQAAAA== X-Change-ID: 20260129-logicvc_drm-b85bad350509 To: Paul Kocialkowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Paul Kocialkowski , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769703681; l=1655; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=zwjOf1i4lGOL1MPJJBIakEtH6mLVNfzraj+FW/M7s80=; b=AZvQNLGw15cC8tDIc4KLtq0vmXX9HIPky6bCCDUD1FpTLI3OuIC1YO6wqhZQwCsHIPt3VcjTt vhH9KGeG2y7CPVA9XhXpNJUW6xbTJsv03JnKO/jNeOKNLEkYn1ycpxv X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The logicvc_drm_config_parse() function calls of_get_child_by_name() to find the "layers" node but fails to release the reference, leading to a device node reference leak. Fix this by using the __free(device_node) cleanup attribute to automatic release the reference when the variable goes out of scope. Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") Signed-off-by: Felix Gu Reviewed-by: Kory Maincent Reviewed-by: Luca Ceresoli --- drivers/gpu/drm/logicvc/logicvc_drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicv= c/logicvc_drm.c index 204b0fee55d0..bbebf4fc7f51 100644 --- a/drivers/gpu/drm/logicvc/logicvc_drm.c +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c @@ -92,7 +92,6 @@ static int logicvc_drm_config_parse(struct logicvc_drm *l= ogicvc) struct device *dev =3D drm_dev->dev; struct device_node *of_node =3D dev->of_node; struct logicvc_drm_config *config =3D &logicvc->config; - struct device_node *layers_node; int ret; =20 logicvc_of_property_parse_bool(of_node, LOGICVC_OF_PROPERTY_DITHERING, @@ -128,7 +127,8 @@ static int logicvc_drm_config_parse(struct logicvc_drm = *logicvc) if (ret) return ret; =20 - layers_node =3D of_get_child_by_name(of_node, "layers"); + struct device_node *layers_node __free(device_node) =3D + of_get_child_by_name(of_node, "layers"); if (!layers_node) { drm_err(drm_dev, "Missing non-optional layers node\n"); return -EINVAL; --- base-commit: 3f24e4edcd1b8981c6b448ea2680726dedd87279 change-id: 20260129-logicvc_drm-b85bad350509 Best regards, --=20 Felix Gu