From nobody Sun Feb 8 06:05:43 2026 Received: from mail-vk1-f226.google.com (mail-vk1-f226.google.com [209.85.221.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEC4359FA1 for ; Thu, 29 Jan 2026 22:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769726804; cv=none; b=uAGevXFQm9IR7Oes4j7QDGKlYTEFaYpYX1Ef/XsNyeH6kdK7kuGAx1zo+kI6+Yk+Bp25mKH1/lqkwQmD4OogAsv8C8JXs1d/PlymzBpddD7+u/odUR79C9lTLsEMinXPm3CLmCLj0nVINvnsfjx7DCE4UFcugqqObvLlAXwzOEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769726804; c=relaxed/simple; bh=LxRnyNMqZdQTNtI5+gBDaLbF3eE/PKtyIHlafMMwiDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JtFhFZ3sCD8wy91+8DTnAGwo9/xYMfiKRWwxxrj1sKDaZeUvwT/L4OSRdrBDeE4T/UaQJ67dq9PDJGeIo0QzWk9oQaIVTaGBBm14XShM2okIZeLq9ThKsXV7zXq9wr/Udtnlt4Ywmiyy+3FJTXsQRMUb9iPDx96VkNDVZKB/Gcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=as72ZIVJ; arc=none smtp.client-ip=209.85.221.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="as72ZIVJ" Received: by mail-vk1-f226.google.com with SMTP id 71dfb90a1353d-56634d4247cso50684e0c.3 for ; Thu, 29 Jan 2026 14:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1769726802; x=1770331602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H6ty1uyYKM756sn4TycAtRGFmZ443M4y88c0mPRhRtU=; b=as72ZIVJaOjgNSxMUkBdNpS5Z3BXDpcbxNbG+TWiUprr4lamApg5wZQvxqP2WuMbvx 9rSl4OvvSAh/y3CouJTb6+ZmugQtJTIgSNv3BCAnqsl8zhpIEPejNc6bA/qEaskRyqzg zmKiqc4/EnXgzzDcODSIt5Xgnu0NVJxUbL/wM9tsEqkf4bOir7G65MZKC56ax7Jo4Qm8 0uHxngKDzE0MooQ9Qr+QfV1q7hRaPjwJ1vpsQyWTHfNpUsIW+vI77xvpvmbH+R04Ktvu P/qFdJ1soM093TQcaFXNUCaZdJMutqhsfR/C7LYbcgbGpiB4m2C1EpBFHLreg1QDJMDY fdpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769726802; x=1770331602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H6ty1uyYKM756sn4TycAtRGFmZ443M4y88c0mPRhRtU=; b=c6hy3+4xEBkr0ZORQ/yu7c3nDKW5LvqfytxAbM6mKxEGwYz/Fxf2qVRcBsHPMttrMV Xr8cxI3wTqsaW626sYKScEEQOH4oYGxoO1nyYXcrqyr4Z7Fk6r6eGUZsuqrYHlgMP/6w RumLxcaotHw9cYQ86VbTKMOx0awRrMbFrz4Ve8MgTF+EkvOezA0rc4NZESxm6D2q214d 8M2ksSeu0ypE3TRl6TQqypn+cqAp4phv4djReJPJ+XRNRSvTADzh59nsck/z1AeziVC2 7AlgnZzh8PTLt+DH3qZ/3m2wxbM+e7g8Jd1tWo7C2TAlYI7lY7P+xMGB3/IWzODVBD7y Edfg== X-Forwarded-Encrypted: i=1; AJvYcCVuJmm/z54f9OFLzpVRCiJNLNHS+phM1v0lzn5awDNo/SIo4AYWCs8NSLLZ0vYsZftbT0W8YoOeBWzE0k4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4AzyUBuIEwl90wd8gd7UNUGj7PWTutqoI6WN4oFMoXy9gEUmi B6QXT1tFF/+51jPrkZb9oM2blu8jYqzF0/5CycOf4cakY9QeUajR0Yc5Tc52nmz3gOgfhg5G1jG 55D8knhhkhmZlqFty5iv+KWSqhQf01dnAG66v X-Gm-Gg: AZuq6aLHrIsy1l8nlep/CTEwUe/wXamer09yxIzb2N1/8rq3TFnR2MbcclIxALMit7v GPWwxYNDNoi5JJFc21Haa6OsIRY33jiZ/AJAbfNu8QLDJYPLjjCCL6rwdrBV4gNfKdv0DzNL1zv k4FyHqm9SfuErvYjCm5QXnn1IRg8v1VWv9iNGm/Xq9dEFpQjhFNkmz76sQPRZBsVnO2RJoA5dVM PJUVglGQukEZCZCguizLomdtdfcKzcMLABD6xLFHvNIj9kkyCKXhUyKjxeWtyqrHRguix21cuIG mZfnN1UelrQd+Mc2k5HjIecDY/iLnbxcUaJh+gwB8gS/VXKDuEGG2isDceytjOUI1/a8gWNmeqr dgbISdFk53QJo8f3rMON20aiFrJfNlLOApBVMWGnSyg== X-Received: by 2002:a05:6122:845:b0:566:465a:8b7e with SMTP id 71dfb90a1353d-5669ffcf054mr166347e0c.1.1769726801899; Thu, 29 Jan 2026 14:46:41 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-56685afbe3csm666803e0c.1.2026.01.29.14.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 14:46:41 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 45719341BED; Thu, 29 Jan 2026 15:46:41 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 3E824E40456; Thu, 29 Jan 2026 15:46:41 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe Cc: Govindarajulu Varadarajan , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH 1/4] ublk: Validate SQE128 flag before accessing the cmd Date: Thu, 29 Jan 2026 15:46:14 -0700 Message-ID: <20260129224618.975401-2-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260129224618.975401-1-csander@purestorage.com> References: <20260129224618.975401-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Govindarajulu Varadarajan ublk_ctrl_cmd_dump() accesses (header *)sqe->cmd before IO_URING_F_SQE128 flag check. This could cause out of boundary memory access. Move the SQE128 flag check earlier in ublk_ctrl_uring_cmd() to return -EINVAL immediately if the flag is not set. Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Govindarajulu Varadarajan Reviewed-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- drivers/block/ublk_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 7981decd1cee..72ee83ae303d 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -5130,14 +5130,14 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd = *cmd, =20 if (ublk_ctrl_uring_cmd_may_sleep(cmd_op) && issue_flags & IO_URING_F_NONBLOCK) return -EAGAIN; =20 - ublk_ctrl_cmd_dump(cmd); - if (!(issue_flags & IO_URING_F_SQE128)) - goto out; + return -EINVAL; + + ublk_ctrl_cmd_dump(cmd); =20 ret =3D ublk_check_cmd_op(cmd_op); if (ret) goto out; =20 --=20 2.45.2