From nobody Sun Feb 8 15:28:36 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DA62D94BA for ; Thu, 29 Jan 2026 18:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710572; cv=none; b=o1LgxPro3x8w7AbQBfojigrkzQnzOWDmi8UHb1BsACugekbUDJ5+UxI0Bv8+kVndjOxV6kjqNimwMVBQCA6vin5RRcImMdkgywkoKn9kNLYRibroEH/E16IXIfS5sRUIXvyVWzmtozXVPvVkUlCV1IQhH4hYD5OlyL13ptNu3DQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710572; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IRCCdre9LPrO86YBqv7E7STiQ8UbqaUkr77eRfEvMqnvebX97jaiadKyKE7MoEUe+jN1ZHYbmgn5b6jRaepWfHe8WL7cIi1K7g+ytf2gpvFb6pgQ95GbTMeP8sbN8f2wAarIUW9YmWszjEMsPdNz1ivhZVvHBTYuhpBU0yvZn/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g2jt4Oe9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g2jt4Oe9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47ee0291921so11861715e9.3 for ; Thu, 29 Jan 2026 10:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710569; x=1770315369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=g2jt4Oe9/mk9z6d5htvWYjrnXcufXMG/5soGP44QeKTxLunINL2WbzVFtIaRtVyyUS 59yQoAUninx2dKYLujix7vW+L/ZUVGl/JaRLbi4q1n1WE/Hsz4ln1KmqDjVuGYePuSqd GU6EkRcl2anjTKEHXcIuR3E1/VcDSmUqJk4IjKnd9UavG8dK3kZzhuUgeG444YaK21UX ih/qN6eBNlvqcVU64+QWRKNK8LOVP8YMDWsI8ZGhp00ccrXyCs1DYTCJYAhN4+E1cSDW e4YaG4ideVZvO5/Gws8vG6B7Hr93n6NrhIDO4G/VBB3mCOnk73wJ2slAVb0AbD4z6jEd EiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710569; x=1770315369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=jP/jLMaBZbBaWw+NIwlQOdbSi9YrXkjRoPiVBHNdFcrru06X5AUBUCN5A4zJv08ExQ qWK38bYq+8+IUaNWlSaR19xfZb1y6oknZI0eIiWSXm348pcB+qnQg0fwZ8lPpFeqJz5G TpFoNEU2gROb5ieskIUmbvfRj2KUvhmGE/bWTqLYg4/8yE2kXj7TGL1vZDBH8Rw7clrn 2OsbtpcMCfa/A/gr8ZpSte93rZzAABm2A1t4gFqgZg/bLMdQBaNX/g8bT+drqJVx13lA qNkRB1GW8euOBPxzN0Z3bdLqd67DwkKu4LxHi9ZT2NNk8lXliTO3aAgHAwzpI9JfllTi DB9g== X-Forwarded-Encrypted: i=1; AJvYcCUw1dWtTOJqrIUquFIJGe5C7f6h+qF7UrAReH5cKYELtwvVS6ZLj0YQgS+wlppEpsTi+M/j18VPaoSiXsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqg+yxWv3Iabzbuo2lLuhmzsk7PO7J100WrqJARkNt4zHBDjf1 31HscE1Hy9iFsPHb1jALbEyHZ7lLavR5+EtO8jRBoXcxW3IFx0RTf/E= X-Gm-Gg: AZuq6aK5QPuZeHvH3nTXn+E2zt1KQ0y35K5ClBuzbks8qMkQ5acCDHSPfn4P51e2qPM ArrZVZNY928963YGKvGBpTQqPkJT6iqRJkJVjA5oeiwJ9topOmXitTYdy7NrT0Lw+QK79fq+8Aj vxpngAjbOm34gOG+YDyti1rK1TW076MnYeyaHcS10arsqv1Xp0RBPBliFXLue/LdFo9XObRvg0k BE1YFDjkuGf7lr3ujTAbhQfxq6ulzfVc4ifUAsSECBSnGlxr+iucbZwVSoiiZeGwpVL8iOC9fA/ CA/Ykv5y1h3eQQJK1UIhnSE5eDiqHzZPPTN5RqAHJs/f9OfN/9Cv6oqBjIvmG6ky/g0xKizRfNd ALkBT3xmbeBD+QgMM8TuusGroZrjhhKiZLjiOyxtayRRUtc+8/QLSkE/1jIqopdPOfa1y14hh06 5R X-Received: by 2002:a05:600c:1385:b0:47e:dc64:f1c6 with SMTP id 5b1f17b1804b1-482db493eb4mr682455e9.6.1769710568712; Thu, 29 Jan 2026 10:16:08 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:07 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v4 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 19:15:38 +0100 Message-ID: <20260129181541.72066-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0