From nobody Sat Feb 7 22:54:59 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 216292DB790 for ; Thu, 29 Jan 2026 18:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710570; cv=none; b=qTb60AEmp3a91WjjlkpFYUt3fku3JjmIqKwYZUOOez8bOo5iHO91k1s4mKyD8NxPica/hVv/tkHCHXB7UvTRIejPKdE1zgonWnaIWRKnYKlYvAlTksfN2P0cP/DreJ7TvyhtJ3Gp8PwKptFOwf0sC0MqsOwW1odBi+EmBPe/n8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710570; c=relaxed/simple; bh=anusSg+ei2G8pY99kSNGBiFGkxTuVaDv4F/ejqaSEKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UjCB4fbFtMdjuGywNrhGJ7aopt5fon+IGfm/dH6YJg8hxpVoGQTsmvSVL4kV+HzacpK1abuf8ywxLBZuDvhlwLTYNSv1KoMrES0g+0jDEVPZKwKfjRw7n+TYv7693vbz5aPyT+fFtBztKMDUVxzlw3NwzP7JSxTx78cfPuRezTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k0LGEX1n; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k0LGEX1n" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so10364505e9.1 for ; Thu, 29 Jan 2026 10:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710567; x=1770315367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkmQJfRqTQzrHHgjjnSwxvqZrCWnUDQPc30Wk1HVPk4=; b=k0LGEX1na3lo3P732hXVTAUHKW+aQG5Qc/hJZryrvCM87ON/dBBfi6cb2zh41ZYVqR ZpDMfom5nQzLIEFSe/YjjOdaabDSFuHCfYdwthStUicuG9hgjeh7IdVcRDIPb7V1zdlF spmXIMO8VY1RB39DnpVcdhJkJsT5+KFfDCoid85J+8w7SkRDz0QXR/Q/Ouu/WuUrP82c MgmUJycBHK0ZVOzjMv/66CnwoKAZhg3TMqQkdPnxEqaXPjssEnQPLrU5KAvi/uOh1L5y aD+qe82/1NdlhYefVsbfWnwT9pjduPpY4YIkuHYUvbxgEpt9YnJY1er/M2+V5DQMeJai BE8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710567; x=1770315367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YkmQJfRqTQzrHHgjjnSwxvqZrCWnUDQPc30Wk1HVPk4=; b=qyhLuYeHLc3n1P4mDMmko/CUvvActGRTznjt8LRYScMM7kFUcfBsQMQ6rmTY6+A6IV vGxyy0ltZn6kPpjEyJBmB77+jpnk4wjYfY/RXTkhz87d1xpvGyx1/yt7pBiUnNHLdjc2 nqGwhHLwlZkK2c5rVxTn/lqhOwpYuROkF7tlnyYQyTeiu00vOAeq4te4nYs5ibKOOSyu GQvvi0zIDEyonP0QTGmYuJiufFzVZhJl6m3r1dkCpi2GM627HO4V0JN66riY68qJ/o5D FPKf1DnUC0mWFeZrDAlYgbVc82msoH+ZDNbelLgGVTWsNSNHydFgFp/bWJ3FRVcXFczk jWIw== X-Forwarded-Encrypted: i=1; AJvYcCVQRGlk63uuHnP4IAzduftXQ2s4c0FVzJad7G1cWlM23qGYQyJkDkLK1UxNAleWOAyJjps2MaX78adf4as=@vger.kernel.org X-Gm-Message-State: AOJu0YwaZMkmfFQvLQTJSVr2EHw0oRueN/RIFVQ2SxoFbwqWc03rIX+J hCFBnti/TBYO61MpC229Yx4NtqMoTQj5paFy6BH8Sg+QDD/iTcWMwVbwo7qjxnU= X-Gm-Gg: AZuq6aK4vL/LYFQCqrJY1ZUJNcT66LNfbCzuScg/41kQWHoH6LEHvCxpCiVtCbO4qls sGj8SxrFQVpmCiwoUya1fLj5HP5DxTC7OoDEffrFQ8IR8tcaLObQiliBU631rW0g32Z/ZHOiwEl onUHoPl3LnMhC37aVY3zBvIgnUZoOqOIwcIQMK/rpCx7lMZ66mkuq++G9e7lhUar3O5VElUM1jE iq0J19Ncfg65pTOReOBzUbKXd2fxzi6DZ04ejvHFZxpMfxN6Wj61vUWlJFvL1LTEeHDG2ifacLR NoyJokKicPyl8kv0fM6YXwke60NssxY3EQYi6JexE8EDRdiev3THuXccsextNd2+YWdAEP3fqnm icZ8ESJncjQFb6h0zicvLsbej51lDifxWxOjzs4jpqPcEgApIfscByCkcv+ni01W0WU6dtwql7E nM X-Received: by 2002:a05:600c:4443:b0:477:7c7d:d9b2 with SMTP id 5b1f17b1804b1-482db4a1030mr491635e9.32.1769710567195; Thu, 29 Jan 2026 10:16:07 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:06 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v4 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Thu, 29 Jan 2026 19:15:37 +0100 Message-ID: <20260129181541.72066-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0 From nobody Sat Feb 7 22:54:59 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DA62D94BA for ; Thu, 29 Jan 2026 18:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710572; cv=none; b=o1LgxPro3x8w7AbQBfojigrkzQnzOWDmi8UHb1BsACugekbUDJ5+UxI0Bv8+kVndjOxV6kjqNimwMVBQCA6vin5RRcImMdkgywkoKn9kNLYRibroEH/E16IXIfS5sRUIXvyVWzmtozXVPvVkUlCV1IQhH4hYD5OlyL13ptNu3DQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710572; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IRCCdre9LPrO86YBqv7E7STiQ8UbqaUkr77eRfEvMqnvebX97jaiadKyKE7MoEUe+jN1ZHYbmgn5b6jRaepWfHe8WL7cIi1K7g+ytf2gpvFb6pgQ95GbTMeP8sbN8f2wAarIUW9YmWszjEMsPdNz1ivhZVvHBTYuhpBU0yvZn/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g2jt4Oe9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g2jt4Oe9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47ee0291921so11861715e9.3 for ; Thu, 29 Jan 2026 10:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710569; x=1770315369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=g2jt4Oe9/mk9z6d5htvWYjrnXcufXMG/5soGP44QeKTxLunINL2WbzVFtIaRtVyyUS 59yQoAUninx2dKYLujix7vW+L/ZUVGl/JaRLbi4q1n1WE/Hsz4ln1KmqDjVuGYePuSqd GU6EkRcl2anjTKEHXcIuR3E1/VcDSmUqJk4IjKnd9UavG8dK3kZzhuUgeG444YaK21UX ih/qN6eBNlvqcVU64+QWRKNK8LOVP8YMDWsI8ZGhp00ccrXyCs1DYTCJYAhN4+E1cSDW e4YaG4ideVZvO5/Gws8vG6B7Hr93n6NrhIDO4G/VBB3mCOnk73wJ2slAVb0AbD4z6jEd EiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710569; x=1770315369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=jP/jLMaBZbBaWw+NIwlQOdbSi9YrXkjRoPiVBHNdFcrru06X5AUBUCN5A4zJv08ExQ qWK38bYq+8+IUaNWlSaR19xfZb1y6oknZI0eIiWSXm348pcB+qnQg0fwZ8lPpFeqJz5G TpFoNEU2gROb5ieskIUmbvfRj2KUvhmGE/bWTqLYg4/8yE2kXj7TGL1vZDBH8Rw7clrn 2OsbtpcMCfa/A/gr8ZpSte93rZzAABm2A1t4gFqgZg/bLMdQBaNX/g8bT+drqJVx13lA qNkRB1GW8euOBPxzN0Z3bdLqd67DwkKu4LxHi9ZT2NNk8lXliTO3aAgHAwzpI9JfllTi DB9g== X-Forwarded-Encrypted: i=1; AJvYcCUw1dWtTOJqrIUquFIJGe5C7f6h+qF7UrAReH5cKYELtwvVS6ZLj0YQgS+wlppEpsTi+M/j18VPaoSiXsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqg+yxWv3Iabzbuo2lLuhmzsk7PO7J100WrqJARkNt4zHBDjf1 31HscE1Hy9iFsPHb1jALbEyHZ7lLavR5+EtO8jRBoXcxW3IFx0RTf/E= X-Gm-Gg: AZuq6aK5QPuZeHvH3nTXn+E2zt1KQ0y35K5ClBuzbks8qMkQ5acCDHSPfn4P51e2qPM ArrZVZNY928963YGKvGBpTQqPkJT6iqRJkJVjA5oeiwJ9topOmXitTYdy7NrT0Lw+QK79fq+8Aj vxpngAjbOm34gOG+YDyti1rK1TW076MnYeyaHcS10arsqv1Xp0RBPBliFXLue/LdFo9XObRvg0k BE1YFDjkuGf7lr3ujTAbhQfxq6ulzfVc4ifUAsSECBSnGlxr+iucbZwVSoiiZeGwpVL8iOC9fA/ CA/Ykv5y1h3eQQJK1UIhnSE5eDiqHzZPPTN5RqAHJs/f9OfN/9Cv6oqBjIvmG6ky/g0xKizRfNd ALkBT3xmbeBD+QgMM8TuusGroZrjhhKiZLjiOyxtayRRUtc+8/QLSkE/1jIqopdPOfa1y14hh06 5R X-Received: by 2002:a05:600c:1385:b0:47e:dc64:f1c6 with SMTP id 5b1f17b1804b1-482db493eb4mr682455e9.6.1769710568712; Thu, 29 Jan 2026 10:16:08 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:07 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v4 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 19:15:38 +0100 Message-ID: <20260129181541.72066-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sat Feb 7 22:54:59 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F20802E542A for ; Thu, 29 Jan 2026 18:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710573; cv=none; b=UGVmy2qvtfSLMIgY5aEhFIfzniAmU1iddH3EMHfP8QaP2pvrPB69YpzLZrTqZiMnFyukMVQv6NubhoEH7cCBoOhzHrXRk5OPfMfF+xhW423Gl6kpsvRthgSwukDc42Mg3CV1MWK7ZvRbQwo9C3cyz4ZWNTI4bW/4ZSNROCwOpx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710573; c=relaxed/simple; bh=rydnYZqJ+NFeWlELYNoZjjVmnW/PmZZQ4nMY0FQMv2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B3Kcis/wkKLmpGXtHFgavaEpPV/nC6Pol8aFFoZnvz+fS7VJx4CDzwPOCMqnubhl2zuLvr3MKIWvE/6ZuvZRh0LUTwjWzETBiSX4CiMumqo4fbV1ccpzHDgAx79205qHqUcOR2PPpNy0gKr8DTgRkINncadDo1H1uPpyXbwoUX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PVQYL3uo; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVQYL3uo" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47edffe5540so16048565e9.0 for ; Thu, 29 Jan 2026 10:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710570; x=1770315370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=PVQYL3uoUcB5Ia2BB3QSIrFFxeVw8mWMGLut0ivBDdppO5yhc4IKPgSQrsf9SfDVYP w/Uueil5njmTPbmf4iVOuCesi9tHp2PNTSsWorSek9rieaOjGaWgAXvuwxM2PKiD2LGz U7hmHMe7USlQn/KE97z6GlSVSOB9cQOIaRPcCsXE93uL3UkbcbAh4lbq45zoQDGBXx3x CwRzChGcJ6Su2OVE+9EntGX+OSWF9hgUL0k1fz0VqNafeQlgTbeKVXD0YDE/V5+j0vhI nJso8rO1yuYzvWSY9iYstErU0ypAqAwtG3z5wOoDQFb0vi6jWArcQZydtsqLSoO0/60O A/Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710570; x=1770315370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=TsbXYeJDUQebCeSqMbijzAV/HhNCxUlLp2q95q/LgZCtYj413Tpel9uZqA1beTU9xb 4SlGU6mwC9YpTeM+IXXSscSQG+VUWYayJCv5RfpFAyDDqE97Bs/R8bFXklmt5seIGxKk q/fghgsTQpu2LU8a/+hwapFT7IFWLQRDbH5t6L5WqLaeZQCNflBS6ClxuGpxLtGuTmtn QJ+qjXygnyLQgPqTWqPu35gy5hW+bEy+mhdG03FunX0OMMoKNAMEthSnXmXcjDkSJqT3 CJozpC0nE27JEkFdurjDE77Or1RCtQI1dAIRtMFm1wG9PgODyG2JHxv0ut1ce3moHG60 WvAw== X-Forwarded-Encrypted: i=1; AJvYcCWQopIDVKhU+Sk1uOa4pPeAve5Tz5XxkqcfjUGXZKMY9D2isqp5oSysrk08U6B/7T+x73Z3hTsNyXtR92Y=@vger.kernel.org X-Gm-Message-State: AOJu0YybW6ntnbAnQyzOoHcO3usXsKpIGyKcLMcYYRzASRsDn9gm0bYc mVcbzA8NdzfbtnzzQxpVb+iZiRk3ZdaL9qyPqTyMAtWES8OZIzF24haSELtFrfw= X-Gm-Gg: AZuq6aIuldP9rYNYyLNC1338u06cui7XLnMSaeXfx77yWFzGXmJ3HWHv4sbBQvKf5yJ AxZflR0NtpesuH5ENuvnZfuBU8mInWDiJl34+qopRef70AlO4ps/jmrrgqWD421vjfJ37fS0NiF MdydOzpSDARWDUKfftoFb+Z+7ztgwW5nn0OGKQbLOMmGLdTD0EnxzKZliRrUKTVhSmYUykQFnUL e65/KlSzpaM9pGcE0r+JLAb9ohBzkHkGT0D214Monm+lwmLNlPfmJijyOzxSEBXSf4vDK7gWGhC 3pBQOcOl+fRh9Yn9sNaebhQJCyluAeB901g8uUXv8xwnyiQN8QtJFY6O5xlAZchruER/6K3abjX 6jOJEO6ZF4RIKGy7JLjpdZhL7u0qN0caQfgStUDWnWXf5WNPLR4lOFEavz4jLsB4NaK0ITlTZap it X-Received: by 2002:a05:600c:474f:b0:477:98f7:2aec with SMTP id 5b1f17b1804b1-482db4592e4mr1009175e9.3.1769710570317; Thu, 29 Jan 2026 10:16:10 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:09 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v4 3/5] staging: rtl8723bs: fix spacing around operators Date: Thu, 29 Jan 2026 19:15:39 +0100 Message-ID: <20260129181541.72066-4-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix coding style issues by adding missing spaces around operators. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 +++++++++---------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index d75a63fd8a6b..ae5e4980ed06 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -17,8 +17,8 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) =20 if (enable) { /* 8051 enable */ - tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, tmp|0x04); + tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); @@ -158,23 +158,23 @@ void _8051Reset8723(struct adapter *padapter) /* Reset 8051(WLMCU) IO wrapper */ /* 0x1c[8] =3D 0 */ /* Suggested by Isaac@SD1 and Gimmy@SD1, coding by Lucas@20130624 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst &=3D ~BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); =20 /* Enable 8051 IO wrapper */ /* 0x1c[8] =3D 1 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst |=3D BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); } =20 u8 g_fwdl_chksum_fail; @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c774a9009e95..668616efa68a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -875,7 +875,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) rtw_write8(padapter, REG_RSV_CTRL + 1, val); val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); val |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, val); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sat Feb 7 22:54:59 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7159013C8EA for ; Thu, 29 Jan 2026 18:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710579; cv=none; b=WxrwO8oKE5Eurmui9Q1yXZE9UDHZ+dedD0T0sOqQ4pdVte1ywaY69MmTZ0bBCH3NAapgs5LJnUmXxDUq0Qp9NpdwBBnznLcY6F/SK0ZZEN7wzafrNakrIkG7IBrONBjK26V+RsLVqCgcZC9faXaBYDzgVISBLYTU9lbCK0aP2J0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710579; c=relaxed/simple; bh=CZJy9AwA4Sgm4gCqYXz1Hym00u0mLZnP0zXpIppJ/CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ofxTSCypPPcyKZxAPAAIAF0KQwsdF3icmrTyTTbcY58xteXr5xmSRCS597Baeee/oJBPtZPQFiYELatW4Q55HEJ0ScadF351Cxf2LJ+YPwolTxB+Hj0YSR1EIwctyK7G5rzeYvWSjN6u/yh8M95L8lvjYztfs8LrJV/xYoc99DA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dKHdAl72; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dKHdAl72" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so9534295e9.3 for ; Thu, 29 Jan 2026 10:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710572; x=1770315372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XA8jrJdAQr2ZBByq5plnySgC50OA+uorsxCy1149Tlc=; b=dKHdAl72LYi7FfAr3bDAvaLOYzTBwGyjRJ8jq7gV+5pdkStS2YGkg8TSwvJ77NRPnx pj6tEshON9558W3uSnW76srI9TNMaG2g3AH1oih3RHsklR5n1NsrBvv1cR6yT/fwnDMq WnzzmJayU860fCDfwnUWNHR70CTB11aVzPqghmx3vn2yVGlmKvm3gzHMeLjjjderjX6B UG2/J8OWvdX0WbwTomqWwWpzatDCXRcb3XbwQhjoE0y7/qzWKj2p60W6QD4S9Og/VsD/ 0dw90Ms62gk6CL7a7LUDn0whGphYYRDRkutc3eUwk+hg4kVaKD/GqI8AFLLl978Sp/q9 +cfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710572; x=1770315372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XA8jrJdAQr2ZBByq5plnySgC50OA+uorsxCy1149Tlc=; b=g5IEB/WLYTCYIUlnVjvgK+TUHqrJOnBafIro4WT0A+vpewcM5ghpSv5TEiXdTzwLPD V5Qu6NdUNtOesFuNszyZpplyWwUCH0m+aXP4rzsCqFAE021ihcQ7qsptkAQNHiaI+54M aYubs2x/b6g6RFxol+GQosYu2GPJa6sVaxnezNQR3RSF7xjdi3U3ZhjKdWxrjfG87MG9 FpBk++IhJr6jY8ZiCsHLWOET7RFbgwInmQGVb3gFalHUVSC7HzXzF6tlZ4j7M/CfI2Xb LyMGFost4LD6PkxdgpW4Kkx15cVgz1XoGMiV2EZCLVxQ5/7X/HRoeo72qTuDp4Hzx3Wh 5UmQ== X-Forwarded-Encrypted: i=1; AJvYcCUUyF7FRXjPOsfmBezz0fzsQNqOcdywRpGsS1sg0+Cw0hvwCYF4PWsNNQS2Z9QZzzorA63AJ43C6/faGmc=@vger.kernel.org X-Gm-Message-State: AOJu0YzJSBpZXJseGQqZYGzN9VAjfYnP/NbliIjqAQbSQORZGJksruR/ tGJMu/HMBWeMpd+q0JE0Tbptn2D0hKdnxWoj49s1hxolBn0nexNb0YY= X-Gm-Gg: AZuq6aKS45Nupcw4kXIs5RcCYHID9H9lSoep/xQ1TAyILvQjTHriWIcYcOc8hr5XaKt qgOH6ZFsxxL297RAGjOwoMWEroYbPs3QtOJYltSURIZ6GQyywMtw+L2kqTG8V5w+dbImhjYWH5b MBJdRqJHFn9/vA4W9FJvy8AvyI/HCsa219PvNNRD1v/RGXznZeqLlL72iAySfhZvy5Dw/+Xl1zL w4IR+5ccnEjDD8jZmLcUKHK10x22RMUXb5quIe72oZgbV3V7YTDYHKdLk+VTqn9lZmaetCB88nl kpZ2WGcgxclANFj8SXcb3B9sGnYg1bS0y2S2Xb87tYEcblcAohnqNTTzAj8CJLKrOFjP3a6Kl+b SInEmB8u5GGrgdk78rLntRbhgMbOcRdlBsAe144Z0Q3iCY+EhEsmP1c2TUqG8yFoVbNox2BhMWD QPczAVOc2nnls= X-Received: by 2002:a05:600c:6214:b0:479:3a86:dc1f with SMTP id 5b1f17b1804b1-482db4973c7mr354435e9.37.1769710571836; Thu, 29 Jan 2026 10:16:11 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:11 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v4 4/5] staging: rtl8723bs: modernize hex output in rtw_report_sec_ie Date: Thu, 29 Jan 2026 19:15:40 +0100 Message-ID: <20260129181541.72066-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual hex-printing loop with the standard kernel '%*ph' format string. This simplifies the code and uses modern logging practices. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7dfc2678924e..5e79a720710f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2071,7 +2071,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, = int iEntry, u8 *ie, uint ie static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *se= c_ie) { uint len; - u8 *buff, *p, i; + u8 *buff, *p; union iwreq_data wrqu; =20 buff =3D NULL; @@ -2087,8 +2087,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) len =3D sec_ie[1] + 2; len =3D (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX; =20 - for (i =3D 0; i < len; i++) - p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]); + p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie); =20 p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")"); =20 --=20 2.52.0 From nobody Sat Feb 7 22:54:59 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F9EA2D94BA for ; Thu, 29 Jan 2026 18:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710578; cv=none; b=ageyQ9r00pm8R/pAADECQHCFTvW8KyBy5xGLzYZ6zbElZgj9d56qA1i8OEkYeDqw49AVGVVp333/EK0uw3Qr7hWfqEyH3GfGcXkpMwORA7lL+Pf46rIKpeyufZwcRq9ghosh8u0s2+A2ox/MeEwPu1xFevkCy6L+h7V25D7Xs60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769710578; c=relaxed/simple; bh=bUeyerzNTibRKm7wU0xU1y09XX+nLkg2/OqCGqcSZ+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bBCYaIt2wjxJ5ANbGq/9nOxG5HLi47R1cWkTjx20cM4ses3BrGSDhPYlOWmkO8bPXu3pt1ltUs3mJD4b2K6nOKidCNgXJGWJ8Ny0/Hy+7Ye+hr3cmKWtEJiX/xnRFPf9zE2/pBdyASZR/dcwPstdCM1OibMlFM/o1WXPFNxAPpI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YP2vxTu8; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YP2vxTu8" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so11755075e9.1 for ; Thu, 29 Jan 2026 10:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769710573; x=1770315373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=YP2vxTu8lpRXhpyR5xFMllDHyoWBUho8PSpcq30zWQ60ef7UDz+nSfDoG3R2F92FvX rK3IpVABwbpTwiZI2gCYfGP89Nd0gzj3odoIvgUCZ8drQymL3FRF1b78G1BkwHvBZYPH RBWCJH7UDmCosF+wTJKfR8frIvnsXj5gt0huCjCpkmkoOWLbXPA4Wg9qWkx9ULM8FBfd NCB/LEA11oumqxir0lgH581ti/EEcMeWO/5+mxYMPZhMkEUxVvZlimxaUHqW9OBUm+7R iWAzxaHYXjem4CdtSxV+fvBsF56YOA3sK+eYM+rFdx2Xifsh2KinCvZPW7ybPvYpkCLP 23Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769710573; x=1770315373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=r00D2stQd+yx/X6K8lZd95/4arLmE+E8V7RIRDqS1Pxn4aNaUIk8IV8YcpnNpsIcTD irhakgR8I/FloqfyUVIYcJy3UX37ISo4bXAkk1duMhhq89IVMKeXh2VnBRs+Tyrhb3OM XcqT+A1NnPDBKGCJfAvdlcHU/NwBtYnCZGafbau04uw6+HAD7ORTCh4Y7fKV4VB2QMBo RvzrWuSlOSRAEtvZFwQUnJIpPqjIl/lX0lsIaeiCtsAGbpjx0jz3/riI7B5wvCyTG+qo xnF8/H3OVm7XBWsOsAkdL0UkxdRLZiuHnzTKKNbDzdNBjAQbjUrtJZIazwqyVfsz6AB+ It1A== X-Forwarded-Encrypted: i=1; AJvYcCWI3VQpEaeftUb0YkvjbCjC02kOHhS8C1xQHq7uVyxmFDD21kh+j0YHelsRlgSRzFKwstZfZhGX9rxHjck=@vger.kernel.org X-Gm-Message-State: AOJu0YyCCyuu58pL7siamzvetrG6xEOOSFx6v3aFBYsEuxZwjG+7N8qH QgoswmcW/uecAMblDfqppbde0rraOy1bmwD7U6A98+Zwf8LZxUjKJ1M= X-Gm-Gg: AZuq6aLxJoI5zq0S23LBPRGk+6aKA+FkNoG8Icjf5j8pWmg3iQ8VWCMJVehibF9aQ2G pXwBHC7qRMtT4mknnNgpFOmM2cP2LckO1ANrU7bhC3LEHC6bFDvd5KxLZxZYMlrJ0WngraqH5BN /vS3x0N9UiNRTFeEBXftGD/7aHgcXPc2pm41C1BZBOkZXdxJvo45UVpPe2CkvEKD3nk8EJoPMbr VmolcMuocOJzwN9iPCbJk3k1K/pVOFTVuZAtdoB7Kq987xpzKGAaxMaiWsBux7r+JpaD9TVEeB5 ZMMi7djsVFRh3+41tpJP/1zaboSVchdSnENiHodf2dHMtlFX/9xmgVYzeD7UCLwT67PD/PqmP6g itU8GylZGKEIo1zvvU+xCmY48m0ESQPor/KPIHiU+3dLgt/+CuEkF+25SgVd6mGE0ciIzj7aPlr WGHXop3uZjc5k= X-Received: by 2002:a05:600c:1388:b0:47e:e2ec:9960 with SMTP id 5b1f17b1804b1-482db49e83bmr594265e9.35.1769710573291; Thu, 29 Jan 2026 10:16:13 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm136578725e9.8.2026.01.29.10.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 10:16:12 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v4 5/5] staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c Date: Thu, 29 Jan 2026 19:15:41 +0100 Message-ID: <20260129181541.72066-6-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129181541.72066-1-lukagejak5@gmail.com> References: <20260129181541.72066-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused local variable 'pattrib' and the unreachable 'if (0)' debug block in OnAction_sa_query to clean up the driver code. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..b61841bf16a5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, un= ion recv_frame *precv_frame unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame = *precv_frame) { u8 *pframe =3D precv_frame->u.hdr.rx_data; - struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 @@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padap= ter, union recv_frame *precv default: break; } - if (0) { - int pp; - - netdev_dbg(padapter->pnetdev, "pattrib->pktlen =3D %d =3D>", pattrib->pk= t_len); - for (pp =3D 0; pp < pattrib->pkt_len; pp++) - pr_cont(" %02x ", pframe[pp]); - pr_cont("\n"); - } =20 return _SUCCESS; } --=20 2.52.0