From nobody Mon Feb 9 11:07:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7341D350A2C for ; Thu, 29 Jan 2026 17:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769708010; cv=none; b=JxljBRDHLlL0FzzflXirf/X4J+ok8yBfSbBROZYEfTV9EmDPXRQdtteBlgA4X9nlEhsPYUAe/vRnOKET3qGdcwHS5MK6/Kkxk8L12eFyiZx0xmcN2xExPjWHbaHR8TlU9zVcKJHIuG9Y9+HGI23vrsttrUGq5xyIs6rBjJG+ZZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769708010; c=relaxed/simple; bh=cP9ImyPYruN0FeNx01mj+tkT0nwjlqhKHIucgPinDcI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XUA5n9XJ2lBxQdWDTuECXmzXxzlPIrqzJyCWsymbBHOUk+nJyA4YhJFr/mhkTgQv4cLHJCp83/MlYWKV31+F7oo9Y5rJN5eMuPfTTVE5/kvSXP2uAHaxaxRJsaCVdipVMXRrtvnlKP3+tBPn9TmJ8pa/EX1qsSFzAZnEWoV7bzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TduDiyPb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BntCl+1F; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TduDiyPb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BntCl+1F" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TAF8ph3143755 for ; Thu, 29 Jan 2026 17:33:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=SXcG6vSc5h00yKZCJrXX/UCp4GEdgmAKFHM IjIBgThY=; b=TduDiyPbBDdzPTAjhKcZ36GpeFPAQBYOp+QnDQ3OhmIhhfk6Rx1 2M/JNzo0HlXND/lX5KgIpx7YKgknykYGyzLWmUhSm2w1cyfRTPwwU/LsOFemDwjm WpTHCzq9WXERQ8Qxz0ugraWmITz3EHSka21kOjWYKNJtbZqNU5DsCYfgWAkPDSxE gsSPgt1TqQf0gA45oTnHzIFKwH7HiHm4AqJAa1Y+IVqj3Ac2g31txsD9FCMch+1f mceTBeU5/At39Pm5bqRuusX/4HdKnGSdnSve6Ffaivm9hVEtIrA30J5qZj50kFqg gxG+cHQiY1M0o3/GaFPvrvBNQIgXW9EzNmQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byqpxm313-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 17:33:26 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c552d1f9eafso2200263a12.0 for ; Thu, 29 Jan 2026 09:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769708006; x=1770312806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SXcG6vSc5h00yKZCJrXX/UCp4GEdgmAKFHMIjIBgThY=; b=BntCl+1F8d7b0wcFIDClTGFFuo8Eg89F+UoBtuDbSrkdDhIp0xWMRCIR/fuKW+3jiv WceAD767Hq8iLIunv9ilLBpQD9sX736Dkb58Tq2j6PRZVuN26vT6E5PmdPje2hV/f025 fLR/n5QT5eM7VP3fYm+nWbYGXbRqcb20nih1IkoVH2vtttWVp8g3gBbaq7+qD+eCWXKg DAHMt+fTksYFMHmPzdKV9tEByZLJN3ErFeK/0sDZVH63VW7ooD9RvR41Ff1A0x3SDwC7 ZLu6faRiLu/bP+qdbq/gS7fEV0+2vbOscUsk9iKsGA2hRnND5LvXQFzsw/68jpdpJUwO X7PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769708006; x=1770312806; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SXcG6vSc5h00yKZCJrXX/UCp4GEdgmAKFHMIjIBgThY=; b=qlgfsWGzOJm9jOlTsHcRD7zYZzIkwEytBJzJ+gmQ3/FhZvAqH/DqM59eh06SFO3p7a xZoATCjChQq6D7mzZ+pORodKD3rBCVdgfIN5rdkpnyMg2TX477ZkrziSaUm34U4mF1JR +Hx4I0yV0XhrTgm80+4G+rHUcyQol13SuJ/lmyNAe5lCmznwiZc2KDSkbciC1iED/Q+5 ijyoo6Z/7wRYjFX9SvyvRFHebNbZc1qfB5TrAZq63C+stJrx6ydBE5J649xPSuGTKOGr 7ljGB6/z43cSAa790+g3TuCPWbnDk/AA0Wnsh6PvEcSr4C9/83w615iuPUDcTYh9ZLkn kMsQ== X-Forwarded-Encrypted: i=1; AJvYcCUr9QcKLMR5feiBPp5qIaqUABCdid1SG9WbYjSoBs408Dzd1rFgfIIGccxmuSM5XmcENEakVx1fToV0JZE=@vger.kernel.org X-Gm-Message-State: AOJu0YzESgqn0gZoa8XlfSXhT/vBDEXhhC03EVrziNIFvufxB3dM5TaB 19fVv0hEQZUJmn/+ibMhuGGOpmG6fMp+57l14KEwjEBrVBwP1pXt+QLQU4ve5u3nLBgSP1sg04s 0jHpWVkSxs9M6pJlEk0qRjAc6kKJ4GgmU+QMHYo1bwEfsPP1UCwUZVjRQYRAhVTEoWrc= X-Gm-Gg: AZuq6aLvrnJCBTz6c6OqyQdIEbdW95djNmOT5efSYvzr8uMO5x7bPtpPvAdWvznruBd i1o7Hkfl3L3F0E1rcG4oQ8ic10yYQlfZEjhV7AxEeP/lCOwCSpJDfMjaTXUeZps5MwJ/FhDGTJ4 Iks4Q1C88QsG+Lmp3qZYg+bb0WHPd/VfG0INppOAp+TIKdJRC0S016+GjMnFb6Nk1BVTqIjwiAu 5JaAwLRMNFDYmttilUe6KFrCna0PFZ/zILs7m4L1wgu2E0d0X/o8hPKggEBEyuilZuYK2v1PkGl CcxSXDrKjZZzG0i0AjZIJm7geQPNEyx9/NsviG3uIrD+R2xOmZo+RA9RsJZDC6RpFdv80MoSZlQ o0tLET1nhFGTIB8gmGAv/PXZKgQ== X-Received: by 2002:a05:6a00:1893:b0:81f:b1d4:b486 with SMTP id d2e1a72fcca58-8236917312amr8954555b3a.8.1769708005328; Thu, 29 Jan 2026 09:33:25 -0800 (PST) X-Received: by 2002:a05:6a00:1893:b0:81f:b1d4:b486 with SMTP id d2e1a72fcca58-8236917312amr8954525b3a.8.1769708004687; Thu, 29 Jan 2026 09:33:24 -0800 (PST) Received: from work ([120.56.206.147]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379b19a9esm7140604b3a.11.2026.01.29.09.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 09:33:24 -0800 (PST) From: Manivannan Sadhasivam To: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bjorn Andersson Subject: [PATCH] OPP: debugfs: Use performance level to distinguish between rates Date: Thu, 29 Jan 2026 23:03:10 +0530 Message-ID: <20260129173310.7241-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: FiOpcKgdu5c3w-Xw8cPYMnvuflPEtUhT X-Proofpoint-ORIG-GUID: FiOpcKgdu5c3w-Xw8cPYMnvuflPEtUhT X-Authority-Analysis: v=2.4 cv=dfSNHHXe c=1 sm=1 tr=0 ts=697b99e6 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=P6uRILVbsMQsecLiYV1+kQ==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=LWgc-Xqq43gjV1u_ZOYA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDEyNCBTYWx0ZWRfXz8aNRQjHY/4h txM1d+TCDOqEIx58P3CJixOrtYHuU48Lubnj5ucf01Nja0zNf1wn3WecHvX+QSTMkT21fd18g1M pXINevd1afjv/boH2CyBwLRLgSClh+FTrnmHZn3xhjiJ+O6pIsqonGbw8r53jF9nDK+MLHFfxVf 1i/nwHvazvaZcvMPIWu0M4Ws4q/tNddkoVkZ1lMmr+i9joL2yx0Zk+zY8NOj4jzEJ92ip4fJBrG J8gNQtNjQHrMr0duztQa+SMd8vt7zgEoRBgXEt472GoNdV8lvDY/cMg2ix9Hv0V/ZVBWdXPxArU DPf1saZpyaz+tqZ6Yj4Jr+OZpLh+/0SvR+pwBcYX2Lzbr633egbqi6p0Kk79HNOviFJp0R9WZt7 mu7Zk35PhItK1NOVcZ670lYoAzvnx0ka0QDcXmOpO//5740Cd8VjxkvJKFom7G83zXPqeanYvsE cqfA1E6IPD9B7HfJBCQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290124 Content-Type: text/plain; charset="utf-8" Some OPP tables have entries with same rate and different performance level. For these entries, using only the rate as the debugfs directory name causes below error: debugfs: 'opp:5000000' already exists in 'soc@0-1c00000.pci' Fix it by appending the performance level to the dir name. Reported-by: Bjorn Andersson Closes: https://lore.kernel.org/linux-arm-msm/75lzykd37zdvrks5i2bb4zb2yzjtm= 25kv3hegmikndkbr772mz@w2ykff3ny45u/ Fixes: 05db35963eef ("OPP: Add support to find OPP for a set of keys") Signed-off-by: Manivannan Sadhasivam --- drivers/opp/debugfs.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 8fc6238b1728..7c912bae2a5a 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -131,21 +131,24 @@ void opp_debug_create_one(struct dev_pm_opp *opp, str= uct opp_table *opp_table) struct dentry *pdentry =3D opp_table->dentry; struct dentry *d; unsigned long id; - char name[25]; /* 20 chars for 64 bit value + 5 (opp:\0) */ + char name[36]; /* "opp:"(4) + u64(20) + "-" (1) + u32(10) + NULL(1) */ =20 /* * Get directory name for OPP. * - * - Normally rate is unique to each OPP, use it to get unique opp-name. + * - Normally rate is unique to each OPP, use it to get unique opp-name, + * together with performance level. * - For some devices rate isn't available or there are multiple, use * index instead for them. */ - if (likely(opp_table->clk_count =3D=3D 1 && opp->rates[0])) + if (likely(opp_table->clk_count =3D=3D 1 && opp->rates[0])) { id =3D opp->rates[0]; - else + snprintf(name, sizeof(name), "opp:%lu-%u", id, opp->level); + } else { id =3D _get_opp_count(opp_table); + snprintf(name, sizeof(name), "opp:%lu", id); + } =20 - snprintf(name, sizeof(name), "opp:%lu", id); =20 /* Create per-opp directory */ d =3D debugfs_create_dir(name, pdentry); --=20 2.51.0