From nobody Sun Feb 8 11:44:48 2026 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D2B318B94 for ; Thu, 29 Jan 2026 17:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769706743; cv=none; b=KfVGS0eyUYwuTLAriTDyw3gumv5rxpMIVZ4W7WAL0Aw5HInBwU4iIu/jScT/LYzKmh4QS/cUiI9AdmAfs6bsX3Bb+W/qzODLrQy4LSZfD0pajkv8WABhc9jP3waEZEHZiAvJeJyeYaHaeowsEHxblCt2xQ7raD7pjHcPYx1QtK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769706743; c=relaxed/simple; bh=OXC1A2rsvEUcoHNtQ2UJItXyNZCYYO98F6lgzlaZNyg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UucEqKaAMzI/a4mZeCba4OSGZMYjhTL+0NwXfZnDAvxT9wtYJBAZbIL1wokhRJql98lpWVxEK+XlHlX/wDjm9Ijyfbliy/MbfnR/iXnTYI5lWRJ/3XS0QenRbstHzpXHr4wtFd4TCJkSvf5RL25poa0nv2tS+cihmhj1+vHtvL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iJdBs1Uh; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iJdBs1Uh" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769706739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwiQGEV6gt5loAkyx50doAeyjzyj3tZN9e7LGO6xQp0=; b=iJdBs1UhjaO+argsRf0QDssIhZtdEWNURcYRXn0xhaL9XkL+VDwsHZtbGqSiL1p+EKtggj onxMDUpcomBMZX+B6ebYLmkafj2cV2Zmw0rjheGTeHZH/FSWnhUwJ41tNnCI5QgQjeuHNX F6xDARAbSi8lzyaH99pN03c681YaL60= From: Sean Anderson To: Andrew Lunn , Heiner Kallweit , Russell King , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S . Miller" , Eric Dumazet , Sean Anderson Subject: [PATCH net-next 1/2] net: phy: dp83867: Program TX FIFO for all interfaces Date: Thu, 29 Jan 2026 12:12:04 -0500 Message-Id: <20260129171205.3868605-2-sean.anderson@linux.dev> In-Reply-To: <20260129171205.3868605-1-sean.anderson@linux.dev> References: <20260129171205.3868605-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" All supported interfaces use the TX FIFO register at least some of the time, so there's no point in checking the interface. Retain the check for the RX FIFO level since it is only used by SGMII. Signed-off-by: Sean Anderson --- drivers/net/phy/dp83867.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 5f5de01c41e1..7e16e9299457 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -744,27 +744,24 @@ static int dp83867_config_init(struct phy_device *phy= dev) */ phy_disable_eee(phydev); =20 - if (phy_interface_is_rgmii(phydev) || - phydev->interface =3D=3D PHY_INTERFACE_MODE_SGMII) { - val =3D phy_read(phydev, MII_DP83867_PHYCTRL); - if (val < 0) - return val; + val =3D phy_read(phydev, MII_DP83867_PHYCTRL); + if (val < 0) + return val; =20 - val &=3D ~DP83867_PHYCR_TX_FIFO_DEPTH_MASK; - val |=3D (dp83867->tx_fifo_depth << - DP83867_PHYCR_TX_FIFO_DEPTH_SHIFT); + val &=3D ~DP83867_PHYCR_TX_FIFO_DEPTH_MASK; + val |=3D (dp83867->tx_fifo_depth << + DP83867_PHYCR_TX_FIFO_DEPTH_SHIFT); =20 - if (phydev->interface =3D=3D PHY_INTERFACE_MODE_SGMII) { - val &=3D ~DP83867_PHYCR_RX_FIFO_DEPTH_MASK; - val |=3D (dp83867->rx_fifo_depth << - DP83867_PHYCR_RX_FIFO_DEPTH_SHIFT); - } - - ret =3D phy_write(phydev, MII_DP83867_PHYCTRL, val); - if (ret) - return ret; + if (phydev->interface =3D=3D PHY_INTERFACE_MODE_SGMII) { + val &=3D ~DP83867_PHYCR_RX_FIFO_DEPTH_MASK; + val |=3D (dp83867->rx_fifo_depth << + DP83867_PHYCR_RX_FIFO_DEPTH_SHIFT); } =20 + ret =3D phy_write(phydev, MII_DP83867_PHYCTRL, val); + if (ret) + return ret; + if (phy_interface_is_rgmii(phydev)) { val =3D phy_read(phydev, MII_DP83867_PHYCTRL); if (val < 0) --=20 2.35.1.1320.gc452695387.dirty