From nobody Sat Feb 7 14:15:44 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9BF21CA0D for ; Thu, 29 Jan 2026 17:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769706622; cv=none; b=nqfJ7kh47h6o8uDpQCu5hiyUwi7PPxfZVjkgWMqrSkjhNpioOFkewePIkJ4SQrG06kjcQ7EdkbsMdFplNKGl4uteY/9iNySG9yi9Cu+PVMt5gj8OrRco2ZO7YZ+Ehp0Iq93CWqOHGkaMHhaZ5boY8KC0GVDzizmTmh8ILU3LdYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769706622; c=relaxed/simple; bh=3ckAdoRifO8lQvfDhsBEfRZFLerezsxYlzbmZdMPjrw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BmXqrZYW6klPd4QWDUZKKQJCAjOG8uPI5Vbll4d2C9OPKgQOlxWMb2JeZfpLkMOVS2VgDwanXFrpjfrgFLWrlrgCSuZHrTXqCBbRhms+FbtKnu4PFfuU/PH/wDmjeXO2lYm7OWnrIoSMlJOzK/hWX6Cr8CDdWiZ4ho+DblGBYnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TSRA3v7Q; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TSRA3v7Q" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-81e93c5961cso1013329b3a.0 for ; Thu, 29 Jan 2026 09:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769706620; x=1770311420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=67evvbj+2qIRK0KIahn0IlunJhUk/WhkeokzHp6+kbo=; b=TSRA3v7QEcfAHJ6ETCyCnb48FlwMsiJvEht1udZOw87E9IuVJxzg1Zb6j1p1xnu0RX McAUD8hF82GlpMLTA6TPH56pvXkrF18Ngl4hnE6GknNmDQUoTTxF8gbx59c3frhzf6gO Xvg2hvX/hYX9fkrau8Kc1nL5ZugHzHya5sq6Bqy7j+uaX1xyJ0eKCL7QEBcsYtF7wQST HuH4QiJrcCWLsE823YCvVrFwct0Cjs8IUtersReHrRAmBiI1rzHqxrBr5jygzLIcGbJe 1FaRN52UzmaRIsF6MNAcunvuhzGRttsP+dmiGZctsNsmJBg0E8u0AIypVKM44zm7ealK oNxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769706620; x=1770311420; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=67evvbj+2qIRK0KIahn0IlunJhUk/WhkeokzHp6+kbo=; b=dk4qsvCphQXCRpIG0aWiMVHZQ34zM5+l2lZ5MEMuDKdio3K78LeYRn4KgN//FOwg3t k72lulnak6wmxx9ptn1GLWnus9UMJ9CNtPxZXr/LKh2hYg5WsQPrHEkxkhzceWobRNGP 574E0iQv7xkTLYQQjRy8QmMY9EzsOAYi7fFHCWsoMZgBGihAzamzcJhUZrX3DAgT++/O Bmredmoumdjf4gjtxdhp0OVzIauoNCxZSLe0QrBNox8BBJ4VNuENXZhZvmCt+ETw6Ai0 kRjV5xfOm85CXNCMnFwgV5KtUirn3YmC0vM4QhvS6FWG9Yp9epEKKyzyCjdrKwlhmRuM IWAQ== X-Forwarded-Encrypted: i=1; AJvYcCWZF7DPCtFCvuBUTB7CSPvtYjIDpToTY1TwLDzVRVoIVYY9bGi/Z8lp9BHXY//SWnVexrXpwWhMWHVZwqA=@vger.kernel.org X-Gm-Message-State: AOJu0YwSnnwINHuTZx/2Zqmvw/ppHplMSJMUwricD89Ki6SZACe8d9d4 r45k18ilgu2CRXPtyIKZ3w1AckpPXxWHs67rv0MHWe3JiLW4uCLEZz5M X-Gm-Gg: AZuq6aKHFy95JQMjQ4riyf4mZ25hnBv/QBaON1KGOdyL2bcgb7m2dWe4md9600XKMqQ NWpAMttTS6zJBzZaQawpsr3LTjeC6eH/jpPh9BCbdUOQVY2v0rtgTZz4fsEYL5pWsklwHK5lGDa UmObkDNs1V2UyB52X2L+GZ34zxAVadx10B8m4r1Riex0LU4d3rwbbIGPQvyVGYC4wgksBgxc4wv Rs8zLcedTke3ZnAV7lUhtZUNRD287/Z594dTyrQpPau2Nvz0gATlulLmA/GlyIJXT0WeuzLOOLI 8xEZZCe6fFUm2DiwfrkCe4sx6PqMuVOm8JaJLjx1oq1gkJqnhfBXXWbwj3FU040lk7Ob21ASLrw PDh8CZIgPKfuJTYJPsEHdZM3PI2EVNR2cuGYVjqwSIN8WSk7Q4bADYoDx1crNVHP0tnkAyuUj0p e+UGIyhTvwTNj6T2GOmg== X-Received: by 2002:a05:6a21:3994:b0:38e:676a:f31 with SMTP id adf61e73a8af0-38ec62dde5fmr9223382637.25.1769706620221; Thu, 29 Jan 2026 09:10:20 -0800 (PST) Received: from localhost ([2404:7ac0:6a85:f78d:610f:9387:1245:5704]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642add55adsm5153767a12.32.2026.01.29.09.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 09:10:19 -0800 (PST) From: zishun yi To: Min Ma , Lizhi Hou , Oded Gabbay Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zishun Yi Subject: [PATCH v2] accel/amdxdna: Fix memory leak in amdxdna_ubuf_map Date: Fri, 30 Jan 2026 01:10:22 +0800 Message-ID: <20260129171022.68578-1-zishun.yi.dev@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zishun Yi The amdxdna_ubuf_map() function allocates memory for sg and internal sg table structures, but it fails to free them if subsequent operations (sg_alloc_table_from_pages or dma_map_sgtable) fail. Fixes: bd72d4acda10 ("accel/amdxdna: Support user space allocated buffer") Signed-off-by: Zishun Yi Reviewed-by: Lizhi Hou Reviewed-by: Min Ma --- v2: Add 'Fixes' tag drivers/accel/amdxdna/amdxdna_ubuf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/accel/amdxdna/amdxdna_ubuf.c b/drivers/accel/amdxdna/a= mdxdna_ubuf.c index 077b2261cf2a..9e3b3b055caa 100644 --- a/drivers/accel/amdxdna/amdxdna_ubuf.c +++ b/drivers/accel/amdxdna/amdxdna_ubuf.c @@ -34,15 +34,21 @@ static struct sg_table *amdxdna_ubuf_map(struct dma_buf= _attachment *attach, ret =3D sg_alloc_table_from_pages(sg, ubuf->pages, ubuf->nr_pages, 0, ubuf->nr_pages << PAGE_SHIFT, GFP_KERNEL); if (ret) - return ERR_PTR(ret); + goto err_free_sg; =20 if (ubuf->flags & AMDXDNA_UBUF_FLAG_MAP_DMA) { ret =3D dma_map_sgtable(attach->dev, sg, direction, 0); if (ret) - return ERR_PTR(ret); + goto err_free_table; } =20 return sg; + +err_free_table: + sg_free_table(sg); +err_free_sg: + kfree(sg); + return ERR_PTR(ret); } =20 static void amdxdna_ubuf_unmap(struct dma_buf_attachment *attach, --=20 2.51.2