From nobody Sat Feb 7 17:04:39 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF180296BC1 for ; Thu, 29 Jan 2026 16:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703140; cv=none; b=XqyD+JT7bKA0XE9WJQPwP9gMkSFkm6D2cu4y+35chT1MPo1jvX9eRHxYBXx12R7h8kUo4GujfQaa4FZxzDjjOfnoOl/u4BgElTQ4UbPZBB6ZLUIgKi9qmng11ur1Wd/aZmthWu/eLFvnGOoWxv7AyYtEJr9+XuFzX7A4YKpE0ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703140; c=relaxed/simple; bh=QH40RDUeKpt5r31k8MiwmTN5CwlPV8u/qUOIpL2Opbg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JFPwPIxMBtUdHSNulavehlzarqAU0jVuiSPKmyPlBl671UTX6U40zU592xA9qi78Z9uUGvDsKFHVdYhm0DM9d5N45nGvb8B/2GTua7BS6EvirwN8REIis0FbtNplyR70HCxUloV3ZQXYJ43Wi/T9oL9X9yXJX7A4evfNgOrQzF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z65dhBKU; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z65dhBKU" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47ee0291921so10739415e9.3 for ; Thu, 29 Jan 2026 08:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769703134; x=1770307934; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T54lN/2f0AojvVlsbKqfRuQ4ek75UA0m33GBdVgd0ok=; b=Z65dhBKUzNVABn3Igv4BWuFO18tBdX0zmxYXh1e39vbcGoOmGxwxVRAzlGcR40tHYE 6tnZNGL0vNi6zmpsOPZvluipCkNnhxm+OZ5ENE7iaz74hhPZMTD/dIJyB0NRbli0RwNr vFk3hR89Zh+4nmJRGwGJXcI4vqfQZRL95fHFs4uQxakoRQ86UAZ6w2FkQKttk+10ibSR GZ9rpCl5vPICWmdT7eSmddl4NvHSz5XKU/RXCYTAh+C4xD2eIJQFUBzF/S9bK/A/IXHb 8LEoWPXxbGjimYczI+afArCGYtuZPoRqD9hO7gCTjMgTPbatVz/hxJbP919/oR7FfaNK GbAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769703134; x=1770307934; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T54lN/2f0AojvVlsbKqfRuQ4ek75UA0m33GBdVgd0ok=; b=nSJZws6d0tpci8G3RTZqixRhg2s8HoZuj7kuxT21TzsbkDUorqpi5ELG96MecycY9k 9tCkbm7sMoPBOQLHd1MyPsO+WP7fkurtyVOoKsVt8WiVeSJIo5i7XW1qUL8RivU8OuCc DCLAtt3UUc2c2v0zsO1w92A3s1RMAwRtNP1jRcDv2qWKPAAbfXMAudyzZ9j9oiCFkxjD H9ix8+EMuCLAdYbamIVX+/GTN/2n308qYFWUkhfVvtwsHu4j4LWWJGHy0wSmGUgp7MQK XOLjFovNyxjk76XFzwy63lIxNXN0QYmTiCDjAsvJPxzb9CCccnqR6iUv0mQGYDWE+xN/ bKJg== X-Forwarded-Encrypted: i=1; AJvYcCUaJmHM/+/2tXSq3fba/2Mz20xUjSZJQX42QqXYVAIK/4En+zuLgDlbnyMgR6ojNgGIsXMeAtBUN2eJDTg=@vger.kernel.org X-Gm-Message-State: AOJu0YzR/6Qhxw6JGj6agTeW3usWpvOHrIo+WsIhVkxtyf8D0GX2F3pS GBk9P89mw9BAmCLf0gEOhpRwJ7JXY/k3ChPS/gQhQWNpKooT5pMgV9V7 X-Gm-Gg: AZuq6aJN5aZ9sLhxkzhdX1cehf6kyZC3wt59UkqYnYnV+/H0kSLm4GerSI34Z0Zq5+Y 7BYHFYN9AwrtTu331F6w9RmGCMDZWSGFNa2PHO6OrVs4Ap5/2YJaj7liInWhfJrSzDil7D4IuS7 Macz0GXR4xRdXpdsrqvcNeBWpCovaGWJuNBG4LzlbqnyWkEafbCHmD1ow2iVkBk4eFPpPDlVHIc sEZpck0k1XtR/a+aof09+j16lT5kGo2hS4mvCe8zp1SKyj+gF6ohnmjApWhXZRU9yxWyCpmxLoI +kwkfaewRxz+DVVfP3YTMHm0wfhkiDDdm8of4n5BcUicm8CEABgGp1Oeb4VMK8MOOHncekkez+X KGyJC4alSzTThKzErtRsIkj4HiSHgCy5j+lFfqrWR8AF+JB4Y/Xf5grPd6sFDIhX4it6nhY8lUP s2O0nN0hpV9A== X-Received: by 2002:a05:600c:530c:b0:477:7b16:5f9f with SMTP id 5b1f17b1804b1-48069ca23e3mr129097865e9.31.1769703133577; Thu, 29 Jan 2026 08:12:13 -0800 (PST) Received: from localhost ([87.254.0.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5dc8d41sm11135e9.13.2026.01.29.08.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:12:13 -0800 (PST) From: Colin Ian King To: Greg Kroah-Hartman , Hans de Goede , linux-staging@lists.linux.dev Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: remove redundant check on status Date: Thu, 29 Jan 2026 16:10:58 +0000 Message-ID: <20260129161058.197372-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The check on status can be removed because all previous assignments on status are followed by a goto statement that bypasses the status check. This minor issue was detected with Coverity Scan static analysis. Remove the redundant check and some empty lines. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 884fcce50d9c..606fc6726155 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1265,19 +1265,12 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) else pstat->flags &=3D ~WLAN_STA_SHORT_PREAMBLE; =20 - - - if (status !=3D WLAN_STATUS_SUCCESS) - goto OnAssocReqFail; - /* TODO: identify_proprietary_vendor_ie(); */ /* Realtek proprietary IE */ /* identify if this is Broadcom sta */ /* identify if this is ralink sta */ /* Customer proprietary IE */ =20 - - /* get a unique AID */ if (pstat->aid =3D=3D 0) { for (pstat->aid =3D 1; pstat->aid <=3D NUM_STA; pstat->aid++) --=20 2.51.0