From nobody Sun Feb 8 17:37:20 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDDC33B947 for ; Thu, 29 Jan 2026 16:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702685; cv=none; b=F5kKqObdbPJePoWEWRtYf1TdCTQTfzZ2sJD7Ipe6V8SGR+P9snCayAlQFzzlKzJw8Cj35QE5mmbdloLKDSzMzjRiwLaC1iFx/ZOHc8qT5mEA436ahWyrYZE0i3/Uwb6SDBTqxnuDyveEYrMUuvO7Sw7eTSSLfa+PDjdV0jrlSzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702685; c=relaxed/simple; bh=pUp+c6LTDlpKVOYcI/ycGERoQP85AZkoROMK1FDTJ1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XLkVoJ1A/qQdohDrbGclvswTk0lO9WEF7YzsF0ofAlWMRVwD+WXXKvzmBrdJ0J/dOeRqbarg/jpZiG9kfC1qop90BejTEaX7B+vg+ugAF1VW9u3vIs2NBxkNYxTRf00gck6GpYen2zoPF04TaPGvGVBgjyR3GQbGZi3JpDOZKjk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W3qZjlH1; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W3qZjlH1" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so8984525e9.0 for ; Thu, 29 Jan 2026 08:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702681; x=1770307481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FwLJT/eb1tpcmkJAI7RUjujsGl2skEe6JBPlya1TjJU=; b=W3qZjlH1MqnNim6RqHb+MLVXRHY9onx5y4oGuT7c4dgiyCD7DSwiNa9aBBJeFJdbmO ezumWQUbzfAP2JkO85PdKJM14kSIKxIBdQrUAzqv259MHtJ8N31ASXJIUGairuyBUPxY s4ow6NT3njvwn4oJy7Js1Gy+5lnM0Ni3QRGQKDvQrDQVF8hawrESOQxoPiYEEme/oAT4 fe97KWOzeR5swv0vGXF5d7+Oz/Usq61GlZYWT3j2+1dnh3gO5GqyJGY/Gjwl7dZUqCvm z6h12ixs21vG1UPjesrCRUpA6M56aiMdKTzlOdP46LQIh6LhxDPZCSUhbf0UG27X/tVB r91Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702681; x=1770307481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FwLJT/eb1tpcmkJAI7RUjujsGl2skEe6JBPlya1TjJU=; b=hQcehk4+sdbOkdewm5ndei2IzjKEMPWq/3kqYtr9IQkcqj3c4c0PhAK/QdegiD258X Kq4Uwbttq3F6mqkSqK+/HA/KxtIEQSbAyb5Rzt9uAfGHoq/QPMZvFKQbUwEZDK4AwGHN wBzMr9d/KF0WZgGu8Q/KC8XpCxlD/U/lDspGuFNOye5mISlHhm+ACgez+2cKdONLXG78 dbQetEQOh4kp2SrQq+byZDPBbeOIqTly5NUxWEKawN0U1g4Pm66yXv9M01k4nhKlUwFQ JXNw4cRuiPFE6qSx+fVnOTaGSHX+xziTQuvg7C7eiAAqftieZOu3r6EttFU2jV5stcFj 61wA== X-Forwarded-Encrypted: i=1; AJvYcCUrwgdqC8+8x0JmPw4p9xFcM2E+j2Yji3aYXPwDImZfm4Li0+BLjZ+S6XjHadFO+SrWQzwaVMw2JJCfbBw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/ThwPkiSmhroAX+dPd1lk8PMr7caYJOO1BIgwNo+W3c/iHxTI 3x5pgzCIueCD6hx+KMlf3lgBVRY20iBjYRXJz3xoqgmMqramhM6Uy10ybUmyqyMD X-Gm-Gg: AZuq6aJBhRVffcSyKHxM8uBhOSEoU9c9njXPkbpZEhNvsX5DZK1Nb+hd3YJwX1mOUPx FTXYKsNDCnQl8Yg500weuGTnXXEJgN6ibIagGOY7WiDzJuFJNQ8Rk4V+7j6UpD26yaCadyfkAXi cz9c1HS/XtLqNhFHJ4zKQIjA1BE+3aoS+fTxBV8SxCJs+w1OUPz+J13TjXlZDMPGFwBCGTyOdV8 MyiKMXc8lnPF9eEqSY0ZIG4EGnMII5zLIrRwc1s5zYDz5ohLSf77XFwFprJXr8gTz8QuHjoFfsk qy8mqG2QiHQDiEpLpIqac26PJs9rDj9pg9IpcqQvuqLd05NinMBRbKSF0XHqkKGn2eki/ZiHxQo tLO9fWF6d9VyochxSWxaGHwQJPoqy2rYcOmaMDwuWTVmpmmwOQmu0xE3KoM+mzrB1UdrnVtoOkk urii8h1zAMjuYTnlT+ttJIzugi0gbsoGh6sRCwWyVDakwics1e5Q== X-Received: by 2002:a05:600c:8b16:b0:475:de14:db1e with SMTP id 5b1f17b1804b1-48069c8c0d2mr127173095e9.24.1769702680506; Thu, 29 Jan 2026 08:04:40 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:40 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 5/5] staging: rtl8723bs: standardize comment style in HAL Date: Thu, 29 Jan 2026 21:04:26 +0500 Message-ID: <20260129160426.13737-6-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel coding style for comments requires a single space after the "/*". Currently, many files in HAL contain two spaces after the "/*", or use irregular indentation. The modified files also suffer from this. Fix line comment style inconsistencies by removing additional space after "/*" to adhere to kernel coding standards. Signed-off-by: Mahad Ibrahim --- .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 54 +++++++++---------- .../staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 32 +++++------ 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_BB.c index 988636a16112..4666b2ff3157 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c @@ -11,11 +11,11 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D - ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ - ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ - ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ - ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ - ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ + ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ + ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ + ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ + ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ + ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ =20 u32 cond1 =3D Condition1, cond2 =3D Condition2; u32 driver1 =3D @@ -31,7 +31,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 if (((cond1 & 0x0000F000) !=3D 0) && ((cond1 & 0x0000F000) !=3D (driver1 = & 0x0000F000))) @@ -39,16 +39,16 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, con= st u32 Condition1, const if (((cond1 & 0x0F000000) !=3D 0) && ((cond1 & 0x0F000000) !=3D (driver1 = & 0x0F000000))) return false; =20 - /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ - /* We don't care [31:28] and [23:20] */ - /* */ + /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* We don't care [31:28] and [23:20] */ + /* */ cond1 &=3D 0x000F0FFF; driver1 &=3D 0x000F0FFF; =20 if ((cond1 & driver1) =3D=3D cond1) { u32 bitMask =3D 0; =20 - if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ + if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ return true; =20 if ((cond1 & BIT0) !=3D 0) /* GLNA */ @@ -60,7 +60,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const if ((cond1 & BIT3) !=3D 0) /* APA */ bitMask |=3D 0xFF000000; =20 - /* BoardType of each RF path is matched */ + /* BoardType of each RF path is matched */ if ((cond2 & bitMask) =3D=3D (driver2 & bitMask)) return true; } @@ -216,16 +216,16 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -240,21 +240,21 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm= _t *pDM_Odm) =20 if (!bMatched) { /* - * Condition isn't matched. - * Discard the following (offset, data) pairs. + * Condition isn't matched. + * Discard the following (offset, data) pairs. */ while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ } else { - /* Configure matched pairs and skip to end of if-else. */ + /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); @@ -476,16 +476,16 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -500,20 +500,20 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm= _t *pDM_Odm) =20 if (!bMatched) { /* - * Condition isn't matched. - * Discard the following (offset, data) pairs. + * Condition isn't matched. + * Discard the following (offset, data) pairs. */ while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ - } else { /* Configure matched pairs and skip to end of if-else. */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ + } else { /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index e428884335a8..9a3393f5122b 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -11,11 +11,11 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D - ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ - ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ - ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ - ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ - ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ + ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ + ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ + ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ + ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ + ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ =20 u32 cond1 =3D Condition1, cond2 =3D Condition2; u32 driver1 =3D @@ -31,7 +31,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 if (((cond1 & 0x0000F000) !=3D 0) && ((cond1 & 0x0000F000) !=3D (driver1 = & 0x0000F000))) @@ -39,16 +39,16 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, con= st u32 Condition1, const if (((cond1 & 0x0F000000) !=3D 0) && ((cond1 & 0x0F000000) !=3D (driver1 = & 0x0F000000))) return false; =20 - /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ - /* We don't care [31:28] and [23:20] */ - /* */ + /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* We don't care [31:28] and [23:20] */ + /* */ cond1 &=3D 0x000F0FFF; driver1 &=3D 0x000F0FFF; =20 if ((cond1 & driver1) =3D=3D cond1) { u32 bitMask =3D 0; =20 - if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ + if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ return true; =20 if ((cond1 & BIT0) !=3D 0) /* GLNA */ @@ -188,16 +188,16 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigMAC_8723B(pDM_Odm, v1, (u8)v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -218,14 +218,14 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm= _t *pDM_Odm) while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ - } else { /* Configure matched pairs and skip to end of if-else. */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ + } else { /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigMAC_8723B(pDM_Odm, v1, (u8)v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); --=20 2.47.3