From nobody Sat Feb 7 14:15:36 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC94309EEC for ; Thu, 29 Jan 2026 16:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702679; cv=none; b=EdCy9W9hcwNw5qVaoVFejD6zo9WIded+IuIGeN+PcQH8Mb0OkrUP+w2+MlbMDyDxnSslXwooS4J4ViR0h8el1cd6t8feexi0B5MX07hfZiPRywQaf6yPTbyol2x/h4EE4zInlila6inBvD3FjTMeGzRCfYqiqSzB4aY7ZJQHhXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702679; c=relaxed/simple; bh=IPcbqWAsVwNeIyEkZ0qKAVG59xeJgPPN3ii7a9al9iY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WnyzEq2oKL7oQzHwMIMR4kivj8Fci8agJCTcPuK9Pe6/h1iUMZxghVV0IHzr89WSPZfNuhPemkelZ9sjWCXbEQxYcgBD7/SNk0CGhDsSg2AIOZ5gemRO4W/c3sbCW2NcLo19U9RSCIpcRmr7LEfMjgXxp107Bt2Bao73fkkis4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CIZt0OTO; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CIZt0OTO" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4801bc32725so8820295e9.0 for ; Thu, 29 Jan 2026 08:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702675; x=1770307475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mf/e15dH3kpD6z1TEY6+wiUq/BevuPDNRQw5o3gS2fc=; b=CIZt0OTO5CNsNM82QToRciaOWRwFQmV2qIwCxv7vqBBBX5TBLrNck/+HQYWbMFpKrq yZ6f131DC41UcXPSXKoTMY9WA9sg/0sx+fcwp9TGnJPs49H/M7AsjoEfhhlgeAkXBfmR wTKP4ebp6GZK50rhk6WY3AorS+xMlZr3oeYx0uxr4ZvZXT2NtEQwtIZE88bKah665yJk EySWGZhuQByLidHLhDQtgz0RYE9eP+K4Ou3/JSyIqRKelp1Y3jpRRoTpTe0Xi2fxWeGD Pw6kUhf7RxN4r8DJHhRpDE4RLi+zETvpxeA2YEk0nlGfA7KJsWcqP2s6ysrIA/UQGxb+ j/kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702675; x=1770307475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mf/e15dH3kpD6z1TEY6+wiUq/BevuPDNRQw5o3gS2fc=; b=ALLvaUHF+rFwoEBF391rGowMyfJnxPG5e3uFxdiqQj3XCvWgiEs1vaLZh+QPZyXXaT kgpFGFQZ7CMtLA6uNXEv9Q9TWCzGdDQ3pxKSntD/6M/Y3KEBcLMbTtz1YlxJ5po4YPId FgJr9FTBQSHWiULtYvsUzNXOB70gtqIPLd3aNBZJMWlgviEy6Dvq9s1fRmtjIQbaBIMX Nzly3ISsYtGAaDBUAWZgjbaxIrcbCfefFHrnKOihZO4WyartbkfrCdXNGr9J23iH4R2o +WZD5Fm4Q8auc/PycFbCBjCmsW3TtVgrd3oqdbhSCOgk0meR9wnJEzbck2XKWS3FiEzO oj7w== X-Forwarded-Encrypted: i=1; AJvYcCURBshhlSUmIzJf2KZid785FUgHr0k+5yP/TKwSlvEAX5JUFF1dxQAYuBdWyhlXFoESe3yhg3tH0LcWZGE=@vger.kernel.org X-Gm-Message-State: AOJu0YxnWP5mSXLXkNmOPSwtaP8fk4tcNI3YKO9R+DEYwVnxpTm1xRQM IdNZDoLHe2Nn2VA3xLuqpWwGlLglewHtxHduDHcMCqPGBbNjS4MOhZOh X-Gm-Gg: AZuq6aIUVz6wGC0ugfT/eroUue1uSiuBxgWLAaC312CMDnvDDDkZCcMS7Fl2ejkarEh 66pIuNFxmxLGmbJTd63cW80O4P6BdVJxpe2KEiqet1pep5J3yWkbb5kuWTdmsDrbGWidc0ASdnf UMIPonytzuh9IEi3c2lkb294h3dsnqC9UFVOomr+F8FSquy//lCD0RcXtMBT9mVDgh8w3esicni PrOWt/TttjW9p2MukJM7GFGJVwC7dcJTzNp5TxEFk7FXLGenHtz2+ZoDA274n3uOvLT42rFay2T HIaC1AYRfx5z73mk3V2bXKyN3A0208JwcXglivXevA0cMR5Z0XXObUjGf7eXnDiSD+yPSO9pYDX haXzoj5angwcF6OyKOhGmQx2c5CnS39Rbcb4EEnwOE959ym0dI4V5yLvnbpddZAYMgH/1u8nEml fPL2NV4/tR9pkU06U3XMroh+G6GUOy/vkfTgCfRi8= X-Received: by 2002:a05:600c:a08c:b0:477:63db:c718 with SMTP id 5b1f17b1804b1-48069c43e80mr132902725e9.16.1769702674965; Thu, 29 Jan 2026 08:04:34 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:34 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 1/5] staging: rtl8723bs: fix open parenthesis alignment Date: Thu, 29 Jan 2026 21:04:22 +0500 Message-ID: <20260129160426.13737-2-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl check regarding: - Lines should not end with a '(' Collapse the multi-line function signature of CheckPositive() into a single line to adhere to kernel coding standards. Signed-off-by: Mahad Ibrahim --- drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 4 +--- drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_BB.c index 5fcb9420fb3d..ab5af96c335f 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c @@ -8,9 +8,7 @@ #include #include "odm_precomp.h" =20 -static bool CheckPositive( - struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2 -) +static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index 9c07df254eaa..ac5e3d52b3bc 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -8,9 +8,7 @@ #include #include "odm_precomp.h" =20 -static bool CheckPositive( - struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2 -) +static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ --=20 2.47.3 From nobody Sat Feb 7 14:15:36 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19DD63358D6 for ; Thu, 29 Jan 2026 16:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702679; cv=none; b=ci6T7NHvRHC2yim5ureXOYgt5TsStwc9bZv79yrybu6Dg05BC8lE2U1/LGCKRzY1ZjINO6naacYRsFp7tfwBiQelG6vsrlQVe3NiBAVY9gjT1FCn4vjZ+PtBFI56YzYLBI/PpdQFa1Pi6Y2yFbRaeD8A8lW7oh703/StB4hBlyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702679; c=relaxed/simple; bh=sU25cQy7XTnbmHtrk/z815qpaWUdmYcJnn9qEEvbQnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bdHFWtbK/VoZLPsqc+zZbz0AmmPrnS/hWqh0pCuq2nD12fgNxZ+vW5jNsdfiHGlwFWY2311Ouw4RhlkLEqOLAqJCFf2tV7FUBT6tLjXSoaOAb/QbbYUSfDbHn+GUZGvZwiQ43qOkw8yCwsW/g2H5FzX20k0nacAsEBz4uBmJEZ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gHWOzttx; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gHWOzttx" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48069a48629so12102305e9.0 for ; Thu, 29 Jan 2026 08:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702676; x=1770307476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=md4zqsrhPtC4Pn78MMJhfjmDzauSiLfeoWDEpx6MXzo=; b=gHWOzttxaKuFYR6YmR9i/+d5ojx2NMCgL3or4E181oLBJYXpnImqsqx89q55rGPw8h HhTtADcMuiJkp99eXiYx8eELbEoUYB3HteSn2cKXkZb7IGGaeQlvZuZ5B4GAmXw89DmW M0NIjRomOhkCk3MqSuOUU2xY7IZdYgQlzvS+q1ln7GvD04ceCA/AxoWg0nYksnOaiHIc 12iMfkXoIFlsXFPi/kp5VwCp21z9km6JzSAz2Zb5Mm9imtHwHoL0KwI5K53h2MJrVRat 5qJyLcmrUfQxnBail5z4o+z4DBLakhqSdAInhlcXX2if/IDW5voLE6B18f4W2/6MEaZA MMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702676; x=1770307476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=md4zqsrhPtC4Pn78MMJhfjmDzauSiLfeoWDEpx6MXzo=; b=cZShlipcdbS3Z2yBZ9wTqIGqyoUhos/zNPEuYsBPZXsNv27NsQrZEfBV+NjLErJwhF SAtaQb/6P4+Fvs/SL8wcdMZdcaVA7KrKIf8LjJZawoBx1l+SAf+ak8D+d1U6Hq3ug3wp I1VjIkdZ2Ssyp7lRpeOpzaKPMeqN8i6z+enpAAH0QVarK59qmTg2sGTqD3PXiYDlLp3o ovAtOsV11ZzIBoYVakn3TT724sbxhU8pMr8Kq5yPF6XjJvFtBLi/iBzPed1I9vqIHdD3 Lv5o3jv+3BzZ3a9YWntJXbGdzQpMkLfgxKhUprKR5lmCGfHtPHTM3wx4vHYC62j6uxxO tNgg== X-Forwarded-Encrypted: i=1; AJvYcCWrVyKysaqs5sZB9vmeGHpgNxvgkx8mOfDIL3J2GB+xhwqlesvdDNv118kJKjSFhzMAtt2sAC8cfuGlGto=@vger.kernel.org X-Gm-Message-State: AOJu0YycIUIqhlkPXaxn/xGuU1BIkZVuUBHEqpfiJiU3aAkW9GFLYn9n T82i4Cx7t57ac3emiwZ/nILRK2VNMAqRHOWm1Y6gxV64uE1dNesRTDSC X-Gm-Gg: AZuq6aIkf8o6mQGus3bpLWhUQO9s6DJyQ3xgraJemvdi5pdsIAuoLaMIgG24lQzK5m2 RiZ8rBi9elHo6ma48vi8VzQbyNi+yELuN8QUHHJEnffO0hlgxl+WdE4HsUYvbbJjkdElivXrirL +xVNNQBLnylsIC8iKUFgRmdu+HXczyyh3Mr7dammEK446wtWahHcEdHRZ7m5ynjCLIIs8UKJ9bF Gh2MslKmwBbpjsc0eT0qH092x9q6qhuBxB6I3jzwM3TH//RAK7acdkSLSSBDtOeIEN0OqOBGnLo yXtv5n8wPD7JXs4cUT71AFn9Q3rZT+UACJtOK2FxhsnBuQCofx1BunLa49sIpCm1DxbDafjDXGG Mtc2bePXS2+763LO5Ci5zW9NpsjIvuRI6mHi6/rM6AKC2mQ5UCTKbSqVlpchiA8CXyugmRxNuLT Gvh0gEaxWqzP2p3Qh4pww/fUzIWEf0jvAGwguMC8E= X-Received: by 2002:a05:600d:15a:20b0:47e:c562:a41f with SMTP id 5b1f17b1804b1-48069c55790mr94395565e9.18.1769702676350; Thu, 29 Jan 2026 08:04:36 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:36 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 2/5] staging: rtl8723bs: fix multiple blank line check Date: Thu, 29 Jan 2026 21:04:23 +0500 Message-ID: <20260129160426.13737-3-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl check regarding: - Please don't use multiple blank lines Remove multiple blank lines to adhere to kernel coding standards. Signed-off-by: Mahad Ibrahim --- drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 1 - drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_BB.c index ab5af96c335f..988636a16112 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c @@ -31,7 +31,6 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index ac5e3d52b3bc..1fbb71149cc7 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -31,7 +31,6 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 --=20 2.47.3 From nobody Sat Feb 7 14:15:36 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97EB3382D2 for ; Thu, 29 Jan 2026 16:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702681; cv=none; b=fIDdu5WKEPOqWjGnwEp1h3OaNwwwr+aQ1wGy+uiB7PqBOeDv8PKtcy85NROKESIPHPMLLRDTYW5ThTVhEX+D38YkDOF5tHkskOLrsGMx3FmJMao0ZLj1UZ4TCWAuPOyxcgWvpgu4ARgIEhPCKG9TDOkQt8x/8rEbw6ZVboBxLZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702681; c=relaxed/simple; bh=zOfSPCiFKqmv34rNskZtHpQC4of07HLOi8SsOKfq/E8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QP+sHWXmQ3ZDsIT65Uo5p6/K8NU/NnkgVvtoJ0fjcrEsWWxRyxh9o7CVp4p6S00FFHt+w/A/9vg3qIwTXSEQlKGUL0FB0vSJq8CNZ9DCCq3Rj7Rxt/XIZUOl6iiumKNzMto49v2rZqW/U8L9nd/ghpMTMja1tqYVNS1l8cWW51Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZZND5yqc; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZZND5yqc" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so11740155e9.2 for ; Thu, 29 Jan 2026 08:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702678; x=1770307478; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vh/uPjKkjFTzbQKBGAxp3Ww1JQS4t2qyH2DOcG7BnPY=; b=ZZND5yqc6McwX421Rcw7oWbYZ/cI0QTyqAz1kEMkkJv0ERPIga2qZVAIa7DZhKBiDb +35DEe409mQdE8nigpIHibSqmOi8pxuZKPuotvUIdx2UYdcFluMhfFG92zbCoj7KQBGG po1sLV/1VR6PmZtoUVJBXmADbZpBmP169cqXNx7LZcy28x84+pDJm4hOSqHbBgyVbg1f PKY3DVflEm+8q5BmtQjDnbad7qVB4ZNcbzY0b5tOybE3ECbpLg/m0/YxPyh5vjXmfBI7 53Qx0Y/jDXRll2PcHzoHFWgJar+CT2m7FapHhVCmfWdTHrr7vbzdF3j9RVD8mTCvlmbp +PpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702678; x=1770307478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vh/uPjKkjFTzbQKBGAxp3Ww1JQS4t2qyH2DOcG7BnPY=; b=qKu/Cymlp7Gqw9RZfS4eE+MLHrGJeJVdvp2K0bauGyaxBURtMgindSm5+9+AyRWQqv NWPYMLN5IBbpLZXgS5whk3y0KqJp9keybCFpT7zaqk4XzIrTI0/XRX3DYiLRzUWaUbve QRWN4lCuAYRHgHLZzkEhyFq+rerQCzUVEVFZc7TAzyTVk8HnilmV3ObFTXC+eNCAhuU7 OuCEbPeZSNAO3U/qdLvLG+f40Cau2PrMH5Uxn6J3tM9h/otyBiKtPwuuzAy5lp8w1EFf l5YSWN+Zct0dZeOHW71T0mQfC5FrzF5OHaqOegDA1k0oZBOJCgwnps5ywJPwuFnMvVYp TXYw== X-Forwarded-Encrypted: i=1; AJvYcCVnkqSQWilNd3Q8EVIQU08R3Glrac+yOLL4V3gCpxtMLNX/AIfW5M6NX2ieMWcWXY9A1R4MArRvxly7LDU=@vger.kernel.org X-Gm-Message-State: AOJu0YyMaWEhgDks32DTVMkHQUn+K+6d+hjcr4EMuq0Wb4lrES2o67xS Nl0k3+vLvlWACDjkYeoSpSJeVhr29wBbZkWWUkoWvYnsGba8lmveNEgj X-Gm-Gg: AZuq6aKAfmkzPLiVGWFuJhgowFDb8fcSfQ6Vs8F6V24O3AZG8lSmj9ZurLPHaW/lAGy 9TpP9hhwoi7oX8x8RN+y1UHNjGigFVxCXhWhT5wfCRoM1Nx8m1cVS7RSz/QVvblzNqQQ0s5gDVZ qVdgKgtIEDDrzj5awdXUdk6/cur/vAugAqnkG3hJPwV08iL40fUWbTJoynkYQRZ5ADK22FIdiHY gScuitaTC8BvBmD1+w0QkBvLGKnGpTqKVPePpIBLnjA0MBtCGsQm6xCoSoGXRtI/rDBVOKKfN65 q8hCK76BftSg3kVi3btGHikymeefJUiRNmtzTxIh8ozfHAne0HMqjXpCcKF/J7a+KdhPwPMLrBz 248IPXfuB0B2t0Cfa2w113w/C3UgxQjrUTP0iU+yHSWJ2GhSFUmYBZy20TAIV1cNqg7iBwp/maP cWZqfhcdjLGXDPCFB8hBCN9e2RBRlqMNW3ZM7m5Dc= X-Received: by 2002:a05:600c:1992:b0:477:79c7:8994 with SMTP id 5b1f17b1804b1-48069c789e8mr119108505e9.30.1769702677711; Thu, 29 Jan 2026 08:04:37 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:37 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 3/5] staging: rtl8723bs: fix missing blank line after declaration Date: Thu, 29 Jan 2026 21:04:24 +0500 Message-ID: <20260129160426.13737-4-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warning regarding: - Missing a blank line after declarations Adhere to kernel coding standards by adding a blank line after variable declaration. Signed-off-by: Mahad Ibrahim --- drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index 1fbb71149cc7..b7176a992518 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -47,6 +47,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const =20 if ((cond1 & driver1) =3D=3D cond1) { u32 bitMask =3D 0; + if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ return true; =20 --=20 2.47.3 From nobody Sat Feb 7 14:15:36 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89AB339865 for ; Thu, 29 Jan 2026 16:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702682; cv=none; b=tocMGIk03pzV0k35pn1eZ6uE9TbW1lgVQfhAFJ+Dr06DvA0Hs8gyzaXA2YFOHfQS0ZEqG5xFE718AKJ9vxrOzauP8Q55V1/t/y7q7o93Y/E2cuaZRMwDg/2llMI6vZxhfXIhf9Jp8j1oVidaUkeYO5TaGzwgPYjMd3uZR4emyJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702682; c=relaxed/simple; bh=LAzDWmRKCQl0iOLrB4RZCL2nKgyhi1poYaM7CKdIhEE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gWc0LYsl5K8cZA+N26mhv0EvDheP9z0IfZE0To/vERpBdXKIolXmcruiMlmPCw+Hk30gzHHHSXoVfscaL2Pu2JtUEzdLmKPLktvJ0o4k2bwvQB4Wlp3gfw/YrKxvZTrq9AwF0jmM64+edPCycSBxC53gzJzsKwCfJhXdEqzOj2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PjW7xZSf; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PjW7xZSf" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so8984345e9.0 for ; Thu, 29 Jan 2026 08:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702679; x=1770307479; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NqhoMwRyN/VLfos/9gInZzs4gm7fqrfrC6kaLcS4hXQ=; b=PjW7xZSfDW+LJbjTt3UE2ZV2DW7CnR4xq7uKF7Lrnk9lqs+79esus470pGxl8r5Ax7 n69CzlL7sffGVFe729mddvji0y+gZx/tFXmu60ExU/iayNtsHk4ObxVndcsppW95ztSa wCsuQ1CweVo4DtCcjECq1PSoC3Fe8mjZ4xkIJnTi1XpnAdA/EX39kTQGzfFgixr0SFi3 TWCvGGC7B2FkUwkcvxQTb5X378NQLaZ1OV7wQC0/L5uQggx25QwfeA8ipvSptsdrhzCL uzeqt8GpxpoYHwN/KgiyayFho4VT67wyGZ8gtj7/nAUwvAvM8QDuwuiKwAl2mhD6HFb1 bY9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702679; x=1770307479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NqhoMwRyN/VLfos/9gInZzs4gm7fqrfrC6kaLcS4hXQ=; b=wVR1+zbtlFC+heXtmz/dr9OYrZrZB9W3k4ESR8PmFWr73Sec7eU2v3jEJh2LjETwyn AxpYl9EK2GiddEG1UfBTz6Yq6PWXAHaicDafRk+XpfTqnNBtDyoW68Fa/CClxUzDPcR7 sxFLZYFsVEN9cvHynexj8mcrYa5eh7jit/dcbXnmkrTYobbCnf3il19uTXcP+xg1H7vb 6pXdldQQlG+jkFyR0OPhR04KhYTLkY01lFVUEfmqG+ZXOfZLz+BV3F3rzpxCGC8MBVrO mlcztFDhdRjAfsir+fNb7f9ZDeEGHSA98eZUYTc2yWaoIpNoq2JwRCDkcjYRjNUSKwBL 1CuQ== X-Forwarded-Encrypted: i=1; AJvYcCVmyU7gZ7simB/SrvNmaYKlY2sQ5RhjJ/ft2kWLkpm0H1YKURRriKFVCl9R/jqAtcLI7h1cAvWfDA2WSEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRC4geKcRhuMIKPonrrqXbM34UV48I4eLr8jKu0cR7N77ubf1W Ba9jIlbuPLS0QGZWb0VPLk5IBaLSRUmFhs5oEtcDJ0t/J3vUwYJpuTnA X-Gm-Gg: AZuq6aK/jIsQG5ByNzg+jEA+yUBhQdrZb3JfIP17NxvGdnFMCoCvJ78rCB5OrKcoNYS TCkS2PbWGZcPFMap5OjP4CGuC26vYx0ueneiWxhqRWiHOnpQZJnPQWMqcGqjfEYm73gPpU6ycXJ U6Qltwx5dVEvWfJWlEvXMqkr4MCm3FHLJzkgdn6GgEkM3eZuTb1LrnY6RuQ+eQLPoUSsI3E5Hbk //Zv0FlHZaqwcZUAe77kSfYq/TSzXjaC+4/cBviKb2MbFZk9YfcOQLbMRO2OSrKM7mBGhXpbUiv c5BTc7TXk0lhwBGQIsGo7qfvK5aRJf+1MRNIz2d1gtFYPPYukG03YhAuedBQfU7ds0awKwy5ULy IyklpgIb2pJiGS3jVc9m5Z9Y1EnAPLHtPTDreokOLHbaMQS3VjZOaIIWupiwG9nHWOP9WXu68Pn YUcMPdXOnN5Zuoi6FnnKnKurFSNIRFHJ/yW/Fat14= X-Received: by 2002:a05:600c:608f:b0:480:68ed:1e73 with SMTP id 5b1f17b1804b1-48069cbf2bdmr94914665e9.36.1769702679126; Thu, 29 Jan 2026 08:04:39 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:38 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 4/5] staging: rtl8723bs: fix line length check Date: Thu, 29 Jan 2026 21:04:25 +0500 Message-ID: <20260129160426.13737-5-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl check regarding: - Line length of X exceeds 100 columns Redistribute comments to multiple lines to adhere to kernel coding standards. Signed-off-by: Mahad Ibrahim --- drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index b7176a992518..e428884335a8 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -60,7 +60,8 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const if ((cond1 & BIT3) !=3D 0) /* APA */ bitMask |=3D 0xFF000000; =20 - if ((cond2 & bitMask) =3D=3D (driver2 & bitMask)) /* BoardType of each = RF path is matched */ + /* BoardType of each RF path is matched */ + if ((cond2 & bitMask) =3D=3D (driver2 & bitMask)) return true; } return false; @@ -210,7 +211,10 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm_= t *pDM_Odm) } =20 if (!bMatched) { - /* Condition isn't matched. Discard the following (offset, data) pair= s. */ + /* + * Condition isn't matched. + * Discard the following (offset, data) pairs. + */ while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 --=20 2.47.3 From nobody Sat Feb 7 14:15:36 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDDC33B947 for ; Thu, 29 Jan 2026 16:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702685; cv=none; b=F5kKqObdbPJePoWEWRtYf1TdCTQTfzZ2sJD7Ipe6V8SGR+P9snCayAlQFzzlKzJw8Cj35QE5mmbdloLKDSzMzjRiwLaC1iFx/ZOHc8qT5mEA436ahWyrYZE0i3/Uwb6SDBTqxnuDyveEYrMUuvO7Sw7eTSSLfa+PDjdV0jrlSzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702685; c=relaxed/simple; bh=pUp+c6LTDlpKVOYcI/ycGERoQP85AZkoROMK1FDTJ1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XLkVoJ1A/qQdohDrbGclvswTk0lO9WEF7YzsF0ofAlWMRVwD+WXXKvzmBrdJ0J/dOeRqbarg/jpZiG9kfC1qop90BejTEaX7B+vg+ugAF1VW9u3vIs2NBxkNYxTRf00gck6GpYen2zoPF04TaPGvGVBgjyR3GQbGZi3JpDOZKjk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W3qZjlH1; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W3qZjlH1" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so8984525e9.0 for ; Thu, 29 Jan 2026 08:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702681; x=1770307481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FwLJT/eb1tpcmkJAI7RUjujsGl2skEe6JBPlya1TjJU=; b=W3qZjlH1MqnNim6RqHb+MLVXRHY9onx5y4oGuT7c4dgiyCD7DSwiNa9aBBJeFJdbmO ezumWQUbzfAP2JkO85PdKJM14kSIKxIBdQrUAzqv259MHtJ8N31ASXJIUGairuyBUPxY s4ow6NT3njvwn4oJy7Js1Gy+5lnM0Ni3QRGQKDvQrDQVF8hawrESOQxoPiYEEme/oAT4 fe97KWOzeR5swv0vGXF5d7+Oz/Usq61GlZYWT3j2+1dnh3gO5GqyJGY/Gjwl7dZUqCvm z6h12ixs21vG1UPjesrCRUpA6M56aiMdKTzlOdP46LQIh6LhxDPZCSUhbf0UG27X/tVB r91Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702681; x=1770307481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FwLJT/eb1tpcmkJAI7RUjujsGl2skEe6JBPlya1TjJU=; b=hQcehk4+sdbOkdewm5ndei2IzjKEMPWq/3kqYtr9IQkcqj3c4c0PhAK/QdegiD258X Kq4Uwbttq3F6mqkSqK+/HA/KxtIEQSbAyb5Rzt9uAfGHoq/QPMZvFKQbUwEZDK4AwGHN wBzMr9d/KF0WZgGu8Q/KC8XpCxlD/U/lDspGuFNOye5mISlHhm+ACgez+2cKdONLXG78 dbQetEQOh4kp2SrQq+byZDPBbeOIqTly5NUxWEKawN0U1g4Pm66yXv9M01k4nhKlUwFQ JXNw4cRuiPFE6qSx+fVnOTaGSHX+xziTQuvg7C7eiAAqftieZOu3r6EttFU2jV5stcFj 61wA== X-Forwarded-Encrypted: i=1; AJvYcCUrwgdqC8+8x0JmPw4p9xFcM2E+j2Yji3aYXPwDImZfm4Li0+BLjZ+S6XjHadFO+SrWQzwaVMw2JJCfbBw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/ThwPkiSmhroAX+dPd1lk8PMr7caYJOO1BIgwNo+W3c/iHxTI 3x5pgzCIueCD6hx+KMlf3lgBVRY20iBjYRXJz3xoqgmMqramhM6Uy10ybUmyqyMD X-Gm-Gg: AZuq6aJBhRVffcSyKHxM8uBhOSEoU9c9njXPkbpZEhNvsX5DZK1Nb+hd3YJwX1mOUPx FTXYKsNDCnQl8Yg500weuGTnXXEJgN6ibIagGOY7WiDzJuFJNQ8Rk4V+7j6UpD26yaCadyfkAXi cz9c1HS/XtLqNhFHJ4zKQIjA1BE+3aoS+fTxBV8SxCJs+w1OUPz+J13TjXlZDMPGFwBCGTyOdV8 MyiKMXc8lnPF9eEqSY0ZIG4EGnMII5zLIrRwc1s5zYDz5ohLSf77XFwFprJXr8gTz8QuHjoFfsk qy8mqG2QiHQDiEpLpIqac26PJs9rDj9pg9IpcqQvuqLd05NinMBRbKSF0XHqkKGn2eki/ZiHxQo tLO9fWF6d9VyochxSWxaGHwQJPoqy2rYcOmaMDwuWTVmpmmwOQmu0xE3KoM+mzrB1UdrnVtoOkk urii8h1zAMjuYTnlT+ttJIzugi0gbsoGh6sRCwWyVDakwics1e5Q== X-Received: by 2002:a05:600c:8b16:b0:475:de14:db1e with SMTP id 5b1f17b1804b1-48069c8c0d2mr127173095e9.24.1769702680506; Thu, 29 Jan 2026 08:04:40 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm135883175e9.11.2026.01.29.08.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:04:40 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH v3 5/5] staging: rtl8723bs: standardize comment style in HAL Date: Thu, 29 Jan 2026 21:04:26 +0500 Message-ID: <20260129160426.13737-6-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> References: <20260129160426.13737-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel coding style for comments requires a single space after the "/*". Currently, many files in HAL contain two spaces after the "/*", or use irregular indentation. The modified files also suffer from this. Fix line comment style inconsistencies by removing additional space after "/*" to adhere to kernel coding standards. Signed-off-by: Mahad Ibrahim --- .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 54 +++++++++---------- .../staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 32 +++++------ 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_BB.c index 988636a16112..4666b2ff3157 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c @@ -11,11 +11,11 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D - ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ - ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ - ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ - ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ - ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ + ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ + ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ + ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ + ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ + ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ =20 u32 cond1 =3D Condition1, cond2 =3D Condition2; u32 driver1 =3D @@ -31,7 +31,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 if (((cond1 & 0x0000F000) !=3D 0) && ((cond1 & 0x0000F000) !=3D (driver1 = & 0x0000F000))) @@ -39,16 +39,16 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, con= st u32 Condition1, const if (((cond1 & 0x0F000000) !=3D 0) && ((cond1 & 0x0F000000) !=3D (driver1 = & 0x0F000000))) return false; =20 - /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ - /* We don't care [31:28] and [23:20] */ - /* */ + /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* We don't care [31:28] and [23:20] */ + /* */ cond1 &=3D 0x000F0FFF; driver1 &=3D 0x000F0FFF; =20 if ((cond1 & driver1) =3D=3D cond1) { u32 bitMask =3D 0; =20 - if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ + if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ return true; =20 if ((cond1 & BIT0) !=3D 0) /* GLNA */ @@ -60,7 +60,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const if ((cond1 & BIT3) !=3D 0) /* APA */ bitMask |=3D 0xFF000000; =20 - /* BoardType of each RF path is matched */ + /* BoardType of each RF path is matched */ if ((cond2 & bitMask) =3D=3D (driver2 & bitMask)) return true; } @@ -216,16 +216,16 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -240,21 +240,21 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm= _t *pDM_Odm) =20 if (!bMatched) { /* - * Condition isn't matched. - * Discard the following (offset, data) pairs. + * Condition isn't matched. + * Discard the following (offset, data) pairs. */ while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ } else { - /* Configure matched pairs and skip to end of if-else. */ + /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); @@ -476,16 +476,16 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -500,20 +500,20 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm= _t *pDM_Odm) =20 if (!bMatched) { /* - * Condition isn't matched. - * Discard the following (offset, data) pairs. + * Condition isn't matched. + * Discard the following (offset, data) pairs. */ while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ - } else { /* Configure matched pairs and skip to end of if-else. */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ + } else { /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/st= aging/rtl8723bs/hal/HalHWImg8723B_MAC.c index e428884335a8..9a3393f5122b 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c @@ -11,11 +11,11 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D - ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ - ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ - ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ - ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ - ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ + ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ + ((pDM_Odm->BoardType & BIT3) >> 3) << 1 | /* _GPA */ + ((pDM_Odm->BoardType & BIT7) >> 7) << 2 | /* _ALNA */ + ((pDM_Odm->BoardType & BIT6) >> 6) << 3 | /* _APA */ + ((pDM_Odm->BoardType & BIT2) >> 2) << 4; /* _BT */ =20 u32 cond1 =3D Condition1, cond2 =3D Condition2; u32 driver1 =3D @@ -31,7 +31,7 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const= u32 Condition1, const pDM_Odm->TypeALNA << 16 | pDM_Odm->TypeAPA << 24; =20 - /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 if (((cond1 & 0x0000F000) !=3D 0) && ((cond1 & 0x0000F000) !=3D (driver1 = & 0x0000F000))) @@ -39,16 +39,16 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, con= st u32 Condition1, const if (((cond1 & 0x0F000000) !=3D 0) && ((cond1 & 0x0F000000) !=3D (driver1 = & 0x0F000000))) return false; =20 - /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ - /* We don't care [31:28] and [23:20] */ - /* */ + /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* We don't care [31:28] and [23:20] */ + /* */ cond1 &=3D 0x000F0FFF; driver1 &=3D 0x000F0FFF; =20 if ((cond1 & driver1) =3D=3D cond1) { u32 bitMask =3D 0; =20 - if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ + if ((cond1 & 0x0F) =3D=3D 0) /* BoardType is DONTCARE */ return true; =20 if ((cond1 & BIT0) !=3D 0) /* GLNA */ @@ -188,16 +188,16 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm= _t *pDM_Odm) u32 v1 =3D Array[i]; u32 v2 =3D Array[i + 1]; =20 - /* This (offset, data) pair doesn't care the condition. */ + /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { odm_ConfigMAC_8723B(pDM_Odm, v1, (u8)v2); continue; } else { - /* This line is the beginning of branch. */ + /* This line is the beginning of branch. */ bool bMatched =3D true; u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 - if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ + if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; READ_NEXT_PAIR(v1, v2, i); } else if (!CheckPositive(pDM_Odm, v1, v2)) { @@ -218,14 +218,14 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm= _t *pDM_Odm) while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 - i -=3D 2; /* prevent from for-loop +=3D 2 */ - } else { /* Configure matched pairs and skip to end of if-else. */ + i -=3D 2; /* prevent from for-loop +=3D 2 */ + } else { /* Configure matched pairs and skip to end of if-else. */ while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigMAC_8723B(pDM_Odm, v1, (u8)v2); READ_NEXT_PAIR(v1, v2, i); } =20 - /* Keeps reading until ENDIF. */ + /* Keeps reading until ENDIF. */ cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); --=20 2.47.3