From nobody Wed Feb 11 02:05:32 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1C7332EA4 for ; Thu, 29 Jan 2026 15:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702242; cv=none; b=D7fdQQcx87ltLMYccUZuqKc/3yL6aMcHuSFKO2bHyjzyxueCm4TQXIa/iIuZZ9F7IMKYrJ1rttIfpjsLhe93rMV5ZVh1pVWkzHp8ZhovFMdQYyvsPnYmgalvHNIC81AWjPhI+ySmilQMBgv3xDQpq4uyWy8m5IltvGush7FXQ+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702242; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T0k3mjXcCKMx3f7eK3AYcC2MbFdwpWNbohoKv0Hunw2aOJB8wxqCXWKlhTa3yJFxwuJ3I8J8GN3RKErC+UsQHlJRihRRJ85YLafjehPGbiPsl0i6fYDPTq0AHUbLfctzjnp3VQdNcavcT8VfyCL1pDnin1VxhJEtDc2IWaYwjpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f9fu0Kdh; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f9fu0Kdh" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42fb2314f52so723903f8f.0 for ; Thu, 29 Jan 2026 07:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702239; x=1770307039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=f9fu0KdhhJ6W8xwCeYqrBRIM4tjpDCw8Zsir4D4Lypsylo+aDu9vR7KEfYM4l7fJgC 5DmtuI0HFhE/djUwf/P1eec/SvGTC9DYzGuVB5+qpCQjYLDAYJvh0dO3JhMpS6/1E2tu 5PSDND4QNWy6zPR1NUsMduhvmk//S3vJFP/VqaMhX0jqzJGPU3Qm8lD60a0/Q04RsCik ows6yjsLxz1AcrikDi5qsEQea4qJjq0WHmvxbySnllR3XR2h0oQSJ0Mz+31S6xQzucou HIa0MHaphXRDr6b31+1iMdjDDivtxVRItJv++vO820OgUAzK/IuaEB/CKb8bFjOlwlm3 4gBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702239; x=1770307039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=h0ekH0/8gBRQG4loZTcIKo/UgL3Mf82Pq+ijqQwKAv0ibvmFHtioENji8QE54bpITN XP74JE2uvtS5oixK0/hJMXpfS82l7QdaEuAPpveOiP1VGzEaS4hfvXRAD1Py+UomVv0l 6VAmfmcAN7mL164mChpSjoS+pTrc+5Q60MlMCQ8UFUV76Aqifs3eiGTnC7oX+wPz51PP 82mmr04DK/TC6x28g5fKoXHMUs3HH12FMW5T08rCTqNc1jkIFGEcNB+UTetGLdD7IrAi C6bguvHgZZVTN5/forkKTrEFzTvpXROzm7v7vnZ5I5rLs2j+zQKFfcQW+D3uui5gVZIN zkaA== X-Forwarded-Encrypted: i=1; AJvYcCVQrSeds76LW2s3wBmPgTM1ZuLxkyViRUhAOLGi6b4PUUtbIYZHzN63M5Urly40SRzD/w/nBUPmROkmvz0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmDleKZPdADuSL+GtCi2K4gI0WKU+VSSFZ7tkcEDqu72l/EXuv zzBKYNLLDPkSFOi7CafsBEZtHQvJIZ51v95tN1X0QTxK0ZG6W88vUSM= X-Gm-Gg: AZuq6aKhfJvAyvdEVq0SBjNz9r1V09EVzF956Dfiey3ahCIcYP9BwFVl744OofMyQSp /MBo107gpw4rB8vHVjB9h8PKExdH9m43Lt7eI94FViabtq1erkS/OER/wPGuMcdwNOBMlTCH4vP bccBN7jS++oogLYWRSNTU9ZEj4pPdTF4nZlOqhOFudiWsjyytPaTf1JXyrzq/Gl/Z7nOLv6niqM DA4J+jEa4k9NyD0AweocsM5m5kRpNG1s3lqfOBbXmSUvkYFhmZeQ5B4d+jPHhCunPqE6vtviueQ 0UXwglRu/kimZYnTrr29IK1YtKDtff6EfabtrJDOUYpBnXPomX+Gf/bgAMIdeAWRv1V6XvuUmUb VAV9Qd8D2L5BHJOmAQKh3L77xf9Ztgiq2xt/5+afkyysfsZFydOkAMMoPM5S+jABh2J/+n99fZP nz X-Received: by 2002:a05:6000:3110:b0:433:1d30:45f with SMTP id ffacd0b85a97d-435f3a6d009mr117781f8f.1.1769702239028; Thu, 29 Jan 2026 07:57:19 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:18 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 16:56:51 +0100 Message-ID: <20260129155654.5565-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0