From nobody Sat Feb 7 17:41:33 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B8031ED62 for ; Thu, 29 Jan 2026 15:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702241; cv=none; b=j5KiC5vXk8LJyUA0xfJAIpPRVTXHTVYKX1Md7jyKehjxrjRktZJQ6plB17LY3sil+d0aCxZLI/abf5xr3jNJIK9uhRHiZO64Cju9hp1QwQ+dn5z7jE9bgyky+BO8ySociaPbNDlV3McxTfTxmqt8PeL9++j/B5iNLcguND4RRc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702241; c=relaxed/simple; bh=anusSg+ei2G8pY99kSNGBiFGkxTuVaDv4F/ejqaSEKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mR3yocOJPvBA35qVl8CvJxVWzggBUSa6nDAMAOQrRb+/7pdggIWYDWuPwYNxSZ8BcFLa5zWmkVs9g0GP6tJ+JRt31rMfoF89QXAPe7zcWHUIC1e2oltJXDBU0+8rAwDvTidFoLs+E5J3FYf7d8HWSrT7jNjE0k9SDrYl//kwOXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a7PD6lz8; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a7PD6lz8" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fed090e5fso984568f8f.1 for ; Thu, 29 Jan 2026 07:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702238; x=1770307038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkmQJfRqTQzrHHgjjnSwxvqZrCWnUDQPc30Wk1HVPk4=; b=a7PD6lz8Ttc8xY24wgLcsybL4FceJfvmLfImntsDRxyWJRtSjZXZSPodY3YCIiIYUL VZ9EeeEJH1bKfTHHOvUvFFh47JhMQCzcI3dAu42fCVQwASfDecQSqG4bf/VF4mG/GZ3d i3CCV0mIil6sGdTNgJSYmhdncnaGQ3EOzH4lwmGTWHHtAru3I70+5NEZCs3d6ay9Upau i3u+ZAYcHXqWyi9Oy9WEXW3vfHUk6v5t0oL/v1Npx40cw2CNN1STX/5TOCEq3MPspSXQ v+uC0n+zFqOpOGV8FvlFDxv2sVq/CTA70wYzpMeCevQjHlQA6fWp8f4DwLLKXvCr8md1 exRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702238; x=1770307038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YkmQJfRqTQzrHHgjjnSwxvqZrCWnUDQPc30Wk1HVPk4=; b=OnC8SwPM3OqA1tamYGJjDh9AwAaTQQljhSKjKkyvLXLKnkAdThpfjGAk9zCwipBw0u lpJq+wReyN73XpVNIO+Zrf84KqXELs8I6k+RiX8GRJvVNYJ7nPb9d12vAdEQbuzZI6t6 GezvVnyS/1Jmuki3AC2Orij3qmqrcuNBqEzOF9lBYG4YCIESBJKv5qxX/+AkRGwzTUUT /uuG7PAoT76UONme8F9grN61NUGZ73kygZYuNQUCAHzCmN6QDG1YBqPxPhTIFJne5Yku ua0qvJscnbhR5wIp9rsg8887lUgK3lrCEXrYEr6Bo/EQpMrQ7wXD4ZUlv/ipi7AD37hr P19Q== X-Forwarded-Encrypted: i=1; AJvYcCWeBsmZRD4wIjMAZo45ydKk8BSCUAOtpGDGuZeSawIgrIiYkCCo5lNQ8AOYbfaJMjCQ0uH9eQZjHcDfp3o=@vger.kernel.org X-Gm-Message-State: AOJu0YwwIy1BUmXxJsFq+2mbyHz1+CjLSHYxR72/sHBZ/LCRNTqEFRpN QvkqFamb8HvNHz8rY0dbOSsHw5/3De7FIRQh2xPkNP2DSZLkjHZI4b4= X-Gm-Gg: AZuq6aIcewhUFHBDWLq98bKG9SqsZ4P+zakmK22FSS2N9u+CWkUp+L4UOHEMenSwjLk FMwVedWVaPAB1Z6hJm0gohSBuxgO4f83hY+IxjBacQ/kcciw/OgosBVEgFWS+jwx1Hn37w6IH57 +Gv14nDimMcoiBLq4KKH9Fm1wXOJ2V/9LrRnXoC2rFzk8n0lviU0eLRF62qEXv0YagGVC8LfTo2 GBhaMvvEw4QZ52DPZEGTgca3y7LWACTw2RX5Ua4ur82tEoyAWDpnS6xjHIO8rE2JkMixSsM+1JH cQKqTZ+Za9pfKJZBJygbJzOauMMv/iELmjs8DNYE5vX2+ya3nXy8OtVv9JHJ4+Ur9ju1KJsay0H iNqFpWE9EJ+idcInFpFvTto94ZADKc3iCCe+tZZa4vhhmP6IXlLbuwE1JnR7siyme2Mt/pRorNU HVaBwsommiP2w= X-Received: by 2002:a05:6000:2c04:b0:431:5ca:c1a9 with SMTP id ffacd0b85a97d-435f3a8b7bcmr106781f8f.23.1769702237655; Thu, 29 Jan 2026 07:57:17 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:16 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak , stable@vger.kernel.org Subject: [PATCH v3 1/5] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Date: Thu, 29 Jan 2026 16:56:50 +0100 Message-ID: <20260129155654.5565-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code checks 'i + 5 < in_len' at the end of the if statement. However, it accesses 'in_ie[i + 5]' before that check, which can lead to an out-of-bounds read. Move the length check to the beginning of the conditional to ensure the index is within bounds before accessing the array. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..7dfc2678924e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,10 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 = *in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && + in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && + in_ie[i + 3] =3D=3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && + in_ie[i + 5] =3D=3D 0x02) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0 From nobody Sat Feb 7 17:41:33 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1C7332EA4 for ; Thu, 29 Jan 2026 15:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702242; cv=none; b=D7fdQQcx87ltLMYccUZuqKc/3yL6aMcHuSFKO2bHyjzyxueCm4TQXIa/iIuZZ9F7IMKYrJ1rttIfpjsLhe93rMV5ZVh1pVWkzHp8ZhovFMdQYyvsPnYmgalvHNIC81AWjPhI+ySmilQMBgv3xDQpq4uyWy8m5IltvGush7FXQ+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702242; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T0k3mjXcCKMx3f7eK3AYcC2MbFdwpWNbohoKv0Hunw2aOJB8wxqCXWKlhTa3yJFxwuJ3I8J8GN3RKErC+UsQHlJRihRRJ85YLafjehPGbiPsl0i6fYDPTq0AHUbLfctzjnp3VQdNcavcT8VfyCL1pDnin1VxhJEtDc2IWaYwjpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f9fu0Kdh; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f9fu0Kdh" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42fb2314f52so723903f8f.0 for ; Thu, 29 Jan 2026 07:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702239; x=1770307039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=f9fu0KdhhJ6W8xwCeYqrBRIM4tjpDCw8Zsir4D4Lypsylo+aDu9vR7KEfYM4l7fJgC 5DmtuI0HFhE/djUwf/P1eec/SvGTC9DYzGuVB5+qpCQjYLDAYJvh0dO3JhMpS6/1E2tu 5PSDND4QNWy6zPR1NUsMduhvmk//S3vJFP/VqaMhX0jqzJGPU3Qm8lD60a0/Q04RsCik ows6yjsLxz1AcrikDi5qsEQea4qJjq0WHmvxbySnllR3XR2h0oQSJ0Mz+31S6xQzucou HIa0MHaphXRDr6b31+1iMdjDDivtxVRItJv++vO820OgUAzK/IuaEB/CKb8bFjOlwlm3 4gBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702239; x=1770307039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=h0ekH0/8gBRQG4loZTcIKo/UgL3Mf82Pq+ijqQwKAv0ibvmFHtioENji8QE54bpITN XP74JE2uvtS5oixK0/hJMXpfS82l7QdaEuAPpveOiP1VGzEaS4hfvXRAD1Py+UomVv0l 6VAmfmcAN7mL164mChpSjoS+pTrc+5Q60MlMCQ8UFUV76Aqifs3eiGTnC7oX+wPz51PP 82mmr04DK/TC6x28g5fKoXHMUs3HH12FMW5T08rCTqNc1jkIFGEcNB+UTetGLdD7IrAi C6bguvHgZZVTN5/forkKTrEFzTvpXROzm7v7vnZ5I5rLs2j+zQKFfcQW+D3uui5gVZIN zkaA== X-Forwarded-Encrypted: i=1; AJvYcCVQrSeds76LW2s3wBmPgTM1ZuLxkyViRUhAOLGi6b4PUUtbIYZHzN63M5Urly40SRzD/w/nBUPmROkmvz0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmDleKZPdADuSL+GtCi2K4gI0WKU+VSSFZ7tkcEDqu72l/EXuv zzBKYNLLDPkSFOi7CafsBEZtHQvJIZ51v95tN1X0QTxK0ZG6W88vUSM= X-Gm-Gg: AZuq6aKhfJvAyvdEVq0SBjNz9r1V09EVzF956Dfiey3ahCIcYP9BwFVl744OofMyQSp /MBo107gpw4rB8vHVjB9h8PKExdH9m43Lt7eI94FViabtq1erkS/OER/wPGuMcdwNOBMlTCH4vP bccBN7jS++oogLYWRSNTU9ZEj4pPdTF4nZlOqhOFudiWsjyytPaTf1JXyrzq/Gl/Z7nOLv6niqM DA4J+jEa4k9NyD0AweocsM5m5kRpNG1s3lqfOBbXmSUvkYFhmZeQ5B4d+jPHhCunPqE6vtviueQ 0UXwglRu/kimZYnTrr29IK1YtKDtff6EfabtrJDOUYpBnXPomX+Gf/bgAMIdeAWRv1V6XvuUmUb VAV9Qd8D2L5BHJOmAQKh3L77xf9Ztgiq2xt/5+afkyysfsZFydOkAMMoPM5S+jABh2J/+n99fZP nz X-Received: by 2002:a05:6000:3110:b0:433:1d30:45f with SMTP id ffacd0b85a97d-435f3a6d009mr117781f8f.1.1769702239028; Thu, 29 Jan 2026 07:57:19 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:18 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 2/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 16:56:51 +0100 Message-ID: <20260129155654.5565-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sat Feb 7 17:41:33 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41BA43385A5 for ; Thu, 29 Jan 2026 15:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702243; cv=none; b=c4+yff/BJsljMY+j2FZF3PKXWrWnAEjmPjDDkWgZ6Q+0k224Sqa4p8PDPzWzwN3+bNYsgSC/yv4opXqaJFaTGRHzTeSlFJpeBUs6nx0sgXK9CWkd+azQ1ElHWKfJ3h3WPXiLAj1NFMsqHlQ7rIV0HfkkvYSAxmDvd7Y1Fe9sNw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702243; c=relaxed/simple; bh=rydnYZqJ+NFeWlELYNoZjjVmnW/PmZZQ4nMY0FQMv2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qrjKdzgALS4GyGqU4mLNWjR+nJA44LTY73oxpGJagQIk3X/Oy2TeystT/qFaCJnRSYSnpc5QkEhPrYyZyzr2zCpg+a0xPyEFM2e2lkFtdbesfpOO7fl539IlpEo947pvK2+FVcDN5rHlT6iHeRQ4sQzEK8JxBgBl/uLCiG0sok0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kn/Kc1nW; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kn/Kc1nW" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-432755545fcso874691f8f.1 for ; Thu, 29 Jan 2026 07:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702241; x=1770307041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=Kn/Kc1nWxm+yg9ON0RLN1kICCRjHwCQbmADzkLYzl27shhmEzc335WEIzbc365Bj8A zNonkBVep3ywPjJ/l87l1J0WCmkQLVAcgrT1aNKyAC0hoKnbDEEmzJp5uVnOWTTtKO6r OkLUQ+/GjWoxyQn+MGVFo8aBr332yaBR6J+zaRodvDd0X7aAAhYzy6xTHKPcnGGV/Mvx NxcX8ViynfzLEjAEjYhjN8UvCa3EP6br2Id7nIzsZuDkESksiJ1TJaMdIfvjr2+iSrZf YysYnn28HuR9Mo43jSO3WG+FdUYPmC7tsrFUUtWk7SoYrc2B2axucwOtzmZDzRF+jwok pU6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702241; x=1770307041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=l7ko2mXq2ozQIt0gzTPVNkFlk416YjVNg6GsW6w7tmR0iAFjhlmG83byMj+Ub5j9y1 rq+ImHDgwzd2uH/LPRAx3p89aU259CzPAZjnrHOqC7Z/7OmyKA4pNtpfCzd3KP3Onm5t VOhEzC5tA4XIatFnyv5Li15cqG0/TvK/WFj0m1OASnO6uJe/CNRjTpWAfWXpAw1gFQgt g9ZIRkghrgniaIKN0x57qT/ZvcnDt7/Do6G7GeBQTBaXUynmtd8OC8K13Y/Pbeh+ipDA mR9LDjMF4haJ/2Yu23NH7jKTwZMB+V6F6Ue/mAAmIVXxrbYBgjrRvFoSfrJ+xW0R9qhv jopw== X-Forwarded-Encrypted: i=1; AJvYcCUb+hLH3f5MncQBRmWmyDYF5OMSsU1Pp54PHfYWm7LvF6ph7i+bJiJ912Nf0x5IezlqEkYQwchhygGcNM8=@vger.kernel.org X-Gm-Message-State: AOJu0YyNKOnx9IadCLkYcUXvkXR23Si1oU2aDXl7Ah+Bk5xFnN1jmUh8 Wn43M+QH5CYu+vvyfOt9vEH5zjXr7Zx1IRWaW218JVHJ16r4ce+7dLo= X-Gm-Gg: AZuq6aLZMQOgT9VArcOCsYfq8+rA2fW8k6YN1cEOR/92t0B8ACEsbNSGf1CSeI5L39o wtZAj4iGzxZRG1le0DyFjZCGGvpPw6d1/GXJl8r4RPwo0HqfhKCi8C2grt8rVN5DiDEF3dPgVGx aj6jAhSwPhOvBLGH3RNYpwScGvdFLpquFqHydodY5J1XBPg12Mp/cM1KM1H/iWsjINstwNTkLEp iq8+0DP9ycxHPbyD93YKliyEhWXEI/9uR05C24soLwOOz6zPsLQxKcbeXgeHtGov2EwMLDhUj+0 6gvcJQXWOQOupiLii70CgxJPcrWMvX8YECtfCVjmRMB4GBaXicDzH+CUDWqW8+jIg9g8duHmN+U NDVhK+ZFkbZymO0S7jHgmNzoeDfcWpxQf3gFZ6dpGP3+/UEIfxaVfqfYCX67vDTcKZoCaEP36Xe e+V/RnjoBV+QY= X-Received: by 2002:a05:6000:3106:b0:432:d9ef:3bf4 with SMTP id ffacd0b85a97d-435f3aafccamr90384f8f.47.1769702240365; Thu, 29 Jan 2026 07:57:20 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:19 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 3/5] staging: rtl8723bs: fix spacing around operators Date: Thu, 29 Jan 2026 16:56:52 +0100 Message-ID: <20260129155654.5565-4-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix coding style issues by adding missing spaces around operators. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 +++++++++---------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index d75a63fd8a6b..ae5e4980ed06 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -17,8 +17,8 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) =20 if (enable) { /* 8051 enable */ - tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, tmp|0x04); + tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); @@ -158,23 +158,23 @@ void _8051Reset8723(struct adapter *padapter) /* Reset 8051(WLMCU) IO wrapper */ /* 0x1c[8] =3D 0 */ /* Suggested by Isaac@SD1 and Gimmy@SD1, coding by Lucas@20130624 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst &=3D ~BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); =20 /* Enable 8051 IO wrapper */ /* 0x1c[8] =3D 1 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst |=3D BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); } =20 u8 g_fwdl_chksum_fail; @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c774a9009e95..668616efa68a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -875,7 +875,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) rtw_write8(padapter, REG_RSV_CTRL + 1, val); val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); val |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, val); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sat Feb 7 17:41:33 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871D133A9F2 for ; Thu, 29 Jan 2026 15:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702245; cv=none; b=eqrLhWLwPge0N7c4cjbWksCG4t/2nXVf8ULYCOIBI8BKHzzrtkeo2VIKJqN6b1jePWlWSXbEgFkxA+sECGD5rKRpW4Zl06qbqRRuhL2/n+ExNErW9Aotcz3qX30xAc2dtVh/K/uToxEg75tim0v6RJF7LxJWiOpNj4GL9y9R+kM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702245; c=relaxed/simple; bh=KgPnjkereDX5KqlGWxnGYXiYqSTZRbaT8uVVEkof5kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nWBo9NUQL2NjYvVu7mtBaWbI0C2O1AgE5T8Q5wkvdbjzSSKroieIYyBHozw0V4Uu7utmXIOqUudc571c8Cj6xirFfJXJiZywqsB06sZsccxn2RK5PuTgN+8rePZ37JGoO3uyXiREPpExh1R4A1l1XmVBJIffQR+z2O2XW7iRtGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dLYs88TL; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dLYs88TL" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso9940265e9.0 for ; Thu, 29 Jan 2026 07:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702242; x=1770307042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0LI8OX4yfH6IgwYI2RaV7W/8FvNlcKtMVfts+WWScD8=; b=dLYs88TL1q5x57JvnHtAHWxXddyt4H1acXzcWOVC3/2ezcKvqSZxOp/2BJHQe+MrMX hJzZYSNs34fmPcr4pKpai96Td6zY2caUJhD550Ih/yG+ZPsZTwRtYwgrkDJVW+WqxRjf iIKQJe62JIY9+M67dqhHwH0ZZC02QdSrx01Ayti1Pit/dufq/qvuwgFNsSKopJFMPwWq OSpt+Bw4+0aO9p7G8QkCGeb94j+HiaX6sthQdxHEoYs+bK6nX92Satp+Pj7ASbHFB3O6 +HZAg74S3DVcebITSKjXJRkc44ilx3uUA9++M9wcvruWAw0BC8ZbdR2vkuop33WzqPie OCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702242; x=1770307042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0LI8OX4yfH6IgwYI2RaV7W/8FvNlcKtMVfts+WWScD8=; b=nZZaQFOnr487HlouPuPKMWeB88Ggr55bbhqDUh8WnPP3fYMBmyJflf6XhCu+TGi6i1 BG+Uvo9sNnmC/VdeBbPgMxm+uYLGPBILaLcTz+TGnMgj3YcG177rxmikdz9TxiIL6e9T W9bffusFpsh+WirHUy0Pa/EVUvneMw0kyL/UmbrhZc1uO5Al3+vByoIzXPY/9tQHDaUg KjCTE4aRU0lI27iJMg0r6x6bmobnninx+Xf/unhejmx9zUwGZnQvl50HxvpAmzQ6VPXN wYjTj/zqaLpcva83xK06LROsHcFY5vMAhaKofxdjpwMzTT9At8c6u8fCQo/tIwjUgvk/ H4Lg== X-Forwarded-Encrypted: i=1; AJvYcCVYH+IobW/LeyG7gGHgMhnmME0S4ySu+VXSLiAynnq0FPeR8jiFZvx+wT6Qhm37/RYNfK3DIuYLz0pH91A=@vger.kernel.org X-Gm-Message-State: AOJu0YxWXke9GGNVbVy96vC6rmJxVBZ0V6xdphQWx82WpuIjO1yo2y3Z vNPBd9mrvPpLolErRgDPykWakXtPL/AOgE4wijaqVhAiJZ9lMUnCMT8= X-Gm-Gg: AZuq6aK9FonMK6Bu60iGMD8e91fPCGPDzDBNvsIrTYLM7//2PauaXI3/UtzESln0ld7 Yw/lsV0iLzPu/z6COtlmc7rOKL7rcl5h5c30mPZ5gzkmQ3JwhEHPq8CTqoIFzz9PRfjp42JfMLa PLP9Gcx9H4TyUniCThMFDEj+R8RYXgbFr/9zZomawSpK30p6AdrN2rl3iUPitQe1j9/TaLPHaj1 lqm/bQPRBXaNJc3EpEnPn6c10ATecvapS8xnJk00KcRbVMA/DsRKlAXcnqlnzuvobXloN71uv3V 7i+qXs5cuAxtloUbvnlxN2SYz2yUdjuvCcMgqeQ+41cTHMMsqbCWsH9Mc8NQDFVhMY3qK4ofGhe jw19HsXJWzz9OJewUUd76dt4GMEQD4UU2f9b5lxaRS7irdW6MHjguvpXD3QGDUnsU3jucSXlpKQ b8 X-Received: by 2002:a05:600c:871a:b0:47d:8479:78d5 with SMTP id 5b1f17b1804b1-4806c00bf4bmr107978585e9.7.1769702241796; Thu, 29 Jan 2026 07:57:21 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:21 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 4/5] staging: rtl8723bs: modernize hex output in rtw_report_sec_ie Date: Thu, 29 Jan 2026 16:56:53 +0100 Message-ID: <20260129155654.5565-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual hex-printing loop with the standard kernel '%*ph' format string. This simplifies the code and uses modern logging practices. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7dfc2678924e..267e487602f0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2087,8 +2087,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) len =3D sec_ie[1] + 2; len =3D (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX; =20 - for (i =3D 0; i < len; i++) - p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]); + p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie); =20 p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")"); =20 --=20 2.52.0 From nobody Sat Feb 7 17:41:33 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0747B339857 for ; Thu, 29 Jan 2026 15:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702248; cv=none; b=pMlakxwnDM4gvuBjahAn9HAeFXM0DyJ9H8pidgzSZDq4FNEGVQgtucqLTnYmPzKYZCc//bJYWBYKcAVwNnmEdeeEqlSy4bNpWYulQmSKWFqaUuf35KabybP39g33OlKC3e53wzUPQ6L6CLqTbwYO5bNRuNY7CYwsma1hgxxf9z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702248; c=relaxed/simple; bh=bUeyerzNTibRKm7wU0xU1y09XX+nLkg2/OqCGqcSZ+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=htAh8fod3L3dyfHMp+CVhQW3r00FqEl178BaI/EgxqC9dVePNVQSNW37aSFam3YxOh8bNZQ4OsVULmFGM3PxgyGTKBUc5pIPpGqqT4AtWpymMH0NZXo0PWpNc1gjLALPBJPf1MRDnoFM1zZVzoMtuP+bSRWpFC/G51gkFflSLm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OmtpZ0nD; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OmtpZ0nD" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-430f2ee2f00so723246f8f.3 for ; Thu, 29 Jan 2026 07:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769702243; x=1770307043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=OmtpZ0nDk8TOnNuhmHp5MC9WMzFAjWK/mCunmTMbGSB39qT/DRgvOmLdQsznsauvcq qR9vxMcP5c57AKD0YUxWm4VAWR8NAnGTpuxlp43Ozm4B/WqDATcHUy0bMhCWVf86kIz6 n0zrVHj5DFXFreU1s7MyEax8X2s6krd7SUrBOyuQU8s97Xd4lteXur7YsTNUNN6qsfrv OD+AEBOlRg1p9OgqWQ2A2K3AhoPU5htpur8aYWwGmcUyM20mg6O0oEtstLDCKL6UNRM1 2A5rZoV6HY0hsBEXWIByDa1B0JIQYZaAXkCkyHEEx+UOdSP+Mn8ztz7EgdwTBMU79rvp yHxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702243; x=1770307043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=pGmWzj6+G+/4C849+wCM70Y6fGB6uFrd5YQTd4F+PsFtjgrkgw70srO8Hhn4Xj9V34 ZoOZXf6X8mRoqhqSVA7X1JjuSCPCrUTTrP57grn/FijsTkoi/kW0xfKqCxghD5bCmgSc 3N2rFv316t3lmpGJfqXQUJQeOMJ4By/P4kY01I8BeAPuKhE3lmrvkBHt3JI4jYn6qkEb iGPMsBfSZelFKcS3SrPTbEVNt4mQAK9oj9NhDw5b0mslH1PIA0YwTGx8Ya9AyFBzImx3 GEVPVjpdYJ2Uj7Nc5Ld9FiBBGXLaiu3fmLWRRIQgPPTIwdee8gffQxWmhCcJVRquXaxU nHOQ== X-Forwarded-Encrypted: i=1; AJvYcCXpplV60cIBNHrm8Fwn76CMOT42sn4GYz/iO4SHLJtnma7W0CScdBd0BYczyEHETF9LVprv8bnYlHtL9YM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqe10vFBk/kov2ySQSsn/cKMYURqxZLFBBOpru1CUIr304m6JL mTui+XcejhkpBELRieuT24TfR7v40oAjWtIW1Ib7EKptqBXQbE7IbCo= X-Gm-Gg: AZuq6aIblylr4b3NbLqzwDUPgnZVRza0YMQtXu+yp45NKuZ2owVCQ92KwXJclMij5g4 xlSTUaqh/bBjdy6CGoBZkOQaoX2E38D5q/IlN0dw/zcU2hr8Siu8sVch3Gk/eYwaR/WlVB2r6GA g0XZTUibCdJ2WCMOqE8t1Tmok7bH9Nhl4hXxnqhlsYpYT2nO/Hpne5BRL9rkRzBbBPu7SoLjaTV oimiIwGgWRuTf/4e8b5DdLFriyDSxk6ANPvN6K4Wo10hJC4FLQrfoXxaJaHv1L5lk66yLJeGMn0 4ZzgHsN/WZ/cEhCooyFMJIQiiePgUDEhk00jsFGfwxCH9pZIZDXnDBvgGvcQRjwsn+i1/SQjQ3l 9+MHs7RWc6soLZPxItdJJIWq6Yh64lNEp78k9Zxwag96WCAdGqNCgjehOSORzSmyYnIYkFOia6X Sn X-Received: by 2002:a5d:5d06:0:b0:435:94aa:df38 with SMTP id ffacd0b85a97d-435f3ab970bmr78552f8f.55.1769702243204; Thu, 29 Jan 2026 07:57:23 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm15749231f8f.16.2026.01.29.07.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 07:57:22 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 5/5] staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c Date: Thu, 29 Jan 2026 16:56:54 +0100 Message-ID: <20260129155654.5565-6-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129155654.5565-1-lukagejak5@gmail.com> References: <20260129155654.5565-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused local variable 'pattrib' and the unreachable 'if (0)' debug block in OnAction_sa_query to clean up the driver code. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..b61841bf16a5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, un= ion recv_frame *precv_frame unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame = *precv_frame) { u8 *pframe =3D precv_frame->u.hdr.rx_data; - struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 @@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padap= ter, union recv_frame *precv default: break; } - if (0) { - int pp; - - netdev_dbg(padapter->pnetdev, "pattrib->pktlen =3D %d =3D>", pattrib->pk= t_len); - for (pp =3D 0; pp < pattrib->pkt_len; pp++) - pr_cont(" %02x ", pframe[pp]); - pr_cont("\n"); - } =20 return _SUCCESS; } --=20 2.52.0