From nobody Tue Feb 10 15:43:24 2026 Received: from mail-dl1-f99.google.com (mail-dl1-f99.google.com [74.125.82.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E9C29827E for ; Thu, 29 Jan 2026 16:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702539; cv=none; b=ReOV98517QxiB8gl0ItSqgAMK+d/KWO/3vdrePY5z5ZT/gAeqfQcWFhbN0xEl4D9FFr55YXL4rq2iN8ElHjoucGeseGnbRq/RHMtSTwGOqfIlpVjOfE2byRJwo8GbyJV5QGPZaNznowGmuroNqnRI0t84IzpqibhN8cQ31VgQ30= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702539; c=relaxed/simple; bh=DHqde27QWSvUIR9UQMg/0u8uJYYHJ69eh9Cu2epYtgw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dl1O4RTHNQ0/BJ+5BaRPiEvyXJISWZWj0k0tR3MtvBnRcke+OmfR4SqvMaE89UP0BvCn6wya8ajSdSQujveo/gM7JIcL2ZfM86hzi+OSDkqDQkWF4cTYg0dfFD2JkbVPWqoJQS4egDtOiNEgJQZQQVL6DxKOfSEQxsq+PRAiZ+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cEHkZ0m7; arc=none smtp.client-ip=74.125.82.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cEHkZ0m7" Received: by mail-dl1-f99.google.com with SMTP id a92af1059eb24-124566b6693so3027348c88.0 for ; Thu, 29 Jan 2026 08:02:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702538; x=1770307338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zZ/bh1ikCUXFmsDLX8py2lt898j0ZtCfmsg+DJjP24=; b=d0ZlZOjTO8AY6L9nSgdgnQCOmH8e+I1wiw2FuoL9n2umcozHQp4KjOa4/lof6KHyMJ IOpEKVCDwLkHkP1ivktSdoaomhdSCkECUnszjKBCMPCPIXzpE64Y6e+loS2g+cSnw2f5 vmlbtRgwm/ciWaKxwgWXsheFdgEY0R9NFt9/rC1xwiD/wEBC0LkF6est0o6uzyCmszNU XUt4VIuqdXQxQqa49maFIv6XGn0SSQt7IAS7K7UjjOuIA8YJuKl5gW6dZqWW9YLN0ii7 kykGyDu9hYxSsx9E53ThoX1JDFLVoc8BKeBrH81vYjfcpZU6QE6vYe0s9E7qpi6diXUb BNBw== X-Gm-Message-State: AOJu0YzykU3/h43XRSeNXlepvOY0izmFLGtrQPZoCVkLf0f0Il3qCprv vCtD5V9qVD5U64qZNbV8s+XLZFD+R2g9LDggDgUMkUuFoh6hO4fgmpvf3BX26ltnNHI5ucsgEEf mTNV9nMWRuEizAQ1XW/iP9HSjqMJXfzhXG98QwTwkUHu7tRepsVRv35yWCSTdsi8WyEGwp1vvDo +yXcrSSLsC9fQUSo/zUwTqjSZLt+JFf6zm/bjllwvySDwWt09eMjKLhnzZc0uzkwj7PsD6HdFUP xDFynuUYk4jQM/UHSA= X-Gm-Gg: AZuq6aLsRRjrCn9UNrJC9e0Unw1U0WpEE1e8D+duGr0jaX36HRt/d1AJNx/o6LDiqVp B6KdiXpaheQuPeKuyIDFJqasVVm4/SeyF6mhcLpe2M5tuesCXPDNrlr3blqobIQF74I9Rnf3h9x 4PLw+hpVF3iYon3gWqkZbtm3lA8uwdlSIvjf/NbkmefdZkIuVqHCCZft3Sf5rDkI1TFvosazq4M b9MxqpayTD3LUQZgkpdFTq23WYQG8S+laLEXWlO4DQyr6DjiaLaMl2bCbUYulc5IzpLzIU5yKgL l7dvjSTYZWwHslJQ6DcE+CYuYMq1j0+/Mqr2ByCxUTcKuDyTb4uQLZPw8OeESZzBNMMUP1XC/9z 5zFc/yFNJUTlCTqwCZd4LBmvtFbNVCBFkB5dXsf/GCZto/OKCJM5rEMcqV9rd3yasxPNx/qzXNo IFmttegz4NSZ2kLwo0Ddc9g+ToYINKtNmlrNIo8Gnf2z7G X-Received: by 2002:a05:7022:2489:b0:11b:b882:3ed5 with SMTP id a92af1059eb24-124a01142bfmr5713605c88.37.1769702537129; Thu, 29 Jan 2026 08:02:17 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-20.dlp.protect.broadcom.com. [144.49.247.20]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-124a9d6bf1bsm914091c88.1.2026.01.29.08.02.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2026 08:02:17 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a7701b6353so10991465ad.3 for ; Thu, 29 Jan 2026 08:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769702535; x=1770307335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3zZ/bh1ikCUXFmsDLX8py2lt898j0ZtCfmsg+DJjP24=; b=cEHkZ0m7g4pGCc35fNoWQ3imyc9O4XvqOz263hN7XY016S65E8vcWIX3doBJutLILc 3dcoAKkUWULPb/zQWOkfIg2EgYB1ohnORh3uasqcpdUrWFh1ORqZAf2D/fxFDrrkdr0j cQhUDIwiKuNe9+nYXMv6Av1m3OE7YfNzsVWYk= X-Received: by 2002:a17:903:2446:b0:29f:b3e5:5186 with SMTP id d9443c01a7336-2a870e9f4bdmr83677345ad.56.1769702535372; Thu, 29 Jan 2026 08:02:15 -0800 (PST) X-Received: by 2002:a17:903:2446:b0:29f:b3e5:5186 with SMTP id d9443c01a7336-2a870e9f4bdmr83676955ad.56.1769702534783; Thu, 29 Jan 2026 08:02:14 -0800 (PST) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4153efsm50354855ad.38.2026.01.29.08.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:02:14 -0800 (PST) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi Subject: [PATCH v3 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Date: Thu, 29 Jan 2026 07:54:51 -0800 Message-Id: <20260129155453.3626544-4-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260129155453.3626544-1-pavan.chebbi@broadcom.com> References: <20260129155453.3626544-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Create an additional auxiliary device to support fwctl. The next patch will create bnxt_fwctl and bind to this device. Reviewed-by: Andy Gospodarek Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- include/linux/bnxt/ulp.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/et= hernet/broadcom/bnxt/bnxt_ulp.c index 3097fc5755e6..9fd3c1e43224 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int id= x) =20 static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] =3D {{ .name =3D "rdma", +}, { + .name =3D "fwctl", }}; =20 static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *e= nt) @@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); + if (i =3D=3D BNXT_AUXDEV_FWCTL) { + edev->flags |=3D BNXT_EN_FLAG_ULP_STOPPED; + mutex_unlock(&edev->en_dev_lock); + continue; + } if (!bnxt_ulp_registered(edev) || (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { mutex_unlock(&edev->en_dev_lock); @@ -316,7 +323,7 @@ void bnxt_ulp_start(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); - if (!bnxt_ulp_registered(edev) || + if (i =3D=3D BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { goto clear_flag_continue; } @@ -521,7 +528,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) aux_dev =3D &bp->aux_priv[idx]->aux_dev; rc =3D auxiliary_device_add(aux_dev); if (rc) { - netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); + netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %= d\n", + idx); auxiliary_device_uninit(aux_dev); if (idx =3D=3D BNXT_AUXDEV_RDMA) bp->flags &=3D ~BNXT_FLAG_ROCE_CAP; diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h index 1a4643c46f86..0851ad3394b0 100644 --- a/include/linux/bnxt/ulp.h +++ b/include/linux/bnxt/ulp.h @@ -24,6 +24,7 @@ struct bnxt; =20 enum bnxt_auxdev_type { BNXT_AUXDEV_RDMA =3D 0, + BNXT_AUXDEV_FWCTL, __BNXT_AUXDEV_MAX }; =20 --=20 2.39.1