From nobody Mon Feb 9 04:12:36 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383B627A91D for ; Thu, 29 Jan 2026 13:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693060; cv=none; b=W7Ix6uUudMeBm4tR+THL7i2mJe+M9EIv8ItggnJ34Zms1QxEs5EMXG4xKwfm1oziIcre7r4AH/LPHwQsKLw9T8PMf66bKSt+A7r86ItypcCuO1WZqMLetpeFPu6HEqb9HWWLrQF50tP9ycF/p//Mw4EgrzOUAmyUwHsmu+4lEoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693060; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KMkFGDZNMmZ5nmlIsDgxl9+9fxmATJ/+oAtvOgIAIYq7nKKTYswFwgFcDM1Chzrf6qQQhDf8yfIK+oY3S07PvMnjlWQm2y93770l+WYFJcAVBnwsmdIcNF9wmfh3oJSwfmAC+sYYGFZ/CdI6/LtF7YozPNJfHvkoLcC3hoR4n/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fbByRJdd; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fbByRJdd" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806bf03573so5410445e9.2 for ; Thu, 29 Jan 2026 05:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693057; x=1770297857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=fbByRJddwtsLMcWgdccqbTaIlKm+keoagKM+GVXiT5I9+rUMxR2g2ZTSNVDqWdkHH9 5S63cUsGEc5E7GYg+FwENygdWvZ0cXiHDpXis0a+l5AB7KfrYQx35BWbhx9EfE5LE+fe MNKQiTimmZC7US/rKd1tJJZSmBFuBgZR4Rw/nJyVcf5n1+9KlpEImVzT/k+PEzPZG8nl 1FxnNMKN7BTJSWeiBhG8QbHXXh/p8MSKlJdEj7KKdfUrVRC7TTVA8n7F1ddCObYAIoqm i8Ks37BkH1CSnhfz9AngA6RTzbG5pSbmUlEg6asaQJ6xe6Dy4hDngEMZ8l2zMoApSEbg DqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693057; x=1770297857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=I6plB9PGnLiQxsJLNrqIftCBLFgaUnRsQnA6KZkRG2MhWks50VHJS21qIlBxqIfsK7 FGCsVPGqzaD+H9O5fgmZ4UdEquULwBLiAUiM0aWUOCzP6jMlbh2IKTxxnzs97J1FNPNm zIw0/IyTBSZVjgHMLbtFmrKcZvW8EamcNjMeIbicVffIThVHSHit7Q9UXUPw+8kxLsNH RX1PeMfB1M+Vs2lBeFOADrBL/dvgVJtoL5802Pq1KNhmHJBkGxx3iA+bZqrxE1878+pZ aDTMkH2C1BMrL74snWIA2sdeILAG4yS9IUnOnAqZVCAJUEZYYfhMm0tev5n5AsVFRJWW 0waA== X-Forwarded-Encrypted: i=1; AJvYcCVv/IbvU4TinXmwInnizQJ8ZlOxS+W0sE2KK1r+ZxK0vf4gdaLxmTq7xTROA1+6TIXGXLVOIQeKFIbHUsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwTzECKxXi2s9MgJQNk7fgZeC69XkUhdkV68pk5p6hN+H+spnzB pB79iW7AdBUubBaQh8i55vkuRHhSzCp1l+SaQ7KXoVr1GgoeqVFsB996hdPloCc= X-Gm-Gg: AZuq6aIzn2wN8yaKq7WnWcBxIgQ+Yhk7QvRGevqESRZCGoGyvpAOGRN1+dnaNTywC6D BpcaKOWg1zS/iUOlah1D1KGmoA5MIHLLLe9RlnceChgt5359P8AndPvaT8DCQisWt/vyJgSMKep aJIacevddbHiiuxXXjVdiQtwoa6Ut5ZzHzTWNTgnutJG7+7Wp9eYO/yjk50u26JQfcDwdEY9qrr ILqd6Oko1RpIGBMoWwrRuEeN1F3XBzqWhOWXKO935A5m0tPZGA09WOnhdOnL1O/sV7aKa00ii9j zaIBOK5qAPC26V5XXIN2FjkPCUm/AzR3K0A5W4ziOb+SZ8TWqf2HSKz/vP2uDt2wPoBfQji+u8N TQMyJV9fIIGrnIvFCjJb+alIIwT37T12HKus0XHa7fZgYENaVprAT7RN/R+MxEm/opIDlWs6P+V yn X-Received: by 2002:a05:600c:1d16:b0:47a:8088:439c with SMTP id 5b1f17b1804b1-48069c9ec08mr127130445e9.35.1769693057452; Thu, 29 Jan 2026 05:24:17 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:16 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 1/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 14:23:48 +0100 Message-ID: <20260129132352.14615-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0