From nobody Sun Feb 8 08:27:37 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383B627A91D for ; Thu, 29 Jan 2026 13:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693060; cv=none; b=W7Ix6uUudMeBm4tR+THL7i2mJe+M9EIv8ItggnJ34Zms1QxEs5EMXG4xKwfm1oziIcre7r4AH/LPHwQsKLw9T8PMf66bKSt+A7r86ItypcCuO1WZqMLetpeFPu6HEqb9HWWLrQF50tP9ycF/p//Mw4EgrzOUAmyUwHsmu+4lEoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693060; c=relaxed/simple; bh=gtRfArYMpYtR3Wwdb2Q6o7l+m0XA7ZJ5Jw1ZMR1mG3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KMkFGDZNMmZ5nmlIsDgxl9+9fxmATJ/+oAtvOgIAIYq7nKKTYswFwgFcDM1Chzrf6qQQhDf8yfIK+oY3S07PvMnjlWQm2y93770l+WYFJcAVBnwsmdIcNF9wmfh3oJSwfmAC+sYYGFZ/CdI6/LtF7YozPNJfHvkoLcC3hoR4n/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fbByRJdd; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fbByRJdd" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806bf03573so5410445e9.2 for ; Thu, 29 Jan 2026 05:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693057; x=1770297857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=fbByRJddwtsLMcWgdccqbTaIlKm+keoagKM+GVXiT5I9+rUMxR2g2ZTSNVDqWdkHH9 5S63cUsGEc5E7GYg+FwENygdWvZ0cXiHDpXis0a+l5AB7KfrYQx35BWbhx9EfE5LE+fe MNKQiTimmZC7US/rKd1tJJZSmBFuBgZR4Rw/nJyVcf5n1+9KlpEImVzT/k+PEzPZG8nl 1FxnNMKN7BTJSWeiBhG8QbHXXh/p8MSKlJdEj7KKdfUrVRC7TTVA8n7F1ddCObYAIoqm i8Ks37BkH1CSnhfz9AngA6RTzbG5pSbmUlEg6asaQJ6xe6Dy4hDngEMZ8l2zMoApSEbg DqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693057; x=1770297857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SsaA9RaWnt72GW7j0IMh4QTElhYpzUgcR96rkJIP9qQ=; b=I6plB9PGnLiQxsJLNrqIftCBLFgaUnRsQnA6KZkRG2MhWks50VHJS21qIlBxqIfsK7 FGCsVPGqzaD+H9O5fgmZ4UdEquULwBLiAUiM0aWUOCzP6jMlbh2IKTxxnzs97J1FNPNm zIw0/IyTBSZVjgHMLbtFmrKcZvW8EamcNjMeIbicVffIThVHSHit7Q9UXUPw+8kxLsNH RX1PeMfB1M+Vs2lBeFOADrBL/dvgVJtoL5802Pq1KNhmHJBkGxx3iA+bZqrxE1878+pZ aDTMkH2C1BMrL74snWIA2sdeILAG4yS9IUnOnAqZVCAJUEZYYfhMm0tev5n5AsVFRJWW 0waA== X-Forwarded-Encrypted: i=1; AJvYcCVv/IbvU4TinXmwInnizQJ8ZlOxS+W0sE2KK1r+ZxK0vf4gdaLxmTq7xTROA1+6TIXGXLVOIQeKFIbHUsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwTzECKxXi2s9MgJQNk7fgZeC69XkUhdkV68pk5p6hN+H+spnzB pB79iW7AdBUubBaQh8i55vkuRHhSzCp1l+SaQ7KXoVr1GgoeqVFsB996hdPloCc= X-Gm-Gg: AZuq6aIzn2wN8yaKq7WnWcBxIgQ+Yhk7QvRGevqESRZCGoGyvpAOGRN1+dnaNTywC6D BpcaKOWg1zS/iUOlah1D1KGmoA5MIHLLLe9RlnceChgt5359P8AndPvaT8DCQisWt/vyJgSMKep aJIacevddbHiiuxXXjVdiQtwoa6Ut5ZzHzTWNTgnutJG7+7Wp9eYO/yjk50u26JQfcDwdEY9qrr ILqd6Oko1RpIGBMoWwrRuEeN1F3XBzqWhOWXKO935A5m0tPZGA09WOnhdOnL1O/sV7aKa00ii9j zaIBOK5qAPC26V5XXIN2FjkPCUm/AzR3K0A5W4ziOb+SZ8TWqf2HSKz/vP2uDt2wPoBfQji+u8N TQMyJV9fIIGrnIvFCjJb+alIIwT37T12HKus0XHa7fZgYENaVprAT7RN/R+MxEm/opIDlWs6P+V yn X-Received: by 2002:a05:600c:1d16:b0:47a:8088:439c with SMTP id 5b1f17b1804b1-48069c9ec08mr127130445e9.35.1769693057452; Thu, 29 Jan 2026 05:24:17 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:16 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 1/5] staging: rtl8723bs: rename u1bTmp to val Date: Thu, 29 Jan 2026 14:23:48 +0100 Message-ID: <20260129132352.14615-2-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..d75a63fd8a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 08:27:37 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 980D32874F5 for ; Thu, 29 Jan 2026 13:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693062; cv=none; b=N9lNFmhZGUz9YQ1T4qoNmNxtVW5pXcSTKA57QRbidLa79RAzc2/vPOdeSUSfUJiQyeMsMMkrrBSFMefQcbaz4LPIJJ/YUjL6PTW5eHcA3Xihhf7BolsNW+gG28eYff9c4794jBwMumGMFS6Jevz4R2csQBoALaAYcXZgK94dH7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693062; c=relaxed/simple; bh=rydnYZqJ+NFeWlELYNoZjjVmnW/PmZZQ4nMY0FQMv2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ODXLPgcSt2f4TueDJ+klQRuEMH0EnXbX2Udsx8bVTtM1byz0WSZYrwEe0+9TrFW+swJiBKlXvCyWgGmc7vT6gqVTXi1lv7T3oaHKhvJj4Yyg3svQxmD8VPr5PgGryqt3L5oCSMdFa+Agc+Hg2aCXlVQkPLizhpE2Rcz2kS0Yaio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SyGMnVXD; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SyGMnVXD" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so7223345e9.3 for ; Thu, 29 Jan 2026 05:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693059; x=1770297859; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=SyGMnVXDiY6GTGXkr7ZkfNzW9B9KHa96fwul/K2LJ6CW2Lz03goKpqDPGKrCOflStW 74AWSfg/lKlwqg8r5c/3dC+HRJezrL7+lI+R1brJqhO0NaZHp5jgvgmCoPMDaUJXVlny xOaOSTOvq1MRCbOckOCHBTiay0Ln45XbI894R1ViF96QMILBp6P3dgyF3FDVzGUPodrW 71sS4IC09Tv2Uiadsod7Q/IX2cSgSJ8aVQcAXPBFO7FIsTkgLNG36tFxqNA6tEZVR0mq viHeYI+47V8u2VXhYwy0Z2XR79MiXGUg8SvUvwuwaZ5ZMoIy+2EQifIz7plJ8d7lMfZi RQtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693059; x=1770297859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itsgzrCz2Yf6Uryqzwzu2QWjHF5Dbr5bnBZ816xY3xM=; b=NKM/eZcsCu1YEUZPFFWxN9VuUJLE2bZq56/fmtihOjCk9AKaHKiop6aCaxDuF6Wiiy 4h7xKmf33oOJDJCIRQQOZ3NJKyyUXhCewCmq8zXogwq7F4Bb1U8qqEl3aCcv9BpZo0lS 6rzbV75VmFLA7zv6CfKz6i6lI7Wy5AEj00nqcVV7e8RYnq2ycj1hEWqyMFs0X9TZD/oc YCgwlD8TRFsbomMMo6e0NUKcm4x1ySHWDLoennz27dhDQsInWvpoMKhNLx7XPqFS40Ro N1uuug40esLNIGUUw0euB2TNRxVZJmyyhDbwINIIGIubJNK6GO/KfScvxH4DgWGYQ3Ah gorg== X-Forwarded-Encrypted: i=1; AJvYcCUNfjHgaGBZoh9SicVxcD/F/YHNNVvcq/58N27usvcg1aMx1j16ucGwxe7LxroS8CGDrd3m3LfCO0JwjcQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yymh3pvXFJVMlI1pzJr2dOBcG3MXUkMsMd3irzlzkbtaLzUlwLY vdSPPGmajLM2RU1tyAOrYytW2A5XK4mkIEOtdvlPwlbFrZmmB6aVPoA= X-Gm-Gg: AZuq6aI17WiN0txeZpWiJ6P7Krq+ZTsapfZzGtKfFFkAQUS4AOqSzNSnNxfBTH0y/Dq GnN2BEPC8Mtthost8oUl2fACNwkLQGfzlCtjpUD090Mpap1ChLJWYOWYIY8wgiFk/f0fwI/qzbS lDqWhE2HVVQJXrPw7iCfQU8TDsWzaw78jXiyg9PnNRngzi1lIk1HICSU4l9DMABy9jnlZhcL7Be C7gzX7H8ysHnOGEihiLYxb4IXYG0k7+ypmbID+gfJo49KkwUf8iZAy0Fp2es/LbobqAEJMglv3+ GVlxv/YmsCEFhy81We97a8hctGBG6Nt7dxQj2L55h44f+0NtGQsTL7S/hKFfpSDB7ZgK+jq+1qT s+c1RiFrrTvBBoIbDsCQ/T/rgrizm9y6Wyh4YzC5tpW6BEhp04N5Aizk6KUs5mI9L777yunrXmA Zu X-Received: by 2002:a05:600c:450b:b0:477:a1a2:d829 with SMTP id 5b1f17b1804b1-48069c0e6bcmr101345105e9.13.1769693058670; Thu, 29 Jan 2026 05:24:18 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:18 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 2/5] staging: rtl8723bs: fix spacing around operators Date: Thu, 29 Jan 2026 14:23:49 +0100 Message-ID: <20260129132352.14615-3-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix coding style issues by adding missing spaces around operators. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 28 +++++++++---------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index d75a63fd8a6b..ae5e4980ed06 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -17,8 +17,8 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) =20 if (enable) { /* 8051 enable */ - tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, tmp|0x04); + tmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); @@ -158,23 +158,23 @@ void _8051Reset8723(struct adapter *padapter) /* Reset 8051(WLMCU) IO wrapper */ /* 0x1c[8] =3D 0 */ /* Suggested by Isaac@SD1 and Gimmy@SD1, coding by Lucas@20130624 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst &=3D ~BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); =20 /* Enable 8051 IO wrapper */ /* 0x1c[8] =3D 1 */ - io_rst =3D rtw_read8(padapter, REG_RSV_CTRL+1); + io_rst =3D rtw_read8(padapter, REG_RSV_CTRL + 1); io_rst |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, io_rst); + rtw_write8(padapter, REG_RSV_CTRL + 1, io_rst); =20 - cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + cpu_rst =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); cpu_rst |=3D BIT(2); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, cpu_rst); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, cpu_rst); } =20 u8 g_fwdl_chksum_fail; @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c774a9009e95..668616efa68a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -875,7 +875,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) rtw_write8(padapter, REG_RSV_CTRL + 1, val); val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); val |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, val); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0 From nobody Sun Feb 8 08:27:37 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E24529B77C for ; Thu, 29 Jan 2026 13:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693064; cv=none; b=lLeCtCaFm0bbbQqM5s5X4+ZrE2+/v8ZUPqODupVdVV7XB6erU8VlizkjaC9Zj2lD8FRpCMVc19lPWk6dDlTQUY4Wh9/3DtN71xTEJ6mV5+66VMsX/X5XdHLvd7uneBqSyahyHP7dk8MRqr6DfU2yerGrWKcnYEi3zcO0trVEV8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693064; c=relaxed/simple; bh=qYVtkn+cxp4QV6/+jBhIsXMwrmuZrnkA6aQayP1iKso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zmoakuys9J4jCouRzSnf8vrKbRD3XoPKYRp/T/IUOffDyldRMpp7f+XPzGKsNwIbYWNinJ0o3V3RPciwj/kGQTwlT72nlNQLPnod3ND/qGOjoDc+BVL8tDrbJnEu4iUUv1k4EZixfe0EyR/jnm06Y0Ki61LWKs2hOTV+X0c08Gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UVV8INix; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UVV8INix" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806f3fc50bso9606725e9.0 for ; Thu, 29 Jan 2026 05:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693060; x=1770297860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1s+z8TAXRPptxKCmOFNnf6+JM2I9hNSLblXA5N2Wnao=; b=UVV8INixRhH8cv98JEGvqTwNkiHb/dd3DgFyac8/3P7K2bxFjFjrK2gI+ytGJWnjmV EvlmdVlebMJtXX5PmIStEEJ1ijDUCmbDw4o5U25smften/7c2eJJ1Q4l8srBWrDIfX1y 2NYvHb4jU2MLutnyWRhKJaat4kL+mHFK59LSsvOnMO2W5SUoyEFOD1DzolTQWId9BVDM DZRLjENmxTzDkgX5kYrlSqoVwCuBVrgpf4bgrvQPs8Sx0OXhtwAw4QZ+bhxOLxVVb46E sOmv1QW4rXWlW9hMMZyGg5sGqXC8htKGulTD5fJ9eOvpUlfUl8J3ppKOnBM7jdK956TN 2yCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693060; x=1770297860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1s+z8TAXRPptxKCmOFNnf6+JM2I9hNSLblXA5N2Wnao=; b=J6ZPwxT2a243pdV6BXFb4iG62Wf0qvDXHWSMdGQqLXQ3rvusn0QlSM8VHKEm+7DATL Rq7wkV9g+x82phYHfP2t/jLFDqP0+xPJXXT1b2tDdLdQ1Xo27ICHUaLb+lrgNUybfVE7 uQNzO8uoNBTKdrqqLNR1ugDLG9H3zxMgAFAle7SqXKOxjTKFZB3cBeQ/k4EfuVGQKzrh C4/r3q/1o+bZjCtr6FX0wJuY9ATlNEwPmfF7uln6asLVAbNm3wmQYUwH5NoJPATewE2p J9lUffSguB7gs3d5ZpguwyWbHiHQ6AWQG285CRfK9YYBckuggBV+OMcRbnNfobgXDs27 jQQQ== X-Forwarded-Encrypted: i=1; AJvYcCUcHrQcbUPyPfnx0C7iY1DFR9Bv4b72nrY94fwN5eNwOrOCVrAQWanfCH5K421jXfNKIJlmRNJuFwexlXc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy34KcbsuPaDr8auC3yXeBw6+KGYQKSfOWxexIVwv3VauJi7l5x nOykRJQlIF7p+cJ/tC5XA38bZBsXZ6FYPyf+3DiaFymQKNniYmwGRH0= X-Gm-Gg: AZuq6aKDzHJmitRGv7vSovPOuExMsFxbYKAMI9VMFDmx54wi6KSVkt6yYB03PeG6H0y 5c/5FkevtQW+gi1h9B1Wo3j9Ec6WXdN8gjirBGa7lOGTWydJUKETWimLWfgXjBsKEgGXPr7Rbwk P3jgzacnM6x3vmROj1xlcLwQ8v7/K/CJdNePO6irpEdmRy1863e3ZMA6i501Xe61lNselsew2bC BgkJZghzA/SbfQwQdELasj/5SfyX4N4GCx3lUPXp1AyRuc2wKVWX/ZrPf5GB6Effa4oSO7DUC03 BwOWSD7+sFBJBNBDjFN7TI3pBLDg3QvTN5teHo4QlpximLonn6Rm/KkVACoq2bxYh59/n1upbyQ NHw47yxxBQvzvvO8invlr544mifrT2jX4eOuKnPvaG4aMpA6et5U0mkMTnafgMjHPOB/qMfl0UT GxuPVDvCAABYg= X-Received: by 2002:a05:600c:1992:b0:471:14f5:126f with SMTP id 5b1f17b1804b1-48069c74078mr112409395e9.33.1769693059958; Thu, 29 Jan 2026 05:24:19 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:19 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 3/5] staging: rtl8723bs: modernize hex output in rtw_report_sec_ie Date: Thu, 29 Jan 2026 14:23:50 +0100 Message-ID: <20260129132352.14615-4-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual hex-printing loop with the standard kernel '%*ph' format string. This simplifies the code and uses modern logging practices. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..c4f58106b3bd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2084,8 +2084,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) len =3D sec_ie[1] + 2; len =3D (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX; =20 - for (i =3D 0; i < len; i++) - p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]); + p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie); =20 p +=3D scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")"); =20 --=20 2.52.0 From nobody Sun Feb 8 08:27:37 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DFF28DF2D for ; Thu, 29 Jan 2026 13:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693065; cv=none; b=tIFdC7KHqie3teXLQV4HIgdA3scZY71njFHhehBDPgkNL+R9pAB9c+YuVlwrFmmmLjNnF18fjs+sVDfH2baqEOXhut7sytZSQvRlt0fzyHl2LmM4ZqCDhb0knwoP/GLib7clAf2wITvh2V++lqfKfOeirl7Om5ZBar803c5hgmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693065; c=relaxed/simple; bh=CoBTJI+JJqaoappzWQvcsHD6mJ/LATRC5Pew2Bil0ms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kUIkZzN9wpBziFnn3RSyvZF87om3ew3IM/UKv4bBd1We9Jhso+UEqEq5IZIEerUQ3t5/NJ9Ye/BAA4ua3GC94mlKJC7A4pTN7nYCcr5YVnq0I9gA3tIOpEYbQutthp2j59PUdmClf4xlfRbzMVPWsNFFb5prxi0NucvdA32wC3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KadrIsFj; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KadrIsFj" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4806bf39419so13180015e9.1 for ; Thu, 29 Jan 2026 05:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693061; x=1770297861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MEq21BVwFHS5FNpeSTGjaMWvoud1JJRBiNNr3IFX3lE=; b=KadrIsFjZR74lDHe1H1YDXqsuorjqjInTkRgkpmay105Fb49oZRQTR+O+qHqZ6N2HT WBknZ6sc0zdDfbEFcboXcbMK/eBrJp0FvfBqsJSicxl2pAs09kEvkWnLEIkL5nVe0UJG yGhQ0+dSTygV4J+pyFurz5ugB2ZS3ZCrMB+2sSpYQf63ZTv1O1vktPZ/I4RR24iqtJ20 PjCQYyuJT3bQ5yVPUQZMVdw4hNdE3rjwzgPLNirZwqWnqpAio8qvUhww3YtHB6EQJJNN P5bGYczp9ir/h+mL3PgWzYabW8O0O7eMBjivRbzRkeq+3jj8C2vEakbsGt6DXg2S+clW XAJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693061; x=1770297861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MEq21BVwFHS5FNpeSTGjaMWvoud1JJRBiNNr3IFX3lE=; b=Q+54f1jcCslsgepeJJ0tE3Dn65yFBNQPp1JDRvTg4lQMt14Dob01K/rc+U4P0rkdsa SZw3aKLwfERhmGv0yw0hYSfIr8H6KvWBW2q+b4JBWj6DdPmRDBUaXz0vJp9VKRBsXZRE fubxSNNaRodxr4lLsGhkss1MLHPyxyIyxVMClX0nz/gu6RgaKmaZKHu+MyZaSg+dgpl3 eYq0A/Xoz63nsahVCMHB5hdKqKrEIibWCKnbkCI1zZKtUFFTIf9n3ByQNXZUPTUomGI1 ouTCaVF7BTHDaGdZ9apRGY6Q22YP+C5S4/Y6w9EUfJKyLpDJWrlpzabXFzJf0CJvWkHV JI1g== X-Forwarded-Encrypted: i=1; AJvYcCXXV/21OlxtHV/0B7SWyFla6RylKn37kQtPbFjZ9K5T9tghA52qpFx4ZxBL5QkRR5Zv/PbVudL+TECxhIs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcOLfhl+GAlpUCTesuWGSspWpqvrfFgBEWZPzuQetBCSzF3i8I TCqEU46FZu2NqiTlmM5TciS5ClD2jRl8YddtT5dx8F0udKkulkEvyzY= X-Gm-Gg: AZuq6aJY7qnXm+2CvpqWP/X43e3c6k8jJbrwmxvrOLXz8hWxYCmgCtxt7LJD87LIAgd +S83YWAenO9CuAl1u7ELxlGGriO0AcvvUL79GQk9mJHGkN/e2Q7Oz02EwRE43Vota2H7/EI50l0 DM8rr5UsHE8ZA83QWfhcp6W9M4Rv0+KcnAzepzQKnCN9y3CxaXxMO9jjrnDJw5Obpej0y1qaPR9 pJ0KS7PjB3eAFdXcJZttuohfuWzTqdSqSq8GWuHNHBfkAW36YWwJLi6h80yF5gGCfmlyHJXbMSw 4aJmToW3bEF+TvO+lvEugqqxufW5cz8WWv2/b0np+gCOr0pvoVuTJ+z6uzS1i/ijSkq6/AUjl+t Nge88h/Tc7zFXXTfclG9UXpJ6kUocnqMoIDjYeCQuy5nt+Ouv90m4Vixb46rwI7TsgIFHZoXjtF mw X-Received: by 2002:a05:600c:1910:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-480829b1c19mr42090625e9.13.1769693061388; Thu, 29 Jan 2026 05:24:21 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:20 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 4/5] staging: rtl8723bs: fix out-of-bounds check in rtw_restruct_wmm_ie Date: Thu, 29 Jan 2026 14:23:51 +0100 Message-ID: <20260129132352.14615-5-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a length check before accessing the OUI in WMM IE to prevent potential out-of-bounds reads. Use memcmp() for better readability. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index c4f58106b3bd..18a70879f78f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2000,7 +2000,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (i + 5 < in_len && in_ie[i] =3D=3D 0xDD && + !memcmp(&in_ie[i + 2], "\x00\x50\xf2\x02", 4)) { for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; --=20 2.52.0 From nobody Sun Feb 8 08:27:37 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CDE727816C for ; Thu, 29 Jan 2026 13:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693066; cv=none; b=dK3rC1gmv7oV6DKGAhOSnKpcTw0Ss1oaZW/T1JsPehysJBeHl729T3HtJeszwT54XruwJTefG7FJX2H9/gcJ0glXrQjCd+bwcgy84jHEPgeUz9iPgjhdp9Rx5GP9gsmNFztjdvzEdUgoYYGknV1yeN5RcsJVkleNM2YjfbyZSXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693066; c=relaxed/simple; bh=bUeyerzNTibRKm7wU0xU1y09XX+nLkg2/OqCGqcSZ+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t9E8UV9+jzULrIvczT76bTAuZ1kpHPKsB8WxeHQvCefi08tFW2xEsFuyWX0g6T1ZRHRD4BCkaASDW0yI1WulXtrsqHk+9A330n3xwbalsp0vHzhcVZFEELNLnydSpw53tPEeZl+l48t9dbaKSy8hf6+La65Dqh4dzfTW4ArFfb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZK4t7hny; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZK4t7hny" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso10013275e9.2 for ; Thu, 29 Jan 2026 05:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769693063; x=1770297863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=ZK4t7hny0WfD2n8qzq35jLg1vqxaZIDlyVZyxq0Xro6vxG0P3bICPAgS1qpXKGZE8l hCxCGMegSEEIFrJPynbayfU4NUcR7lNuKfPlQWL2tV7QHt2G+qakMy/JwuDkev7rsswp 9bjIo+WQ/Hmms8PH0g20hi8iY+8Wd6wWOPiNa2z7G4DLQwMfODmqMGlIu752XjM5iCex wTGSV5UDjy1jQMwLZBg6pRWLkEerzCXlSYH+HgNMnQnRUJ1l5EKPBCSk+8Qm+WXsQ7xL CccJCKx5T+YwsTZ4ovl/YDqfnPmYThkAq4hoLpXPwYivVoIIiAxt3J7b+QbfAgBuamen wrhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769693063; x=1770297863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JbtbqJ7f8/zNbFuNHfOJLh3NY0SZ40/NTWDq64DfleQ=; b=Ir/cTY677Pe18stUuFq82s7hPbFyL3PZvrauRn0kDsYru19zu1Bag3BdHqgKWjjPJJ jE2r8GUBcnD1e1qTZQem4Dopp1kXv9Mrv3XfQ4ABkEdnmSJVVNAvjYMcAdrQI0w48jCl 4B5Aus/XO1X2ba2NZsmg65Biv8FMq09cI5oNQjQXpjvRRcYLViNGZVYFWUl/PgSAuVid 8DEH7BtV8LP3O2XyKE/tb6kmFhrq5g5aLGHV2yIiiIcZtiwmhmQnE8cuquFy3+bWj1t3 ANug+eVC4/rK5EBXZlF3YTIHJlcAPOpDsEVYyfofklnNoR3hTLaoIDZ0EOuAOsiZqilo o1OQ== X-Forwarded-Encrypted: i=1; AJvYcCW3YxmFZgf9LOqApxvZbo+LghaX/iUvzSEZM+VuKuJA0mFuhZ1v+SsINoOHLCq11+9XVURQyQK/qsPpGUs=@vger.kernel.org X-Gm-Message-State: AOJu0YzsYAILDlleQ/JEG3EPhrf+QskT72ciZD+bcy5XVr2oB4E7/UZa /F4l8JsvhQuararefkdLBVsRculzX6yZoCuhFl3KmpDYpA5Zc828pYM= X-Gm-Gg: AZuq6aI6CsxDmx9qyex22L51DAAN2lc7HNQs7/JP9KgEvBqKKlnaQ1AunvOZWsTG9gp XlDJwh0VDt4Ad88Xx6YE57bxoPSUH7BOmL0oplZPEjkRmNLGmMS9CLF8m2VQME7Z7Y3SNrCnCb/ wKues+Sit+O4qfqzh/cnKIb3EMRlw8IF/+umIxrJ/5qRv7mjGSVxX2xflSv/WNpDN2YwX3yF6C0 UmeMksWmaE/zPNeI0ZOVcnpy0augburAwNr2FFZrgpSHQVl0fpViHA2oT1bjSWS/Mmu917zLoSY p6lvRGDru03sAhBCZ0rSTdrAvMChgT1voupeoAXbQmTCkzC/K5g5cv09tDUFSh3Y/OpaVsUNQ0X X8TXcF9v109r98Yp928gCufhbT9BtoVidWYE4lJ87V/KFe89InTnoIffJqfzN/ZqVkYBUQ3KnL0 rh0EbzoJVVgC4= X-Received: by 2002:a05:600c:190c:b0:480:4a4f:c36f with SMTP id 5b1f17b1804b1-48069c4869bmr116635555e9.21.1769693062695; Thu, 29 Jan 2026 05:24:22 -0800 (PST) Received: from LGPC ([31.223.131.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7404sm217492315e9.1.2026.01.29.05.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:24:22 -0800 (PST) From: Luka Gejak To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 5/5] staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c Date: Thu, 29 Jan 2026 14:23:52 +0100 Message-ID: <20260129132352.14615-6-lukagejak5@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129132352.14615-1-lukagejak5@gmail.com> References: <20260129132352.14615-1-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the unused local variable 'pattrib' and the unreachable 'if (0)' debug block in OnAction_sa_query to clean up the driver code. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..b61841bf16a5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, un= ion recv_frame *precv_frame unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame = *precv_frame) { u8 *pframe =3D precv_frame->u.hdr.rx_data; - struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 @@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padap= ter, union recv_frame *precv default: break; } - if (0) { - int pp; - - netdev_dbg(padapter->pnetdev, "pattrib->pktlen =3D %d =3D>", pattrib->pk= t_len); - for (pp =3D 0; pp < pattrib->pkt_len; pp++) - pr_cont(" %02x ", pframe[pp]); - pr_cont("\n"); - } =20 return _SUCCESS; } --=20 2.52.0