From nobody Sat Feb 7 20:40:30 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA6F633FE18 for ; Thu, 29 Jan 2026 10:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769681258; cv=none; b=F3jAyS422FKTX5EhaI9qjlsvTi4/i1MnY2DCAfH+zJXSNLdXPidKlWJDEYfI0jnMIu5GYNtIusfTJxHxCaQ78EoWhtJlvoLYNU8SdPs8zcbLZgdNByZmhWwXVwE34AuwPphLin23Eex7rJEH33kD93BDiGZGZrRLnos2jMi6J0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769681258; c=relaxed/simple; bh=rfxEsYInWia8qH8FnA11YtoY9QEMMmR9k7ERn4DjfXU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jSKobEuGBLOj+1McDPSnNG70NZQ5g0fEe3DpyQJeW5RYtRr2ERPhhXaxu8ChbrGmmKMsJLQ0caIjp6+5ErsgldATyNePfk2n+sZaXWaCZZtG7OPC5RkTHZ66n1PP4FtFiv7ascX3QAf/7RKzAK88HceZ4PsmM4vwNqrmYK8vYdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fDjfDtwW; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fDjfDtwW" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-81e8a9d521dso450517b3a.2 for ; Thu, 29 Jan 2026 02:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769681257; x=1770286057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Sz2uU6hd9uouWC2Fb9WCzlVE7j6msZQUQaAAumPyPyI=; b=fDjfDtwWw/0vPUWnbE4SC0f+/wqgPaIdyCb8/HMtkgCEaDslKOgBr6pDpxNQ6LSZHJ q3cywnzkfWQ2fX9ph1PYnt7XejlmRfEzAIocUUdecG0TXnW3UC3Qvv9EfRNqTQLhoNyr eGeheLuim8VgYYpQK38EgtCLF7TaiSyTJipU/QLkdKmE44WYD2WEAQ0DSoa6PRZtUuzV ryufs3xQ+JJqQvInUOSSpOUNL7CDxGhsduuYmruokPzqixxgOFwxDeOF+pg7++8Fe7iN dco4Krd7SImRvfHH4OX53BoqSXEE3eoxZS9jO+eN3ah0TzPePzXRcZabBRvicpNZKJMU w9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769681257; x=1770286057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sz2uU6hd9uouWC2Fb9WCzlVE7j6msZQUQaAAumPyPyI=; b=abHr5fEkjFIbcKyhnE8ppORtLwQFDbhDMdH61jM5GRxnougvNL/b9zS5xlkAMdSmYr FIQW/C9pKwaPXlnfAR92T7oHH0zby6VxLcLJ5pC1RtT1qJ4FIsiDqzzK0aZoczD42Qjw N22Be9+AjlqZAjk0giL3WvXaw5OLXeqa7kzAm8RhZvx5D+w8BobY2+24UBSYpKJZ83lk KYPFzMPyNKZgCzVppq3U+n326YUqFi64mDsHZxUwYJ/tXNXeTIc5XqzkR/Rp0LlR3AFM /ZX/e6/jEz6efQJzgajRg1W8OnXVDuhMwqkiFiEiAXiiz2fXfCkssDIr+TV008/1A/uc JK0w== X-Forwarded-Encrypted: i=1; AJvYcCW5uuGmuVv3URgwqtX6Wyw3VJ7vPKuKsk6rKdRcSvnwPOSiysU/P0zVflPq08NuGgNMu0DgdaOlz+BgTUc=@vger.kernel.org X-Gm-Message-State: AOJu0YzrkdiO/PHcZ4b9Xxq+GONitAC81cKfD7gHOqFSbdMbxc7CXJYp g6fZG7UcSJWaipcLkAzUPMy9/00hE2JcVzEQFW67yxDpbMT4tYFu6VGL X-Gm-Gg: AZuq6aKYkQwAnKRhMFRt0/9nH/NR1G1HLafbzPEkaolnz+oXy8S6zSpHgc3FucKsSDQ ufjA/MJlcdgN25ByEvYXifQ9p+W130p+Dx2eWQVnfFe3SHgBe5vsT4L4o60Mi/oUA/C4meCyJF2 WdKhFYuPfABBqQ54AKL98hgs+BfZTxumHbhBcPj4NnGf9vrPeGk+1wuM3sMjVjs+LdNmfrHPPfT VEIfr1xwWwVgjHlOgb/jpWqIfAmIyjqZDXv7BgbNl0J3aRpMaWJp3aM2aTatPgBIVnVpdG9P3if 5yPPjynkNv2s5fdpvEFHVPR2XfBG8Df8m7PcAZpCOOLtfgHsy+9NPCj00C4pAc6hKjlUTsuDRDG szCPNHrkAllUKZ3rkEu5UExDwmFGWXEEwMoqpVhIDwPt1WTDZP0BVCfcLPBSub2mR28iQFsAL3f B6VTHnXrdDgo4zf28JFA== X-Received: by 2002:a05:6a00:418c:b0:81e:f623:ba04 with SMTP id d2e1a72fcca58-82369148d2dmr7497094b3a.13.1769681256847; Thu, 29 Jan 2026 02:07:36 -0800 (PST) Received: from localhost ([2404:7ac0:6ed1:1f5d:ea62:4a2b:e100:6492]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfcaadsm5375349b3a.37.2026.01.29.02.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 02:07:36 -0800 (PST) From: zishun yi To: Min Ma , Lizhi Hou , Oded Gabbay Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zishun Yi Subject: [PATCH] accel/amdxdna: Fix memory leak in amdxdna_ubuf_map Date: Thu, 29 Jan 2026 18:07:31 +0800 Message-ID: <20260129100731.56116-1-zishun.yi.dev@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zishun Yi The amdxdna_ubuf_map() function allocates memory for sg and internal sg table structures, but it fails to free them if subsequent operations (sg_alloc_table_from_pages or dma_map_sgtable) fail. Signed-off-by: Zishun Yi --- drivers/accel/amdxdna/amdxdna_ubuf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/accel/amdxdna/amdxdna_ubuf.c b/drivers/accel/amdxdna/a= mdxdna_ubuf.c index 077b2261cf2a..9e3b3b055caa 100644 --- a/drivers/accel/amdxdna/amdxdna_ubuf.c +++ b/drivers/accel/amdxdna/amdxdna_ubuf.c @@ -34,15 +34,21 @@ static struct sg_table *amdxdna_ubuf_map(struct dma_buf= _attachment *attach, ret =3D sg_alloc_table_from_pages(sg, ubuf->pages, ubuf->nr_pages, 0, ubuf->nr_pages << PAGE_SHIFT, GFP_KERNEL); if (ret) - return ERR_PTR(ret); + goto err_free_sg; =20 if (ubuf->flags & AMDXDNA_UBUF_FLAG_MAP_DMA) { ret =3D dma_map_sgtable(attach->dev, sg, direction, 0); if (ret) - return ERR_PTR(ret); + goto err_free_table; } =20 return sg; + +err_free_table: + sg_free_table(sg); +err_free_sg: + kfree(sg); + return ERR_PTR(ret); } =20 static void amdxdna_ubuf_unmap(struct dma_buf_attachment *attach, --=20 2.51.2