From nobody Sun Feb 8 23:24:50 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA0937B3F6 for ; Thu, 29 Jan 2026 08:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769676805; cv=none; b=e12RyOf3yyhFBwJ6XjhS3+XMqVv5abe3kwIkbm3I6pLSnfcpFUYlkc4N4Qum0pfAsZYLZNDz9xBoBTSWPvqRRp6eo/tYhp7othIFUHNkiAM7oS9ri9FIHJiSF5v0Fibi4F+BiyOMMT4KkvV+YqdXTjUwyfB17vYznxtZ0Ix7fjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769676805; c=relaxed/simple; bh=9cHg4yudx0KYot1AXmxgLTYZE6CP3WU8JWGdgL+x0d8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SPZFL7BuNvHuaiMzD5UvuQ5gSpAhZQuH48ouDPyr9BN/OJJN8Uc5beA1dm0mSAma99+/d/mcYVfyCMDHYM2T3Op5yWMsHKAAo2l2eRjO74c+voRBnKflIRpvw79+xdL9S0QfUCsZlboMisZKU6uXKXsftphJkQRrjtilGQeU4r4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BUGOxAHo; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BUGOxAHo" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a7a94c6d4fso3560215ad.0 for ; Thu, 29 Jan 2026 00:53:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769676801; x=1770281601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2XpMMUS1e/vYJVAQpO8ah+VrCXSORaptOSTTscCu+vs=; b=BUGOxAHohipQgMilGogatL46TtzHHjTj/p0uyXylRdsUN0ybP9m12vC9hp4UVPb8md Ezxjj/viH4Oq6R+Jw6ClxCHJvy7SZmGNjSNsfBwjB+HzV5JxKEzGjbafbQjNAsts7hu9 dxMd7WcMMdjRex4lstMA4RYFCKOGZySu5BI9XERjkgIUDU9bXyuGELLQUyncmg4X1AKI LSX0SnxOyf9hcs+TPOtKY1aEfyL3bUMb9tWrtq/V629eFYoygu1QiJm5sCwgfkKW0ui1 VihMncM0/W1EatZ7jyYMC87p3GIiVD/12TBW/76hVeq46Pr7eF9WsHumy3Ygo7LVTOou BlgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769676801; x=1770281601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2XpMMUS1e/vYJVAQpO8ah+VrCXSORaptOSTTscCu+vs=; b=EQ4soWMoMjbrdVrUdEU178bfzfCQMAj5zSc+/8o+51FwAzWt5NoFOVKMVOeC58bVEE oyJArvv04ERLtTv+TjAzLhWz1tY2ghH3vP5EZ/LDO6TRvAG6pEdC97HxgfzD9VpG1br3 35pVGUMaM8kq4Iuudr+4y3rqP8mXI3Zjg6oLmS73mbQziTXztC1jfLim8T+b77R6fR5R OSdzLKH8Aw+OwPzfmVUGJJL9GnV9KEUoRuss6hy3OTrXKQUrI1VgSu6VODFPIY0cTWNd w1P+E7MtMYvtQ+LW9vyk7VH729AWyxXiYnQXDVCAWfRVqcUrzhnMv3OE0dVa4Jyhc8iM uY9A== X-Forwarded-Encrypted: i=1; AJvYcCXSUJdz15K9OmNguKQMC828udK7SgK+N7+Yxk44UaULlTYYgbEWnM57FgXacm0T6pU4jrPDKZvP+tCKUBQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7bAJKxVzOAt6l8gRaphvzxh/y1fgbirL5O2337EMJ2pBkyLiZ F+BHTQXV1dSvEE02GHahlYvlaIaEK4LF/8A+TFZ4znFqzvr1+eiEgMZPND6BVIwPGjg= X-Gm-Gg: AZuq6aIFAdG8PI5x6HYUTldd0PlK84T3m9xT4NU6TM6BmvfQ+DHf9DePGhwZx7N5pwn enVmR1qmjJ0FMNh0Y12N6kuGYZ2Iu+0U8AgciY4YkSrRR9G4qcVGf1eyR0JIRt5h5aM5dLOh4T1 fEnywrrTkYZSJ8oTkM3rTIgHwrwkQulgqJYwiSDqofH/E6WIij9GxaKTJQz0LccOEflGKRK6rAx Ph5lXi6UIJyiArYPYG4F9KwsXQumYdhfGQNIgVtKxpI6Jd41uVKFmNrSCzJCsruqwtdpEP96WG7 cw5iPkVKKMnY4KYW0OxOSUVXi8Dabs3CxyztgrOLPuWVnnI9TDdH0Qm4V22KeqP9+jVSO1Jgv/r llotUB76GOmNDgcNw060zDpEOoAn+H26xaBxfze56N9RNPRtvAYB59bIUhz1cHvsGvSynycGbXr JexJQFD5F87ryHUd5hL1Is0sTgYPijTGC16vg= X-Received: by 2002:a17:902:cf0d:b0:2a7:919c:34c6 with SMTP id d9443c01a7336-2a870ddea27mr77364185ad.38.1769676801431; Thu, 29 Jan 2026 00:53:21 -0800 (PST) Received: from d.home.mmyangfl.tk ([2a09:bac1:7680:d30::4:384]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3eef50sm44651165ad.12.2026.01.29.00.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 00:53:21 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [RFC net-next 1/4] net: dsa: yt921x: Refactor port error message Date: Thu, 29 Jan 2026 16:51:33 +0800 Message-ID: <20260129085139.2767649-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260129085139.2767649-1-mmyangfl@gmail.com> References: <20260129085139.2767649-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sometimes we might get error codes from the underlying bus but the return type of the method is void, so an error message is desired. There're many instances of the same pattern, refactor it. Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 112c2a237d9c..1b66b07f45b2 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -185,6 +185,9 @@ struct yt921x_reg_mdio { #define to_yt921x_priv(_ds) container_of_const(_ds, struct yt921x_priv, ds) #define to_device(priv) ((priv)->ds.dev) =20 +#define print_port_err(dev, port, res, action) dev_err( \ + (dev), "Failed to %s port %d: %i\n", (action), (port), (res)) + static int yt921x_reg_read(struct yt921x_priv *priv, u32 reg, u32 *valp) { WARN_ON(!mutex_is_locked(&priv->reg_lock)); @@ -720,8 +723,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, in= t port) mib->tx_jumbo; =20 if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", - port, res); + print_port_err(dev, port, res, "read stats for"); return res; } =20 @@ -1101,8 +1103,7 @@ yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int= port, mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "unmirror", - port, res); + print_port_err(dev, port, res, "unmirror"); } =20 static int @@ -1689,8 +1690,7 @@ static void yt921x_dsa_port_fast_age(struct dsa_switc= h *ds, int port) mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "clear FDB for", - port, res); + print_port_err(dev, port, res, "clear FDB for"); } =20 static int @@ -2265,8 +2265,7 @@ yt921x_dsa_port_bridge_leave(struct dsa_switch *ds, i= nt port, mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "unbridge", - port, res); + print_port_err(dev, port, res, "unbridge"); } =20 static int @@ -2398,8 +2397,7 @@ yt921x_dsa_port_stp_state_set(struct dsa_switch *ds, = int port, u8 state) mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dev, "Failed to %s port %d: %i\n", "set STP state for", - port, res); + print_port_err(dev, port, res, "set STP state for"); } =20 static int __maybe_unused @@ -2737,8 +2735,7 @@ yt921x_phylink_mac_link_down(struct phylink_config *c= onfig, unsigned int mode, mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dp->ds->dev, "Failed to %s port %d: %i\n", "bring down", - port, res); + print_port_err(dp->ds->dev, port, res, "bring down"); } =20 static void @@ -2758,8 +2755,7 @@ yt921x_phylink_mac_link_up(struct phylink_config *con= fig, mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dp->ds->dev, "Failed to %s port %d: %i\n", "bring up", - port, res); + print_port_err(dp->ds->dev, port, res, "bring up"); =20 schedule_delayed_work(&priv->ports[port].mib_read, 0); } @@ -2778,8 +2774,7 @@ yt921x_phylink_mac_config(struct phylink_config *conf= ig, unsigned int mode, mutex_unlock(&priv->reg_lock); =20 if (res) - dev_err(dp->ds->dev, "Failed to %s port %d: %i\n", "config", - port, res); + print_port_err(dp->ds->dev, port, res, "config"); } =20 static void --=20 2.51.0