From nobody Mon Feb 9 19:25:55 2026 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620C1372B3D for ; Thu, 29 Jan 2026 08:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769674737; cv=none; b=p1sjf+Jo25j9ZWjsUacnUbK333zXOPM6YIlwIdSC+mKq8hB2ct4Jgn+GM2EvWQCLZ9XF96MzAAIsr0WbHmcu7fWy+JscV5nI6upCnf8asVG5sFNmUhuxquFmFysc6ttsndCHk+qGKPE2LAx5wKWVrQMV22kqFU25uLCl5yjT5fQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769674737; c=relaxed/simple; bh=yQMWxOQ7To8SqJpkDZDwLnRGe4qHkGxdoilEnftC3Po=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HUCn9OGYsYJMYcMhkPJxrPLguGGP+DM8qWE22BTQ3KeNSBXsaC4+N8kRYKwsvXGed5TpH0NTZwbt0sSPNLUjIAQzZlz4XpB7l862kkycE2rzcQ3uCuvktHxX1hMJOjz9b8dIZ1F3E6Oi1HXeje4aYyQFjaWrHpIaPFtbWIv8zw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lZGEqU+E; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZGEqU+E" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2b6fd5bec41so1509487eec.1 for ; Thu, 29 Jan 2026 00:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769674735; x=1770279535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=q14ebJgYOBwi4oXp2H6aUXb34czVGi/YpKLXXPgCXl0=; b=lZGEqU+EpMijB5ztHUWucWTfWblCOHKDx1XR8U951t9p78rPD/AzH9qUJ2WuHcdFF/ 5KVdCxH1nIWXINXGh2KoJuqXSqLyu/hokYWD3kilCtA7KvNEoo61ALn4iqe1HfBstsH/ F9J7nB3c1ZzblWIb9EAooLDggLJUD71nUSgR41JJ82QASLbsDkpi76ymRq1jq2zCpct/ iIYVo6cNRpvfCSdXP940wQwnS85pViMgOvZSKt/mUCZ/0DGDwPzGUs05521UOMY5X2Cp 3NbykRSUxe4SA5GcIPwVJBzvDO3flx+So7iEDBuyMVBR9PgygQMiRjxt3yQbwIlGjUCI xO/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769674735; x=1770279535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q14ebJgYOBwi4oXp2H6aUXb34czVGi/YpKLXXPgCXl0=; b=vq2DMYOsiNl8Xoj8E3zMtdgbSO41/Xfu1TOH0kLopRZofm7ftgKklhoKqivvc7oOfe 5itbhBRQQhRb4eK6loxg/3pra+iOLUNem67xr46zkJAtsBQwIfL8MFGaSLNkHYpDUmdL k1XdEHvK0DjojeyottE/pM613xlKt2hjPWXGRkwk6JHP5CgHCDC/gnLANDuxPanEviRQ maNFod0Q+cgKWPekMsnBrgNr93i0md2rFzyyHqj4LBiIu0ky+DktnSx2qSjvPtGfwAZQ RCxp9fK8wHeD6l6cAd2wJn2H4eVeXr0Kbzl+VEfn7GyFB9y3m4wel4Rc73djgbbL40CD QRog== X-Forwarded-Encrypted: i=1; AJvYcCWPHOgzaFtxf2dP71tw4jx+jk3M+VVqHKplLScrgHvPF+UPd3KJdX27Di8aWxwOazbrbd2aJEk4jPznkrU=@vger.kernel.org X-Gm-Message-State: AOJu0YxZxfStZHRTuZw/al1eMpxBFGnbSbgnph5L1ygpGoDfY0pTShU+ sP3LXXGZ2+T7y0sn2qsiHMBS/AuRsyLwnubDTu/mD3yTD7jCojh5Wh1A X-Gm-Gg: AZuq6aL0rkPsfMT9LpWK/BgoENlO2GBWfp/4dT8Rcl3WFYLCowduBvli+6iAXD4kUOG Yvb/0tNVCSw/JMP7sXtcyYG1UjFPxzrAguCByxwPIak2r5o3Pxcnt0pJaE9zzFV1GOQXwMy8t16 QDl5BlIcVFUIVjqXfAl3FWds5u7U4KdoGvWOxsK/+D9/zaRd/5vDaEVOSYpd+pFeTl+maZXOwWp Faea4z5lqLPu9LnOV/bfPEwr6U5j3VseDg5WoFjKvPpXdZo6CCjZfgoPyQbECGhfAIND8vK1O63 oJ3hBPCYKW6q8vH8UF4pHS+EHm9ON2ZtoYG0Y5LptQqrSvwBLGpB9vrsrm4cECRJ3fDARukH5h6 RjwgM5CQNsY4LpRDU91TqlUiXWBITqasQeyPS/PbDgNyWq+wWStj6lzgpEKJy5E6HlqWowZJ4LE jOmpICvn+xtFuBye035FcCFBXO6S86JKWJccW4OoOoM9zp0m1htmMbnBQsQPx5 X-Received: by 2002:a05:7300:7307:b0:2b0:5012:734a with SMTP id 5a478bee46e88-2b78d9f0bc0mr4601976eec.34.1769674735088; Thu, 29 Jan 2026 00:18:55 -0800 (PST) Received: from zcache.home.zacbowling.com ([2001:5a8:60d:bc9:f31e:1cb:296a:cc2a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9efb4casm5483508c88.16.2026.01.29.00.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 00:18:54 -0800 (PST) Sender: Zac Bowling From: Zac To: nbd@nbd.name Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, linux@frame.work, lorenzo@kernel.org, ryder.lee@mediatek.com, sean.wang@kernel.org, sean.wang@mediatek.com, zac@zacbowling.com, zbowling@gmail.com Subject: [PATCH v7 6/6] wifi: mt76: mt7925: fix MLO ROC setup error handling Date: Thu, 29 Jan 2026 00:18:39 -0800 Message-ID: <20260129081839.179709-7-zac@zacbowling.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129081839.179709-1-zac@zacbowling.com> References: <20260129081839.179709-1-zac@zacbowling.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace noisy WARN_ON_ONCE checks with silent returns in mt7925_mcu_set_mlo_roc(). During MLO setup, links may not be fully configured when ROC is requested. The WARN_ON_ONCE statements were triggering unnecessary kernel warnings during normal operation. Changes: - Replace WARN_ON_ONCE(!link_conf) with silent if (!link_conf) - Replace WARN_ON_ONCE(!links[i].chan) with silent check - Add explicit mconf NULL check before use - Use -ENOLINK error code to indicate link not ready - Replace continue with return to fail fast on invalid links The -ENOLINK error code properly indicates that the link is not yet ready for ROC, allowing upper layers to retry later without generating spurious kernel warnings. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 device") Signed-off-by: Zac Bowling --- .../net/wireless/mediatek/mt76/mt7925/mcu.c | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/= wireless/mediatek/mt76/mt7925/mcu.c index 2ed4af282120..5ca2106b1ce0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c @@ -1341,15 +1341,23 @@ int mt7925_mcu_set_mlo_roc(struct mt792x_phy *phy, = struct mt792x_bss_conf *mconf for (i =3D 0; i < ARRAY_SIZE(links); i++) { links[i].id =3D i ? __ffs(~BIT(mconf->link_id) & sel_links) : mconf->link_id; + link_conf =3D mt792x_vif_to_bss_conf(vif, links[i].id); - if (WARN_ON_ONCE(!link_conf)) - return -EPERM; + if (!link_conf) + return -ENOLINK; =20 links[i].chan =3D link_conf->chanreq.oper.chan; - if (WARN_ON_ONCE(!links[i].chan)) - return -EPERM; + if (!links[i].chan) + /* Channel not configured yet - this can happen during + * MLO AP setup when links are being added sequentially. + * Return -ENOLINK to indicate link not ready. + */ + return -ENOLINK; =20 links[i].mconf =3D mt792x_vif_to_link(mvif, links[i].id); + if (!links[i].mconf) + return -ENOLINK; + links[i].tag =3D links[i].id =3D=3D mconf->link_id ? UNI_ROC_ACQUIRE : UNI_ROC_SUB_LINK; =20 @@ -1364,8 +1372,8 @@ int mt7925_mcu_set_mlo_roc(struct mt792x_phy *phy, st= ruct mt792x_bss_conf *mconf type =3D MT7925_ROC_REQ_JOIN; =20 for (i =3D 0; i < ARRAY_SIZE(links) && i < hweight16(vif->active_links); = i++) { - if (WARN_ON_ONCE(!links[i].mconf || !links[i].chan)) - continue; + if (!links[i].mconf || !links[i].chan) + return -ENOLINK; =20 chan =3D links[i].chan; center_ch =3D ieee80211_frequency_to_channel(chan->center_freq); --=20 2.52.0