From nobody Mon Feb 9 05:58:21 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6FBC3382F8 for ; Thu, 29 Jan 2026 01:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769649400; cv=none; b=pCTRzXba3jiU5E2nVWpgK4J4r2wu3T9r1lLgO7BsQo6UM0l5+X4Vl7GD4P+acVmuacZvLxV9HQs96a5BIQo6vSCazTMV1NsSxg3VNnGF6iRYbujdzWsT4KvNgkuniGSBMwa54KK5RnrlMs5xVeo59c0tLuF7ERa4c4zaUnMIlms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769649400; c=relaxed/simple; bh=Oi162mi6i9IEnnNv6uPixUH7Wd19+um7eCx9W0j7qNY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SZueBgN+FwjzqYHAbefe9PWoQGLQYAAdkqTherYmtYCfNNDFIVL/cQcGtY3wZF6D9gMhCYOTCLTuOaNJhdhBFxjNYO5WRW9FQJr/WDjCugErkZx3yI+trpaIchk7lB72yZU9XZNuVkp4T7RTLZKwmkFPM6A8ETIVJiYcGmUBahI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aWY5uYcR; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aWY5uYcR" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-34abd303b4aso805084a91.1 for ; Wed, 28 Jan 2026 17:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769649398; x=1770254198; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=f+prWW7rpbp1pSxf9bX6axWwAfKRzuFR7Mjnf0TwcpA=; b=aWY5uYcRhVR3rIc/WIhWu0xOEymyFTOdwGCZ0tWTYWKkEp+lkvlMNHNtgGDv5hfbEw Lt4vEmZMxuA3b50Ovz+LEGJvCJValJtophtoG4HkV4lLcg9UOAqVzM45+xSJKxlGac62 1wWrr+/4vC+SZa2A9H2pA6IaUCb7x/VtqgIgJbdGRoewZ+2/VkId1peSmtVW5tAigDsb Fn/Vaa/WcAfjorIaFJcpyONedWVGM35o4w0G8faE30hc0YjajhQo/JCJO5MG+CA0HAbK qKVCz/aVYbFb89NiqmyzJiBubg23KqRtAjS9TrHfoDtDFBXvaviuyIDEa+gdlF2RAhSL Spzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769649398; x=1770254198; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f+prWW7rpbp1pSxf9bX6axWwAfKRzuFR7Mjnf0TwcpA=; b=G5IS+TZjdKAAzIypiAhEn7eRZvyl39c5H53uullM8MXvht2fFtbxvtIK/ll4LSdaDa zZ1DR0PNMS27ie/7uQQBfPWBu11LiYKicpL3DIS8KopVDrmHaj6glGL5QNlPDoHKseDL G8DYHESGJMseWWnL4CE9jIVz1c3b9x4LVH4vaQCeGvv0nIVmEXBoTfga3KV4LNYF2cje l8j9EyT/nLcETJu1urUhxCOqwn2X9yAWYxGJXHDcLW6WJv/ICxvDI3dNpANWPuH9f3Hx 2SBzgvdQBQOSZCaSvLit/zauz10YzPzIbl/r024wuh90/HSnYN0CQEkZZZHiVARij4Kc F7qw== X-Gm-Message-State: AOJu0Yxi0EcU3D+GCRHaHfBL9KlefVftvLBi7e2eli8CsgZ7/CnHoBz1 ARkN03/d5TmT5CEuutlQh3pk4KrbIStQ2pQxzW49ixIaHCumiY18QJVFiy4C1JD+usXX2L4pJ+j PXaZ6kg== X-Received: from pjbso3.prod.google.com ([2002:a17:90b:1f83:b0:33b:c211:1fa9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d603:b0:34e:7938:669c with SMTP id 98e67ed59e1d1-353feda725cmr6069000a91.25.1769649397968; Wed, 28 Jan 2026 17:16:37 -0800 (PST) Reply-To: Sean Christopherson Date: Wed, 28 Jan 2026 17:15:09 -0800 In-Reply-To: <20260129011517.3545883-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129011517.3545883-1-seanjc@google.com> X-Mailer: git-send-email 2.53.0.rc1.217.geba53bf80e-goog Message-ID: <20260129011517.3545883-38-seanjc@google.com> Subject: [RFC PATCH v5 37/45] KVM: x86/tdp_mmu: Alloc external_spt page for mirror page table splitting From: Sean Christopherson To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Sean Christopherson , Paolo Bonzini Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Kai Huang , Rick Edgecombe , Yan Zhao , Vishal Annapurve , Ackerley Tng , Sagi Shahar , Binbin Wu , Xiaoyao Li , Isaku Yamahata Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Isaku Yamahata Enhance tdp_mmu_alloc_sp_for_split() to allocate a page table page for the external page table for splitting the mirror page table. Signed-off-by: Isaku Yamahata Co-developed-by: Yan Zhao Signed-off-by: Yan Zhao [sean: use kvm_x86_ops.alloc_external_sp()] Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/tdp_mmu.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index 3b0da898824a..4f5b80f0ca03 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -1447,7 +1447,7 @@ bool kvm_tdp_mmu_wrprot_slot(struct kvm *kvm, return spte_set; } =20 -static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_split(void) +static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_split(struct tdp_iter *it= er) { struct kvm_mmu_page *sp; =20 @@ -1461,6 +1461,15 @@ static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_spl= it(void) return NULL; } =20 + if (is_mirror_sptep(iter->sptep)) { + sp->external_spt =3D (void *)kvm_x86_call(alloc_external_sp)(GFP_KERNEL_= ACCOUNT); + if (!sp->external_spt) { + free_page((unsigned long)sp->spt); + kmem_cache_free(mmu_page_header_cache, sp); + return NULL; + } + } + return sp; } =20 @@ -1540,7 +1549,7 @@ static int tdp_mmu_split_huge_pages_root(struct kvm *= kvm, else write_unlock(&kvm->mmu_lock); =20 - sp =3D tdp_mmu_alloc_sp_for_split(); + sp =3D tdp_mmu_alloc_sp_for_split(&iter); =20 if (shared) read_lock(&kvm->mmu_lock); --=20 2.53.0.rc1.217.geba53bf80e-goog