From nobody Mon Feb 9 20:14:18 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC12C3859CC for ; Thu, 29 Jan 2026 11:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769684521; cv=none; b=o9zYrCCFTMth0WWjlDIK5DHxGXMYLvlPcvcPux7kUIjkuFddggQSwUiwddH8MQmf0QA8SjqmHcPBurYPkmgheXIbInZfL4kyYcFP2dwyQ7vVqAIdt8mjzm014fUIsIkSl7VO26vm0FLpR95ZwY6RPi63tf0sI753wUe2MXohivY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769684521; c=relaxed/simple; bh=MCfkzr9F858y4zadZYVKuvqBAXRlw6hXZT3L1bGnZ0E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=g8pMjI4kY9p+lmlQ3ua4woRkFgLEwzkujncCihllGPmtBq91yy0J7792WR8RzW6e1KwesuCSzpJlkQB0pxfzLVJuRcLqLAAIe4ILCy++FE4+Av8VDQ09HV9q7M4TadaFY0JoO5dlBuu7pywUFuWPNOLrV+1QipobdIpsC8U3yWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.trumtrar.info) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vlPmf-0001fg-Mf; Thu, 29 Jan 2026 12:01:57 +0100 From: Steffen Trumtrar Date: Thu, 29 Jan 2026 12:01:44 +0100 Subject: [PATCH] leds: lp5860: detect and report fault state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-v6-19-topic-ti-lp5860-fault-v1-1-49c812dc06da@pengutronix.de> X-B4-Tracking: v=1; b=H4sIABc+e2kC/x3MQQqFIBAA0KvErBtQI8muEi3KZmogStQfH6K7J y3f5t2QKAol6KsbIl2S5DwKdF2B36ZjJZSlGIwyVmnj8LKoHeYziMcsuIe2swp5+u0ZfTcvmlv HvmEoQ4jE8v/2YXyeF5ogUCZtAAAA X-Change-ID: 20260129-v6-19-topic-ti-lp5860-fault-c8bd1f59fc3f To: Lee Jones , Pavel Machek Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Steffen Trumtrar X-Mailer: b4 0.14.3 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The lp5860 can detect shorts and open circuits. If an open (LOD) or short (LSD) is detected, the global bit in LP5860_FAULT_STATE is set. The channel that caused this can be read from the corresponding Dot_lsdX and Dot_lodX register and bit offset. The global bits can be cleared by writing 0xf to the LOD/LSD_clear register. Signed-off-by: Steffen Trumtrar --- Documentation/ABI/testing/sysfs-class-spi-lp5860 | 50 +++++++++ drivers/leds/rgb/leds-lp5860-core.c | 135 +++++++++++++++++++= ++++ include/linux/platform_data/leds-lp5860.h | 12 +- 3 files changed, 196 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-spi-lp5860 b/Documentati= on/ABI/testing/sysfs-class-spi-lp5860 index 80b22a9d66421..ded9eec855bd9 100644 --- a/Documentation/ABI/testing/sysfs-class-spi-lp5860 +++ b/Documentation/ABI/testing/sysfs-class-spi-lp5860 @@ -21,3 +21,53 @@ Contact: Steffen Trumtrar Description: Contains and sets the global brightness for the R color group. Can be adjusted in 128 steps from 0% to 100% of the maximum brightness. + +What: /sys/class/spi_master/spi/spi./fault_state +Date: January 2026 +KernelVersion: 6.19 +Contact: Steffen Trumtrar +Description: + Contains and sets the global fault state: + + * 3: Open and short detected + * 2: Open detected + * 1: Short detected + + Can be cleared by writing the corresponding value back to fault_state. + + Example usage:: + + ## Read + # cat /sys/class/spi_master/spi/spi./fault_state + 2 + + ## Write + # echo 2 > /sys/class/spi_master/spi/spi./fault_state + +What: /sys/class/spi_master/spi/spi./fault_state_= open +Date: January 2026 +KernelVersion: 6.19 +Contact: Steffen Trumtrar +Description: + Contains all LEDs and channels where an open condition was detected. + The format is ledname:channel. + + Example usage:: + + ## Read + # cat /sys/class/spi_master/spi/spi./fault_state_open + rgb1:0 rgb2:4 + +What: /sys/class/spi_master/spi/spi./fault_state_= short +Date: May 2025 +KernelVersion: 6.15 +Contact: Steffen Trumtrar +Description: + Contains all LEDs and channels where a short condition was detected. + The format is ledname:channel. + + Example usage:: + + ## Read + # cat /sys/class/spi_master/spi/spi./fault_state_short + rgb1:0 rgb2:4 diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp= 5860-core.c index 79a932edd1d24..ef00577a63a73 100644 --- a/drivers/leds/rgb/leds-lp5860-core.c +++ b/drivers/leds/rgb/leds-lp5860-core.c @@ -19,6 +19,138 @@ static struct lp5860_led *mcled_cdev_to_led(struct led_= classdev_mc *mc_cdev) return container_of(mc_cdev, struct lp5860_led, mc_cdev); } =20 +static const char *lp5860_find_led(struct lp5860 *lp, unsigned int idx) +{ + struct mc_subled *mc_led_info; + struct lp5860_led *led; + int i, j; + + for (i =3D lp->leds_count - 1; i >=3D 0; i--) { + led =3D &lp->leds[i]; + + mc_led_info =3D led->mc_cdev.subled_info; + + for (j =3D 0; j < led->mc_cdev.num_colors; j++) { + if (mc_led_info[j].channel =3D=3D idx) + return led->mc_cdev.led_cdev.dev->kobj.name; + } + } + + return 0; +} + +static ssize_t lp5860_fault_state_lod_lsd(struct lp5860 *led, char *buf, + unsigned int reg, unsigned int length) +{ + unsigned int value =3D 0; + unsigned int dot, bit; + unsigned int max_bits; + unsigned int offset =3D 0; + int len =3D 0; + bool match =3D false; + int ret; + + for (dot =3D 0; dot < length; dot++) { + match =3D false; + ret =3D regmap_read(led->regmap, reg + dot, &value); + if (ret) + return ret; + + max_bits =3D BITS_PER_BYTE; + /* every 3rd Dot_x register only has 2 bits */ + if (dot % 3 =3D=3D 2) + max_bits =3D 2; + + for (bit =3D 0; bit < max_bits; bit++) { + offset++; + if (value & BIT(bit)) { + len +=3D sprintf(buf + len, "%s:%d", lp5860_find_led(led, offset), + offset - 1); + match =3D true; + len +=3D sprintf(buf + len, " "); + } + } + } + + buf[len++] =3D '\n'; + + return len; +} + +static ssize_t lp5860_fault_state_open_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct lp5860 *led =3D dev_get_drvdata(dev); + unsigned int value =3D 0; + int ret; + + ret =3D regmap_read(led->regmap, LP5860_REG_FAULT_STATE, &value); + if (ret) + return ret; + + if (!(value & LP5860_FAULT_STATE_LOD)) + return 0; + + return lp5860_fault_state_lod_lsd(led, buf, LP5860_REG_DOT_LOD_START, + LP5860_DOT_LOD_LENGTH); +} +static LP5860_DEV_ATTR_R(fault_state_open); + +static ssize_t lp5860_fault_state_short_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct lp5860 *led =3D dev_get_drvdata(dev); + unsigned int value =3D 0; + int ret; + + ret =3D regmap_read(led->regmap, LP5860_REG_FAULT_STATE, &value); + if (ret) + return ret; + + if (!(value & LP5860_FAULT_STATE_LSD)) + return 0; + + return lp5860_fault_state_lod_lsd(led, buf, LP5860_REG_DOT_LSD_START, + LP5860_DOT_LSD_LENGTH); +} +static LP5860_DEV_ATTR_R(fault_state_short); + +static ssize_t lp5860_fault_state_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct lp5860 *led =3D dev_get_drvdata(dev); + unsigned int value =3D 0; + int ret; + + ret =3D regmap_read(led->regmap, LP5860_REG_FAULT_STATE, &value); + if (ret) + return ret; + return sysfs_emit(buf, "%d\n", (value & 0x3)); +} + +static ssize_t lp5860_fault_state_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct lp5860 *led =3D dev_get_drvdata(dev); + unsigned int value =3D 0; + int ret; + + if (kstrtoint(buf, 0, &value)) + return -EINVAL; + + if (value & LP5860_FAULT_STATE_LOD) + ret =3D regmap_write(led->regmap, LP5860_REG_LOD_CLEAR, 0xf); + if (value & LP5860_FAULT_STATE_LSD) + ret =3D regmap_write(led->regmap, LP5860_REG_LSD_CLEAR, 0xf); + + if (ret < 0) + return ret; + return len; +} +static LP5860_DEV_ATTR_RW(fault_state); + LP5860_SHOW_MODE(r_global_brightness_set, LP5860_REG_R_CURRENT_SET, LP5860= _CC_GROUP_MASK, 0) LP5860_STORE_MODE(r_global_brightness_set, LP5860_REG_R_CURRENT_SET, LP586= 0_CC_GROUP_MASK, 0) DEVICE_ATTR_RW(r_global_brightness_set); @@ -35,6 +167,9 @@ static struct attribute *lp5860_led_attrs[] =3D { &dev_attr_r_global_brightness_set.attr, &dev_attr_g_global_brightness_set.attr, &dev_attr_b_global_brightness_set.attr, + &dev_attr_fault_state_open.attr, + &dev_attr_fault_state_short.attr, + &dev_attr_fault_state.attr, NULL, }; =20 diff --git a/include/linux/platform_data/leds-lp5860.h b/include/linux/plat= form_data/leds-lp5860.h index 94d184702b11a..d032a0e6d2617 100644 --- a/include/linux/platform_data/leds-lp5860.h +++ b/include/linux/platform_data/leds-lp5860.h @@ -189,6 +189,9 @@ #define LP5860_DOT_CS_OFF 0x00 =20 /* Dot lod value */ +#define LP5860_FAULT_STATE_LOD BIT(1) +#define LP5860_FAULT_STATE_LSD BIT(0) + #define LP5860_DOT_LOD0_OFFSET 0 #define LP5860_DOT_LOD1_OFFSET 1 #define LP5860_DOT_LOD2_OFFSET 2 @@ -201,7 +204,9 @@ #define LP5860_DOT_LOD_ON 0x01 #define LP5860_DOT_LOD_OFF 0x00 =20 -/* dot lsd value */ +/* Dot lsd value */ +#define LP5860_DOT_LOD_LENGTH 0x20 + #define LP5860_DOT_LSD0_OFFSET 0 #define LP5860_DOT_LSD1_OFFSET 1 #define LP5860_DOT_LSD2_OFFSET 2 @@ -215,6 +220,8 @@ #define LP5860_DOT_LSD_OFF 0x00 =20 /* Register lod state */ +#define LP5860_DOT_LSD_LENGTH 0x20 + #define LP5860_GLOBAL_LOD_OFFSET 1 #define LP5860_GLOBAL_LOD_STATE BIT(1) #define LP5860_GLOBAL_LSD_OFFSET 0 @@ -248,6 +255,9 @@ */ #define LP5860_MAX_LED_CHANNELS 4 =20 +#define LP5860_DEV_ATTR_R(name) \ + DEVICE_ATTR(name, 0444, lp5860_##name##_show, NULL) + #define LP5860_DEV_ATTR_RW(name) \ DEVICE_ATTR(name, 0644, lp5860_##name##_show, lp5860_##name##_store) =20 --- base-commit: d60f615f21e161506b3ac9bee8add471f0e27a8c change-id: 20260129-v6-19-topic-ti-lp5860-fault-c8bd1f59fc3f Best regards, --=20 Steffen Trumtrar