From nobody Mon Feb 9 05:29:16 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A93C83876AB; Thu, 29 Jan 2026 11:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769687000; cv=none; b=ArDJwIRCM8zGNS4ZQ3frA8N/z2XpH4hzT5l6HS/AoMgJTwu24v0u1eV0cZTWqsZRToi0wo8Ur8C0uF+H5H0pxDck88vggNSjViVbXPXlshm3QIkGRob0+VtiveRoAr7iQXIB3QvXETH9Q8tZCWM4siLCb50oNJXPElnQJ6MWYB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769687000; c=relaxed/simple; bh=5oJ7muIlKrTCE7hk0LsBSqCNpuuKQGVs3p7fy03ndGc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dxb9/UjIeKLgtB13+odUzEYKUrUdCk44UxNkWHGNTjfhqietsYGn67emjvYfT6KJHKX5Zyzhp7CZrqm719xSQkDFIEasdfpCmzg9MyJljx9HpVzW0X3KwY9gvmJid9t7vXur+osBfXABIF++pTtkPYOPLmgeVZymIaxVWnhfqbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=LxPT3+Lq; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LxPT3+Lq" Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:f52e:2bba:80e9:14d8]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 91B6E2147; Thu, 29 Jan 2026 12:42:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769686959; bh=5oJ7muIlKrTCE7hk0LsBSqCNpuuKQGVs3p7fy03ndGc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LxPT3+LqQ5hLQNxLrbyPur/9fY3+kMCr0RgTVJICe+YCBjswq61wzQr0Da4/rmTmm 15EH3j3vWGRZzmLbnof2ngBAuIDfxTWX7nV8qJEXaFy23WvIebO3j1geCL/z425Otm 5Byw5Cpsdn3jxbCfvJNPVwnwMo1l5IRIqloYdFQc= From: Stefan Klug Date: Thu, 29 Jan 2026 12:43:10 +0100 Subject: [PATCH v3 1/4] media: dw100: Implement V4L2 requests support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-sklug-v6-16-topic-dw100-v3-1-dev-v3-1-2eb5685eaf09@ideasonboard.com> References: <20260129-sklug-v6-16-topic-dw100-v3-1-dev-v3-0-2eb5685eaf09@ideasonboard.com> In-Reply-To: <20260129-sklug-v6-16-topic-dw100-v3-1-dev-v3-0-2eb5685eaf09@ideasonboard.com> To: Xavier Roumegue , Mauro Carvalho Chehab , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Nicolas Dufresne , Stefan Klug X-Mailer: b4 0.14.2 The dw100 dewarper hardware present on the NXP i.MX8MP allows very flexible dewarping using a freely configurable vertex map. Aside from lens dewarping the vertex map can be used to implement things like arbitrary zoom, pan and rotation. The current driver supports setting that vertex map before calling VIDIOC_STREAMON. To control above mentioned features during streaming it is necessary to update the vertex map dynamically. To do that in a race free manner V4L2 requests support is required. This patch adds V4L2 requests support to prepare for dynamic vertex map updates. Signed-off-by: Stefan Klug --- Changes in v2: - Use v4l2_m2m_buf_done_and_job_finish() to mark the buffers as done in the correct order. Changes in v1: - Moved v4l2_ctrl_request_complete into dw100_device_run --- drivers/media/platform/nxp/dw100/dw100.c | 49 +++++++++++++++++++++++++---= ---- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platf= orm/nxp/dw100/dw100.c index 4aaf9c3fff5397f0441944ee926f2c8ba6fc864a..1cb895da9912371a2b23ca62412= c572d9cb75c00 100644 --- a/drivers/media/platform/nxp/dw100/dw100.c +++ b/drivers/media/platform/nxp/dw100/dw100.c @@ -459,6 +459,15 @@ static int dw100_queue_setup(struct vb2_queue *vq, return 0; } =20 +static int dw100_buf_out_validate(struct vb2_buffer *vb) +{ + struct vb2_v4l2_buffer *vbuf =3D to_vb2_v4l2_buffer(vb); + + vbuf->field =3D V4L2_FIELD_NONE; + + return 0; +} + static int dw100_buf_prepare(struct vb2_buffer *vb) { unsigned int i; @@ -500,6 +509,13 @@ static void dw100_buf_queue(struct vb2_buffer *vb) v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf); } =20 +static void dw100_buf_request_complete(struct vb2_buffer *vb) +{ + struct dw100_ctx *ctx =3D vb2_get_drv_priv(vb->vb2_queue); + + v4l2_ctrl_request_complete(vb->req_obj.req, &ctx->hdl); +} + static void dw100_return_all_buffers(struct vb2_queue *q, enum vb2_buffer_state state) { @@ -553,11 +569,13 @@ static void dw100_stop_streaming(struct vb2_queue *q) } =20 static const struct vb2_ops dw100_qops =3D { - .queue_setup =3D dw100_queue_setup, - .buf_prepare =3D dw100_buf_prepare, - .buf_queue =3D dw100_buf_queue, - .start_streaming =3D dw100_start_streaming, - .stop_streaming =3D dw100_stop_streaming, + .queue_setup =3D dw100_queue_setup, + .buf_out_validate =3D dw100_buf_out_validate, + .buf_prepare =3D dw100_buf_prepare, + .buf_queue =3D dw100_buf_queue, + .start_streaming =3D dw100_start_streaming, + .stop_streaming =3D dw100_stop_streaming, + .buf_request_complete =3D dw100_buf_request_complete, }; =20 static int dw100_m2m_queue_init(void *priv, struct vb2_queue *src_vq, @@ -575,6 +593,7 @@ static int dw100_m2m_queue_init(void *priv, struct vb2_= queue *src_vq, src_vq->timestamp_flags =3D V4L2_BUF_FLAG_TIMESTAMP_COPY; src_vq->lock =3D &ctx->vq_mutex; src_vq->dev =3D ctx->dw_dev->v4l2_dev.dev; + src_vq->supports_requests =3D true; =20 ret =3D vb2_queue_init(src_vq); if (ret) @@ -1058,7 +1077,6 @@ static const struct v4l2_ioctl_ops dw100_ioctl_ops = =3D { static void dw100_job_finish(struct dw100_device *dw_dev, bool with_error) { struct dw100_ctx *curr_ctx; - struct vb2_v4l2_buffer *src_vb, *dst_vb; enum vb2_buffer_state buf_state; =20 curr_ctx =3D v4l2_m2m_get_curr_priv(dw_dev->m2m_dev); @@ -1069,16 +1087,13 @@ static void dw100_job_finish(struct dw100_device *d= w_dev, bool with_error) return; } =20 - src_vb =3D v4l2_m2m_src_buf_remove(curr_ctx->fh.m2m_ctx); - dst_vb =3D v4l2_m2m_dst_buf_remove(curr_ctx->fh.m2m_ctx); - if (likely(!with_error)) buf_state =3D VB2_BUF_STATE_DONE; else buf_state =3D VB2_BUF_STATE_ERROR; =20 - v4l2_m2m_buf_done(src_vb, buf_state); - v4l2_m2m_buf_done(dst_vb, buf_state); + v4l2_m2m_buf_done_and_job_finish(dw_dev->m2m_dev, curr_ctx->fh.m2m_ctx, + buf_state); =20 dev_dbg(&dw_dev->pdev->dev, "Finishing transaction with%s error(s)\n", with_error ? "" : "out"); @@ -1460,6 +1475,12 @@ static void dw100_device_run(void *priv) src_buf =3D v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); dst_buf =3D v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); =20 + v4l2_ctrl_request_setup(src_buf->vb2_buf.req_obj.req, + &ctx->hdl); + + v4l2_ctrl_request_complete(src_buf->vb2_buf.req_obj.req, + &ctx->hdl); + dw100_start(ctx, src_buf, dst_buf); } =20 @@ -1467,6 +1488,11 @@ static const struct v4l2_m2m_ops dw100_m2m_ops =3D { .device_run =3D dw100_device_run, }; =20 +static const struct media_device_ops dw100_m2m_media_ops =3D { + .req_validate =3D vb2_request_validate, + .req_queue =3D v4l2_m2m_request_queue, +}; + static struct video_device *dw100_init_video_device(struct dw100_device *d= w_dev) { struct video_device *vfd =3D &dw_dev->vfd; @@ -1578,6 +1604,7 @@ static int dw100_probe(struct platform_device *pdev) dw_dev->mdev.dev =3D &pdev->dev; strscpy(dw_dev->mdev.model, "dw100", sizeof(dw_dev->mdev.model)); media_device_init(&dw_dev->mdev); + dw_dev->mdev.ops =3D &dw100_m2m_media_ops; dw_dev->v4l2_dev.mdev =3D &dw_dev->mdev; =20 ret =3D video_register_device(vfd, VFL_TYPE_VIDEO, -1); --=20 2.51.0