From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C92236405F; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=WBAIUwDS7f7YMkPBHPLDQNImllVNh6RKECdnpIrYWCuTwGBwTMCbdoDnO02d5uEM4qUUSKAGec7e8sv3d9jR49imGfo0Qj2SpilHQje5AM6G1JjlVLosi5FjZ+OAxWRNl7vw2HdIdlBUL2/vidF9VA60PQ+Dtz05EHYn9i8Ocxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=IpG7K26YMbIYlMeNw0cmbfVLcX2DzmYeW2ZXxwHgglM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MQt46NyNb2TGkE+kduTX3JM085cHccvv1vrm/ocoJnONSxJ4TYRX6vm57RqxHuc3f2ttRIAvNCOXFFGtrIQ6CYdNWXGTcqrN1oi+DRcq49kcMzBcfTEpZsRDunllbwT9tCAE8fvXtICHl9UY5/WWG+5JTRSpqz1HszPvAg7TGkg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sYL33MXb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sYL33MXb" Received: by smtp.kernel.org (Postfix) with ESMTPS id BFCD9C16AAE; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723005; bh=IpG7K26YMbIYlMeNw0cmbfVLcX2DzmYeW2ZXxwHgglM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=sYL33MXb3f9GkOtqfM77vPMoYK6szbN6GSOObPKiYrrkp1YfDoX88/BPiMfYU9T6R HrA3Nu7Jc8pfz7Ks6MB4lpFdRiWxsO6xuSNuUfiLrENpLGD06vhOhNMZVa7fe4BJMU I/0QZcDyzOHYyNZ2tatvLD3tU91G55JUKyuDgBdJ0KaVV5mzAOrPkB9B54IArOuODi LO10ob4jWju0JUgQP9EQVnhCel77MVe9lxyqYrFiI0WadxRq1Ll0lBKBfK+COd0lYs nx9Hu/HmlSQoK5/KtarUmK5mFOxobWU3oA7YHKZQK/sqUVrUwg9BfzD0JsQQlrzs9P 1wqVugwkgbvzw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6FDD73E9B; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:13 +0000 Subject: [PATCH v7 1/6] i2c: xiic: skip input clock setup on non-OF systems Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-1-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=1542; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=6voIA/a0l46cOc5ueYDVp8U+gfCNRwVU2ZoxgHh2Stc=; b=uBwWwmjKsmN67KJ/S9Ua6hanWw+GJQYf5zu/W4/drXYAPDqOkwughktr2P0AaBqADRvqAnCOm V4MRkqI0US1BbcTMGp7vo1PHJU6tME9zl1ePwNyn+YoiJHIm62Y0GzG X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain The xiic driver supports operation without explicit clock configuration when clocks cannot be specified via firmware, such as on ACPI-based systems. This behavior is implemented in xiic_setclk(), which returns early when either i2c_clk or input_clk are zero. Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 28015d77599d..912a94d4d080 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1423,6 +1423,7 @@ MODULE_DEVICE_TABLE(of, xiic_of_match); =20 static int xiic_i2c_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; const struct of_device_id *match; @@ -1464,10 +1465,12 @@ static int xiic_i2c_probe(struct platform_device *p= dev) mutex_init(&i2c->lock); spin_lock_init(&i2c->atomic_lock); =20 - i2c->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), - "failed to enable input clock.\n"); + if (is_of_node(dev->fwnode)) { + i2c->clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(i2c->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + "failed to enable input clock.\n"); + } =20 i2c->dev =3D &pdev->dev; pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); --=20 2.52.0 From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3CF363C5E; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=UofWDBKoPQ5Pwx4b2/KoudQrh76obiR22qAeH1bNJsWfeXcvAxMI1ACDF/1Uyq9JYVrlF0WDeNZrOuob/woSEQrxJ6fyOHJ9qBn1GzVdqx7wMvoR2tqSRDYyc0SpqG8C9jRy3Ba9+0Kvp+pzTqwn7c/LA42aHwL6qR2oste1vcQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=brx5w1sBoP4rgYEbfgYXX3fyk016qy1FYk3BSETc+Z8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EJ13GHPdhZNzJmOhqgHJCIcQO8HD/+JTXq2E+dxq5C6VDOjf8iGZHH2Id7LSAWnJZsm05vq6CpSsIbmZUWU5q5IbK01qY0fx9VY8mctES4I/shKy8FbOFi4RoH7mHN1jrlDp6st0ljiOTXxPYO5S22Mp4GR36tP1qUGmCpREMvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CLViJ3O8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CLViJ3O8" Received: by smtp.kernel.org (Postfix) with ESMTPS id CCED8C19425; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723005; bh=brx5w1sBoP4rgYEbfgYXX3fyk016qy1FYk3BSETc+Z8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=CLViJ3O8BuTJDeerrtus6D+JUA5jjUQ/kVFC44PsLzZN9DghX1D0NslbVHS9OesJR 9Zg518kHU2EZREGg4KnHpazEkys45FUgujXTRT2nzQ6QFMQvCwSqsymahxxneMKjIz FOD8rD9SUrPaB2q+snlbZbI7V/U13oKMsd+875H5oJgefRxV1Zm/jes5Tmd/KZCVOa Q7QprnNZZWy6JrIgEg7Z6uNCubtG/PijoRcQ/HTSUDI5glgcoLtb9ASxeKNs4sd4O3 Yb0FLDM0Uuy8/2+0PFhWp3DYTPQf8gTpq3lzlMp0ZnExnIzsaPSwu33F+Fiu6IsRgP ILu9bjs2akP+A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA09D73E9E; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:14 +0000 Subject: [PATCH v7 2/6] i2c: xiic: switch to devres managed APIs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-2-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=2599; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=zykN6ZbMH9Nn+LViqCFPQScoNBhSq6F1OqapwVemGvw=; b=zZpDJ7/w7XL3qTy2Z5St/mPn622Dpk7ZY0mmDnZ0wNVsVuRjmUCJkuz6rpxNaaTQi0xuqpAiv ND5S89Q0NlvCkscEhooEHlZYXxQtsN2mujwJGv7F1lWvbIne90QrRFn X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Simplify the error code paths by switching to devres managed helper functions. Signed-off-by: Abdurrahman Hussain Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/i2c-xiic.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 912a94d4d080..a480cbb86d93 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1462,7 +1462,10 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); =20 - mutex_init(&i2c->lock); + ret =3D devm_mutex_init(dev, &i2c->lock); + if (ret) + return ret; + spin_lock_init(&i2c->atomic_lock); =20 if (is_of_node(dev->fwnode)) { @@ -1475,8 +1478,9 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c->dev =3D &pdev->dev; pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); pm_runtime_use_autosuspend(i2c->dev); - pm_runtime_set_active(i2c->dev); - pm_runtime_enable(i2c->dev); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) + return ret; =20 /* SCL frequency configuration */ i2c->input_clk =3D clk_get_rate(i2c->clk); @@ -1492,7 +1496,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) =20 if (ret < 0) { dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); - goto err_pm_disable; + return ret; } =20 i2c->singlemaster =3D @@ -1511,16 +1515,14 @@ static int xiic_i2c_probe(struct platform_device *p= dev) i2c->endianness =3D BIG; =20 ret =3D xiic_reinit(i2c); - if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); - goto err_pm_disable; - } + if (ret) + return dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); =20 /* add i2c adapter to i2c tree */ ret =3D i2c_add_adapter(&i2c->adap); if (ret) { xiic_deinit(i2c); - goto err_pm_disable; + return ret; } =20 if (pdata) { @@ -1532,12 +1534,6 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n", (unsigned long)res->start, irq, i2c->i2c_clk); =20 - return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); - return ret; } =20 @@ -1558,8 +1554,6 @@ static void xiic_i2c_remove(struct platform_device *p= dev) xiic_deinit(i2c); =20 pm_runtime_put_sync(i2c->dev); - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); } =20 --=20 2.52.0 From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C57936405A; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=tUh+JJdiAHI4dc+389+buVU5kYSRUJ9ueRYwBjoovBdsOPMta33BDHrwd5WUUZutBu6Aamo1ACd9OuqAWa7JbucITk0ZmLxasO4padWWPM69gc5cUPRhx6rcnLYCh4/BVF2iJBc26axs48/5QjsZGGhcTv9NxhXRn7zOfGmG3sY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=brjSiH7R5FA4tu3Sa6BJ43nSvJfgsNAMf6VD6KddoQM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tK1VyCT8LypXCEeF+rWHF3wy/707bRV1yhUxtK0gHqNMxhbSw8VRKLdIDUN9ksynvlDHV2mhoj6Bg2Y+mmDGc0q0Lffz7n/YR1gQCvVti7K9zOehs+H+XKi3QIqMMqEU3PoxsN/I/rJHwFXGJBBVaCOCDR1ptHcCn02Gnuu8tpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ab3SsJPi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ab3SsJPi" Received: by smtp.kernel.org (Postfix) with ESMTPS id D4D91C2BC87; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723005; bh=brjSiH7R5FA4tu3Sa6BJ43nSvJfgsNAMf6VD6KddoQM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ab3SsJPiF94TK48jLjonQtWQ0xe5f318tbBO7EtoSGl9XLAG31Ru/Ds9V6jlW5KN3 dlLm44LU0cky9PmBnKFCjJUoFuA8fffzRg1IG6XctrzZ11ttaGY21Tcj1phfK7hw0/ x20vee/M8Rg0uoATF42tjdabJKQAsRbN0dpNRGJX8IK7Ee/6a2uxsgVHDiseuH4pjL Q+2Rn0VDZjATO7qEMP9VEd2ht5FdFLtUIbwV2TANYHc37aPkadNg256fVY1dq7jRUZ K21FkiMAIxSeYFX2t/EfQLkSBg8YYRLXp8lXe4A+/Y2sdbHL5LqLYDdOs5xiuBRGxe b92KdlYzqGZJQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC0DD73EA0; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:15 +0000 Subject: [PATCH v7 3/6] i2c: xiic: remove duplicate error message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-3-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain , Andrew Lunn X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=958; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=zo3dFn0HlGyzLosogoUEV42eLeWA4pxDMvHnGq762BA=; b=6rfEoX/3ErdGjF2NOVeNicWIblBIaO5nt4cWgVlXdXicLxUCeEC1gtUnpqz9TsVf/7S5dnJsJ WmgTfw9UEbmA/ccDBPK/wzk7B8+aUvG3vYVJDf/30Wsa6jiMl2UBu28 X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain The devm_request_threaded_irq() already prints an error message. Remove the duplicate. Reviewed-by: Andy Shevchenko Reviewed-by: Andrew Lunn Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index a480cbb86d93..ca5685660e45 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1493,11 +1493,8 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, xiic_process, IRQF_ONESHOT, pdev->name, i2c); - - if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); + if (ret) return ret; - } =20 i2c->singlemaster =3D of_property_read_bool(pdev->dev.of_node, "single-master"); --=20 2.52.0 From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C9B13644A0; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=ftyvDrBMKSmI7MgwPfKKjVJ3+GYqwTDuStWBXZYm5roQotTVMZ4w2aO+nRNZD+tzz1Pi/K9H3yjm77IcmUrjb1halMSO/kdIRcJoFfQyNemTEQeUuXrYph23PruKwdDAh7dWR1sJxsgsgqWj9tnBvtN15gBQWMzIhYxxm29Fj6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=FU05woc9KNICdXvI3avBjfEyGwzculRUk+KkEyBnixU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NEJ5chk2P9G+iBLEFGjMu9/OEupwLK1iund4GTXJk62WA62dDUjd+2O0KEXtqmXdjeK0wyk6j7x0xlZ/v5VakvPo7uOG9GOuGysv7NZQMwFBMcfcoBYqedge9wPVKHY0MNEfEgxViHnO0YGj4XEFfKQXFn0RPDXBQOUkCOJ3hKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dRojS5MZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dRojS5MZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id E2BA5C2BCB1; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723005; bh=FU05woc9KNICdXvI3avBjfEyGwzculRUk+KkEyBnixU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=dRojS5MZ8781sio7NUb54+5HijXqc86r/ntlx4zrc7zFMGccvN65t8osa+8xa4RYo oX9Gg69tqPCuhFDqsYKG7gl/fiE3mtAK/kaZSzeE88oR++Puu7oH52AmlAQoYr/cDf geP1IfmGoQI3Ecxwzj65MdEE/KFQXSrb+f+mUT4ScVmXCrz3Vz3xrYXYA6Al1o6d7T VV+buL7IhpEF2u9rMmGOWnFvlKir1S7XobGn43ZaLv7KRGum047S3i1dEoCl9QaXYt RrSxGkRwWmNu22+X+MyYJe/vVoP7KU7mnUv7Qim9yMCmIAhuYUj2INuj1/p0Hqqz8K 6rNMmRG2eZdlA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA00ED73EA2; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:16 +0000 Subject: [PATCH v7 4/6] i2c: xiic: switch to generic device property accessors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-4-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=2990; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=+x2c/OcVOHGBoIVRSCOnSJb7Hf0R0tox+oc5Sm3xWbQ=; b=WZjJ463tDPwAdrSsI3fESbqkC2Ex99EbZWd5+tostmw9k8t8uPm1qMHN84DS7eQ01NOxoyYos JwZzK+Kw0p1Al5YY7G5HxFGyYfnBOVELlGuqTee+Dbn+//hlyAtW1Ap X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Use generic device property accessors. Reviewed-by: Andy Shevchenko Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index ca5685660e45..3578c00d6404 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include @@ -1408,7 +1407,6 @@ static const struct i2c_adapter xiic_adapter =3D { .algo =3D &xiic_algorithm, }; =20 -#if defined(CONFIG_OF) static const struct xiic_version_data xiic_2_00 =3D { .quirks =3D DYNAMIC_MODE_READ_BROKEN_BIT, }; @@ -1419,14 +1417,13 @@ static const struct of_device_id xiic_of_match[] = =3D { {}, }; MODULE_DEVICE_TABLE(of, xiic_of_match); -#endif =20 static int xiic_i2c_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; - const struct of_device_id *match; + const struct xiic_version_data *data; struct resource *res; int ret, irq; u8 i; @@ -1436,12 +1433,9 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) if (!i2c) return -ENOMEM; =20 - match =3D of_match_node(xiic_of_match, pdev->dev.of_node); - if (match && match->data) { - const struct xiic_version_data *data =3D match->data; - + data =3D device_get_match_data(dev); + if (data) i2c->quirks =3D data->quirks; - } =20 i2c->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(i2c->base)) @@ -1458,7 +1452,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c->adap =3D xiic_adapter; i2c_set_adapdata(&i2c->adap, i2c); i2c->adap.dev.parent =3D &pdev->dev; - i2c->adap.dev.of_node =3D pdev->dev.of_node; + device_set_node(&i2c->adap.dev, dev_fwnode(dev)); snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); =20 @@ -1484,8 +1478,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) =20 /* SCL frequency configuration */ i2c->input_clk =3D clk_get_rate(i2c->clk); - ret =3D of_property_read_u32(pdev->dev.of_node, "clock-frequency", - &i2c->i2c_clk); + ret =3D device_property_read_u32(dev, "clock-frequency", &i2c->i2c_clk); /* If clock-frequency not specified in DT, do not configure in SW */ if (ret || i2c->i2c_clk > I2C_MAX_FAST_MODE_PLUS_FREQ) i2c->i2c_clk =3D 0; @@ -1496,8 +1489,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) if (ret) return ret; =20 - i2c->singlemaster =3D - of_property_read_bool(pdev->dev.of_node, "single-master"); + i2c->singlemaster =3D device_property_read_bool(dev, "single-master"); =20 /* * Detect endianness --=20 2.52.0 From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CE59364E9A; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=UKMB52hNQfBhdlcPLJs+U4Bm9M/sUGxpIinWlgHDlhzfgww7bChQdPiGR3quHXKvStW7MIwXxwtQo95gG9pq/u7ihQ9IfMYRJHd4rawkisJZHiqcFnL4fJB8nV7PRKDidJQ6XGs2W0EZv0HOqxqp80W85wp+MGzTqrOiznYzkZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=aK3PD+1V9CbJdF7r5/K5yWNnPE96LBlgQvwpAazD83g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nsmUrYULR4dmScYCHt0PyWZbLp2p3dMEe48izVf3+yh3sVEr1ydda09jU/9Q6Zvs0pPcA5HkkAva9ynPXo3DtGSMCvmrPjhXNNJdx3hmpWrl9RQzBL2FgyNFr92TZxKS+6Egn/xfLidhau8iEJJVtXB7OsOzlWsxViLf4h+Nr80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FgWO2Nb/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FgWO2Nb/" Received: by smtp.kernel.org (Postfix) with ESMTPS id F11E0C2BC9E; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723006; bh=aK3PD+1V9CbJdF7r5/K5yWNnPE96LBlgQvwpAazD83g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FgWO2Nb/7yL+sNMUC/+zaK555uGGDiIXiXXyLwFDlTgYah6ArbhC2btUxhx2Mw9zo TFy06UyFRe1TFL5mlTbdfMvrxRvqYOONZ1AU+JMpKRerhpslrfn5qDqfCkXSOfDPyw RCSj37EYGDFTZyY9Z9pjyi0uJgYtuxF2VnOB9lFWAROsVrW9TNmLuzs0AJyq+5J4iI 65uijRwh+1sD3kEUZWuxhiwnlTEqMvCBSBBLtz8DVt5FSt5kEtnruAnCgWFzDMtQI0 uwHhdA4U3v3kVRqE4/w/Ls8+DERExDRkWQByDDGja7J7AL6IwMUY7FmZhsP+j6P3SU qMSPIJdWMEiMw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8171D73E9C; Thu, 29 Jan 2026 21:43:25 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:17 +0000 Subject: [PATCH v7 5/6] i2c: xiic: cosmetic cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-5-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=3586; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=Iwa891qmu5bsxzfQcaF7qqAdE4otD0QTMnDYJyhw7aQ=; b=3Vlmq/TnuvEJ0CllMYPLJX/3z5XypTON5mdYlh3tHWNKv5KI8g1BICU40VYBJGy3jCNbNIOzW Zcy6RKpUi7FBjU8BzX7Bsee/2XeGA9E9uFXzlp4P8Ux0lmXiDyx/BVp X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Re-use dev pointer instead of referencing &pdev->dev everywhere. Reviewed-by: Andy Shevchenko Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 3578c00d6404..37a15065db60 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1429,7 +1429,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) u8 i; u32 sr; =20 - i2c =3D devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL); + i2c =3D devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL); if (!i2c) return -ENOMEM; =20 @@ -1445,13 +1445,13 @@ static int xiic_i2c_probe(struct platform_device *p= dev) if (irq < 0) return irq; =20 - pdata =3D dev_get_platdata(&pdev->dev); + pdata =3D dev_get_platdata(dev); =20 /* hook up driver to tree */ platform_set_drvdata(pdev, i2c); i2c->adap =3D xiic_adapter; i2c_set_adapdata(&i2c->adap, i2c); - i2c->adap.dev.parent =3D &pdev->dev; + i2c->adap.dev.parent =3D dev; device_set_node(&i2c->adap.dev, dev_fwnode(dev)); snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); @@ -1465,13 +1465,14 @@ static int xiic_i2c_probe(struct platform_device *p= dev) if (is_of_node(dev->fwnode)) { i2c->clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(i2c->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + return dev_err_probe(dev, PTR_ERR(i2c->clk), "failed to enable input clock.\n"); } =20 - i2c->dev =3D &pdev->dev; - pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); - pm_runtime_use_autosuspend(i2c->dev); + i2c->dev =3D dev; + + pm_runtime_set_autosuspend_delay(dev, XIIC_PM_TIMEOUT); + pm_runtime_use_autosuspend(dev); ret =3D devm_pm_runtime_set_active_enabled(dev); if (ret) return ret; @@ -1483,9 +1484,8 @@ static int xiic_i2c_probe(struct platform_device *pde= v) if (ret || i2c->i2c_clk > I2C_MAX_FAST_MODE_PLUS_FREQ) i2c->i2c_clk =3D 0; =20 - ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, - xiic_process, IRQF_ONESHOT, - pdev->name, i2c); + ret =3D devm_request_threaded_irq(dev, irq, NULL, xiic_process, + IRQF_ONESHOT, pdev->name, i2c); if (ret) return ret; =20 @@ -1520,7 +1520,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c_new_client_device(&i2c->adap, pdata->devices + i); } =20 - dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n", + dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n", (unsigned long)res->start, irq, i2c->i2c_clk); =20 return ret; @@ -1528,22 +1528,22 @@ static int xiic_i2c_probe(struct platform_device *p= dev) =20 static void xiic_i2c_remove(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c =3D platform_get_drvdata(pdev); int ret; =20 /* remove adapter & data */ i2c_del_adapter(&i2c->adap); =20 - ret =3D pm_runtime_get_sync(i2c->dev); - - if (ret < 0) - dev_warn(&pdev->dev, "Failed to activate device for removal (%pe)\n", + ret =3D pm_runtime_get_sync(dev); + if (ret) + dev_warn(dev, "Failed to activate device for removal (%pe)\n", ERR_PTR(ret)); else xiic_deinit(i2c); =20 - pm_runtime_put_sync(i2c->dev); - pm_runtime_dont_use_autosuspend(&pdev->dev); + pm_runtime_put_sync(dev); + pm_runtime_dont_use_autosuspend(dev); } =20 static const struct dev_pm_ops xiic_dev_pm_ops =3D { --=20 2.52.0 From nobody Mon Feb 9 01:11:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF3E364E9D; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; cv=none; b=pZdJZJDYnGspGIbV0C1VcJcwaSM1Txsy3x2LPo4hLTns+OcvSRry7waxdJOdlaAb9cppPKJrSv0trptbPzgBoAFKU2MKJFPibEKAFl6kUr4Dk9PzkXpRLQJnwGmiNnoen3oQXvJD1RHt9u4ucynu/Ufa0wTxi5aaN4Oq1KPlRvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723006; c=relaxed/simple; bh=63LIznqFOs+vjoKgYNAGULivL80MwirjxtzcB50EozY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=it/0hLUtPWstzGDF2iL/f5PHX+xZURL9s12oCreeERyo/o9supcC7/eViEzpKUloQAhMNHUz/fYO8ESGoOFxQ5/f0zBqvYviAcKT+3WzG+FtCSi3kdnVOhT1r1JLYMktDSxVmHRD35yjaOtj1HPszJDjPcpddbem/+BaSZl+5QM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F17P0uMt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F17P0uMt" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0B307C4CEF7; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769723006; bh=63LIznqFOs+vjoKgYNAGULivL80MwirjxtzcB50EozY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=F17P0uMtYIGb2OgbcRMRPnqr7mzmm8VMjda/u8aBKUKo4NmcV39qOnU9ufh8EBe2G QUbAcuAQeo10NNTQkdfN6WnqwP0VMxX+fOXzxBSCXuLCSQcAIXbnoT6hXBO859edX3 4AFYm9Ucf9mZoBdJl6mR1PqUnGw+I4LiOdDyXsnZsa0aKeipWxjHLvhGlv7ZBkYdJY H886VBWcU8pR35FEZFv8GIwAgco3YIoRc0b+HdmzzUOa/IZ99BdPxydjtP7Hhl6wCB 1b4V/aL17a8V88+Hb6+wWmsS1c3hDvUSaEvf3uiqP6bfStKcdMt3LvXX/VlxIUrTnW 3ejr3THvlccoA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02631D73E9B; Thu, 29 Jan 2026 21:43:26 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Thu, 29 Jan 2026 21:43:18 +0000 Subject: [PATCH v7 6/6] i2c xiic: cosmetic: use resource format specifier in debug log Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-i2c-xiic-v7-6-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> In-Reply-To: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> To: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769723005; l=796; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=AyCNoRBKLYKfBPlFJJJUJ1HZ4ulZ88H5iw5TKWG8oFw=; b=uQhYS1vit0sv+bhMHnHmHsL2lmmclZrijbdaPDHxYdtFj5dfVi4YedI9NYD+Z/SyM+YsYV4vz IZ6i3jzydC0AASM1+x6xkBVi5X/v2/P+CWVis0tU9y2DhXTR5v7qGMU X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Use standard resource format specifier %pR in debug log. Signed-off-by: Abdurrahman Hussain Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/i2c-xiic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 37a15065db60..b24b7a7bab8c 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1520,8 +1520,8 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c_new_client_device(&i2c->adap, pdata->devices + i); } =20 - dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n", - (unsigned long)res->start, irq, i2c->i2c_clk); + dev_dbg(dev, "mmio %pR irq %d scl clock frequency %d\n", + res, irq, i2c->i2c_clk); =20 return ret; } --=20 2.52.0