From nobody Sun Feb 8 17:13:54 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7C5338551E for ; Thu, 29 Jan 2026 12:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769688827; cv=none; b=rFhjt6cv8FTGPp+3bFripqhmUMwdRNcN4BONjFIAZzA3qWxGp9iNTBhiJhMZ7EC5OFiHFVUp9v8ZTXrR8EwoWRdB3uLGoNrMAFtQxl0eFIRuZa260wC+KOmqLS3pkEXaFqpCBBEGtsHdxmRR2MWBEXxr7GdPJDzC9k6fJm3TYm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769688827; c=relaxed/simple; bh=xdhkekPo3kh19syYUuARxRHdMgZBVsCYB5XBYgJUQpk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cdNOzBe35g4e1sVsZ8TnPHXqNnIdNdSbtnn+y4A5GWat2/gB7LaVIl2j+XQ440fiBhzIkIP8Tv/XMf24tm5t0g9/xk1FlvIldOnVjqUQuWSGar+lnkWFYgQvlGiXSU+l4WGvNrbW0k6kc/PkauQY6gm1S+FZR1ECcs6w0Gm9Ca8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=V+zMPHJg; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="V+zMPHJg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1769688817; bh=xdhkekPo3kh19syYUuARxRHdMgZBVsCYB5XBYgJUQpk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=V+zMPHJg+jKRTTIkPwBQSQjzQb2QiYWk4tTQ5P38cjFNCgYSrg1y8xPWyu6nPj3EZ VDgXuyPIOHAEjocygwLSjv0cTKRLub5a4BGfb/lnwZ9kqlYyAznOxzvj7oEGS4Z7kp F38kQLDVCOHRo61Jic2Ma0iihHwcSOypUfOLGfusOE3/QiEI74087fhOlnYfwVVi0j RVX3EMqOqheA1EK9VNh5NamVNSk6UNJfSTPODJxkUVQ9YbV4h1AbQSwuUUjwv6R9GA Ozbo5Rnl5tA5pZfe2gsgD0mjtVToBkJf1HUmLUrC/04qfCs2oX37KHBL1UKg9Ndj1C T149mAkPgGNFg== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id AA8D717E1305; Thu, 29 Jan 2026 13:13:37 +0100 (CET) From: Cristian Ciocaltea Date: Thu, 29 Jan 2026 14:13:32 +0200 Subject: [PATCH v2 1/5] drm/bridge: dw-hdmi-qp: Provide HDMI Vendor Specific InfoFrame Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260129-dw-hdmi-qp-iframe-v2-1-0157ad05232c@collabora.com> References: <20260129-dw-hdmi-qp-iframe-v2-0-0157ad05232c@collabora.com> In-Reply-To: <20260129-dw-hdmi-qp-iframe-v2-0-0157ad05232c@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Since commit b626b1a1c9cc ("drm/bridge: refactor HDMI InfoFrame callbacks"), the following warning is generated: [ 13.654149] rockchip-drm display-subsystem: [drm] HDMI VSI not support= ed Add the missing support for sending HDMI Vendor-Specific Infoframes. Additionally, introduce dw_hdmi_qp_write_{pkt|infoframe}() helpers, as a prerequisite to rework all dw_hdmi_qp_bridge_write_*_infoframe() callbacks and get rid of some boilerplate code. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 39 ++++++++++++++++++++++++= +--- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.h | 2 ++ 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 036316e2b60d..93aae1d8027d 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -969,9 +970,9 @@ static int dw_hdmi_qp_bridge_clear_avi_infoframe(struct= drm_bridge *bridge) =20 static int dw_hdmi_qp_bridge_clear_hdmi_infoframe(struct drm_bridge *bridg= e) { - /* FIXME: add support for this InfoFrame */ + struct dw_hdmi_qp *hdmi =3D bridge->driver_private; =20 - drm_warn_once(bridge->encoder->dev, "HDMI VSI not supported\n"); + dw_hdmi_qp_mod(hdmi, 0, PKTSCHED_VSI_TX_EN, PKTSCHED_PKT_EN); =20 return 0; } @@ -998,6 +999,32 @@ static int dw_hdmi_qp_bridge_clear_audio_infoframe(str= uct drm_bridge *bridge) return 0; } =20 +static void dw_hdmi_qp_write_pkt(struct dw_hdmi_qp *hdmi, const u8 *buffer, + size_t start, size_t len, unsigned int reg) +{ + u32 val =3D 0; + size_t i; + + for (i =3D start; i < start + len; i++) + val |=3D buffer[i] << ((i % 4) * BITS_PER_BYTE); + + dw_hdmi_qp_write(hdmi, val, reg); +} + +static void dw_hdmi_qp_write_infoframe(struct dw_hdmi_qp *hdmi, const u8 *= buffer, + size_t len, unsigned int reg) +{ + size_t i; + + /* InfoFrame packet header */ + dw_hdmi_qp_write_pkt(hdmi, buffer, 1, 2, reg); + + /* InfoFrame packet body */ + for (i =3D 0; i < len - 3; i +=3D 4) + dw_hdmi_qp_write_pkt(hdmi, buffer + 3, i, min(len - i - 3, 4), + reg + i + 4); +} + static int dw_hdmi_qp_bridge_write_avi_infoframe(struct drm_bridge *bridge, const u8 *buffer, size_t len) { @@ -1011,9 +1038,15 @@ static int dw_hdmi_qp_bridge_write_avi_infoframe(str= uct drm_bridge *bridge, static int dw_hdmi_qp_bridge_write_hdmi_infoframe(struct drm_bridge *bridg= e, const u8 *buffer, size_t len) { + struct dw_hdmi_qp *hdmi =3D bridge->driver_private; + dw_hdmi_qp_bridge_clear_hdmi_infoframe(bridge); =20 - /* FIXME: add support for the HDMI VSI */ + dw_hdmi_qp_write_infoframe(hdmi, buffer, len, PKT_VSI_CONTENTS0); + + dw_hdmi_qp_mod(hdmi, 0, PKTSCHED_VSI_FIELDRATE, PKTSCHED_PKT_CONFIG1); + dw_hdmi_qp_mod(hdmi, PKTSCHED_VSI_TX_EN, PKTSCHED_VSI_TX_EN, + PKTSCHED_PKT_EN); =20 return 0; } diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.h b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.h index 91a15f82e32a..53688eae8dba 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.h +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.h @@ -198,6 +198,7 @@ #define PKTSCHED_PRQUEUE2_CONFIG2 0xa94 #define PKTSCHED_PKT_CONFIG0 0xa98 #define PKTSCHED_PKT_CONFIG1 0xa9c +#define PKTSCHED_VSI_FIELDRATE BIT(14) #define PKTSCHED_DRMI_FIELDRATE BIT(13) #define PKTSCHED_AVI_FIELDRATE BIT(12) #define PKTSCHED_PKT_CONFIG2 0xaa0 @@ -206,6 +207,7 @@ #define PKTSCHED_DRMI_TX_EN BIT(17) #define PKTSCHED_AUDI_TX_EN BIT(15) #define PKTSCHED_AVI_TX_EN BIT(13) +#define PKTSCHED_VSI_TX_EN BIT(12) #define PKTSCHED_EMP_CVTEM_TX_EN BIT(10) #define PKTSCHED_AMD_TX_EN BIT(8) #define PKTSCHED_GCP_TX_EN BIT(3) --=20 2.52.0