From nobody Sun Feb 8 13:38:55 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EE822F7440 for ; Wed, 28 Jan 2026 22:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769639250; cv=none; b=ozdGr5JoqhXwfjuH+Q7bBSf6jrz3I+kUCScvh+l4+OZePswCl/59qrSxhKsyC7MZnGoyIfV43ZYBTpHvlUSU20F8KT3X5VW3BuE0R5yVgobM5qwlA4C/XaHlhM4/n4t34lW1xKf/uvK4M20U4BS3GSNukh40G7aFc07+uzjjo+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769639250; c=relaxed/simple; bh=DX1dunjFl7ul6NzJr9ty/Zk8vvkbi/BbccSxsuaroQg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e78/D4yeJ4wKsCOPFTwua4BKFkVJ8qWIqtTLu36WuUIYXK+oSgzOG7DoUJStbpTjF+Ds5TIHiYFBzEYtzL0ZIdC06BDv/Zkho7sdwyepSgqCKZ1BKX59YCibN1eb3xlsWM/TQLN5JiWplUsqjESXsPT5Tp6BLx0J00w6pHuDRSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=je7fEDoE; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="je7fEDoE" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a0d67f1877so1637385ad.2 for ; Wed, 28 Jan 2026 14:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1769639248; x=1770244048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3eYfjgqY4a/BMsIpyzIRy1aMQwrAiII0bz0e/dp/Dkk=; b=je7fEDoESR1eSvSBe8qjZX0CQIy8Cz0JqW/ILWr7GopkEuZqKMBMbhMl7GJnx3u9vE 2MWDgxnLB6DQOl+FmngFA/s5BjNoxj3rvwJme1IF7b6drgpBWKILvfR+ti5g6NFjET+R mDWenW4QZsMcufecH2iHzIk4ud2QNyM+LBDTEm0MlR6jGwe2vD08zinCl0BmwJYlPnwL bN4y6TaLlUbwdtjODEtmg49WT3hkwZ0Umrb7n7QyYwC4slD0sAIpleRL4SyOsf+Cz3VA SP8A/nfo8ysmwzDf6gkKyoCoo7/jLTQQ2kXydEDWz7HgrLCSPyWxR5wVrd2YVcO0OOfY pCqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769639248; x=1770244048; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3eYfjgqY4a/BMsIpyzIRy1aMQwrAiII0bz0e/dp/Dkk=; b=j+0SZSbA04pM4uDLzyoADvM+8wbzS4TRnx91jJmv22oaX+yw9B1xoBNj8jusqbPW35 +VIaDVomA78qXQOPsT6tXgFe3OJmehXbPUHx8UNzNKS38MXvdamNDdij5BC3FUwiGUXv zrGn6y1FUrqacIJLHyeawiILvNzeIscmBoiao5y3nEcJZn8U8Mx6g1CN5XGenwk8SaSQ 1klnGpMMN2umZVygWgnWFlzWL6V5TfS5Q4Kb3vLuuRcG4VWRMkjos57B7HJEe3eXqT+2 1uDwXPEy7NNrfkJ9X0R6/URzvxik6x73ed8AQjalrmrPtG7z0BikG3rPQpIGAub+SrVD ziKw== X-Forwarded-Encrypted: i=1; AJvYcCXRc3wRLqSQ00whw9P4fgXOFpYWx0RWqEmzijdOmcqufzyNUsgh+MQw7YHt1U3+qwR9A3wCCY98GQJfnlY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/0GHG2XB7gaXRWZSHCcsPOTe+AN7kcNODBoeN3p+89TmTOh1b c7KwXe2Ml+LcXKyC98FDxkvij3AoCyC1sWF6/mnxxWK7UuoieykXQUmYlkQ47Bb61uM= X-Gm-Gg: AZuq6aIf5JKyuNhi6XqZG5lGzgsyZiaMSCgf1FeLBBdcWB0Nu3Dzc4i1cLmGw8wuso/ fsH953yT4Aa3UgUMTxduzRraunyQpnud3PzEp+x+Y8+OrmncF2FegRuYg/iI8luyb5HR093ffdP xtiIg+F03JL4HZ41NLbROXoiXgCx1A40cLncSCFI/tT1jYN99EqT9OSTA6ze5gBJFi34exz1hhY LO0l9ReP6oAT2HZRry9aXxIHabiQd0qSDcEPpMiDUnYloovUpE/QTb7ut9iASVsySYdfwmsMdBQ UuRv1P7ScMrLnHnOXE2WK4696qTGYd2cUYZk5wFmoZ30iKo7/c28avtLOQOde+DrfBhcqNCkNxr +ym5UfIV8VVpwnI4YOm288q8WW7IPRTDHEMx5SddZnRYViOgXdIKWMlBFR0McZHWT X-Received: by 2002:a17:903:3b84:b0:297:df4e:fdd5 with SMTP id d9443c01a7336-2a870dd5039mr63469825ad.23.1769639248298; Wed, 28 Jan 2026 14:27:28 -0800 (PST) Received: from localhost ([2a03:2880:2ff::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4c40e1sm32169395ad.55.2026.01.28.14.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 14:27:27 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: shruti.parab@broadcom.com, Joe Damato Subject: [PATCH net-next] bnxt_en: Allow ntuple filters for drops Date: Wed, 28 Jan 2026 14:27:17 -0800 Message-ID: <20260128222718.1679581-1-joe@dama.to> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It appears that in commit 7efd79c0e689 ("bnxt_en: Add drop action support for ntuple"), bnxt gained support for ntuple filters for packet drops. However, support for this does not seem to work in recent kernels or against net-next: % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 rmgr: Cannot insert RX class rule: Operation not supported Cannot insert classification rule The issue is that the existing code uses ethtool_get_flow_spec_ring_vf, which will return a non-zero value if the ring_cookie is set to RX_CLS_FLOW_DISC, which then causes bnxt_add_ntuple_cls_rule to return -EOPNOTSUPP because it thinks the user is trying to set an ntuple filter for a vf. Fix this by first checking that the ring_cookie is not RX_CLS_FLOW_DISC. After this patch, ntuple filters for drops can be added: % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 Added rule with ID 0 % ethtool -n eth0 44 RX rings available Total 1 rules Filter: 0 Rule Type: UDP over IPv4 Src IP addr: 1.1.1.1 mask: 0.0.0.0 Dest IP addr: 0.0.0.0 mask: 255.255.255.255 TOS: 0x0 mask: 0xff Src port: 0 mask: 0xffff Dest port: 0 mask: 0xffff Action: Drop Signed-off-by: Joe Damato --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/ne= t/ethernet/broadcom/bnxt/bnxt_ethtool.c index 6b15fedbb16f..fd32231bf8e0 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -1353,10 +1353,12 @@ static int bnxt_add_ntuple_cls_rule(struct bnxt *bp, if (!bp->vnic_info) return -EAGAIN; =20 - vf =3D ethtool_get_flow_spec_ring_vf(fs->ring_cookie); - ring =3D ethtool_get_flow_spec_ring(fs->ring_cookie); - if ((fs->flow_type & (FLOW_MAC_EXT | FLOW_EXT)) || vf) - return -EOPNOTSUPP; + if (fs->ring_cookie !=3D RX_CLS_FLOW_DISC) { + vf =3D ethtool_get_flow_spec_ring_vf(fs->ring_cookie); + ring =3D ethtool_get_flow_spec_ring(fs->ring_cookie); + if ((fs->flow_type & (FLOW_MAC_EXT | FLOW_EXT)) || vf) + return -EOPNOTSUPP; + } =20 if (flow_type =3D=3D IP_USER_FLOW) { if (!bnxt_verify_ntuple_ip4_flow(&fs->h_u.usr_ip4_spec, base-commit: 239f09e258b906deced5c2a7c1ac8aed301b558b --=20 2.47.3