From nobody Tue Feb 10 03:56:15 2026 Received: from mail-dy1-f226.google.com (mail-dy1-f226.google.com [74.125.82.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC9C36F435 for ; Wed, 28 Jan 2026 18:57:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626653; cv=none; b=VNVTmbl5nvfELeUnuBLLztfRT1z0Y1Yx5xaEh5BHsGtgWykUr7EHxuewHNqq1RupxWRrm5SnaXScDdmgbs4H/AvWCY0NrRMJ0YLtaL53ImZVsn9qSblmtfJrVJWQ6wlS22oZwLjyqE8KbknMN1pXoVYkQrf0zyZsTv/sxnpkJ1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626653; c=relaxed/simple; bh=P6NQdhvSGOiOEaZnIgzwu82OeAsyfH7kGJEwellkPqc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U+i6QgNpFcatUhKO2kMJIaafxHtyQaYtWH+GJ4qhdNlmvBHlv8KawcVoLkBCUHYAy0cppj0xX3B3avoBmEN71UXUtFo89JLyQm3Uis1LsVXs2s3TaE/I/NMEAWb5XByANPnrFFLUJBdYUmR20ofdgAOWBke9+d23+Sbj0e/3fcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Su+Vou5i; arc=none smtp.client-ip=74.125.82.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Su+Vou5i" Received: by mail-dy1-f226.google.com with SMTP id 5a478bee46e88-2b70abe3417so540299eec.0 for ; Wed, 28 Jan 2026 10:57:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769626652; x=1770231452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EAAzkfzFSB7WTgu4dHa6SgmJadc1G5A9GOoFDZhQpTY=; b=c5NXN1rgWR8b4kaqH9bsQsfn5TDLNmKW9clZd4t1enoHVf1lf+O7hbe4k+6ZKTsDtI zA6urJxQG0Wpi0ck7xhNmMkbG2+xZ+zAzt2Kx3yFST4HMAJLgnL9z0g9hMqN6zLnRqdh A3bEXk9AlngIWf+vqejba7VkpX6X+yTYSBofKmWvcSPX7x5L8jvO18AvBn2RDTeNDtHH o8c6KQU1tCi9f91kNLzcV1664yLjZYpeWUTuILBK3TIKaWeN8vyC8ph1d0/ebkPZTfw5 7o6MAbgHbrd/Jr+s7YPAIlWlt86/eo+FLuuwvE7atMFJES7Mm8Lf33aNHLZqKDaYqpUz djvA== X-Forwarded-Encrypted: i=1; AJvYcCWQwA5Cjkg8FAIiUJCA5nZL+8n3HzO7MydLhSX77beH3XhFDOydBVqw4c8uIbP09QoLkWRSNhmmjSqpAHc=@vger.kernel.org X-Gm-Message-State: AOJu0YxMnHNxjay+ZQ+wQwJIaw60wsw68QVG2/3ZVmR8w63D3eMJX7Sv tr9zwbR0Yyx8OIxCZdU0VAN2MC1Hx2e3j9eQNpi6Hs0HYR7LV0jR5zfBHX9fXcEVe48fzdYrIjM Wqw5jodYJOajSxCLXa1EuBd70DOkZgD50QdxfLQU3GJIgM4BcY+shYkIgOr8opIAk8sbH3HAWw9 aHq82NrT0ozyFYPfNU+U/8DFrguF5r9DOmni60jLH0/lMA4pH6slB0PGLydxP030ztWI91LV8bV HIMaKi68nAZkj6ALa7J0npfLA== X-Gm-Gg: AZuq6aLl8xJznLidxql6SrtSFQWFkkIquKi70TbJyaxawqfCH1j3UzDYrOP2DDIOLAC vSPH+SRVLSn/zuv13ZA3pjK2Y56PZ1HgTGO44hyvWrqmwy5anxhIcQYp+ggIfEIMUQNMiiK0fM4 5Z4236VHSq6jrco5/YQW2mBjf67y0H4JUtem/N891TOW8qtxcHSnYLGDpQCZDL8BkmSqd+R87zl ujYcYp/yB+90HALkqbMukoFjUiLsPHec6JBtyKKSV0HBWuwEAop6Y6TU6t/j3fF4ZEe2SJLzqqS ZdlRGH4YeeMrXh2gJ1gZWGfkrqzTHQy8cK43t+LHzJ/Zjq/Q5I9oAYCS2vt/bZZqQlnawWAjFsq LFIXnXd1pnv2QVgFqVqOHpqZJi0n32hgghKGpZhwA7L1V8jj5rQYtPhHYKWrPbUD2NIytsr+zy5 1iQqLTUKkD7Lu8oArFdV8vNMHx1Ui4WAVHQ5jmzWKXthWN7CQc+l8= X-Received: by 2002:a05:7300:cc0e:b0:2b0:52ac:92fe with SMTP id 5a478bee46e88-2b78d9b5b90mr4595328eec.21.1769626651522; Wed, 28 Jan 2026 10:57:31 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-17.dlp.protect.broadcom.com. [144.49.247.17]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2b7a14babd5sm277234eec.0.2026.01.28.10.57.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2026 10:57:31 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82323cc7594so60300b3a.2 for ; Wed, 28 Jan 2026 10:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769626650; x=1770231450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EAAzkfzFSB7WTgu4dHa6SgmJadc1G5A9GOoFDZhQpTY=; b=Su+Vou5iTAEfvVr5yVFkzw2JqRbKItAadRy/Oh/l3W+sKvMLKRvOXH5y075ZWaRQfX bcOx+CLVQyil9h3/B0WAD2aBQ+Y82xFfAddmQYeZTivQn8PDM0im957eJ0nX3e7yklKK GrmDY+G8trruxS2YeRErIJfR/T6m+h89FIiqw= X-Forwarded-Encrypted: i=1; AJvYcCWaJw9HkyGiZ0/L86+vdcgyc93VyaDfb4FgcDFS65s5ttnKfFnhADHdWdvTAuJIIo84lVArV/Z3p0c472w=@vger.kernel.org X-Received: by 2002:a05:6a00:2d84:b0:81f:852b:a936 with SMTP id d2e1a72fcca58-8236917bb29mr5795985b3a.15.1769626649996; Wed, 28 Jan 2026 10:57:29 -0800 (PST) X-Received: by 2002:a05:6a00:2d84:b0:81f:852b:a936 with SMTP id d2e1a72fcca58-8236917bb29mr5795963b3a.15.1769626649623; Wed, 28 Jan 2026 10:57:29 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c22466sm3263536b3a.50.2026.01.28.10.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 10:57:29 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rahul Gupta Subject: [v7, net-next 5/8] bng_en: Add ndo_features_check support Date: Thu, 29 Jan 2026 00:26:20 +0530 Message-ID: <20260128185623.26559-6-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> References: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement ndo_features_check to validate hardware constraints per-packet: - Disable SG if nr_frags exceeds hardware limit. - Disable GSO if packet/fragment length exceeds supported maximum. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 24 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_txrx.h | 3 +++ 3 files changed, 28 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 78f04db3c597..fba7f6a73b85 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2421,6 +2421,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_features_check =3D bnge_features_check, }; =20 static void bnge_init_mac_addr(struct bnge_dev *bd) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index 261b071a8bd6..312b5cbea2a5 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -966,3 +966,27 @@ netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struc= t net_device *dev) dev_core_stats_tx_dropped_inc(dev); return NETDEV_TX_OK; } + +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features) +{ + u32 len; + + features =3D vlan_features_check(skb, features); +#if (MAX_SKB_FRAGS > TX_MAX_FRAGS) + if (skb_shinfo(skb)->nr_frags > TX_MAX_FRAGS) + features &=3D ~NETIF_F_SG; +#endif + + if (skb_is_gso(skb)) + len =3D bnge_get_gso_hdr_len(skb) + skb_shinfo(skb)->gso_size; + else + len =3D skb->len; + + len >>=3D 9; + if (unlikely(len >=3D ARRAY_SIZE(bnge_lhint_arr))) + features &=3D ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + + return features; +} diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.h index 81a24d8f9689..32be5eb46870 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h @@ -119,4 +119,7 @@ irqreturn_t bnge_msix(int irq, void *dev_instance); netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struct net_device *dev); void bnge_reuse_rx_data(struct bnge_rx_ring_info *rxr, u16 cons, void *dat= a); int bnge_napi_poll(struct napi_struct *napi, int budget); +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features); #endif /* _BNGE_TXRX_H_ */ --=20 2.47.3