From nobody Tue Feb 10 15:45:42 2026 Received: from mail-yx1-f100.google.com (mail-yx1-f100.google.com [74.125.224.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEC72D7DD1 for ; Wed, 28 Jan 2026 18:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626644; cv=none; b=l00DIm7luBsawfb1AXh09SjtU8r4lBzCJyBe4xzMw4GcTMIqWrXVogRDxOON8mKDRuXfkWHtlYOIfANn3W6rR80ekWnewYF9Ue9DIqIciDp4o4FK+sGslPpcVbsooJJA/H9ZESy83rNj072u7KAd1NM8Ak+d7QmXEWkMxiv+7kA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626644; c=relaxed/simple; bh=mK2FMNivQRKgUq/yMhNB8Gkj0x70D5HHRcCjELHwKtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X+XIxY3cDm404hcGEm1faV9ar+LtxV16xhtZwri/s0FldvlvnhJuHXbsL9nMCRj6zTfmZT91qqq2ilExGqxJuEZ2DBqjLCyTRrnJLHxR7sUV1gKmQHu/CLwM/dcYOOxZ1Yk5Ux4tLeRgZ+nqU8c0mNi+KS361BSx+tb5QWifp3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=DSb8LtrG; arc=none smtp.client-ip=74.125.224.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="DSb8LtrG" Received: by mail-yx1-f100.google.com with SMTP id 956f58d0204a3-64969550a1aso140511d50.1 for ; Wed, 28 Jan 2026 10:57:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769626641; x=1770231441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bY/8sfiCJgs8vKFouKLhV8muyspKbmjqdge49UT5PEs=; b=rRJw8VoipkqWF63+zfluOoRuK/dZlD5MyIY4AEZLIcOws8rfcFBAZK/2CEzbpvVTVr /lxWyEphaKywAGwc04mgbeVRh0VVS02aNSoGfftNxVdh2JnBWq9eYGXP76ehmH+UZ/8W fal7r9u5f2rDMTqUgqCn/gG9FlOdqoBqjCvIsPg6fXR5U1kOC3bzVx10iOk/DuGeUsRz l/gg+K/4Ct9lX0c51odMwji4ijaKjPYsWy02rLVju8shwZ5drtJpeAkjDgnIn7m3WEWm A54MhwTChz2AEj32PyyR6I8g/dmurmayiH4Jiz474cnIUX3+7PQO6zXdApRVSPVUlV24 NY7A== X-Forwarded-Encrypted: i=1; AJvYcCVsJzMXZjdjXfak11ax+5ZUNhKwU0BASibJAA0+JRlN4evJJE3Y1mOR5ad6u4bVITendaqtjUynPEenvmY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9cTQUzY9kGksHJdvorRChnS8DlIRSp8PHZj1xPjTUWY8YZQXr 0BLXNJltptKE9cof90vnCbe+J9XxMA6ZTr18yAp34ktJFiVnYZXh3QnD01PNc0ogtf+BkOMBag5 EXhTbwDPbDcHb9HpghMWpRogxsOehvGH4WioICU0X2Sqj+gHQDkDl3rgQledmXrwdd8AuWDWjWw C0akkunvHbU3fr9WBtDII3Vn/Ig81tpgLMaHPWtfCadUiWlHQis/llpn5zbkpq9/62867Jcf0Io utSGc5vrUFFSTVtCmVRU88EOA== X-Gm-Gg: AZuq6aJt/QYCrPMPRdXIgpLV/TvBR+QlP8lJgIUduvQTLJHuxWeFKVvyRe87OCBpC9O HVffW5IJlgcMYSf/vXoC0oxZn9MMLEdaPRD7ui+dv7D686DsOHxPC0a50UICKlbzfG6mcOQq/nS z1i/ph6hxX9mej0GCy4JmQlzFsXfdSV0Vyrnt9FP2IvQu1U/C1GcgIb38XraJLFijVR/S/rfK/J iC6gOuHGUMFFbKGK3K3DEavmdofdw2kLbx+pjqQ5V3kqdxLdBlHTp5Ql8R5jBYoU/ogLXf7NqwR XGxPTm/EdrOMZZCFW81d5FN36dexM8KLxLSrlluua9/NDaeYz34DCDv0dBuCWaU162UwYBYXPFK LS5F9hGurF+dpV3zcKDiUS5lI7ksaRCcVkWsF5qmZMzlTXYsorJu0tMDYpHMtvYY3Bx7JSUGiF6 VJtqdn04C4A6jqp/glFcqZlxEHdgL+sR/lf3ldWbifg+zZcXTSMXc= X-Received: by 2002:a05:690e:118e:b0:643:55d:7731 with SMTP id 956f58d0204a3-6498fc6bffcmr4464436d50.83.1769626641018; Wed, 28 Jan 2026 10:57:21 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-17.dlp.protect.broadcom.com. [144.49.247.17]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-64995fbc7bfsm260714d50.0.2026.01.28.10.57.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2026 10:57:21 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-81efa628efbso92047b3a.1 for ; Wed, 28 Jan 2026 10:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769626640; x=1770231440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bY/8sfiCJgs8vKFouKLhV8muyspKbmjqdge49UT5PEs=; b=DSb8LtrGIEsspOm9MU/j8yZaq6jIgugXgOeYYasu+7NY7FpN0glafLpXC56s9pCQHH 3dgxmE3ONPW7TIHYmkfG6jpyszVpodIwXMo06ukV3LgvKVDt6mRmCRD2ynZfX6IUI3Ur Pq0NMqxvzvJrailwLGtqc8CGUhC9tddHGh3uQ= X-Forwarded-Encrypted: i=1; AJvYcCUzrQ+0BszVt01SinMHs5f1zC+i9x0vT1b9WBcaqU0MZqsi/moouZMoZQzMYKMZ4BwWRd37jzhzDw8fyZ8=@vger.kernel.org X-Received: by 2002:a05:6a00:3904:b0:81f:4999:ae46 with SMTP id d2e1a72fcca58-823692c0dc6mr6121652b3a.48.1769626639748; Wed, 28 Jan 2026 10:57:19 -0800 (PST) X-Received: by 2002:a05:6a00:3904:b0:81f:4999:ae46 with SMTP id d2e1a72fcca58-823692c0dc6mr6121628b3a.48.1769626639306; Wed, 28 Jan 2026 10:57:19 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c22466sm3263536b3a.50.2026.01.28.10.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 10:57:18 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v7, net-next 3/8] bng_en: Handle an HWRM completion request Date: Thu, 29 Jan 2026 00:26:18 +0530 Message-ID: <20260128185623.26559-4-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> References: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 3 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 70d2fbca2a95..500653f085e6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2305,8 +2305,7 @@ static int bnge_open(struct net_device *dev) =20 static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path =3D 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index ce5e93a50ad8..810b1046f794 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -77,6 +77,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index a8a55e166331..99d9ac80647a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -383,6 +383,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn,= struct bnge_napi *bnapi, } } =20 +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id =3D=3D seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl =3D (struct hwrm_cmpl *)txcmp; + u16 cmpl_type =3D TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id =3D le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info = *cpr, int budget) { @@ -433,8 +470,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struc= t bnge_cp_ring_info *cpr, rx_pkts++; else if (rc =3D=3D -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_DONE || + cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type =3D=3D CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons =3D NEXT_RAW_CMP(raw_cons); =20 if (rx_pkts && rx_pkts =3D=3D budget) { @@ -552,6 +592,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done +=3D __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |=3D cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons =3D NEXT_RAW_CMP(raw_cons); } --=20 2.47.3