From nobody Tue Feb 10 08:26:48 2026 Received: from mail-yx1-f100.google.com (mail-yx1-f100.google.com [74.125.224.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C41372B3B for ; Wed, 28 Jan 2026 18:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626633; cv=none; b=ccI2F6LicGsj7PTDIcVreKzi06qAD3GlLxtIYyOHosgYQckmEibfrBvRq3zlrA7GBt40gaMvvfQfhO0yVBnmmXoVkNg4AjVLZa5sFXeltT+TgbHrm6YoUbIZU9j2zrwLm6Y9/zvFxFKvW6t6MukSPMs+wx268GsTa4egCOyoqfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769626633; c=relaxed/simple; bh=G42HEdK63RMSkNcCPQGCk4X08ncSFrRURRT8K21yxRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lFalURXSh4DkIUrc+cw2do+yVfDV8+jZ6oWCeLPeOEA1d3YKbUepITrw9teZS2yV111NFr6l+CwFO842OuTpqB9MJgh2bg4YOkRmjjjOJz+HVCHsP0QJR65/8iDPJJk6RpieLywKWQS23kvz/VqpEPyZ0Hfm1zcmerxPDXxhEu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VDH1Or9V; arc=none smtp.client-ip=74.125.224.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VDH1Or9V" Received: by mail-yx1-f100.google.com with SMTP id 956f58d0204a3-6495d592c10so126375d50.1 for ; Wed, 28 Jan 2026 10:57:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769626631; x=1770231431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=AYMAw9UoqG66w1w3/X7ltEcuFpYYgglTUx3ENGp9loKKdAehwPK3uaZz0vrfTp7WXf 2Pw5uIq6utvi/Y7Gpp1QaDytuoE5MuS9uo3RozXBvwgZmivf6LC0vx4TTlD93oDhGppA qVnyOrkfETT7SpcdF8EzeqzzsrSEe9E6piQDPhopHbJEJ3wUV+DEuH31I0qd4nsrRhho Z5xKfkHlOzOGT1ePVLtWtYoo/0G8cFdMRrPW96UWRyVLIKU57wW8QB7h+y9VNCE0Dr/g Q11NWwLY8ss+qGQtCdwJjtkzqx8G93WlKrhU9pwOLinp1xNihg+5DKQClfSz6/dh9Od8 QCxQ== X-Forwarded-Encrypted: i=1; AJvYcCXs/+cPkI+oWsDpAjTV4gu4H72JjCThBkL9adprsRCne746OtUqLXM7Am/OWVWWW8gv1Ebqis55Dy+gXdg=@vger.kernel.org X-Gm-Message-State: AOJu0YyfmYlbuxX59trS0Vc9JB1v0aR837jZsEfXT9xHIzPbS93XHwLc tcfilnpwTPNQXtA0jYkQDnjKqr9uoIVJC8khexQDQgkMHKNq+9lY+8LePN78YJ51HuQ+I4TQ3Kc CQbga0EKNaEnQR//7HKhvzZDol5iCqiFe5zFcxcpBhS1zf2/dKahxfyfmYW6Uby+3wYMJXef4Yf thbcjkOxXKD6Zlj4UvJm0FBaq79Z4qc0N5fOZFA52RGlKZ/0hhj9N/QbR3XDEPlVN0LmGPdHl94 XA7mbo4iIjtPilEXOFl9gRatQ== X-Gm-Gg: AZuq6aJ9zhYpLcbwJ+V2EakmfEa9ndnCv1pkReMywhN0cFnOKAIhtfjsIGFgqSglshQ lFdl5rFHFOhVR8Q2PIKt9dMCkxOL30KG3dkbliEZR44tzF7jENP6aFI6B+foVlmaUNm47MVNSlS IledPtNfQx+7CRkm4p7LZ7yclLdgK5XJBPxodUj4XntoH9F5POrLQygEIldaJmQdZhKmHHuACuE OKCe7elICrSGkiCO78Iq11h8Cc4zAifGNPZ2Mf7RT0B9aM9AzYlxatSLxRu7A5onleHTRGB8kFO FFraq8dCjI/ggcOZylG1ElOJxZdcq2PpbUyph9fiuJ8Wns863u0/fK1pJeJ9+xiqDH629TkeRn7 WlpCPDeWs4UWN+PcQHGoJQKW78GY6NCcJiGLzHf74qWnQzITKJFzFkcz7kUzsdAQ5PXr+hdoJKR V+CIONuMQ65QCo6MhUcC/YyzJi0wALRRyqEjrQmvuYfYIHQ/KWN04= X-Received: by 2002:a05:690e:bc4:b0:649:3b6f:28da with SMTP id 956f58d0204a3-6498fbf32ddmr4507548d50.38.1769626630794; Wed, 28 Jan 2026 10:57:10 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-17.dlp.protect.broadcom.com. [144.49.247.17]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-64995fbc7bfsm260662d50.0.2026.01.28.10.57.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2026 10:57:10 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81f3f3af760so264291b3a.1 for ; Wed, 28 Jan 2026 10:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769626629; x=1770231429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=VDH1Or9VcCBjdhg77DfMlFvKh3g+iKHWp6uOCI47PX93awI7Bug4YsLYY6V2IENoXj Cik1bs31ZdU3RJMoCRu/MG16F0AFP9yCxAmSyoWFV0/E0nk5vw1+40o+wF34Se/Np1X7 MkV52LB3g1JiWIWC+izaIHUdWth7b5/WnFQqI= X-Forwarded-Encrypted: i=1; AJvYcCUcel4HlsEOauZXz04qiPfjJSmwuiw98HG3LIWZEuebI1wP8/7KtuHx19aOaIVBWHrWUWrpi5boLf57kMU=@vger.kernel.org X-Received: by 2002:a05:6a00:ad86:b0:81f:9a5c:5b95 with SMTP id d2e1a72fcca58-82369301f3emr6799944b3a.68.1769626629506; Wed, 28 Jan 2026 10:57:09 -0800 (PST) X-Received: by 2002:a05:6a00:ad86:b0:81f:9a5c:5b95 with SMTP id d2e1a72fcca58-82369301f3emr6799921b3a.68.1769626629130; Wed, 28 Jan 2026 10:57:09 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c22466sm3263536b3a.50.2026.01.28.10.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 10:57:08 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v7, net-next 1/8] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Thu, 29 Jan 2026 00:26:16 +0530 Message-ID: <20260128185623.26559-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> References: <20260128185623.26559-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 832eeb960bd2..8bd019ea55a2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -2295,7 +2296,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space =3D rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); =20 - bn->rx_copy_thresh =3D BNGE_RX_COPY_THRESH; ring_size =3D bn->rx_ring_size; bn->rx_agg_ring_size =3D 0; bn->rx_agg_nr_pages =3D 0; @@ -2334,7 +2334,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size =3D agg_ring_size; bn->rx_agg_ring_mask =3D (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; =20 - rx_size =3D SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size =3D max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size =3D SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space =3D rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2367,6 +2370,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask =3D bn->cp_bit - 1; } =20 +static void bnge_init_ring_params(struct bnge_net *bn) +{ + u32 rx_size; + + bn->rx_copybreak =3D BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size =3D SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2456,6 +2470,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bn->rx_dir =3D DMA_FROM_DEVICE; =20 bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); =20 bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index fb3b961536ba..557cca472db6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -135,7 +135,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; =20 -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 =20 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -186,7 +187,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; --=20 2.47.3