From nobody Sun Feb 8 07:58:28 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ABEB330B2B for ; Wed, 28 Jan 2026 17:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769620953; cv=none; b=g58kqqVTgNzf0RQTHj0oF6RxH+ykuSTwnAjJojsO5dP7rG0HC7dDWo1iSRVpXgWpQT+9vIGug7gfBc/OOuwoqGDMtGVSv+7l3+QfLU7O9KN17KH9aloXe5KKMERtMLKKSb84500ldtPUdhnVmji5qKvqvEvSM9yJieSkBUUyqtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769620953; c=relaxed/simple; bh=m2DAeGWzupsYOReRvQVc1ESXRJf8bpaCOfiQBtpsZb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u/cxiXAhUf8ZqNQ8Fww7llKpcb+xGrEE+ybbOmbiNEZitO/DQAOwRUCo0hqdEmYG2ns5q0OGT1hPkUztL/9HAv3kDznfFqqj44EgXuZx01BDsQXRT9QKumUNs/snIpGm/llf70vsBjOpy86MJFyV29Z/sGLsXMUXOqVeMuiknTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l6Dtj652; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l6Dtj652" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47edffe5540so1099455e9.0 for ; Wed, 28 Jan 2026 09:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769620950; x=1770225750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r3VV7ZXSxulCvmS7hGVdpnbRSgB5Z/EbJYfxcinKUqg=; b=l6Dtj652c/C+wWF/TbV+5UjsYAlpJOvkuWR95jH7n1NSfBNjW5F8N8f+P2wo+9GrUo iTOfnhG30oknNPrbD59g8eX7r9YnZVFx8bRKqujX2inOXTsALnaq9v+dZien/Xu8HqxU lT7wYO4iflAVt34fKB7UiiCVciv9CTSfWC5+bLG6MwK7m4O0a4NWdcF0ghU1SJFIQDKm h+CyiUqbLZT7VkPpv+6/qTi+WOY8bR8aLnQ7AX5YfgYk6xd2a0lceSunvNYTvdZChQfn qT96Lfz4utiNetQ9zcqsqX1X8441lELBFogTkLEvZ+wTJdEykLZnRYqwLJ0KySHMhnNh uLlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769620950; x=1770225750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r3VV7ZXSxulCvmS7hGVdpnbRSgB5Z/EbJYfxcinKUqg=; b=b71ZWWoElo45qh4I7mBgtHjzZpxcKlSNMLilBi0I6hb7EF4RDNuRjEuk3pSU/ClQd9 GtbafektMv3E0h/zpNtm2Q2CXCd4QMg+S2MC7rYCzyHDpXrq7rcgiKgoVVF+NjoGOPqh lX/nTGWXx89Or0rvEy+5zF8Cxx/tPzHtyiXOrsIof5Ld0SZcC3NrwSKWxHog97QiahvU W5V7mmZViRzEUmEsjdQ0gYXAuVJgFHNhzzQeCxWgkXWoboYLAsGGskvwv7SshoXSzwEk zNamVvPGLzt2dkS6IccHWuaitsRew26rTkRJavjKRbzpxclbAyMMMH0h8cBUMJilZVE7 yqpQ== X-Forwarded-Encrypted: i=1; AJvYcCXBlmxwgLnWszC1Y8Y+dfDWHJei6wD+FGLUMRntfZ3s3bPDZGBnZcJJD/gpg4fkCrH/RQMaGFXqjM3OQ5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9aX/t+sKI9FDkP1gpbJt/Jb33IRndVMLhwv28Q1DGRb/Y3BXv 4F2jFVs+aCvRmnP7yoLfXckyGCHtUjB/DgAd/01PD7OYREP9AP2TJk26 X-Gm-Gg: AZuq6aI7EI1ySmXCvSR/vqhWSMiRXjp2GWgaIZyefw01mNw3MA2K2c5PSCTgmyhwde4 1gvFr7k6AC52XBsvnl3Hh+khDMlAVZszSijBzKWMEvXf9oZwjUUkC9hk/wlcBSJJQufAZML7g1Y IHgvYxpVw8RuBh98AkTWR7KEzeXxQbRZyCt4VnN3g/f/gHM0lUzJvzaeB8ID2lcfQnTK1LuSg2G CD6loXfDkS3S9appaakzJHIOj3vOO69aqOuXHRsMy+KJbL8ckMTIek4LGZd17oXGnhDKUgQkhbo nUAQ/7/VDUi/wDnh2X+mC7CFuuzXRBpeYWBcP1XFImGfxDUiDIoU1Lm+ERmRnY2xX3BsHBcjDTF 0lIDCRQxKtZNFXC0PuK8pW+/1+gDJ9+mtktdstVB+DgrELhUM3mYbD45IV0aRsZSOpp7XtTYPjO 3nWsSRvdkO X-Received: by 2002:a05:600c:1c1c:b0:46e:761b:e7ff with SMTP id 5b1f17b1804b1-48069c67621mr80472415e9.28.1769620949660; Wed, 28 Jan 2026 09:22:29 -0800 (PST) Received: from TTPP ([31.176.180.180]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm155554655e9.9.2026.01.28.09.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 09:22:29 -0800 (PST) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno Date: Wed, 28 Jan 2026 18:21:43 +0100 Message-ID: <20260128172143.23472-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260125221219.26151-1-omer.e.idrissi@gmail.com> References: <20260125221219.26151-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Changes since v1: - Removed leftover comment accidentally left in previous version - No functional changes Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index abb6fdfe7e1f..8fa823f7bab3 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -205,7 +205,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv (padapter->mlmepriv.LinkDetectInfo.bHigherBusyTxTraffic) ) { if ((phwxmit->accnt > 0) && (phwxmit->accnt < 5)) { - err =3D -2; + err =3D -EBUSY; break; } } @@ -260,7 +260,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv "%s: xmit_buf is not enough!\n", __func__); #endif - err =3D -2; + err =3D -ENOBUFS; complete(&(pxmitpriv->xmit_comp)); break; } @@ -380,7 +380,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) /* dequeue frame and write to hardware */ =20 ret =3D xmit_xmitframes(padapter, pxmitpriv); - if (ret =3D=3D -2) { + if (ret =3D=3D -EBUSY || ret =3D=3D -ENOBUFS) { /* here sleep 1ms will cause big TP loss of TX */ /* from 50+ to 40+ */ if (padapter->registrypriv.wifi_spec) --=20 2.51.0