From nobody Tue Feb 10 01:15:05 2026 Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57BCA2D7D30; Wed, 28 Jan 2026 14:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=94.231.106.210 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769611771; cv=none; b=UoVK0j3okwnkUgwnWC+NskA5fdz/v6KQ7OeRAd3QKb8E1596NTzKZ2GpR9XJC78Nom44rjsXI8192FzzSOGoQwI/v8J37jhVxBmbTddGPmyoQ4TrUTSAom+py7cEVqC5Iv3Ppsc58dJiD7JEU/Ylenoab5BKdV/n8PPjD7QHWjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769611771; c=relaxed/simple; bh=Aioox3rnLyBh3Qn7704KGfRcMdTIvPjXkFSn9oO5ek4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LECVE2Zjz4LqUeQGrJX8aXXM4DRU6nQ/xMnaRr/zG2zSLBlmRelbGWC2i8G5iw/Ay1NuZbrkk6i94D+zpEm6k2Caz4j9yl6l4GVlpu/r6tb7YSM/8qw87m2XWcfsgK8AN411Vbr1R01724IO8TkAY+hfXa1bPNP25i4Y2Nt5BzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gaisler.com; spf=pass smtp.mailfrom=gaisler.com; dkim=fail (0-bit key) header.d=gaisler.com header.i=@gaisler.com header.b=Z5rxydNw reason="key not found in DNS"; arc=none smtp.client-ip=94.231.106.210 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gaisler.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gaisler.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=gaisler.com header.i=@gaisler.com header.b="Z5rxydNw" Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4f1QCX02QLz1FQVM; Wed, 28 Jan 2026 15:49:28 +0100 (CET) Received: from d-5xj5g74.got.gaisler.com.com (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) by smtp.simply.com (Simply.com) with ESMTPA id 4f1QCW51Tmz1FDY1; Wed, 28 Jan 2026 15:49:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=simplycom2; t=1769611767; bh=IMU/wLjbU6RVE7LY0W7niv61k/USFwtxnDj46IVSkeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z5rxydNw4MmYE71yQiFrPFUnVE/Hjh0aAPQnQ5KHPdgRoiKihNJcv+tu5Hb5SY+Tg wEjTufmYYcZ0vG9ysPSM8MwLXee13F5O+RJKgpQHaFFVdImn/fryqbSNnj2jCTzLfe hGBpgJ5ehpNQJ0DVCIcm0GqSLlvgU0geA27r9fD9U2kO9UHrigUJDF6UrxvoZruhFb MD6vbop8Kis+2/BxG8LFfaKNN4yyOYRjaBRXJS/WaBnITEcLLYKrQbMpXUQ8BwEH7O FeCTSxo53ARNkyQXnUosACCoQBlsMaxyaSEbbWQG1YqKic32osF0qUu5xYZVKjHLpJ GyJmNpARAttLA== From: Arun Muthusamy To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mkl@pengutronix.de, mailhol@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Daniel Hellstrom , Arun Muthusamy Subject: [PATCH v4 04/15] can: grcan: Add clock handling Date: Wed, 28 Jan 2026 15:49:10 +0100 Message-ID: <20260128144921.5458-5-arun.muthusamy@gaisler.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260128144921.5458-1-arun.muthusamy@gaisler.com> References: <20260128144921.5458-1-arun.muthusamy@gaisler.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Daniel Hellstrom Add clock handling and add error messages for missing 'freq' DT property. Signed-off-by: Daniel Hellstrom Signed-off-by: Arun Muthusamy --- drivers/net/can/grcan.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c index 3b1b09943436..f3821e224f4f 100644 --- a/drivers/net/can/grcan.c +++ b/drivers/net/can/grcan.c @@ -34,7 +34,7 @@ #include #include #include - +#include #include #define DRV_NAME "grcan" @@ -1644,6 +1644,7 @@ static int grcan_probe(struct platform_device *ofdev) { struct device_node *np =3D ofdev->dev.of_node; struct device_node *sysid_parent; + struct clk *clk; u32 sysid, ambafreq; int irq, err; void __iomem *base; @@ -1663,8 +1664,19 @@ static int grcan_probe(struct platform_device *ofdev) err =3D of_property_read_u32(np, "freq", &ambafreq); if (err) { - dev_err(&ofdev->dev, "unable to fetch \"freq\" property\n"); - goto exit_error; + clk =3D devm_clk_get(&ofdev->dev, NULL); + if (IS_ERR(clk)) { + dev_err_probe(&ofdev->dev, PTR_ERR(clk), + "Failed both to get \"freq\" property and clock for fallback\n"); + err =3D PTR_ERR(clk); + goto exit_error; + } + + ambafreq =3D clk_get_rate(clk); + if (!ambafreq) { + dev_err(&ofdev->dev, "Invalid or Uninitialized clock\n"); + return -EINVAL; + } } base =3D devm_platform_ioremap_resource(ofdev, 0); -- 2.51.0