From nobody Mon Feb 9 05:40:01 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012070.outbound.protection.outlook.com [52.101.48.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27CA634EEE2; Wed, 28 Jan 2026 11:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599691; cv=fail; b=LAJTox4CFCIP5ANtHiCP7q7mv75eO0oGxAOdgDxc7wo1dWFBSsx10b+mHMKYoN4E4+PS6KGZdpMcIhKIExjRgzOip0PiSnaTP7zrxoU7RFpmMo3OkHRjzBAPxWwVwPdH/ZnzAs5XROs+qNjFUd31BRgopTewTcufcmTaXPagDow= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599691; c=relaxed/simple; bh=/no988dXRByA4dAv6xSmtV1gqdNqkJud8OF8Lw/T7fY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E6DZl5q7osqNNSM4i5NoWHtIy4zfVNZNNsKoZUMjAqn0NFFr8jl+ze1GAbpXM0hXCgrWNTLaEaa4q5OWbqectDNIYUss/5+inkbD5c0X4ailALZ6oYnV5X44utdO3wTWdQeOsM3Hy6OuWBlzrvSVWgHHMGTh5MMrUDQcd1lYqfY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oSFsMEUd; arc=fail smtp.client-ip=52.101.48.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oSFsMEUd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QhEj2NsEtV39odxRukpbJ4mFlHICHaKoyq0Qu8fJzAJ+/kd1Py4Rz7fhllfhodSWHNklbtvgvUaTIPzXiO/enLzlGYmZsDjCIXUtZb0NdzBaYiF2UtPSEkL3slwQAsoLYl84fAd5GFsi86rKDefqSMpLRsJUYLohiJKAYbDIKJljpQBAmKH0+AQM+MfLGV947Vc1fD+pjeoxPROi/5PPBl6qjqhb1NsA43x4DjW5fD9fRvmhdu6pHDNWX4gtEgv2JFI4C+JP60hWPo7rFWEPmV0ayR5B2DMGbV7siKzUgo1Dte33s0QWzx2yKQQi48GwhFahsGcGzUW7FoBYHn/Rbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yDRVdmRjGd6OOqu3CIeP6RyxaEBJy6PkXdTwAY/9YLw=; b=BnZY/+SNsDmCDKyKqP/3Vboq2P2niHjL8RQnjeDtF7UU/yUUPbvctwlssKeBIO1pdFgZa25oaKKxz6hI1M+itFCmb4ZXNIUAhQYLzEGVaXMcChWUe4NlBqeYx4jWjqHQwxvnbgglGKhdLlBEMWfDG20z99lxfKRkggKJzv+sT75pLTWCGE2KQxAkxN9Qej/qgcDyR8Kth9INmvWfINOeasqVmHip74KSa16v+qyOyhB4pftlinWSXXpSWKKOIgIZ/ezeAM8JA1kO/y8mfcyurunt0BcH9auLB2dLnoh5ZviMuzqdF+TcbUbHRddYhoDbwiN9omrHXCPtyEr4a5DwZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDRVdmRjGd6OOqu3CIeP6RyxaEBJy6PkXdTwAY/9YLw=; b=oSFsMEUd7aJH2YaGXZ+OlY+EqAHzGCybzlgl7Bx1wvhVFd3b90DsEXoxZqebwsrVJdK0OIo1tnMFSPtSdGhqPm0mmR5zOmJt9q6EWlR8zkDVhkdDvSDfFyHJ7Aylb4JlJ75UCE3MJqzNWsQSnEiRrOlz0ix1r76rKWbNoN9XTeIsOTgXIsj3DdZkbWdk7jw7S9bqYpqQ+VaNguhNUATpXmMSMR3dL+CMfMhGnGAHG3tS4SdQGiQZd6pN9hQxOEkDoto5Ltfnw6koLmzQrQOqb9NpX+ba88N7O3caePW5kU61ULb9bccKvdPgw2jiwbJGUlpbg0vTVMrssxDSWzJ/lQ== Received: from BN1PR10CA0007.namprd10.prod.outlook.com (2603:10b6:408:e0::12) by PH0PR12MB7982.namprd12.prod.outlook.com (2603:10b6:510:28d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.7; Wed, 28 Jan 2026 11:28:01 +0000 Received: from BN1PEPF00004682.namprd03.prod.outlook.com (2603:10b6:408:e0:cafe::20) by BN1PR10CA0007.outlook.office365.com (2603:10b6:408:e0::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.8 via Frontend Transport; Wed, 28 Jan 2026 11:27:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF00004682.mail.protection.outlook.com (10.167.243.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Wed, 28 Jan 2026 11:28:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 28 Jan 2026 03:27:48 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 28 Jan 2026 03:27:47 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 28 Jan 2026 03:27:42 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Donald Hunter , Jiri Pirko , Jonathan Corbet , Saeed Mahameed , "Leon Romanovsky" , Tariq Toukan , Mark Bloch , , , , , Gal Pressman , Moshe Shemesh , Carolina Jubran , Cosmin Ratiu , Jiri Pirko , Randy Dunlap , Simon Horman , Krzysztof Kozlowski Subject: [PATCH net-next V7 04/14] devlink: Add helpers to lock nested-in instances Date: Wed, 28 Jan 2026 13:25:34 +0200 Message-ID: <20260128112544.1661250-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260128112544.1661250-1-tariqt@nvidia.com> References: <20260128112544.1661250-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004682:EE_|PH0PR12MB7982:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ee9a5d5-7f6a-4fc4-c364-08de5e604b4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EAFlT7AJWRu7A3noIaYs59gx+y+lLYAotYnLzgBVQp81nydf1iXF5rQEpUQX?= =?us-ascii?Q?bJXt+dikOAPVnLhssPfUkI1Q3qcHH3+aSMEyqi4tnEv1czHK5PL6hOoT25w/?= =?us-ascii?Q?vu1vP2fBhKKrAr/jKUmeYzLfvAdeDOqEwMkcUux2YpQ60T8bxY2Djx491vou?= =?us-ascii?Q?RHKaDhRTDXWLDoMeeYtLFGWUxgNITe0JXF5Tqhf1eHAX85Ffuk7NlCkWhdjP?= =?us-ascii?Q?s2T9IAMA611Xu35+gBlkEz3VbPq8wSCtEQsr3gIvM/sKuaF2vyGsZvXAvpRg?= =?us-ascii?Q?nFuRGNFhYN5JzEveW4ZTTqbd/5NH9BEAQn8E04aKfH+gid/iHVJQnvMpk9Ht?= =?us-ascii?Q?YaiFDpR6KpHbYB5H+VD+pz/LrtrRkqQilwVa12fd2Vmu1ejA9z8crIcqDA2y?= =?us-ascii?Q?uqywAtX1PyaAF/bRv6dQlJZUO60/eOSA/DdZ5EFkQGBWBdWb/ZmzKKNgI2Xa?= =?us-ascii?Q?Nqg9W0LqnMGcbuZZXzbNS7LlzBYravQd7P8SnsUHJS610O9psWfuD+1Uj8/D?= =?us-ascii?Q?AgBvGFBTysYY7yFArKqJEH8fPLmkK6rG+CIc3r1N+/gbE3gNyf42t+Q4sPQq?= =?us-ascii?Q?0ywSwG2J937i1yETSydnD1umSZCuqkIimb9C/sh5z3RsIG2k17qPbobz99rs?= =?us-ascii?Q?ottKYG6HTBAZgxK02EXjs1a2tFmnTDQfrYWC7fC2giBa0A52+gqc83Oiabsr?= =?us-ascii?Q?zh00B+2VWZaOHKsYkUWJsEFigomZmU/ODKs/3wuIOZm9UTSFSm5KSjrzAPDt?= =?us-ascii?Q?RqPkWIs3J3ntVNXdgvPWHa99Q3QBumdSv3ONW/N1hqRxQSNptzvptj+8uKFI?= =?us-ascii?Q?hMDT9VeY6AVZMESwH3LZ8Tk8f2SecSnGXuzpCI0TJlClYI4vt+nXCvwILxDZ?= =?us-ascii?Q?9wUbz86ajHeRWl+M9KSXdksjPTCBn8FczDO6nXjbD/F4KHaJOxM6rcMjorGK?= =?us-ascii?Q?bnugXLqblLIhp390itHLwM2JRHoDow/Vgn9SFKpkeT6c45IbCZhHpDjZSZkZ?= =?us-ascii?Q?v0MiySNzfsl0jW3Sfb6ef6p/IF6TbXzjMrOLleVKYUb/UOrYiI2FWlc+aBal?= =?us-ascii?Q?g97t423+kSKNDK5Ujx/brsC1+JgwylR+XAWiTkGGtkxzdIdMOJ2ePlxpX+Sl?= =?us-ascii?Q?76U9hAkOfZyIVbxBojQKV0eJr34/+yf9kGaxqHcr2RDU4WVQJKAyEMFdLxi6?= =?us-ascii?Q?dZFfYFaicK4fkadeLGP2vIyrfjbozQvc8HO9WJU5bf6CYNOOfY3JRyGr0JP5?= =?us-ascii?Q?3Sve61eCEll/665jB53VksjuD3aiUXtFqVXFhi2kMDqNwz/3FZERoJv3+OMi?= =?us-ascii?Q?sonY701eT/1msWjfWCZiOS08gwuuz5pPrvkcde9peZIiPkGqNgNCgsy4054f?= =?us-ascii?Q?tvPJgG2vfaLVI8se1dtRwpZVG8m6pMU5hUD6qeB37PsxMk5evHFYxn1/LRf8?= =?us-ascii?Q?O7OyOtvVXuZ3cQ6vylQMcDAf52mzfDblz+kELhiPVgsjXXrJnZNVOphgpZDd?= =?us-ascii?Q?ISaAG7CW6AEF6IKKZ8d3ojgc+fHDHrQRvt69cW2+a1fpVWTb//7joTrgf9dd?= =?us-ascii?Q?hTbw7M7P66N5JdWEXuLrfHPewqtxiY4FPeoBpZhHSRFUmqzgWYVcK4ORbeP6?= =?us-ascii?Q?1YEqMcI8Iy0g3itpUS1Ooa4txS6CDCnlB9r2fMyWnzubWIuoGR2S0Jf4S/ru?= =?us-ascii?Q?+uEwSg=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2026 11:28:00.4368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee9a5d5-7f6a-4fc4-c364-08de5e604b4a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004682.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7982 Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu Upcoming code will need to obtain a reference to locked nested-in devlink instances. Add helpers to lock, obtain an already locked reference and unlock/unref the nested-in instance. Signed-off-by: Cosmin Ratiu Reviewed-by: Carolina Jubran Reviewed-by: Jiri Pirko Signed-off-by: Tariq Toukan --- net/devlink/core.c | 42 +++++++++++++++++++++++++++++++++++++ net/devlink/devl_internal.h | 3 +++ 2 files changed, 45 insertions(+) diff --git a/net/devlink/core.c b/net/devlink/core.c index 6ae62c7f2a80..f228190df346 100644 --- a/net/devlink/core.c +++ b/net/devlink/core.c @@ -67,6 +67,48 @@ static void __devlink_rel_put(struct devlink_rel *rel) devlink_rel_free(rel); } =20 +struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel) +{ + struct devlink *devlink; + + if (!rel) + return NULL; + devlink =3D devlinks_xa_get(rel->nested_in.devlink_index); + if (!devlink) + return NULL; + devl_lock(devlink); + if (devl_is_registered(devlink)) + return devlink; + devl_unlock(devlink); + devlink_put(devlink); + return NULL; +} + +/* Returns the nested in devlink object and validates its lock is held. */ +struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel) +{ + struct devlink *devlink; + unsigned long index; + + if (!rel) + return NULL; + index =3D rel->nested_in.devlink_index; + devlink =3D xa_find(&devlinks, &index, index, DEVLINK_REGISTERED); + if (devlink) + devl_assert_locked(devlink); + return devlink; +} + +void devlink_nested_in_put_unlock(struct devlink_rel *rel) +{ + struct devlink *devlink =3D devlink_nested_in_get_locked(rel); + + if (devlink) { + devl_unlock(devlink); + devlink_put(devlink); + } +} + static void devlink_rel_nested_in_notify_work(struct work_struct *work) { struct devlink_rel *rel =3D container_of(work, struct devlink_rel, diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h index 14eaad9cfe35..aea43d750d23 100644 --- a/net/devlink/devl_internal.h +++ b/net/devlink/devl_internal.h @@ -120,6 +120,9 @@ typedef void devlink_rel_notify_cb_t(struct devlink *de= vlink, u32 obj_index); typedef void devlink_rel_cleanup_cb_t(struct devlink *devlink, u32 obj_ind= ex, u32 rel_index); =20 +struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel); +struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel); +void devlink_nested_in_put_unlock(struct devlink_rel *rel); void devlink_rel_nested_in_clear(u32 rel_index); int devlink_rel_nested_in_add(u32 *rel_index, u32 devlink_index, u32 obj_index, devlink_rel_notify_cb_t *notify_cb, --=20 2.44.0