From nobody Mon Feb 9 11:28:39 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DEA134DB7B for ; Wed, 28 Jan 2026 09:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594161; cv=none; b=iCsAq6gMyT4eOlq0vI3VN4SzrakaW8IVZJfDc4sN04PTpKboRsMeXfwh7NirDuElESXneGTWjrdbx3nbMrzn48jJwAAdTDaZAie/SsQ+qYhg18j08GZRQgypXvvAFtPysKtSuAhGZfK62c5XAdOwmwFT5aDyshWjsoOAgI2GWO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594161; c=relaxed/simple; bh=yfATDPyMLX+uZK2zELAA2dhtgtAncPVGNpngvqJ6X5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WkQ5AHx2gXmE0kd5sDtv1/nZIHeTI8tOaSfKKNtle3YCypWS+G3Zv3vuWP+1eQIHWJfp8zLEsDV+L6z3tqQF+W2R7Td/RDo5sSzv3TenKdpjVLYjNUv2WjQRJyk21ShfqZgw/+pF9cDecn5FbMUo/JgHenYkxE5WpobNly8bKzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=VGCHbWBv; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=voC2LShX; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="VGCHbWBv"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="voC2LShX" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769594158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVLlTuYd15Wnn+arM3sk8Ckt4tR3I9d+Xqe5g1pMH/E=; b=VGCHbWBvBNEppkqCzz2phXn5DE7BGzVXvzJAuOLGZSHTauyKzgcHPMbwy9Uay+/q0b9zSg wxvKqgbNR13VNoXWmQvfB+0Mm3ok6ULgkhqD8ZdfOrxInv3D6ScuHADDCXqPYrikdm6lOp oJ15vWWl1tCr1+wrrlhYApp8v96tsPGdYgK5/k6nWuFxaiM4ALb/VH1+Qp8GkbjO0Vhy/Z P3nZmj34cz9WYnI/d6sHdCcbkHYasjXa2hJ2pTRJyx1aXV/wQ8okYhUn/FG9/Uc4ERTjZP sTE3R/nNb6jdSYB2aqsqQCkUmDB7NdaBzXdFPJybto7lmDQhELbVE79x4zcXqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769594158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVLlTuYd15Wnn+arM3sk8Ckt4tR3I9d+Xqe5g1pMH/E=; b=voC2LShXIE+uzaZ15IAFxX/+rPTA8/M7RukjkwrmaZlacO7fr6TvnwIT0HGYx2aCEJFl5a /RXyzE8k0LxNEECQ== To: linux-kernel@vger.kernel.org Cc: "Thomas Gleixner" , Sebastian Andrzej Siewior , Jassi Brar Subject: [PATCH v2 04/20] mailbox: bcm-ferxrm-mailbox: Use default primary handler Date: Wed, 28 Jan 2026 10:55:24 +0100 Message-ID: <20260128095540.863589-5-bigeasy@linutronix.de> In-Reply-To: <20260128095540.863589-1-bigeasy@linutronix.de> References: <20260128095540.863589-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" request_threaded_irq() is invoked with a primary and a secondary handler and no flags are passed. The primary handler is the same as irq_default_primary_handler() so there is no need to have an identical copy. The lack of the IRQF_ONESHOT can be dangerous because the interrupt source is not masked while the threaded handler is active. This means, especially on LEVEL typed interrupt lines, the interrupt can fire again before the threaded handler had a chance to run. Use the default primary interrupt handler by specifying NULL and set IRQF_ONESHOT so the interrupt source is masked until the secondary handler is done. Signed-off-by: Sebastian Andrzej Siewior --- Cc: Jassi Brar --- drivers/mailbox/bcm-flexrm-mailbox.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-fle= xrm-mailbox.c index 41f79e51d9e5a..4255fefc3a5a0 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -1173,14 +1173,6 @@ static int flexrm_debugfs_stats_show(struct seq_file= *file, void *offset) =20 /* =3D=3D=3D=3D=3D=3D FlexRM interrupt handler =3D=3D=3D=3D=3D */ =20 -static irqreturn_t flexrm_irq_event(int irq, void *dev_id) -{ - /* We only have MSI for completions so just wakeup IRQ thread */ - /* Ring related errors will be informed via completion descriptors */ - - return IRQ_WAKE_THREAD; -} - static irqreturn_t flexrm_irq_thread(int irq, void *dev_id) { flexrm_process_completions(dev_id); @@ -1271,10 +1263,8 @@ static int flexrm_startup(struct mbox_chan *chan) ret =3D -ENODEV; goto fail_free_cmpl_memory; } - ret =3D request_threaded_irq(ring->irq, - flexrm_irq_event, - flexrm_irq_thread, - 0, dev_name(ring->mbox->dev), ring); + ret =3D request_threaded_irq(ring->irq, NULL, flexrm_irq_thread, + IRQF_ONESHOT, dev_name(ring->mbox->dev), ring); if (ret) { dev_err(ring->mbox->dev, "failed to request ring%d IRQ\n", ring->num); --=20 2.51.0